* [PATCH] Delete unneed variable "delay" on line 79
@ 2021-06-24 5:56 Jason Wang
2021-07-20 6:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Jason Wang @ 2021-06-24 5:56 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: linux, linux-arm-kernel, linux-samsung-soc, linux-kernel, Jason Wang
"delay" variable on line 79 can be deleted by returning "0" on line 88.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
arch/arm/mach-s3c/mach-gta02.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
index aec8b451c016..418939ce0fc3 100644
--- a/arch/arm/mach-s3c/mach-gta02.c
+++ b/arch/arm/mach-s3c/mach-gta02.c
@@ -79,13 +79,12 @@ static struct pcf50633 *gta02_pcf;
static long gta02_panic_blink(int state)
{
- long delay = 0;
char led;
led = (state) ? 1 : 0;
gpio_direction_output(GTA02_GPIO_AUX_LED, led);
- return delay;
+ return 0;
}
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Delete unneed variable "delay" on line 79
2021-06-24 5:56 [PATCH] Delete unneed variable "delay" on line 79 Jason Wang
@ 2021-07-20 6:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-20 6:47 UTC (permalink / raw)
To: Jason Wang
Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-arm-kernel, linux,
linux-kernel
On Thu, 24 Jun 2021 13:56:27 +0800, Jason Wang wrote:
> "delay" variable on line 79 can be deleted by returning "0" on line 88.
Please use subject prefix matching subsystem
(git log --oneline -- arch/arm/mach-s3c).
Applied, thanks!
[1/1] Delete unneed variable "delay" on line 79
commit: 8729ca2a6f2dd154e32b6d4858425ba29b012f7f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Delete unneed variable "delay" on line 79
@ 2021-07-20 6:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-20 6:47 UTC (permalink / raw)
To: Jason Wang
Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-arm-kernel, linux,
linux-kernel
On Thu, 24 Jun 2021 13:56:27 +0800, Jason Wang wrote:
> "delay" variable on line 79 can be deleted by returning "0" on line 88.
Please use subject prefix matching subsystem
(git log --oneline -- arch/arm/mach-s3c).
Applied, thanks!
[1/1] Delete unneed variable "delay" on line 79
commit: 8729ca2a6f2dd154e32b6d4858425ba29b012f7f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-20 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 5:56 [PATCH] Delete unneed variable "delay" on line 79 Jason Wang
2021-07-20 6:47 ` Krzysztof Kozlowski
2021-07-20 6:47 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.