* [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
@ 2021-07-19 22:30 Vincent Li
2021-07-20 18:19 ` Martin KaFai Lau
2021-07-20 20:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Vincent Li @ 2021-07-19 22:30 UTC (permalink / raw)
To: bpf; +Cc: daniel, Vincent Li
When run test_tc_tunnel.sh, it complains following error
ipip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
test basic connectivity
nc: cannot use -p and -l
nc man page has:
-l Listen for an incoming connection rather than initiating
a connection to a remote host.Cannot be used together with
any of the options -psxz. Additionally, any timeouts specified
with the -w option are ignored.
Correct nc in server_listen().
Signed-off-by: Vincent Li <vincent.mc.li@gmail.com>
---
tools/testing/selftests/bpf/test_tc_tunnel.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_tc_tunnel.sh b/tools/testing/selftests/bpf/test_tc_tunnel.sh
index c9dde9b9d987..088fcad138c9 100755
--- a/tools/testing/selftests/bpf/test_tc_tunnel.sh
+++ b/tools/testing/selftests/bpf/test_tc_tunnel.sh
@@ -69,7 +69,7 @@ cleanup() {
}
server_listen() {
- ip netns exec "${ns2}" nc "${netcat_opt}" -l -p "${port}" > "${outfile}" &
+ ip netns exec "${ns2}" nc "${netcat_opt}" -l "${port}" > "${outfile}" &
server_pid=$!
sleep 0.2
}
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
2021-07-19 22:30 [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l Vincent Li
@ 2021-07-20 18:19 ` Martin KaFai Lau
2021-07-20 19:38 ` Vincent Li
2021-07-20 20:50 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Martin KaFai Lau @ 2021-07-20 18:19 UTC (permalink / raw)
To: Vincent Li; +Cc: bpf, daniel
On Mon, Jul 19, 2021 at 03:30:22PM -0700, Vincent Li wrote:
> When run test_tc_tunnel.sh, it complains following error
>
> ipip
> encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
> test basic connectivity
> nc: cannot use -p and -l
>
> nc man page has:
>
> -l Listen for an incoming connection rather than initiating
> a connection to a remote host.Cannot be used together with
> any of the options -psxz. Additionally, any timeouts specified
> with the -w option are ignored.
>
> Correct nc in server_listen().
I have two distros and both work with -p in listen.
However, they also work the same without -p, so it makes sense to remove it.
Acked-by: Martin KaFai Lau <kafai@fb.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
2021-07-20 18:19 ` Martin KaFai Lau
@ 2021-07-20 19:38 ` Vincent Li
0 siblings, 0 replies; 4+ messages in thread
From: Vincent Li @ 2021-07-20 19:38 UTC (permalink / raw)
To: Martin KaFai Lau; +Cc: bpf, Daniel Borkmann
On Tue, Jul 20, 2021 at 11:19 AM Martin KaFai Lau <kafai@fb.com> wrote:
>
> On Mon, Jul 19, 2021 at 03:30:22PM -0700, Vincent Li wrote:
> > When run test_tc_tunnel.sh, it complains following error
> >
> > ipip
> > encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
> > test basic connectivity
> > nc: cannot use -p and -l
> >
> > nc man page has:
> >
> > -l Listen for an incoming connection rather than initiating
> > a connection to a remote host.Cannot be used together with
> > any of the options -psxz. Additionally, any timeouts specified
> > with the -w option are ignored.
> >
> > Correct nc in server_listen().
> I have two distros and both work with -p in listen.
> However, they also work the same without -p, so it makes sense to remove it.
>
Thanks Martin, I use Centos 8 distro.
> Acked-by: Martin KaFai Lau <kafai@fb.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
2021-07-19 22:30 [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l Vincent Li
2021-07-20 18:19 ` Martin KaFai Lau
@ 2021-07-20 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-20 20:50 UTC (permalink / raw)
To: Vincent Li; +Cc: bpf, daniel
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Mon, 19 Jul 2021 15:30:22 -0700 you wrote:
> When run test_tc_tunnel.sh, it complains following error
>
> ipip
> encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
> test basic connectivity
> nc: cannot use -p and -l
>
> [...]
Here is the summary with links:
- [bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
https://git.kernel.org/bpf/bpf-next/c/875fc315dbc3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-20 21:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 22:30 [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l Vincent Li
2021-07-20 18:19 ` Martin KaFai Lau
2021-07-20 19:38 ` Vincent Li
2021-07-20 20:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.