* [PATCH net] bnxt_en: Fix static checker warning in bnxt_fw_reset_task()
@ 2021-07-26 18:52 Michael Chan
2021-07-26 21:52 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2021-07-26 18:52 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, gospo, dan.carpenter, Somnath Kotur
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
From: Somnath Kotur <somnath.kotur@broadcom.com>
Now that we return when bnxt_open() fails in bnxt_fw_reset_task(),
there is no need to check for 'rc' value again before invoking
bnxt_reenable_sriov().
Fixes: 3958b1da725a ("bnxt_en: fix error path of FW reset")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 4db162cee911..89606587b156 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -12131,9 +12131,8 @@ static void bnxt_fw_reset_task(struct work_struct *work)
/* Make sure fw_reset_state is 0 before clearing the flag */
smp_mb__before_atomic();
clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state);
- bnxt_ulp_start(bp, rc);
- if (!rc)
- bnxt_reenable_sriov(bp);
+ bnxt_ulp_start(bp, 0);
+ bnxt_reenable_sriov(bp);
bnxt_vf_reps_alloc(bp);
bnxt_vf_reps_open(bp);
bnxt_dl_health_recovery_done(bp);
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bnxt_en: Fix static checker warning in bnxt_fw_reset_task()
2021-07-26 18:52 [PATCH net] bnxt_en: Fix static checker warning in bnxt_fw_reset_task() Michael Chan
@ 2021-07-26 21:52 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-26 21:52 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, gospo, dan.carpenter, somnath.kotur
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 26 Jul 2021 14:52:48 -0400 you wrote:
> From: Somnath Kotur <somnath.kotur@broadcom.com>
>
> Now that we return when bnxt_open() fails in bnxt_fw_reset_task(),
> there is no need to check for 'rc' value again before invoking
> bnxt_reenable_sriov().
>
> Fixes: 3958b1da725a ("bnxt_en: fix error path of FW reset")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>
> [...]
Here is the summary with links:
- [net] bnxt_en: Fix static checker warning in bnxt_fw_reset_task()
https://git.kernel.org/netdev/net/c/758684e49f4c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-26 21:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 18:52 [PATCH net] bnxt_en: Fix static checker warning in bnxt_fw_reset_task() Michael Chan
2021-07-26 21:52 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.