All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: hisilicon: hi3559a: select RESET_HISI
@ 2021-07-17  4:31 Randy Dunlap
  2021-07-19  2:55 ` Dongjiu Geng
  2021-07-27  0:23 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-07-17  4:31 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, kernel test robot, Dongjiu Geng, Stephen Boyd,
	stable, linux-clk, Michael Turquette

The clk-hi3559a driver uses functions from reset.c so it should
select RESET_HISI to avoid build errors.

Fixes these build errors:
aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'

Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Dongjiu Geng <gengdongjiu@huawei.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: stable@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>
---
 drivers/clk/hisilicon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
+++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
@@ -18,6 +18,7 @@ config COMMON_CLK_HI3519
 config COMMON_CLK_HI3559A
 	bool "Hi3559A Clock Driver"
 	depends on ARCH_HISI || COMPILE_TEST
+	select RESET_HISI
 	default ARCH_HISI
 	help
 	  Build the clock driver for hi3559a.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI
  2021-07-17  4:31 [PATCH] clk: hisilicon: hi3559a: select RESET_HISI Randy Dunlap
@ 2021-07-19  2:55 ` Dongjiu Geng
  2021-07-27  0:23 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Dongjiu Geng @ 2021-07-19  2:55 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, kernel test robot, Dongjiu Geng, Stephen Boyd,
	stable, linux-clk, Michael Turquette

Randy Dunlap <rdunlap@infradead.org> 于2021年7月17日周六 下午12:34写道:
>
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
>
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'
>
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Dongjiu Geng <gengdongjiu@huawei.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: stable@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> ---
>  drivers/clk/hisilicon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
> +++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
> @@ -18,6 +18,7 @@ config COMMON_CLK_HI3519
>  config COMMON_CLK_HI3559A
>         bool "Hi3559A Clock Driver"
>         depends on ARCH_HISI || COMPILE_TEST
> +       select RESET_HISI
>         default ARCH_HISI
>         help
>           Build the clock driver for hi3559a.

Reviewed-by: Dongjiu Geng <gengdongjiu1@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI
  2021-07-17  4:31 [PATCH] clk: hisilicon: hi3559a: select RESET_HISI Randy Dunlap
  2021-07-19  2:55 ` Dongjiu Geng
@ 2021-07-27  0:23 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-07-27  0:23 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Randy Dunlap, kernel test robot, Dongjiu Geng, stable, linux-clk,
	Michael Turquette

Quoting Randy Dunlap (2021-07-16 21:31:59)
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
> 
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'
> 
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Dongjiu Geng <gengdongjiu@huawei.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: stable@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> ---

Applied to clk-fixes

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-27  0:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-17  4:31 [PATCH] clk: hisilicon: hi3559a: select RESET_HISI Randy Dunlap
2021-07-19  2:55 ` Dongjiu Geng
2021-07-27  0:23 ` Stephen Boyd

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.