From: Stephen Boyd <sboyd@kernel.org> To: Russell King (Oracle) <linux@armlinux.org.uk>, <u.kleine-koenig@pengutronix.de> Cc: Michael Turquette <mturquette@baylibre.com>, Claudiu.Beznea@microchip.com, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, lee.jones@linaro.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, Ludovic.Desroches@microchip.com, o.rempel@pengutronix.de, andy.shevchenko@gmail.com, aardelean@deviqon.com, linux-pwm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, broonie@kernel.org, Jonathan.Cameron@huawei.com, linux-arm-kernel@lists.infradead.org, a.zummo@towertech.it, linux-spi@vger.kernel.org, wsa@kernel.org, kernel@pengutronix.de, akpm@linux-foundation.org, torvalds@linux-foundation.org Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks] Date: Sat, 31 Jul 2021 00:41:19 -0700 [thread overview] Message-ID: <162771727997.714452.2303764341103276867@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <20210728204033.GF22278@shell.armlinux.org.uk> Quoting Russell King (Oracle) (2021-07-28 13:40:34) > > I adapted the Subject in the hope to catch Stephen's and Michael's > > attention. My impression is that this thread isn't on their radar yet, > > but the topic here seems important enough to get a matching Subject. The thread is on my radar but... > > Have you thought about sending your pull request to the clk API > maintainer (iow, me) ? > +1 This patch doesn't fall under CCF maintainer. $ ./scripts/get_maintainer.pl -f include/linux/clk.h Russell King <linux@armlinux.org.uk> (maintainer:CLK API) linux-clk@vger.kernel.org (open list:CLK API) linux-kernel@vger.kernel.org (open list) Finally, this sort of patch has been discussed for years and I didn't see any mention of those previous attempts in the patch series. Has something changed since that time? I think we've got a bunch of hand rolled devm things in the meantime but not much else. I still wonder if it would be better if we had some sort of DT binding that said "turn this clk on when the driver probes this device and keep it on until the driver is unbound". That would probably work well for quite a few drivers that don't want to ever call clk_get() or clk_prepare_enable() and could tie into the assigned-clock-rates property in a way that let us keep the platform details out of the drivers. We could also go one step further and make a clk pm domain when this new property is present and then have the clk be enabled based on runtime PM of the device (and if runtime PM is disabled then just enable it at driver probe time).
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Russell King (Oracle) <linux@armlinux.org.uk>, <u.kleine-koenig@pengutronix.de> Cc: Michael Turquette <mturquette@baylibre.com>, Claudiu.Beznea@microchip.com, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, lee.jones@linaro.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, Ludovic.Desroches@microchip.com, o.rempel@pengutronix.de, andy.shevchenko@gmail.com, aardelean@deviqon.com, linux-pwm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, broonie@kernel.org, Jonathan.Cameron@huawei.com, linux-arm-kernel@lists.infradead.org, a.zummo@towertech.it, linux-spi@vger.kernel.org, wsa@kernel.org, kernel@pengutronix.de, akpm@linux-foundation.org, torvalds@linux-foundation.org Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks] Date: Sat, 31 Jul 2021 00:41:19 -0700 [thread overview] Message-ID: <162771727997.714452.2303764341103276867@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <20210728204033.GF22278@shell.armlinux.org.uk> Quoting Russell King (Oracle) (2021-07-28 13:40:34) > > I adapted the Subject in the hope to catch Stephen's and Michael's > > attention. My impression is that this thread isn't on their radar yet, > > but the topic here seems important enough to get a matching Subject. The thread is on my radar but... > > Have you thought about sending your pull request to the clk API > maintainer (iow, me) ? > +1 This patch doesn't fall under CCF maintainer. $ ./scripts/get_maintainer.pl -f include/linux/clk.h Russell King <linux@armlinux.org.uk> (maintainer:CLK API) linux-clk@vger.kernel.org (open list:CLK API) linux-kernel@vger.kernel.org (open list) Finally, this sort of patch has been discussed for years and I didn't see any mention of those previous attempts in the patch series. Has something changed since that time? I think we've got a bunch of hand rolled devm things in the meantime but not much else. I still wonder if it would be better if we had some sort of DT binding that said "turn this clk on when the driver probes this device and keep it on until the driver is unbound". That would probably work well for quite a few drivers that don't want to ever call clk_get() or clk_prepare_enable() and could tie into the assigned-clock-rates property in a way that let us keep the platform details out of the drivers. We could also go one step further and make a clk pm domain when this new property is present and then have the clk be enabled based on runtime PM of the device (and if runtime PM is disabled then just enable it at driver probe time). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-31 7:41 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 17:41 [PATCH v7 0/6] clk: provide new devm helpers for prepared and enabled clocks Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 1/6] clk: generalize devm_clk_get() a bit Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 2/6] clk: Provide new devm_clk_helpers for prepared and enabled clocks Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 3/6] pwm: atmel: Simplify using devm_clk_get_prepared() Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 4/6] rtc: at91sam9: Simplify using devm_clk_get_enabled() Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 5/6] i2c: imx: " Uwe Kleine-König 2021-05-10 17:41 ` Uwe Kleine-König 2021-05-10 17:41 ` [PATCH v7 6/6] spi: davinci: " Uwe Kleine-König 2021-05-11 7:58 ` [PATCH v7 0/6] clk: provide new devm helpers for prepared and enabled clocks Alexandru Ardelean 2021-05-11 7:58 ` Alexandru Ardelean 2021-05-24 11:09 ` Uwe Kleine-König 2021-05-24 11:09 ` Uwe Kleine-König 2021-06-09 20:21 ` [PULL] Add variants of devm_clk_get for prepared and enabled clocks " Uwe Kleine-König 2021-06-25 17:14 ` Uwe Kleine-König 2021-06-25 17:14 ` Uwe Kleine-König 2021-07-05 8:01 ` Uwe Kleine-König 2021-07-05 8:01 ` Uwe Kleine-König 2021-07-22 6:06 ` Uwe Kleine-König 2021-07-22 6:06 ` Uwe Kleine-König 2021-07-22 7:40 ` Wolfram Sang 2021-07-22 7:40 ` Wolfram Sang 2021-07-22 8:18 ` Uwe Kleine-König 2021-07-22 8:18 ` Uwe Kleine-König 2021-07-22 12:07 ` Wolfram Sang 2021-07-22 12:07 ` Wolfram Sang [not found] ` <CAHp75VfC=s12Unw3+Cn0ag71mM5i90=Jbwj4nYwB5cPKiUTRSA@mail.gmail.com> 2021-07-23 9:13 ` Uwe Kleine-König 2021-07-23 9:13 ` Uwe Kleine-König 2021-07-26 9:18 ` Claudiu.Beznea 2021-07-26 9:18 ` Claudiu.Beznea 2021-07-26 9:52 ` Andy Shevchenko 2021-07-26 9:52 ` Andy Shevchenko 2021-07-26 12:32 ` Wolfram Sang 2021-07-26 12:32 ` Wolfram Sang 2021-07-26 13:28 ` Andy Shevchenko 2021-07-26 13:28 ` Andy Shevchenko 2021-07-26 17:40 ` Wolfram Sang 2021-07-26 17:40 ` Wolfram Sang 2021-07-28 20:25 ` About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks] Uwe Kleine-König 2021-07-28 20:25 ` Uwe Kleine-König 2021-07-28 20:40 ` Russell King (Oracle) 2021-07-28 20:40 ` Russell King (Oracle) 2021-07-31 7:41 ` Stephen Boyd [this message] 2021-07-31 7:41 ` Stephen Boyd 2021-07-31 8:07 ` Andy Shevchenko 2021-07-31 8:07 ` Andy Shevchenko 2021-07-31 12:00 ` Uwe Kleine-König 2021-07-31 12:00 ` Uwe Kleine-König 2021-08-02 9:36 ` Jonathan Cameron 2021-08-02 9:36 ` Jonathan Cameron 2021-08-02 9:48 ` Russell King (Oracle) 2021-08-02 9:48 ` Russell King (Oracle) 2021-08-02 15:27 ` Uwe Kleine-König 2021-08-02 15:27 ` Uwe Kleine-König 2021-08-02 16:38 ` Russell King (Oracle) 2021-08-02 16:38 ` Russell King (Oracle) 2021-08-02 17:13 ` Andy Shevchenko 2021-08-02 17:13 ` Andy Shevchenko 2021-08-02 20:28 ` Russell King (Oracle) 2021-08-02 20:28 ` Russell King (Oracle) 2021-08-03 8:11 ` Stephen Boyd 2021-08-03 8:11 ` Stephen Boyd 2021-08-03 10:40 ` Uwe Kleine-König 2021-08-03 10:40 ` Uwe Kleine-König 2021-08-06 0:26 ` Stephen Boyd 2021-08-06 0:26 ` Stephen Boyd 2021-09-14 13:22 ` Uwe Kleine-König 2021-09-14 13:22 ` Uwe Kleine-König 2021-09-14 13:52 ` Mark Brown 2021-09-14 13:52 ` Mark Brown 2021-08-03 7:44 ` Stephen Boyd 2021-08-03 7:44 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=162771727997.714452.2303764341103276867@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=Claudiu.Beznea@microchip.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=Ludovic.Desroches@microchip.com \ --cc=a.zummo@towertech.it \ --cc=aardelean@deviqon.com \ --cc=akpm@linux-foundation.org \ --cc=alexandre.belloni@bootlin.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mturquette@baylibre.com \ --cc=o.rempel@pengutronix.de \ --cc=thierry.reding@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.