[PATCH] ASoC: amd: vangogh: Drop superfluous mmap callback

[PATCH] ASoC: amd: vangogh: Drop superfluous mmap callback

[Takashi Iwai]

The mmap callback of vangogh driver just calls the default mmap
handler, and it's superfluous, as the PCM core would call it if not
set.  Let's drop the superfluous mmap callback.

Fixes: 361414dc1f07 ("ASoC: amd: add vangogh i2s dma driver pm ops")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/amd/vangogh/acp5x-pcm-dma.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c
index 9f8eb72ac834..f10de38976cb 100644
--- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c
+++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c
@@ -315,13 +315,6 @@ static int acp5x_dma_new(struct snd_soc_component *component,
 	return 0;
 }
 
-static int acp5x_dma_mmap(struct snd_soc_component *component,
-			  struct snd_pcm_substream *substream,
-			  struct vm_area_struct *vma)
-{
-	return snd_pcm_lib_default_mmap(substream, vma);
-}
-
 static int acp5x_dma_close(struct snd_soc_component *component,
 			   struct snd_pcm_substream *substream)
 {
@@ -364,7 +357,6 @@ static const struct snd_soc_component_driver acp5x_i2s_component = {
 	.close		= acp5x_dma_close,
 	.hw_params	= acp5x_dma_hw_params,
 	.pointer	= acp5x_dma_pointer,
-	.mmap		= acp5x_dma_mmap,
 	.pcm_construct	= acp5x_dma_new,
 };
 
-- 
2.26.2

Re: [PATCH] ASoC: amd: vangogh: Drop superfluous mmap callback

[Mark Brown]

On Wed, 4 Aug 2021 09:52:23 +0200, Takashi Iwai wrote:
> The mmap callback of vangogh driver just calls the default mmap
> handler, and it's superfluous, as the PCM core would call it if not
> set.  Let's drop the superfluous mmap callback.
> 
> 
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: vangogh: Drop superfluous mmap callback
      commit: f2553d46783409656d82e46913354ed0c058cc0c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark