* [PATCH] hw/virtio: Fix leak of host-notifier memory-region
@ 2021-08-12 1:37 Yajun Wu via
2021-08-12 10:36 ` Stefano Garzarella
0 siblings, 1 reply; 2+ messages in thread
From: Yajun Wu via @ 2021-08-12 1:37 UTC (permalink / raw)
To: qemu-devel, mst; +Cc: Yajun Wu
If call virtio_queue_set_host_notifier_mr fails, should free
host-notifier memory-region.
Signed-off-by: Yajun Wu <yajunw@nvidia.com>
---
hw/virtio/vhost-user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index aec6cc1..3ae5297 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -1474,6 +1474,7 @@ static int vhost_user_slave_handle_vring_host_notifier(struct vhost_dev *dev,
g_free(name);
if (virtio_queue_set_host_notifier_mr(vdev, queue_idx, &n->mr, true)) {
+ object_unparent(OBJECT(&n->mr));
munmap(addr, page_size);
return -1;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/virtio: Fix leak of host-notifier memory-region
2021-08-12 1:37 [PATCH] hw/virtio: Fix leak of host-notifier memory-region Yajun Wu via
@ 2021-08-12 10:36 ` Stefano Garzarella
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Garzarella @ 2021-08-12 10:36 UTC (permalink / raw)
To: Yajun Wu; +Cc: qemu-devel, mst
On Thu, Aug 12, 2021 at 04:37:26AM +0300, Yajun Wu via wrote:
>If call virtio_queue_set_host_notifier_mr fails, should free
>host-notifier memory-region.
>
We can add:
Fixes: 44866521bd ("vhost-user: support registering external host notifiers")
>Signed-off-by: Yajun Wu <yajunw@nvidia.com>
>---
> hw/virtio/vhost-user.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
>index aec6cc1..3ae5297 100644
>--- a/hw/virtio/vhost-user.c
>+++ b/hw/virtio/vhost-user.c
>@@ -1474,6 +1474,7 @@ static int vhost_user_slave_handle_vring_host_notifier(struct vhost_dev *dev,
> g_free(name);
>
> if (virtio_queue_set_host_notifier_mr(vdev, queue_idx, &n->mr, true)) {
>+ object_unparent(OBJECT(&n->mr));
> munmap(addr, page_size);
> return -1;
> }
>--
>1.8.3.1
>
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-12 10:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 1:37 [PATCH] hw/virtio: Fix leak of host-notifier memory-region Yajun Wu via
2021-08-12 10:36 ` Stefano Garzarella
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.