All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gt: Potential error pointer dereference in pinned_context()
@ 2021-08-13 11:36 ` Dan Carpenter
  0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2021-08-13 11:36 UTC (permalink / raw)
  To: Jani Nikula, Chris Wilson
  Cc: Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter,
	Matthew Auld, Thomas Hellström, Jason Ekstrand,
	Lucas De Marchi, intel-gfx, dri-devel, kernel-janitors

If the intel_engine_create_pinned_context() function returns an error
pointer, then dereferencing "ce" will Oops.  Use "vm" instead of
"ce->vm".

Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index d0a7c934fd3b..1dac21aa7e5c 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -177,7 +177,7 @@ static struct intel_context *pinned_context(struct intel_gt *gt)
 	ce = intel_engine_create_pinned_context(engine, vm, SZ_512K,
 						I915_GEM_HWS_MIGRATE,
 						&key, "migrate");
-	i915_vm_put(ce->vm);
+	i915_vm_put(vm);
 	return ce;
 }
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-08-20 16:34 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 11:36 [PATCH] drm/i915/gt: Potential error pointer dereference in pinned_context() Dan Carpenter
2021-08-13 11:36 ` [Intel-gfx] " Dan Carpenter
2021-08-13 12:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-13 14:01 ` [PATCH] " Thomas Hellström
2021-08-13 14:01   ` [Intel-gfx] " Thomas Hellström
2021-08-20 16:34   ` Rodrigo Vivi
2021-08-20 16:34     ` [Intel-gfx] " Rodrigo Vivi
2021-08-13 16:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2021-08-18 18:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Potential error pointer dereference in pinned_context() (rev2) Patchwork
2021-08-18 20:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.