* [PATCH rdma-rc 0/3] RDMA/bnxt_re: Bug fixes
@ 2021-08-18 20:57 Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs Selvin Xavier
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Selvin Xavier @ 2021-08-18 20:57 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma, Selvin Xavier
Some simple bug fixes
Naresh Kumar PBS (1):
RDMA/bnxt_re: Add missing spin lock initialization
Selvin Xavier (2):
RDMA/bnxt_re: Disable atomic support on VFs
RDMA/bnxt_re: Fix query SRQ failure
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 +
drivers/infiniband/hw/bnxt_re/main.c | 2 +-
drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
--
2.5.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs
2021-08-18 20:57 [PATCH rdma-rc 0/3] RDMA/bnxt_re: Bug fixes Selvin Xavier
@ 2021-08-18 20:57 ` Selvin Xavier
2021-08-19 2:34 ` kernel test robot
2021-08-18 20:57 ` [PATCH rdma-rc 2/3] RDMA/bnxt_re: Add missing spin lock initialization Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 3/3] RDMA/bnxt_re: Fix query SRQ failure Selvin Xavier
2 siblings, 1 reply; 6+ messages in thread
From: Selvin Xavier @ 2021-08-18 20:57 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma, Selvin Xavier
Atomics is not currently supported for VFs. Enabling only
for PFs.
Fixes: 35f5ace5dea4 ("RDMA/bnxt_re: Enable global atomic ops if platform supports")
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
drivers/infiniband/hw/bnxt_re/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index a8688a9..f6d4c54 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -129,7 +129,7 @@ static int bnxt_re_setup_chip_ctx(struct bnxt_re_dev *rdev, u8 wqe_mode)
rdev->rcfw.res = &rdev->qplib_res;
bnxt_re_set_drv_mode(rdev, wqe_mode);
- if (bnxt_qplib_determine_atomics(en_dev->pdev))
+ if (!rdev->qplib_res.is_vf && bnxt_qplib_determine_atomics(en_dev->pdev))
ibdev_info(&rdev->ibdev,
"platform doesn't support global atomics.");
return 0;
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH rdma-rc 2/3] RDMA/bnxt_re: Add missing spin lock initialization
2021-08-18 20:57 [PATCH rdma-rc 0/3] RDMA/bnxt_re: Bug fixes Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs Selvin Xavier
@ 2021-08-18 20:57 ` Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 3/3] RDMA/bnxt_re: Fix query SRQ failure Selvin Xavier
2 siblings, 0 replies; 6+ messages in thread
From: Selvin Xavier @ 2021-08-18 20:57 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma, Naresh Kumar PBS, Selvin Xavier
From: Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>
Add the missing initialization of srq lock.
Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters")
Signed-off-by: Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index 283b6b8..ea0054c 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -1681,6 +1681,7 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq,
if (nq)
nq->budget++;
atomic_inc(&rdev->srq_count);
+ spin_lock_init(&srq->lock);
return 0;
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH rdma-rc 3/3] RDMA/bnxt_re: Fix query SRQ failure
2021-08-18 20:57 [PATCH rdma-rc 0/3] RDMA/bnxt_re: Bug fixes Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 2/3] RDMA/bnxt_re: Add missing spin lock initialization Selvin Xavier
@ 2021-08-18 20:57 ` Selvin Xavier
2 siblings, 0 replies; 6+ messages in thread
From: Selvin Xavier @ 2021-08-18 20:57 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma, Selvin Xavier, Naresh Kumar PBS
Fill the missing parameters for the FW command while
querying SRQ.
Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters")
Signed-off-by: Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index d4d4959..312bf25 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -713,6 +713,8 @@ int bnxt_qplib_query_srq(struct bnxt_qplib_res *res,
sbuf = bnxt_qplib_rcfw_alloc_sbuf(rcfw, sizeof(*sb));
if (!sbuf)
return -ENOMEM;
+ req.resp_size = sizeof(*sb) / BNXT_QPLIB_CMDQE_UNITS;
+ req.srq_cid = cpu_to_le32(srq->id);
sb = sbuf->sb;
rc = bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
(void *)sbuf, 0);
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs
2021-08-18 20:57 ` [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs Selvin Xavier
@ 2021-08-19 2:34 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-08-19 2:34 UTC (permalink / raw)
To: Selvin Xavier, jgg, dledford; +Cc: kbuild-all, linux-rdma, Selvin Xavier
[-- Attachment #1: Type: text/plain, Size: 2839 bytes --]
Hi Selvin,
I love your patch! Yet something to improve:
[auto build test ERROR on rdma/for-next]
[also build test ERROR on v5.14-rc6 next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Selvin-Xavier/RDMA-bnxt_re-Bug-fixes/20210819-045917
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5b4e1e8d37b166a3d6c7468eb96a8d7bc77740dd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Selvin-Xavier/RDMA-bnxt_re-Bug-fixes/20210819-045917
git checkout 5b4e1e8d37b166a3d6c7468eb96a8d7bc77740dd
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/infiniband/hw/bnxt_re/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_setup_chip_ctx':
>> drivers/infiniband/hw/bnxt_re/main.c:131:29: error: 'struct bnxt_qplib_res' has no member named 'is_vf'
131 | if (!rdev->qplib_res.is_vf && bnxt_qplib_determine_atomics(en_dev->pdev))
| ^
vim +131 drivers/infiniband/hw/bnxt_re/main.c
109
110 static int bnxt_re_setup_chip_ctx(struct bnxt_re_dev *rdev, u8 wqe_mode)
111 {
112 struct bnxt_qplib_chip_ctx *chip_ctx;
113 struct bnxt_en_dev *en_dev;
114 struct bnxt *bp;
115
116 en_dev = rdev->en_dev;
117 bp = netdev_priv(en_dev->net);
118
119 chip_ctx = kzalloc(sizeof(*chip_ctx), GFP_KERNEL);
120 if (!chip_ctx)
121 return -ENOMEM;
122 chip_ctx->chip_num = bp->chip_num;
123
124 rdev->chip_ctx = chip_ctx;
125 /* rest members to follow eventually */
126
127 rdev->qplib_res.cctx = rdev->chip_ctx;
128 rdev->rcfw.res = &rdev->qplib_res;
129
130 bnxt_re_set_drv_mode(rdev, wqe_mode);
> 131 if (!rdev->qplib_res.is_vf && bnxt_qplib_determine_atomics(en_dev->pdev))
132 ibdev_info(&rdev->ibdev,
133 "platform doesn't support global atomics.");
134 return 0;
135 }
136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64468 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs
@ 2021-08-19 2:34 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-08-19 2:34 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]
Hi Selvin,
I love your patch! Yet something to improve:
[auto build test ERROR on rdma/for-next]
[also build test ERROR on v5.14-rc6 next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Selvin-Xavier/RDMA-bnxt_re-Bug-fixes/20210819-045917
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5b4e1e8d37b166a3d6c7468eb96a8d7bc77740dd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Selvin-Xavier/RDMA-bnxt_re-Bug-fixes/20210819-045917
git checkout 5b4e1e8d37b166a3d6c7468eb96a8d7bc77740dd
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/infiniband/hw/bnxt_re/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_setup_chip_ctx':
>> drivers/infiniband/hw/bnxt_re/main.c:131:29: error: 'struct bnxt_qplib_res' has no member named 'is_vf'
131 | if (!rdev->qplib_res.is_vf && bnxt_qplib_determine_atomics(en_dev->pdev))
| ^
vim +131 drivers/infiniband/hw/bnxt_re/main.c
109
110 static int bnxt_re_setup_chip_ctx(struct bnxt_re_dev *rdev, u8 wqe_mode)
111 {
112 struct bnxt_qplib_chip_ctx *chip_ctx;
113 struct bnxt_en_dev *en_dev;
114 struct bnxt *bp;
115
116 en_dev = rdev->en_dev;
117 bp = netdev_priv(en_dev->net);
118
119 chip_ctx = kzalloc(sizeof(*chip_ctx), GFP_KERNEL);
120 if (!chip_ctx)
121 return -ENOMEM;
122 chip_ctx->chip_num = bp->chip_num;
123
124 rdev->chip_ctx = chip_ctx;
125 /* rest members to follow eventually */
126
127 rdev->qplib_res.cctx = rdev->chip_ctx;
128 rdev->rcfw.res = &rdev->qplib_res;
129
130 bnxt_re_set_drv_mode(rdev, wqe_mode);
> 131 if (!rdev->qplib_res.is_vf && bnxt_qplib_determine_atomics(en_dev->pdev))
132 ibdev_info(&rdev->ibdev,
133 "platform doesn't support global atomics.");
134 return 0;
135 }
136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 64468 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-19 2:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 20:57 [PATCH rdma-rc 0/3] RDMA/bnxt_re: Bug fixes Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 1/3] RDMA/bnxt_re: Disable atomic support on VFs Selvin Xavier
2021-08-19 2:34 ` kernel test robot
2021-08-19 2:34 ` kernel test robot
2021-08-18 20:57 ` [PATCH rdma-rc 2/3] RDMA/bnxt_re: Add missing spin lock initialization Selvin Xavier
2021-08-18 20:57 ` [PATCH rdma-rc 3/3] RDMA/bnxt_re: Fix query SRQ failure Selvin Xavier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.