* [PATCH] kselftest/arm64: mte: Fix misleading output when skipping tests
@ 2021-08-19 17:29 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-08-19 17:29 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Shuah Khan
Cc: Amit Daniel Kachhap, linux-arm-kernel, linux-kselftest, Mark Brown
When skipping the tests due to a lack of system support for MTE we
currently print a message saying FAIL which makes it look like the test
failed even though the test did actually report KSFT_SKIP, creating some
confusion. Change the error message to say SKIP instead so things are
clearer.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/arm64/mte/mte_common_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b/tools/testing/selftests/arm64/mte/mte_common_util.c
index f50ac31920d1..0328a1e08f65 100644
--- a/tools/testing/selftests/arm64/mte/mte_common_util.c
+++ b/tools/testing/selftests/arm64/mte/mte_common_util.c
@@ -298,7 +298,7 @@ int mte_default_setup(void)
int ret;
if (!(hwcaps2 & HWCAP2_MTE)) {
- ksft_print_msg("FAIL: MTE features unavailable\n");
+ ksft_print_msg("SKIP: MTE features unavailable\n");
return KSFT_SKIP;
}
/* Get current mte mode */
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] kselftest/arm64: mte: Fix misleading output when skipping tests
@ 2021-08-19 17:29 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-08-19 17:29 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Shuah Khan
Cc: Amit Daniel Kachhap, linux-arm-kernel, linux-kselftest, Mark Brown
When skipping the tests due to a lack of system support for MTE we
currently print a message saying FAIL which makes it look like the test
failed even though the test did actually report KSFT_SKIP, creating some
confusion. Change the error message to say SKIP instead so things are
clearer.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/arm64/mte/mte_common_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b/tools/testing/selftests/arm64/mte/mte_common_util.c
index f50ac31920d1..0328a1e08f65 100644
--- a/tools/testing/selftests/arm64/mte/mte_common_util.c
+++ b/tools/testing/selftests/arm64/mte/mte_common_util.c
@@ -298,7 +298,7 @@ int mte_default_setup(void)
int ret;
if (!(hwcaps2 & HWCAP2_MTE)) {
- ksft_print_msg("FAIL: MTE features unavailable\n");
+ ksft_print_msg("SKIP: MTE features unavailable\n");
return KSFT_SKIP;
}
/* Get current mte mode */
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kselftest/arm64: mte: Fix misleading output when skipping tests
2021-08-19 17:29 ` Mark Brown
@ 2021-08-20 10:21 ` Catalin Marinas
-1 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-08-20 10:21 UTC (permalink / raw)
To: Will Deacon, Mark Brown, Shuah Khan
Cc: linux-kselftest, linux-arm-kernel, Amit Daniel Kachhap
On Thu, 19 Aug 2021 18:29:02 +0100, Mark Brown wrote:
> When skipping the tests due to a lack of system support for MTE we
> currently print a message saying FAIL which makes it look like the test
> failed even though the test did actually report KSFT_SKIP, creating some
> confusion. Change the error message to say SKIP instead so things are
> clearer.
Applied to arm64 (for-next/kselftest), thanks!
[1/1] kselftest/arm64: mte: Fix misleading output when skipping tests
https://git.kernel.org/arm64/c/83e5dcbece4e
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kselftest/arm64: mte: Fix misleading output when skipping tests
@ 2021-08-20 10:21 ` Catalin Marinas
0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-08-20 10:21 UTC (permalink / raw)
To: Will Deacon, Mark Brown, Shuah Khan
Cc: linux-kselftest, linux-arm-kernel, Amit Daniel Kachhap
On Thu, 19 Aug 2021 18:29:02 +0100, Mark Brown wrote:
> When skipping the tests due to a lack of system support for MTE we
> currently print a message saying FAIL which makes it look like the test
> failed even though the test did actually report KSFT_SKIP, creating some
> confusion. Change the error message to say SKIP instead so things are
> clearer.
Applied to arm64 (for-next/kselftest), thanks!
[1/1] kselftest/arm64: mte: Fix misleading output when skipping tests
https://git.kernel.org/arm64/c/83e5dcbece4e
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-20 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 17:29 [PATCH] kselftest/arm64: mte: Fix misleading output when skipping tests Mark Brown
2021-08-19 17:29 ` Mark Brown
2021-08-20 10:21 ` Catalin Marinas
2021-08-20 10:21 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.