* [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
@ 2021-08-25 7:47 Tianci Yin
2021-08-25 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Tianci Yin @ 2021-08-25 7:47 UTC (permalink / raw)
To: igt-dev, Petri Latvala, Arkadiusz Hiler
Cc: Rodrigo Siqueira, Mark Yacoub, Harry Wentland, Nicholas Choi, Tianci.Yin
From: "Tianci.Yin" <tianci.yin@amd.com>
[why]
For subtest legacy-setmode and atomic-setmode, fb buffer is
unbinded from plane by block_plane(), then igt_display_commit2()
will trigger a dmesg warning message in drm_atomic_helper_commit(),
since for block commit, drm will wait fences that represents
finishing fb writing, when it find this fence has no accompanying
fb, it gives out a warning.
[how]
Just remove igt_plane_set_fb() from block_plane() to retain
the fb binding with plane.
Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630
(inside i7-9700K), both pass.
Signed-off-by: Tianci.Yin <tianci.yin@amd.com>
---
tests/kms_atomic_interruptible.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index 0a127921..03980d6e 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_
if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {
igt_output_set_pipe(output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
}
igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_atomic_interruptible: fix a warning message on AMD GPU
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
@ 2021-08-25 12:09 ` Patchwork
2021-08-25 17:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-08-25 12:09 UTC (permalink / raw)
To: Tianci Yin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 2931 bytes --]
== Series Details ==
Series: tests/kms_atomic_interruptible: fix a warning message on AMD GPU
URL : https://patchwork.freedesktop.org/series/94006/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10519 -> IGTPW_6153
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/index.html
Known issues
------------
Here are the changes found in IGTPW_6153 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [PASS][1] -> [INCOMPLETE][2] ([i915#2940])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][3] ([fdo#109271] / [i915#1436] / [i915#2722])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/fi-bsw-kefka/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [DMESG-WARN][4] ([i915#3958]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-rkl-11600: [SKIP][6] ([i915#3919]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/fi-rkl-11600/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/fi-rkl-11600/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3919]: https://gitlab.freedesktop.org/drm/intel/issues/3919
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958
Participating hosts (40 -> 33)
------------------------------
Missing (7): fi-ilk-m540 bat-adls-5 fi-hsw-4200u fi-tgl-1115g4 fi-bsw-cyan fi-bdw-samus bat-jsl-1
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6185 -> IGTPW_6153
CI-20190529: 20190529
CI_DRM_10519: 3edb12bf2c3cd732bc930e3e418e4aeaaaf32ffa @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6153: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/index.html
IGT_6185: 5dca04416f50576f464ebbd9aea96edccd7e4eab @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/index.html
[-- Attachment #2: Type: text/html, Size: 3609 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_atomic_interruptible: fix a warning message on AMD GPU
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
2021-08-25 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-08-25 17:11 ` Patchwork
2021-08-26 7:28 ` [igt-dev] [PATCH] " Yin, Tianci (Rico)
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-08-25 17:11 UTC (permalink / raw)
To: Tianci Yin; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 24715 bytes --]
== Series Details ==
Series: tests/kms_atomic_interruptible: fix a warning message on AMD GPU
URL : https://patchwork.freedesktop.org/series/94006/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10519_full -> IGTPW_6153_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/index.html
Known issues
------------
Here are the changes found in IGTPW_6153_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl3/igt@gem_create@create-massive.html
- shard-apl: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl2/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-snb6/igt@gem_ctx_persistence@idempotent.html
* igt@gem_eio@hibernate:
- shard-iclb: [PASS][4] -> [DMESG-WARN][5] ([i915#1226])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb5/igt@gem_eio@hibernate.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb8/igt@gem_eio@hibernate.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][6] ([i915#3354])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-snb5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl2/igt@gem_exec_fair@basic-deadline.html
- shard-apl: NOTRUN -> [FAIL][9] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#307])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb5/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb6/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
* igt@gem_mmap_gtt@cpuset-medium-copy:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#1888] / [i915#307])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-glk6/igt@gem_mmap_gtt@cpuset-medium-copy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk6/igt@gem_mmap_gtt@cpuset-medium-copy.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#644])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][19] ([i915#2658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-snb6/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@yf-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#768])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb5/igt@gem_render_copy@yf-tiled-to-vebox-linear.html
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-kbl6/igt@gem_softpin@noreloc-s3.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl3/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3323])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl6/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271]) +274 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl8/igt@gen7_exec_parse@basic-offset.html
* igt@i915_pm_rpm@gem-mmap-type@fixed:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3976])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl2/igt@i915_pm_rpm@gem-mmap-type@fixed.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [PASS][26] -> [DMESG-WARN][27] ([i915#118] / [i915#95]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-glk7/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk8/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3777]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#111615])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#110723])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb4/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3886]) +11 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
- shard-glk: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk7/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109278] / [i915#3886])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#3886])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb5/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][36] ([fdo#109271]) +369 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-snb7/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][37] ([fdo#109271]) +17 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk3/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#3689]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb1/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-snb: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +17 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-snb6/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +27 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk8/igt@kms_color_chamelium@pipe-d-ctm-max.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][42] ([i915#1319]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl7/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#3359])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-64x21-random:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278]) +6 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb5/igt@kms_cursor_crc@pipe-d-cursor-64x21-random.html
* igt@kms_dsc@basic-dsc-enable@edp-1-pipe-c:
- shard-iclb: NOTRUN -> [DMESG-WARN][45] ([i915#1226]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb2/igt@kms_dsc@basic-dsc-enable@edp-1-pipe-c.html
* igt@kms_flip@2x-nonexisting-fb:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109274])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb4/igt@kms_flip@2x-nonexisting-fb.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: [PASS][47] -> [FAIL][48] ([i915#2546])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109280])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#533]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][52] ([fdo#108145] / [i915#265]) +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2733])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl8/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658]) +4 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][55] -> [SKIP][56] ([fdo#109642] / [fdo#111068] / [i915#658])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb2/igt@kms_psr2_su@page_flip.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb8/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@cursor_plane_onoff:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271]) +16 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl3/igt@kms_psr@cursor_plane_onoff.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][58] -> [SKIP][59] ([fdo#109441]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb2/igt@kms_psr@psr2_suspend.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb4/igt@kms_psr@psr2_suspend.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994]) +3 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl3/igt@sysfs_clients@fair-7.html
- shard-iclb: NOTRUN -> [SKIP][61] ([i915#2994])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb1/igt@sysfs_clients@fair-7.html
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2994])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl6/igt@sysfs_clients@fair-7.html
- shard-tglb: NOTRUN -> [SKIP][63] ([i915#2994])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb6/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][64] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-tglb2/igt@gem_eio@unwedge-stress.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [FAIL][66] ([i915#2842]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-glk6/igt@gem_exec_fair@basic-none-vip@rcs0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][68] ([i915#2842]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb7/igt@gem_exec_fair@basic-pace@bcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb2/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][70] ([i915#2428]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][72] ([fdo#109271]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@requests:
- shard-tglb: [DMESG-FAIL][74] -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-tglb1/igt@i915_selftest@live@requests.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb1/igt@i915_selftest@live@requests.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][76] ([i915#180]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-apl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-kbl: [DMESG-WARN][78] ([i915#180]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-kbl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl4/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [SKIP][80] ([i915#433]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-tglb8/igt@kms_hdmi_inject@inject-audio.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][82] ([fdo#109441]) -> [PASS][83] +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_rotation_crc@sprite-rotation-180:
- shard-glk: [FAIL][84] ([i915#1888] / [i915#65]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-glk5/igt@kms_rotation_crc@sprite-rotation-180.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-glk3/igt@kms_rotation_crc@sprite-rotation-180.html
* igt@kms_vblank@pipe-c-wait-forked-busy-hang:
- shard-kbl: [SKIP][86] ([fdo#109271]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-kbl1/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl1/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][88] ([i915#2842]) -> [SKIP][89] ([fdo#109271])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][90] ([i915#2684]) -> [WARN][91] ([i915#1804] / [i915#2684])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][92] ([i915#658]) -> [SKIP][93] ([i915#2920]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][94] ([i915#2920]) -> [SKIP][95] ([i915#658]) +2 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-apl: ([FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][100], [FAIL][101], [FAIL][102]) ([i915#180] / [i915#3002] / [i915#3363])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-apl3/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-apl1/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-apl8/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10519/shard-apl1/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl2/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl6/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/shard-apl6/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3976]: https://gitlab.freedesktop.org/drm/intel/issues/3976
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#65]: https://gitlab.freedesktop.org/drm/intel/issues/65
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 7)
------------------------------
Missing (4): pig-skl-6260u pig-kbl-iris shard-rkl pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6185 -> IGTPW_6153
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_10519: 3edb12bf2c3cd732bc930e3e418e4aeaaaf32ffa @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6153: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/index.html
IGT_6185: 5dca04416f50576f464ebbd9aea96edccd7e4eab @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6153/index.html
[-- Attachment #2: Type: text/html, Size: 31102 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
2021-08-25 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-25 17:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2021-08-26 7:28 ` Yin, Tianci (Rico)
2021-08-26 10:37 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_atomic_interruptible: fix a warning message on AMD GPU (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Yin, Tianci (Rico) @ 2021-08-26 7:28 UTC (permalink / raw)
To: igt-dev, Petri Latvala, Arkadiusz Hiler, Siqueira, Rodrigo
Cc: Mark Yacoub, Wentland, Harry, Choi, Nicholas
[-- Attachment #1: Type: text/plain, Size: 2042 bytes --]
[AMD Official Use Only]
Hi Siqueira, Rodrigo,
Would you please help reviewing this patch?
Thank you very much!
Rico
________________________________
From: Tianci Yin <tianci.yin@amd.com>
Sent: Wednesday, August 25, 2021 15:47
To: igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>; Petri Latvala <petri.latvala@intel.com>; Arkadiusz Hiler <arek@hiler.eu>
Cc: Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Mark Yacoub <markyacoub@google.com>; Wentland, Harry <Harry.Wentland@amd.com>; Choi, Nicholas <Nicholas.Choi@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
From: "Tianci.Yin" <tianci.yin@amd.com>
[why]
For subtest legacy-setmode and atomic-setmode, fb buffer is
unbinded from plane by block_plane(), then igt_display_commit2()
will trigger a dmesg warning message in drm_atomic_helper_commit(),
since for block commit, drm will wait fences that represents
finishing fb writing, when it find this fence has no accompanying
fb, it gives out a warning.
[how]
Just remove igt_plane_set_fb() from block_plane() to retain
the fb binding with plane.
Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630
(inside i7-9700K), both pass.
Signed-off-by: Tianci.Yin <tianci.yin@amd.com>
---
tests/kms_atomic_interruptible.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index 0a127921..03980d6e 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_
if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {
igt_output_set_pipe(output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
}
igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 4143 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_atomic_interruptible: fix a warning message on AMD GPU (rev2)
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
` (2 preceding siblings ...)
2021-08-26 7:28 ` [igt-dev] [PATCH] " Yin, Tianci (Rico)
@ 2021-08-26 10:37 ` Patchwork
2021-08-26 12:32 ` [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Rodrigo Siqueira
2021-08-26 12:36 ` Rodrigo Siqueira
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-08-26 10:37 UTC (permalink / raw)
To: Yin, Tianci (Rico); +Cc: igt-dev
== Series Details ==
Series: tests/kms_atomic_interruptible: fix a warning message on AMD GPU (rev2)
URL : https://patchwork.freedesktop.org/series/94006/
State : failure
== Summary ==
Applying: tests/kms_atomic_interruptible: fix a warning message on AMD GPU
Using index info to reconstruct a base tree...
Patch failed at 0001 tests/kms_atomic_interruptible: fix a warning message on AMD GPU
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
` (3 preceding siblings ...)
2021-08-26 10:37 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_atomic_interruptible: fix a warning message on AMD GPU (rev2) Patchwork
@ 2021-08-26 12:32 ` Rodrigo Siqueira
2021-08-26 12:36 ` Rodrigo Siqueira
5 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Siqueira @ 2021-08-26 12:32 UTC (permalink / raw)
To: Tianci Yin
Cc: igt-dev, Petri Latvala, Arkadiusz Hiler, Mark Yacoub,
Harry Wentland, Nicholas Choi
On 08/25, Tianci Yin wrote:
> From: "Tianci.Yin" <tianci.yin@amd.com>
>
> [why]
> For subtest legacy-setmode and atomic-setmode, fb buffer is
> unbinded from plane by block_plane(), then igt_display_commit2()
> will trigger a dmesg warning message in drm_atomic_helper_commit(),
> since for block commit, drm will wait fences that represents
> finishing fb writing, when it find this fence has no accompanying
> fb, it gives out a warning.
>
> [how]
> Just remove igt_plane_set_fb() from block_plane() to retain
> the fb binding with plane.
> Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630
> (inside i7-9700K), both pass.
>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com>
> ---
> tests/kms_atomic_interruptible.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> index 0a127921..03980d6e 100644
> --- a/tests/kms_atomic_interruptible.c
> +++ b/tests/kms_atomic_interruptible.c
> @@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_
>
> if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {
> igt_output_set_pipe(output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> }
> igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));
>
> --
> 2.25.1
>
Hi,
This change lgtm. I tested it on vkms, amdgpu, and vc4 (test skip).
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Thanks
Siqueira
--
Rodrigo Siqueira
https://siqueira.tech
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
` (4 preceding siblings ...)
2021-08-26 12:32 ` [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Rodrigo Siqueira
@ 2021-08-26 12:36 ` Rodrigo Siqueira
2021-08-27 2:26 ` Yin, Tianci (Rico)
5 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Siqueira @ 2021-08-26 12:36 UTC (permalink / raw)
To: Tianci Yin
Cc: igt-dev, Petri Latvala, Arkadiusz Hiler, Mark Yacoub,
Harry Wentland, Nicholas Choi
On 08/25, Tianci Yin wrote:
> From: "Tianci.Yin" <tianci.yin@amd.com>
>
> [why]
> For subtest legacy-setmode and atomic-setmode, fb buffer is
> unbinded from plane by block_plane(), then igt_display_commit2()
> will trigger a dmesg warning message in drm_atomic_helper_commit(),
> since for block commit, drm will wait fences that represents
> finishing fb writing, when it find this fence has no accompanying
> fb, it gives out a warning.
>
> [how]
> Just remove igt_plane_set_fb() from block_plane() to retain
> the fb binding with plane.
> Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630
> (inside i7-9700K), both pass.
>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com>
> ---
> tests/kms_atomic_interruptible.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> index 0a127921..03980d6e 100644
> --- a/tests/kms_atomic_interruptible.c
> +++ b/tests/kms_atomic_interruptible.c
> @@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_
>
> if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {
> igt_output_set_pipe(output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> }
> igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));
>
> --
> 2.25.1
>
Btw, did you submit a V2?
If so, it looks like that there is a merge problem in the new version, see:
https://patchwork.freedesktop.org/series/94006/#rev2
Thanks
--
Rodrigo Siqueira
https://siqueira.tech
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
2021-08-26 12:36 ` Rodrigo Siqueira
@ 2021-08-27 2:26 ` Yin, Tianci (Rico)
0 siblings, 0 replies; 8+ messages in thread
From: Yin, Tianci (Rico) @ 2021-08-27 2:26 UTC (permalink / raw)
To: Siqueira, Rodrigo
Cc: igt-dev, Petri Latvala, Arkadiusz Hiler, Mark Yacoub, Wentland,
Harry, Choi, Nicholas
[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]
[AMD Official Use Only]
Hi Rodrigo Siqueira,
Thanks for your reviewing.
I only sent the patch one time by git send-email, I don't know where does the V2 come from.
Thanks,
Rico
________________________________
From: Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
Sent: Thursday, August 26, 2021 20:36
To: Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Cc: igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>; Petri Latvala <petri.latvala@intel.com>; Arkadiusz Hiler <arek@hiler.eu>; Mark Yacoub <markyacoub@google.com>; Wentland, Harry <Harry.Wentland@amd.com>; Choi, Nicholas <Nicholas.Choi@amd.com>
Subject: Re: [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU
On 08/25, Tianci Yin wrote:
> From: "Tianci.Yin" <tianci.yin@amd.com>
>
> [why]
> For subtest legacy-setmode and atomic-setmode, fb buffer is
> unbinded from plane by block_plane(), then igt_display_commit2()
> will trigger a dmesg warning message in drm_atomic_helper_commit(),
> since for block commit, drm will wait fences that represents
> finishing fb writing, when it find this fence has no accompanying
> fb, it gives out a warning.
>
> [how]
> Just remove igt_plane_set_fb() from block_plane() to retain
> the fb binding with plane.
> Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630
> (inside i7-9700K), both pass.
>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com>
> ---
> tests/kms_atomic_interruptible.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> index 0a127921..03980d6e 100644
> --- a/tests/kms_atomic_interruptible.c
> +++ b/tests/kms_atomic_interruptible.c
> @@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_
>
> if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {
> igt_output_set_pipe(output, PIPE_NONE);
> - igt_plane_set_fb(plane, NULL);
> }
> igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));
>
> --
> 2.25.1
>
Btw, did you submit a V2?
If so, it looks like that there is a merge problem in the new version, see:
https://patchwork.freedesktop.org/series/94006/#rev2
Thanks
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: Type: text/html, Size: 4953 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-08-27 2:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 7:47 [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Tianci Yin
2021-08-25 12:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-25 17:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-08-26 7:28 ` [igt-dev] [PATCH] " Yin, Tianci (Rico)
2021-08-26 10:37 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_atomic_interruptible: fix a warning message on AMD GPU (rev2) Patchwork
2021-08-26 12:32 ` [igt-dev] [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU Rodrigo Siqueira
2021-08-26 12:36 ` Rodrigo Siqueira
2021-08-27 2:26 ` Yin, Tianci (Rico)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.