All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [i-g-t V2] tests/kms_setmode: Handle unsupported modes for invalid crtc test
@ 2021-08-27  5:23 Tejas Upadhyay
  2021-08-27  6:20 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_setmode: Handle unsupported modes for invalid crtc test (rev3) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Tejas Upadhyay @ 2021-08-27  5:23 UTC (permalink / raw)
  To: igt-dev

Unsupported modes in crtc need to return proper error in order
to report back that applied config was failed or not. Thus
previously added ENOENT error but later decided to remove
crtc_supports_mode check which is also possible solution.

Test affected (fail -> pass after change) :
igt@kms_setmode@invalid-clone-single-[crtc|crtc-stealing]

invalid-clone-single-crtc-stealing still fails which is not
related and will be handled with different follow up patch.

Changes since V1:
	- Replaced previous logic with crtc_supports_mode check removal

Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
---
 tests/kms_setmode.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 89220b83..80665204 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -569,9 +569,6 @@ int __test_crtc_config(struct crtc_config *crtcs, int crtc_count,
 	for (int i = 0; i < crtc->cconfs->connector->count_modes; i++) {
 		uint32_t *ids;
 
-		if (!crtc_supports_mode(crtc, &crtc->cconfs->connector->modes[i]))
-			continue;
-
 		crtc->mode = crtc->cconfs->connector->modes[i];
 
 		get_crtc_config_str(crtc, str_buf[base], sizeof(str_buf[base]));
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-30  6:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27  5:23 [igt-dev] [i-g-t V2] tests/kms_setmode: Handle unsupported modes for invalid crtc test Tejas Upadhyay
2021-08-27  6:20 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_setmode: Handle unsupported modes for invalid crtc test (rev3) Patchwork
2021-08-27  8:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-27 10:53 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_setmode: Handle unsupported modes for invalid crtc test (rev4) Patchwork
2021-08-27 14:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-08-30  6:29 ` [igt-dev] [i-g-t V2] tests/kms_setmode: Handle unsupported modes for invalid crtc test Modem, Bhanuprakash

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.