* [PATCH 1/2] doc: Clarify wording regarding actions and flow rules.
@ 2017-12-01 18:26 Roy Franz
2017-12-01 18:26 ` [PATCH 2/2] doc: Fix typo Roy Franz
2017-12-04 13:51 ` [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Adrien Mazarguil
0 siblings, 2 replies; 5+ messages in thread
From: Roy Franz @ 2017-12-01 18:26 UTC (permalink / raw)
To: dev; +Cc: Roy Franz
Current wording regarding actions and flow rules doesn't make sense.
Signed-off-by: Roy Franz <roy.franz@cavium.com>
---
Maybe a better word than 'assigned' could be chosen? (attached,
associated with, etc) I'm happy to spin this if needed.
doc/guides/prog_guide/rte_flow.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
index d158be5e4..9de6d32d3 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -984,7 +984,7 @@ Actions
~~~~~~~
Each possible action is represented by a type. Some have associated
-configuration structures. Several actions combined in a list can be affected
+configuration structures. Several actions combined in a list can be assigned
to a flow rule. That list is not ordered.
They fall in three categories:
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] doc: Fix typo
2017-12-01 18:26 [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Roy Franz
@ 2017-12-01 18:26 ` Roy Franz
2017-12-11 15:20 ` Mcnamara, John
2017-12-04 13:51 ` [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Adrien Mazarguil
1 sibling, 1 reply; 5+ messages in thread
From: Roy Franz @ 2017-12-01 18:26 UTC (permalink / raw)
To: dev; +Cc: Roy Franz
Fix trivial typo (an -> and) in description of service core masks.
Signed-off-by: Roy Franz <roy.franz@cavium.com>
---
doc/guides/prog_guide/service_cores.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/prog_guide/service_cores.rst b/doc/guides/prog_guide/service_cores.rst
index 3a029ba9c..5a8d8941a 100644
--- a/doc/guides/prog_guide/service_cores.rst
+++ b/doc/guides/prog_guide/service_cores.rst
@@ -55,7 +55,7 @@ Service Core Initialization
There are two methods to having service cores in a DPDK application, either by
using the service coremask, or by dynamically adding cores using the API.
The simpler of the two is to pass the `-s` coremask argument to EAL, which will
-take any cores available in the main DPDK coremask, an if the bits are also set
+take any cores available in the main DPDK coremask, and if the bits are also set
in the service coremask the cores become service-cores instead of DPDK
application lcores.
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] doc: Clarify wording regarding actions and flow rules.
2017-12-01 18:26 [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Roy Franz
2017-12-01 18:26 ` [PATCH 2/2] doc: Fix typo Roy Franz
@ 2017-12-04 13:51 ` Adrien Mazarguil
1 sibling, 0 replies; 5+ messages in thread
From: Adrien Mazarguil @ 2017-12-04 13:51 UTC (permalink / raw)
To: Roy Franz; +Cc: dev, Roy Franz
On Fri, Dec 01, 2017 at 10:26:39AM -0800, Roy Franz wrote:
> Current wording regarding actions and flow rules doesn't make sense.
>
> Signed-off-by: Roy Franz <roy.franz@cavium.com>
> ---
> Maybe a better word than 'assigned' could be chosen? (attached,
> associated with, etc) I'm happy to spin this if needed.
Agreed, "affected" doesn't make much sense here. I think "assigned" is the
best compromise (intelligibility / changes ratio).
This clarification is also a worthy candidate for stable@dpdk.org.
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] doc: Fix typo
2017-12-01 18:26 ` [PATCH 2/2] doc: Fix typo Roy Franz
@ 2017-12-11 15:20 ` Mcnamara, John
2018-01-11 17:37 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Mcnamara, John @ 2017-12-11 15:20 UTC (permalink / raw)
To: Roy Franz, dev; +Cc: Roy Franz
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roy Franz
> Sent: Friday, December 1, 2017 6:27 PM
> To: dev@dpdk.org
> Cc: Roy Franz <roy.franz@cavium.com>
> Subject: [dpdk-dev] [PATCH 2/2] doc: Fix typo
>
> Fix trivial typo (an -> and) in description of service core masks.
>
> Signed-off-by: Roy Franz <roy.franz@cavium.com>
Thanks. For future reference the subject line should be lowercase like:
doc: fix typo
Or better
doc: fix typo in service cores doc
See: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
Apart from that,
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] doc: Fix typo
2017-12-11 15:20 ` Mcnamara, John
@ 2018-01-11 17:37 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-01-11 17:37 UTC (permalink / raw)
To: Roy Franz; +Cc: dev, Mcnamara, John, Roy Franz
11/12/2017 16:20, Mcnamara, John:
> > Fix trivial typo (an -> and) in description of service core masks.
> >
> > Signed-off-by: Roy Franz <roy.franz@cavium.com>
>
> Thanks. For future reference the subject line should be lowercase like:
>
> doc: fix typo
>
> Or better
>
> doc: fix typo in service cores doc
Better to use "guide" when fixing a guide:
doc: fix typo in prog guide
> See: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
>
> Apart from that,
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Series applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-11 17:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 18:26 [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Roy Franz
2017-12-01 18:26 ` [PATCH 2/2] doc: Fix typo Roy Franz
2017-12-11 15:20 ` Mcnamara, John
2018-01-11 17:37 ` Thomas Monjalon
2017-12-04 13:51 ` [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Adrien Mazarguil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.