Re: [PATCH 3/4] arm64: dts: renesas: r8a7795: Add DU device to DT

Re: [PATCH 3/4] arm64: dts: renesas: r8a7795: Add DU device to DT

[Laurent Pinchart]

Hi Geert,

On Monday 25 Apr 2016 10:34:38 Geert Uytterhoeven wrote:
> On Sun, Apr 24, 2016 at 2:34 AM, Laurent Pinchart wrote:
> > Add the DU device to r8a7795.dtsi in a disabled state.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 46 +++++++++++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index
> > ad25330e7827..b64366c541ed 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -1379,5 +1379,51 @@
> >                         clocks = <&cpg CPG_MOD 600>;
> >                         power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> >                 };
> > +
> > +               du: display@feb00000 {
> > +                       compatible = "renesas,du-r8a7795";
> > +                       reg = <0 0xfeb00000 0 0x80000>,
> > +                             <0 0xfeb90000 0 0x14>;
> > +                       reg-names = "du", "lvds.0";
> > +                       interrupts = <0 256 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <0 268 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <0 269 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <0 270 IRQ_TYPE_LEVEL_HIGH>;
> 
> GIC_SPI (4x)

I'll fix that.

> > +                       clocks = <&cpg CPG_MOD 724>,
> > +                                <&cpg CPG_MOD 723>,
> > +                                <&cpg CPG_MOD 722>,
> > +                                <&cpg CPG_MOD 721>,
> > +                                <&cpg CPG_MOD 727>;
> > +                       clock-names = "du.0", "du.1", "du.2", "du.3",
> > "lvds.0";
>
> BTW, now you have your "always-on" PM Domain, it would be nice to revamp the
> DU bindings to have one device node per DU instance, so there can be a
> one-to-one mapping of device nodes, DU instances, and DU module clocks...

I wish it could be that easy. The DU instances are not independent, they share 
resources that are controlled by one DU in particular. It might be possible to 
split LVDS support out, but for the DU channels it would be way more complex.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/4] R-Car Gen3 DU enablement on Salvator-X board

[Laurent Pinchart]

Hi Simon,

The FCP DT bindings have been merged upstream, could you apply patches 1/4 and 
2/4 from this series to your tree ? I'll retest patch 3/4 and 4/4 and then ask 
you to apply them as well.

On Sunday 24 Apr 2016 03:34:51 Laurent Pinchart wrote:
> Hello,
> 
> This patch series enables DU support on the Salvator-X board. The first
> three patches add the FCPV, VSP and DU devices to the r8a7795 .dtsi, while
> the last patch enables DU support for the board. Only the VGA output is
> currently supported, support for HDMI is work in progress.
> 
> The FCP DT bindings have been posted for review [1] but haven't been
> approved yet. As the bindings are simple I expect that last missing
> dependency to be accepted very soon, in which case this series could be
> merged for v4.7. Early review would be appreciated to make sure this could
> happen.
> 
> [1] https://patchwork.linuxtv.org/patch/33006/
> 
> Laurent Pinchart (4):
>   arm64: dts: renesas: r8a7795: Add FCPV nodes
>   arm64: dts: renesas: r8a7795: Add VSP instances
>   arm64: dts: renesas: r8a7795: Add DU device to DT
>   arm64: dts: renesas: salvator-x: Enable DU
> 
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  44 +++++
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi           | 199 ++++++++++++++++++
>  2 files changed, 243 insertions(+)

-- 
Regards,

Laurent Pinchart