All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap
@ 2021-09-21  4:03 priyanka.dandamudi
  2021-09-21  4:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: priyanka.dandamudi @ 2021-09-21  4:03 UTC (permalink / raw)
  To: igt-dev, arjun.melkaveri, priyanka.dandamudi, matthew.auld,
	ashutosh.dixit

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Update mmap__wc with mmap__device_coherent, as it works
on discrete platforms, while still using an explicit WC mmap on
integrated platforms.
Below are the updated tests:
gem_exec_capture
gem_exec_nop
perf_pmu
prime_busy

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/gem_exec_capture.c | 4 ++--
 tests/i915/gem_exec_nop.c     | 7 ++++---
 tests/i915/perf_pmu.c         | 4 ++--
 tests/prime_busy.c            | 6 +++---
 4 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
index f2ea6cb0..19f3836e 100644
--- a/tests/i915/gem_exec_capture.c
+++ b/tests/i915/gem_exec_capture.c
@@ -107,7 +107,7 @@ static void __capture1(int fd, int dir, uint64_t ahnd, const intel_ctx_t *ctx,
 	reloc[1].read_domains = I915_GEM_DOMAIN_RENDER;
 	reloc[1].write_domain = I915_GEM_DOMAIN_RENDER;
 
-	seqno = gem_mmap__wc(fd, obj[SCRATCH].handle, 0, 4096, PROT_READ);
+	seqno = gem_mmap__device_coherent(fd, obj[SCRATCH].handle, 0, 4096, PROT_READ);
 	gem_set_domain(fd, obj[SCRATCH].handle,
 			I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 
@@ -278,7 +278,7 @@ static struct offset {
 		obj[count + 1].relocation_count = ARRAY_SIZE(reloc);
 	}
 
-	seqno = gem_mmap__wc(fd, obj[0].handle, 0, 4096, PROT_READ);
+	seqno = gem_mmap__device_coherent(fd, obj[0].handle, 0, 4096, PROT_READ);
 	gem_set_domain(fd, obj[0].handle,
 			I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 
diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
index c435335b..03adc9ee 100644
--- a/tests/i915/gem_exec_nop.c
+++ b/tests/i915/gem_exec_nop.c
@@ -132,7 +132,7 @@ static void poll_ring(int fd, const intel_ctx_t *ctx,
 	obj.relocation_count = ARRAY_SIZE(reloc);
 
 	r = memset(reloc, 0, sizeof(reloc));
-	batch = gem_mmap__wc(fd, obj.handle, 0, 4096, PROT_WRITE);
+	batch = gem_mmap__device_coherent(fd, obj.handle, 0, 4096, PROT_WRITE);
 
 	for (unsigned int start_offset = 0;
 	     start_offset <= 128;
@@ -257,7 +257,7 @@ static void poll_sequential(int fd, const intel_ctx_t *ctx,
 	obj[1].relocation_count = ARRAY_SIZE(reloc);
 
 	r = memset(reloc, 0, sizeof(reloc));
-	batch = gem_mmap__wc(fd, obj[1].handle, 0, 4096, PROT_WRITE);
+	batch = gem_mmap__device_coherent(fd, obj[1].handle, 0, 4096, PROT_WRITE);
 
 	for (unsigned int start_offset = 0;
 	     start_offset <= 128;
@@ -313,7 +313,7 @@ static void poll_sequential(int fd, const intel_ctx_t *ctx,
 	if (cached)
 		state = gem_mmap__cpu(fd, obj[0].handle, 0, 4096, PROT_READ);
 	else
-		state = gem_mmap__wc(fd, obj[0].handle, 0, 4096, PROT_READ);
+		state = gem_mmap__device_coherent(fd, obj[0].handle, 0, 4096, PROT_READ);
 
 	memset(&execbuf, 0, sizeof(execbuf));
 	execbuf.buffers_ptr = to_user_pointer(obj);
@@ -972,6 +972,7 @@ igt_main
 
 		device = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(device);
+		gem_require_mmap_device_coherent(device);
 		gem_submission_print_method(device);
 		gem_scheduler_print_capability(device);
 
diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index 924f39d1..1214cda8 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -717,7 +717,7 @@ sema_wait(int gem_fd, const intel_ctx_t *ctx,
 	bb_offset = get_offset(ahnd, bb_handle, 4096, 0);
 	obj_offset = get_offset(ahnd, obj_handle, 4096, 0);
 
-	obj_ptr = gem_mmap__wc(gem_fd, obj_handle, 0, 4096, PROT_WRITE);
+	obj_ptr = gem_mmap__device_coherent(gem_fd, obj_handle, 0, 4096, PROT_WRITE);
 
 	batch[0] = MI_STORE_DWORD_IMM;
 	batch[1] = obj_offset + sizeof(*obj_ptr);
@@ -877,7 +877,7 @@ __sema_busy(int gem_fd, uint64_t ahnd, int pmu, const intel_ctx_t *ctx,
 
 	gem_quiescent_gpu(gem_fd);
 
-	map = gem_mmap__wc(gem_fd, obj.handle, 0, 4096, PROT_WRITE);
+	map = gem_mmap__device_coherent(gem_fd, obj.handle, 0, 4096, PROT_WRITE);
 	gem_execbuf(gem_fd, &eb);
 	spin = igt_spin_new(gem_fd, .ahnd = ahnd, .ctx = ctx, .engine = e->flags);
 
diff --git a/tests/prime_busy.c b/tests/prime_busy.c
index e2684837..0cc011e5 100644
--- a/tests/prime_busy.c
+++ b/tests/prime_busy.c
@@ -83,7 +83,7 @@ static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 		pfd[BATCH].fd = prime_handle_to_fd(fd, obj[BATCH].handle);
 	}
 
-	batch = gem_mmap__wc(fd, obj[BATCH].handle, 0, size, PROT_WRITE);
+	batch = gem_mmap__device_coherent(fd, obj[BATCH].handle, 0, size, PROT_WRITE);
 	gem_set_domain(fd, obj[BATCH].handle,
 			I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
 
@@ -175,7 +175,7 @@ static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 	igt_assert(!prime_busy(&pfd[SCRATCH], true));
 
 	munmap(batch, size);
-	batch = gem_mmap__wc(fd, obj[SCRATCH].handle, 0, 4096, PROT_READ);
+	batch = gem_mmap__device_coherent(fd, obj[SCRATCH].handle, 0, 4096, PROT_READ);
 	for (i = 0; i < 1024; i++)
 		igt_assert_eq_u32(batch[i], i);
 	munmap(batch, 4096);
@@ -237,7 +237,7 @@ igt_main
 		};
 
 		igt_fixture
-			gem_require_mmap_wc(fd);
+			gem_require_mmap_device_coherent(fd);
 
 		for (const struct mode *m = modes; m->name; m++) {
 			igt_subtest_with_dynamic(m->name)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: use device_coherent mmap
  2021-09-21  4:03 [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap priyanka.dandamudi
@ 2021-09-21  4:58 ` Patchwork
  2021-09-21 15:50 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
  2021-09-24 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: use device_coherent mmap (rev2) Patchwork
  2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-09-21  4:58 UTC (permalink / raw)
  To: priyanka.dandamudi; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 7671 bytes --]

== Series Details ==

Series: tests/i915: use device_coherent mmap
URL   : https://patchwork.freedesktop.org/series/94880/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10615 -> IGTPW_6241
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6241 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6241, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6241:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload:
    - fi-bxt-dsi:         NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-bxt-dsi/igt@i915_module_load@reload.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_module_load@reload:
    - {fi-jsl-1}:         [TIMEOUT][2] ([i915#4136]) -> [INCOMPLETE][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-jsl-1/igt@i915_module_load@reload.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-jsl-1/igt@i915_module_load@reload.html

  
Known issues
------------

  Here are the changes found in IGTPW_6241 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-compute:
    - fi-cfl-guc:         NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-cfl-guc/igt@amdgpu/amd_basic@cs-compute.html

  * igt@amdgpu/amd_basic@cs-sdma:
    - fi-cfl-8109u:       NOTRUN -> [SKIP][5] ([fdo#109271]) +17 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-cfl-8109u/igt@amdgpu/amd_basic@cs-sdma.html
    - fi-kbl-7500u:       NOTRUN -> [SKIP][6] ([fdo#109271]) +17 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-kbl-7500u/igt@amdgpu/amd_basic@cs-sdma.html

  * igt@i915_module_load@reload:
    - fi-rkl-guc:         NOTRUN -> [INCOMPLETE][7] ([i915#4130] / [i915#4136])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-rkl-guc/igt@i915_module_load@reload.html
    - fi-bsw-kefka:       [PASS][8] -> [INCOMPLETE][9] ([i915#4179])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-bsw-kefka/igt@i915_module_load@reload.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-bsw-kefka/igt@i915_module_load@reload.html
    - fi-glk-dsi:         [PASS][10] -> [INCOMPLETE][11] ([i915#4130])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-glk-dsi/igt@i915_module_load@reload.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-glk-dsi/igt@i915_module_load@reload.html
    - fi-cfl-8109u:       NOTRUN -> [DMESG-WARN][12] ([i915#4136])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-cfl-8109u/igt@i915_module_load@reload.html
    - fi-bsw-nick:        [PASS][13] -> [INCOMPLETE][14] ([i915#4179])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-bsw-nick/igt@i915_module_load@reload.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-bsw-nick/igt@i915_module_load@reload.html

  * igt@runner@aborted:
    - fi-bsw-kefka:       NOTRUN -> [FAIL][15] ([i915#3690])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-bsw-kefka/igt@runner@aborted.html
    - fi-bsw-nick:        NOTRUN -> [FAIL][16] ([i915#3690])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-bsw-nick/igt@runner@aborted.html
    - fi-rkl-guc:         NOTRUN -> [FAIL][17] ([i915#2426] / [i915#4136])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-rkl-guc/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-rkl-guc:         [INCOMPLETE][18] ([i915#4130]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html
    - fi-cfl-guc:         [INCOMPLETE][20] ([i915#4130]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-cfl-guc/igt@core_hotunplug@unbind-rebind.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-cfl-guc/igt@core_hotunplug@unbind-rebind.html
    - fi-bxt-dsi:         [INCOMPLETE][22] ([i915#4130]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-bxt-dsi/igt@core_hotunplug@unbind-rebind.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-bxt-dsi/igt@core_hotunplug@unbind-rebind.html
    - fi-kbl-7500u:       [INCOMPLETE][24] ([i915#4130]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
    - fi-cfl-8109u:       [INCOMPLETE][26] ([i915#4130]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
    - fi-rkl-guc:         [SKIP][28] ([i915#3919]) -> [PASS][29] +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-rkl-guc/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-rkl-guc/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html

  
#### Warnings ####

  * igt@i915_module_load@reload:
    - fi-kbl-r:           [TIMEOUT][30] ([i915#4136]) -> [INCOMPLETE][31] ([i915#4130])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10615/fi-kbl-r/igt@i915_module_load@reload.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/fi-kbl-r/igt@i915_module_load@reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
  [i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
  [i915#3919]: https://gitlab.freedesktop.org/drm/intel/issues/3919
  [i915#4130]: https://gitlab.freedesktop.org/drm/intel/issues/4130
  [i915#4136]: https://gitlab.freedesktop.org/drm/intel/issues/4136
  [i915#4179]: https://gitlab.freedesktop.org/drm/intel/issues/4179


Participating hosts (37 -> 31)
------------------------------

  Missing    (6): bat-dg1-6 fi-tgl-1115g4 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus bat-jsl-1 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6213 -> IGTPW_6241

  CI-20190529: 20190529
  CI_DRM_10615: 4aedbb89fd6dc4f0b3c5e9213059b0e84e054d19 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6241: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/index.html
  IGT_6213: e9ae59cb8b4f1e7bc61a9261f33fc7e52ae06c65 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6241/index.html

[-- Attachment #2: Type: text/html, Size: 9605 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap
  2021-09-21  4:03 [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap priyanka.dandamudi
  2021-09-21  4:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2021-09-21 15:50 ` Matthew Auld
  2021-09-24 11:06   ` Matthew Auld
  2021-09-24 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: use device_coherent mmap (rev2) Patchwork
  2 siblings, 1 reply; 8+ messages in thread
From: Matthew Auld @ 2021-09-21 15:50 UTC (permalink / raw)
  To: priyanka.dandamudi; +Cc: igt-dev, arjun.melkaveri, Matthew Auld, Ashutosh Dixit

On Tue, 21 Sept 2021 at 05:10, <priyanka.dandamudi@intel.com> wrote:
>
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Update mmap__wc with mmap__device_coherent, as it works
> on discrete platforms, while still using an explicit WC mmap on
> integrated platforms.
> Below are the updated tests:
> gem_exec_capture
> gem_exec_nop
> perf_pmu
> prime_busy
>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap
  2021-09-21 15:50 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
@ 2021-09-24 11:06   ` Matthew Auld
  2021-09-24 11:17     ` Petri Latvala
  0 siblings, 1 reply; 8+ messages in thread
From: Matthew Auld @ 2021-09-24 11:06 UTC (permalink / raw)
  To: priyanka.dandamudi; +Cc: igt-dev, arjun.melkaveri, Matthew Auld, Ashutosh Dixit

On Tue, 21 Sept 2021 at 16:50, Matthew Auld
<matthew.william.auld@gmail.com> wrote:
>
> On Tue, 21 Sept 2021 at 05:10, <priyanka.dandamudi@intel.com> wrote:
> >
> > From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> >
> > Update mmap__wc with mmap__device_coherent, as it works
> > on discrete platforms, while still using an explicit WC mmap on
> > integrated platforms.
> > Below are the updated tests:
> > gem_exec_capture
> > gem_exec_nop
> > perf_pmu
> > prime_busy
> >
> > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>

Could you please re-send this for CI(or hit the test-again button in
pw)? Plus the other related series? DG1 BAT looks to be in better
shape now.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap
  2021-09-24 11:06   ` Matthew Auld
@ 2021-09-24 11:17     ` Petri Latvala
  2021-09-24 11:24       ` Matthew Auld
  0 siblings, 1 reply; 8+ messages in thread
From: Petri Latvala @ 2021-09-24 11:17 UTC (permalink / raw)
  To: Matthew Auld
  Cc: priyanka.dandamudi, igt-dev, arjun.melkaveri, Matthew Auld,
	Ashutosh Dixit

On Fri, Sep 24, 2021 at 12:06:06PM +0100, Matthew Auld wrote:
> On Tue, 21 Sept 2021 at 16:50, Matthew Auld
> <matthew.william.auld@gmail.com> wrote:
> >
> > On Tue, 21 Sept 2021 at 05:10, <priyanka.dandamudi@intel.com> wrote:
> > >
> > > From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > >
> > > Update mmap__wc with mmap__device_coherent, as it works
> > > on discrete platforms, while still using an explicit WC mmap on
> > > integrated platforms.
> > > Below are the updated tests:
> > > gem_exec_capture
> > > gem_exec_nop
> > > perf_pmu
> > > prime_busy
> > >
> > > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > > Cc: Matthew Auld <matthew.auld@intel.com>
> > > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> 
> Could you please re-send this for CI(or hit the test-again button in
> pw)? Plus the other related series? DG1 BAT looks to be in better
> shape now.

Re-test for this queued.


-- 
Petri Latvala

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap
  2021-09-24 11:17     ` Petri Latvala
@ 2021-09-24 11:24       ` Matthew Auld
  2021-09-24 12:04         ` Petri Latvala
  0 siblings, 1 reply; 8+ messages in thread
From: Matthew Auld @ 2021-09-24 11:24 UTC (permalink / raw)
  To: Petri Latvala
  Cc: priyanka.dandamudi, igt-dev, arjun.melkaveri, Matthew Auld,
	Ashutosh Dixit

On Fri, 24 Sept 2021 at 12:13, Petri Latvala <petri.latvala@intel.com> wrote:
>
> On Fri, Sep 24, 2021 at 12:06:06PM +0100, Matthew Auld wrote:
> > On Tue, 21 Sept 2021 at 16:50, Matthew Auld
> > <matthew.william.auld@gmail.com> wrote:
> > >
> > > On Tue, 21 Sept 2021 at 05:10, <priyanka.dandamudi@intel.com> wrote:
> > > >
> > > > From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > > >
> > > > Update mmap__wc with mmap__device_coherent, as it works
> > > > on discrete platforms, while still using an explicit WC mmap on
> > > > integrated platforms.
> > > > Below are the updated tests:
> > > > gem_exec_capture
> > > > gem_exec_nop
> > > > perf_pmu
> > > > prime_busy
> > > >
> > > > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > > > Cc: Matthew Auld <matthew.auld@intel.com>
> > > > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> >
> > Could you please re-send this for CI(or hit the test-again button in
> > pw)? Plus the other related series? DG1 BAT looks to be in better
> > shape now.
>
> Re-test for this queued.

Thanks a bunch. Could you please also use your superpowers to re-test:
https://patchwork.freedesktop.org/series/94726/

?

>
>
> --
> Petri Latvala

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap
  2021-09-24 11:24       ` Matthew Auld
@ 2021-09-24 12:04         ` Petri Latvala
  0 siblings, 0 replies; 8+ messages in thread
From: Petri Latvala @ 2021-09-24 12:04 UTC (permalink / raw)
  To: Matthew Auld
  Cc: priyanka.dandamudi, igt-dev, arjun.melkaveri, Matthew Auld,
	Ashutosh Dixit

On Fri, Sep 24, 2021 at 12:24:02PM +0100, Matthew Auld wrote:
> On Fri, 24 Sept 2021 at 12:13, Petri Latvala <petri.latvala@intel.com> wrote:
> >
> > On Fri, Sep 24, 2021 at 12:06:06PM +0100, Matthew Auld wrote:
> > > On Tue, 21 Sept 2021 at 16:50, Matthew Auld
> > > <matthew.william.auld@gmail.com> wrote:
> > > >
> > > > On Tue, 21 Sept 2021 at 05:10, <priyanka.dandamudi@intel.com> wrote:
> > > > >
> > > > > From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > > > >
> > > > > Update mmap__wc with mmap__device_coherent, as it works
> > > > > on discrete platforms, while still using an explicit WC mmap on
> > > > > integrated platforms.
> > > > > Below are the updated tests:
> > > > > gem_exec_capture
> > > > > gem_exec_nop
> > > > > perf_pmu
> > > > > prime_busy
> > > > >
> > > > > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > > > > Cc: Matthew Auld <matthew.auld@intel.com>
> > > > > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> > >
> > > Could you please re-send this for CI(or hit the test-again button in
> > > pw)? Plus the other related series? DG1 BAT looks to be in better
> > > shape now.
> >
> > Re-test for this queued.
> 
> Thanks a bunch. Could you please also use your superpowers to re-test:
> https://patchwork.freedesktop.org/series/94726/
> 
> ?

Done.


-- 
Petri Latvala

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: use device_coherent mmap (rev2)
  2021-09-21  4:03 [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap priyanka.dandamudi
  2021-09-21  4:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  2021-09-21 15:50 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
@ 2021-09-24 12:11 ` Patchwork
  2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-09-24 12:11 UTC (permalink / raw)
  To: priyanka.dandamudi; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 6033 bytes --]

== Series Details ==

Series: tests/i915: use device_coherent mmap (rev2)
URL   : https://patchwork.freedesktop.org/series/94880/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10636 -> IGTPW_6256
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6256 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6256, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6256:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_basic@create-close:
    - fi-kbl-soraka:      [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10636/fi-kbl-soraka/igt@gem_basic@create-close.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-kbl-soraka/igt@gem_basic@create-close.html

  
Known issues
------------

  Here are the changes found in IGTPW_6256 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@query-info:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][3] ([fdo#109315])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html

  * igt@amdgpu/amd_cs_nop@nop-gfx0:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][4] ([fdo#109315] / [i915#2575]) +16 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html

  * igt@gem_huc_copy@huc-copy:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][5] ([i915#2190])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html

  * igt@i915_pm_backlight@basic-brightness:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][6] ([i915#1155])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][7] ([fdo#111827]) +8 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][8] ([i915#4103]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][9] ([fdo#109285])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_psr@primary_mmap_gtt:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][10] ([i915#1072]) +3 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html

  * igt@prime_vgem@basic-userptr:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][11] ([i915#3301])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gtt:
    - fi-bdw-5557u:       [DMESG-FAIL][12] ([i915#3674]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10636/fi-bdw-5557u/igt@i915_selftest@live@gtt.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-bdw-5557u/igt@i915_selftest@live@gtt.html

  * igt@kms_flip@basic-flip-vs-modeset@c-dp1:
    - fi-cfl-8109u:       [FAIL][14] ([i915#4165]) -> [PASS][15] +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10636/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
    - fi-cfl-8109u:       [DMESG-WARN][16] ([i915#295]) -> [PASS][17] +18 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10636/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html

  
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3674]: https://gitlab.freedesktop.org/drm/intel/issues/3674
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165


Participating hosts (40 -> 34)
------------------------------

  Additional (1): fi-tgl-1115g4 
  Missing    (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-bdw-samus bat-jsl-2 bat-jsl-1 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6218 -> IGTPW_6256

  CI-20190529: 20190529
  CI_DRM_10636: 182ebf8cf588fa509b36f2b7de3a25eff9624238 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6256: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/index.html
  IGT_6218: 8d4169d9543d8e5c01f0c746f603801a4d65ead0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6256/index.html

[-- Attachment #2: Type: text/html, Size: 7035 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-24 12:11 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21  4:03 [igt-dev] [PATCH i-g-t] tests/i915: use device_coherent mmap priyanka.dandamudi
2021-09-21  4:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-09-21 15:50 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
2021-09-24 11:06   ` Matthew Auld
2021-09-24 11:17     ` Petri Latvala
2021-09-24 11:24       ` Matthew Auld
2021-09-24 12:04         ` Petri Latvala
2021-09-24 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: use device_coherent mmap (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.