* [PATCH] ASoC: samsung: add missing "fallthrough;"
@ 2021-09-27 9:54 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-09-27 9:54 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Liam Girdwood, Mark Brown
Cc: Arnd Bergmann, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
With gcc, we get a warning in this file:
In file included from include/linux/io.h:13,
from sound/soc/samsung/s3c-i2s-v2.c:16:
sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger':
arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
#define __raw_writel __raw_writel
^
arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel'
#define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
^~~~~~~~~~~~
arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed'
#define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); })
^~~~~~~~~~~~~~
sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel'
writel(0x0, i2s->regs + S3C2412_IISFIC);
^~~~~~
sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here
case SNDRV_PCM_TRIGGER_RESUME:
^~~~
From all I can tell, this was indeed meant to fall through, so
add "fallthrough;" statement to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/samsung/s3c-i2s-v2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index e9481187a08c..de66cc422e6e 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -397,6 +397,8 @@ static int s3c2412_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
/* clear again, just in case */
writel(0x0, i2s->regs + S3C2412_IISFIC);
+ fallthrough;
+
case SNDRV_PCM_TRIGGER_RESUME:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
if (!i2s->master) {
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ASoC: samsung: add missing "fallthrough;"
@ 2021-09-27 9:54 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-09-27 9:54 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Liam Girdwood, Mark Brown
Cc: linux-kernel, alsa-devel, Takashi Iwai, Arnd Bergmann
From: Arnd Bergmann <arnd@arndb.de>
With gcc, we get a warning in this file:
In file included from include/linux/io.h:13,
from sound/soc/samsung/s3c-i2s-v2.c:16:
sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger':
arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
#define __raw_writel __raw_writel
^
arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel'
#define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
^~~~~~~~~~~~
arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed'
#define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); })
^~~~~~~~~~~~~~
sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel'
writel(0x0, i2s->regs + S3C2412_IISFIC);
^~~~~~
sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here
case SNDRV_PCM_TRIGGER_RESUME:
^~~~
From all I can tell, this was indeed meant to fall through, so
add "fallthrough;" statement to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/samsung/s3c-i2s-v2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index e9481187a08c..de66cc422e6e 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -397,6 +397,8 @@ static int s3c2412_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
/* clear again, just in case */
writel(0x0, i2s->regs + S3C2412_IISFIC);
+ fallthrough;
+
case SNDRV_PCM_TRIGGER_RESUME:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
if (!i2s->master) {
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: samsung: add missing "fallthrough;"
2021-09-27 9:54 ` Arnd Bergmann
@ 2021-09-27 9:56 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-27 9:56 UTC (permalink / raw)
To: Arnd Bergmann, Sylwester Nawrocki, Liam Girdwood, Mark Brown
Cc: Arnd Bergmann, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
On 27/09/2021 11:54, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With gcc, we get a warning in this file:
>
> In file included from include/linux/io.h:13,
> from sound/soc/samsung/s3c-i2s-v2.c:16:
> sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger':
> arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel'
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed'
> #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); })
> ^~~~~~~~~~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel'
> writel(0x0, i2s->regs + S3C2412_IISFIC);
> ^~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here
> case SNDRV_PCM_TRIGGER_RESUME:
> ^~~~
>
> From all I can tell, this was indeed meant to fall through, so
> add "fallthrough;" statement to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/samsung/s3c-i2s-v2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: samsung: add missing "fallthrough;"
@ 2021-09-27 9:56 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-27 9:56 UTC (permalink / raw)
To: Arnd Bergmann, Sylwester Nawrocki, Liam Girdwood, Mark Brown
Cc: linux-kernel, alsa-devel, Takashi Iwai, Arnd Bergmann
On 27/09/2021 11:54, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With gcc, we get a warning in this file:
>
> In file included from include/linux/io.h:13,
> from sound/soc/samsung/s3c-i2s-v2.c:16:
> sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger':
> arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel'
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed'
> #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); })
> ^~~~~~~~~~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel'
> writel(0x0, i2s->regs + S3C2412_IISFIC);
> ^~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here
> case SNDRV_PCM_TRIGGER_RESUME:
> ^~~~
>
> From all I can tell, this was indeed meant to fall through, so
> add "fallthrough;" statement to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/samsung/s3c-i2s-v2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: add missing "fallthrough;"
2021-09-27 9:54 ` Arnd Bergmann
@ 2021-09-27 17:45 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-09-27 17:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Arnd Bergmann, Liam Girdwood, Sylwester Nawrocki
Cc: Mark Brown, alsa-devel, linux-kernel, Takashi Iwai,
Arnd Bergmann, Jaroslav Kysela
On Mon, 27 Sep 2021 11:54:34 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With gcc, we get a warning in this file:
>
> In file included from include/linux/io.h:13,
> from sound/soc/samsung/s3c-i2s-v2.c:16:
> sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger':
> arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel'
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed'
> #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); })
> ^~~~~~~~~~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel'
> writel(0x0, i2s->regs + S3C2412_IISFIC);
> ^~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here
> case SNDRV_PCM_TRIGGER_RESUME:
> ^~~~
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: samsung: add missing "fallthrough;"
commit: 501849d97e532ca77371498e5a1b1881aab2e6d2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: samsung: add missing "fallthrough;"
@ 2021-09-27 17:45 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-09-27 17:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Arnd Bergmann, Liam Girdwood, Sylwester Nawrocki
Cc: alsa-devel, Arnd Bergmann, Takashi Iwai, linux-kernel, Mark Brown
On Mon, 27 Sep 2021 11:54:34 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With gcc, we get a warning in this file:
>
> In file included from include/linux/io.h:13,
> from sound/soc/samsung/s3c-i2s-v2.c:16:
> sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger':
> arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel'
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed'
> #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); })
> ^~~~~~~~~~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel'
> writel(0x0, i2s->regs + S3C2412_IISFIC);
> ^~~~~~
> sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here
> case SNDRV_PCM_TRIGGER_RESUME:
> ^~~~
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: samsung: add missing "fallthrough;"
commit: 501849d97e532ca77371498e5a1b1881aab2e6d2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-27 17:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 9:54 [PATCH] ASoC: samsung: add missing "fallthrough;" Arnd Bergmann
2021-09-27 9:54 ` Arnd Bergmann
2021-09-27 9:56 ` Krzysztof Kozlowski
2021-09-27 9:56 ` Krzysztof Kozlowski
2021-09-27 17:45 ` Mark Brown
2021-09-27 17:45 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.