All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] tests/kms_flip : skip subtest bo-too-big
@ 2021-09-27 19:26 Aurabindo Pillai
  2021-09-27 20:10 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip : skip subtest bo-too-big (rev2) Patchwork
  2021-09-28  0:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Aurabindo Pillai @ 2021-09-27 19:26 UTC (permalink / raw)
  To: igt-dev, markyacoub; +Cc: rodrigo.siqueira

[Why]
The rationale of the test does not hold true for AMD hardware. The
aperture size calculation has an upper bound check which is done through
i915 specific IOCTL. Hence this part of subtest must be moved
out of the platform agnostic tests. Moreover, AMD hardware
supports buffers larger than aperture size.

[How]
Skip the bo-too-big subtest unless its run on i915 as the test fails on
AMD, VKMS and VC4

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 tests/kms_flip.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 54137871..03e61e46 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1705,6 +1705,9 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 		test_nonblocking_read(drm_fd);
 
 	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+		if ((tests[i].flags & TEST_BO_TOOBIG) && !is_i915_device(drm_fd))
+			continue;
+
 		igt_describe("Basic test for validating modeset, dpms and pageflips");
 		igt_subtest_with_dynamic_f("%s%s",
 			      tests[i].flags & TEST_BASIC ? "basic-" : "",
@@ -1721,6 +1724,9 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 
 	igt_fork_signal_helper();
 	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+		if ((tests[i].flags & TEST_BO_TOOBIG) && !is_i915_device(drm_fd))
+			continue;
+
 		/* relative blocking vblank waits that get constantly interrupt
 		 * take forver. So don't do them. */
 		if ((tests[i].flags & TEST_VBLANK_BLOCK) &&
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-28  0:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 19:26 [igt-dev] [PATCH i-g-t v2] tests/kms_flip : skip subtest bo-too-big Aurabindo Pillai
2021-09-27 20:10 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip : skip subtest bo-too-big (rev2) Patchwork
2021-09-28  0:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.