* [Intel-gfx] [PATCH] drm/i915: Update memory bandwidth formulae
@ 2021-09-28 3:34 Radhakrishna Sripada
2021-09-28 6:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 1 reply; 2+ messages in thread
From: Radhakrishna Sripada @ 2021-09-28 3:34 UTC (permalink / raw)
To: intel-gfx
The formulae has been updated to include more variables. Make
sure the code carries the same.
Bspec: 64631
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Suggested-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 62 ++++++++++++++++++++-----
1 file changed, 50 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 4b94256d7319..fbaf43e682c6 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -27,6 +27,9 @@ struct intel_qgv_info {
u8 num_points;
u8 num_psf_points;
u8 t_bl;
+ u8 max_numchannels;
+ u8 channel_width;
+ u8 deinterleave;
};
static int dg1_mchbar_read_qgv_point_info(struct drm_i915_private *dev_priv,
@@ -145,9 +148,30 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv,
switch (dram_info->type) {
case INTEL_DRAM_DDR4:
qi->t_bl = 4;
+ qi->max_numchannels = 2;
+ qi->channel_width = 64;
+ qi->deinterleave = 2;
break;
case INTEL_DRAM_DDR5:
qi->t_bl = 8;
+ qi->max_numchannels = 4;
+ qi->channel_width = 32;
+ qi->deinterleave = 2;
+ break;
+ case INTEL_DRAM_LPDDR4:
+ if (IS_ROCKETLAKE(dev_priv)) {
+ qi->t_bl = 8;
+ qi->max_numchannels = 4;
+ qi->channel_width = 32;
+ qi->deinterleave = 2;
+ break;
+ }
+ fallthrough;
+ case INTEL_DRAM_LPDDR5:
+ qi->t_bl = 16;
+ qi->max_numchannels = 8;
+ qi->channel_width = 16;
+ qi->deinterleave = 4;
break;
default:
qi->t_bl = 16;
@@ -263,12 +287,14 @@ static const struct intel_sa_info adlp_sa_info = {
static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel_sa_info *sa)
{
struct intel_qgv_info qi = {};
+ const struct dram_info *dram_info = &dev_priv->dram_info;
bool is_y_tile = true; /* assume y tile may be used */
int num_channels = max_t(u8, 1, dev_priv->dram_info.num_channels);
- int deinterleave;
int ipqdepth, ipqdepthpch;
int dclk_max;
- int maxdebw;
+ int maxdebw, peakbw;
+ int clperchgroup;
+ int num_groups = ARRAY_SIZE(dev_priv->max_bw);
int i, ret;
ret = icl_get_qgv_points(dev_priv, &qi);
@@ -278,22 +304,37 @@ static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
return ret;
}
- deinterleave = DIV_ROUND_UP(num_channels, is_y_tile ? 4 : 2);
+ if (dram_info->type == INTEL_DRAM_LPDDR4 || dram_info->type == INTEL_DRAM_LPDDR5)
+ num_channels *= 2;
+
+ if (is_y_tile || num_channels < qi.max_numchannels)
+ qi.deinterleave = DIV_ROUND_UP(qi.deinterleave, 2);
+
+ num_channels = min_t(u8, num_channels, qi.max_numchannels);
dclk_max = icl_sagv_max_dclk(&qi);
ipqdepthpch = 16;
- maxdebw = min(sa->deprogbwlimit * 1000,
- icl_calc_bw(dclk_max, 16, 1) * 6 / 10); /* 60% */
+ peakbw = num_channels * DIV_ROUND_UP(qi.deinterleave, 8) * dclk_max;
+ maxdebw = min(sa->deprogbwlimit * 1000, peakbw * 6 / 10); /* 60% */
ipqdepth = min(ipqdepthpch, sa->displayrtids / num_channels);
+ /*
+ * clperchgroup = 4kpagespermempage * clperchperblock,
+ * clperchperblock = 8 /num_channels * interleave
+ */
+ clperchgroup = 4 * DIV_ROUND_UP(8, num_channels) * qi.deinterleave;
- for (i = 0; i < ARRAY_SIZE(dev_priv->max_bw); i++) {
+ for (i = 0; i < num_groups; i++) {
struct intel_bw_info *bi = &dev_priv->max_bw[i];
int clpchgroup;
int j;
- clpchgroup = (sa->deburst * deinterleave / num_channels) << i;
- bi->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
+ clpchgroup = (sa->deburst * qi.deinterleave / num_channels) << i;
+
+ if (i < num_groups - 1 && clpchgroup < clperchgroup)
+ bi->num_planes = (ipqdepth - clpchgroup) / clpchgroup + 1;
+ else
+ bi->num_planes = 0;
bi->num_qgv_points = qi.num_points;
bi->num_psf_gv_points = qi.num_psf_points;
@@ -329,9 +370,6 @@ static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
"BW%d / PSF GV %d: num_planes=%d bw=%u\n",
i, j, bi->num_planes, bi->psf_bw[j]);
}
-
- if (bi->num_planes == 1)
- break;
}
/*
@@ -339,7 +377,7 @@ static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
* SAGV point, but we can't send PCode commands to restrict it
* as it will fail and pointless anyway.
*/
- if (qi.num_points == 1)
+ if (qi.num_points >= 1)
dev_priv->sagv_status = I915_SAGV_NOT_CONTROLLED;
else
dev_priv->sagv_status = I915_SAGV_ENABLED;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Update memory bandwidth formulae
2021-09-28 3:34 [Intel-gfx] [PATCH] drm/i915: Update memory bandwidth formulae Radhakrishna Sripada
@ 2021-09-28 6:19 ` Patchwork
0 siblings, 0 replies; 2+ messages in thread
From: Patchwork @ 2021-09-28 6:19 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 12356 bytes --]
== Series Details ==
Series: drm/i915: Update memory bandwidth formulae
URL : https://patchwork.freedesktop.org/series/95138/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10650 -> Patchwork_21173
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21173 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21173, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21173:
### CI changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* boot:
- {fi-jsl-1}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-jsl-1/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-jsl-1/boot.html
- {fi-ehl-2}: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-ehl-2/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-ehl-2/boot.html
### IGT changes ###
#### Possible regressions ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-u2: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-tgl-u2/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-u2/igt@debugfs_test@read_all_entries.html
* igt@gem_exec_suspend@basic-s0:
- fi-rkl-11600: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-11600/igt@gem_exec_suspend@basic-s0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-11600/igt@gem_exec_suspend@basic-s0.html
- fi-rkl-guc: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-guc/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-guc/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@basic-rte:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@i915_pm_rpm@basic-rte.html
* igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1:
- fi-rkl-11600: NOTRUN -> [FAIL][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-11600/igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1.html
* igt@kms_flip@basic-flip-vs-modeset@c-dp3:
- fi-tgl-1115g4: NOTRUN -> [FAIL][13] +36 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@kms_flip@basic-flip-vs-modeset@c-dp3.html
* igt@kms_flip@basic-flip-vs-modeset@c-hdmi-a1:
- fi-rkl-guc: [PASS][14] -> [FAIL][15] +23 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-guc/igt@kms_flip@basic-flip-vs-modeset@c-hdmi-a1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-guc/igt@kms_flip@basic-flip-vs-modeset@c-hdmi-a1.html
* igt@kms_flip@basic-plain-flip@c-hdmi-a1:
- fi-rkl-11600: [PASS][16] -> [FAIL][17] +22 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-11600/igt@kms_flip@basic-plain-flip@c-hdmi-a1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-11600/igt@kms_flip@basic-plain-flip@c-hdmi-a1.html
* igt@prime_vgem@basic-fence-flip:
- fi-rkl-guc: [PASS][18] -> [SKIP][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-guc/igt@prime_vgem@basic-fence-flip.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-guc/igt@prime_vgem@basic-fence-flip.html
#### Warnings ####
* igt@prime_vgem@basic-fence-flip:
- fi-rkl-11600: [SKIP][20] ([i915#1845]) -> [SKIP][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-11600/igt@prime_vgem@basic-fence-flip.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-11600/igt@prime_vgem@basic-fence-flip.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
- {fi-tgl-dsi}: [PASS][22] -> [FAIL][23] +29 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html
* igt@prime_vgem@basic-fence-flip:
- {fi-tgl-dsi}: [PASS][24] -> [SKIP][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-tgl-dsi/igt@prime_vgem@basic-fence-flip.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-dsi/igt@prime_vgem@basic-fence-flip.html
Known issues
------------
Here are the changes found in Patchwork_21173 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-icl-y: [PASS][26] -> [FAIL][27] ([i915#3521])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-icl-y/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-icl-y/boot.html
- fi-icl-u2: [PASS][28] -> [FAIL][29] ([i915#3521])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-icl-u2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-icl-u2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][30] ([fdo#109315])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][31] ([fdo#109315] / [i915#2575]) +16 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-pnv-d510: NOTRUN -> [SKIP][32] ([fdo#109271]) +17 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-pnv-d510/igt@amdgpu/amd_prime@amd-to-i915.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][33] ([i915#2190])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][34] ([i915#1155])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@basic-rte:
- fi-rkl-guc: [PASS][35] -> [SKIP][36] ([fdo#109308]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-guc/igt@i915_pm_rpm@basic-rte.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-guc/igt@i915_pm_rpm@basic-rte.html
- fi-rkl-11600: [PASS][37] -> [SKIP][38] ([fdo#109308]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-rkl-11600/igt@i915_pm_rpm@basic-rte.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-rkl-11600/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][39] -> [INCOMPLETE][40] ([i915#3921])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][41] ([fdo#111827]) +8 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][42] ([i915#4103]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][43] ([fdo#109285])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][44] ([i915#1072]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][45] ([i915#3301])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-tgl-u2: NOTRUN -> [FAIL][46] ([i915#1814])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-tgl-u2/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][47] ([i915#4140]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-pnv-d510/igt@i915_selftest@live@requests.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-7500u: [FAIL][49] ([i915#3449]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10650/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3449]: https://gitlab.freedesktop.org/drm/intel/issues/3449
[i915#3521]: https://gitlab.freedesktop.org/drm/intel/issues/3521
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4140]: https://gitlab.freedesktop.org/drm/intel/issues/4140
Participating hosts (37 -> 34)
------------------------------
Additional (1): fi-tgl-1115g4
Missing (4): fi-bdw-samus fi-bsw-cyan bat-jsl-1 bat-adlp-4
Build changes
-------------
* Linux: CI_DRM_10650 -> Patchwork_21173
CI-20190529: 20190529
CI_DRM_10650: f08f69e3c959e13a418965e33e4327d9ca3ca69a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6223: a36eb05d05bdb16f9f0fa8d611893ee89f13840a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21173: eba326efbc2a0dfcfa80d2100d8996e83fc81327 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
eba326efbc2a drm/i915: Update memory bandwidth formulae
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21173/index.html
[-- Attachment #2: Type: text/html, Size: 13974 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-28 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 3:34 [Intel-gfx] [PATCH] drm/i915: Update memory bandwidth formulae Radhakrishna Sripada
2021-09-28 6:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.