All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: acp-rt5645: Constify static snd_soc_ops
@ 2021-10-04 22:45 ` Rikard Falkeborn
  0 siblings, 0 replies; 4+ messages in thread
From: Rikard Falkeborn @ 2021-10-04 22:45 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel,
	Rikard Falkeborn

The struct cz_aif1_ops is only assigned to the ops field in the
snd_soc_dai_link struct which is a pointer to const struct snd_soc_ops.
Make it const to allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/soc/amd/acp-rt5645.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c
index d6ba94677ac2..6d5c547a32de 100644
--- a/sound/soc/amd/acp-rt5645.c
+++ b/sound/soc/amd/acp-rt5645.c
@@ -91,7 +91,7 @@ static int cz_init(struct snd_soc_pcm_runtime *rtd)
 	return 0;
 }
 
-static struct snd_soc_ops cz_aif1_ops = {
+static const struct snd_soc_ops cz_aif1_ops = {
 	.hw_params = cz_aif1_hw_params,
 };
 
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ASoC: amd: acp-rt5645: Constify static snd_soc_ops
@ 2021-10-04 22:45 ` Rikard Falkeborn
  0 siblings, 0 replies; 4+ messages in thread
From: Rikard Falkeborn @ 2021-10-04 22:45 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: linux-kernel, alsa-devel, Takashi Iwai, Rikard Falkeborn

The struct cz_aif1_ops is only assigned to the ops field in the
snd_soc_dai_link struct which is a pointer to const struct snd_soc_ops.
Make it const to allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/soc/amd/acp-rt5645.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c
index d6ba94677ac2..6d5c547a32de 100644
--- a/sound/soc/amd/acp-rt5645.c
+++ b/sound/soc/amd/acp-rt5645.c
@@ -91,7 +91,7 @@ static int cz_init(struct snd_soc_pcm_runtime *rtd)
 	return 0;
 }
 
-static struct snd_soc_ops cz_aif1_ops = {
+static const struct snd_soc_ops cz_aif1_ops = {
 	.hw_params = cz_aif1_hw_params,
 };
 
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: acp-rt5645: Constify static snd_soc_ops
  2021-10-04 22:45 ` Rikard Falkeborn
@ 2021-10-05 15:37   ` Mark Brown
  -1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-10-05 15:37 UTC (permalink / raw)
  To: Liam Girdwood, Rikard Falkeborn
  Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel

On Tue, 5 Oct 2021 00:45:14 +0200, Rikard Falkeborn wrote:
> The struct cz_aif1_ops is only assigned to the ops field in the
> snd_soc_dai_link struct which is a pointer to const struct snd_soc_ops.
> Make it const to allow the compiler to put it in read-only memory.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: acp-rt5645: Constify static snd_soc_ops
      commit: d54aa2aeaa70237f4482336e86195235ea1de032

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: acp-rt5645: Constify static snd_soc_ops
@ 2021-10-05 15:37   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-10-05 15:37 UTC (permalink / raw)
  To: Liam Girdwood, Rikard Falkeborn
  Cc: linux-kernel, alsa-devel, Mark Brown, Takashi Iwai

On Tue, 5 Oct 2021 00:45:14 +0200, Rikard Falkeborn wrote:
> The struct cz_aif1_ops is only assigned to the ops field in the
> snd_soc_dai_link struct which is a pointer to const struct snd_soc_ops.
> Make it const to allow the compiler to put it in read-only memory.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: acp-rt5645: Constify static snd_soc_ops
      commit: d54aa2aeaa70237f4482336e86195235ea1de032

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-05 15:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 22:45 [PATCH] ASoC: amd: acp-rt5645: Constify static snd_soc_ops Rikard Falkeborn
2021-10-04 22:45 ` Rikard Falkeborn
2021-10-05 15:37 ` Mark Brown
2021-10-05 15:37   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.