* [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with
@ 2021-10-05 4:35 Kai Song
2021-10-07 17:54 ` Thierry Reding
2021-10-07 18:42 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Kai Song @ 2021-10-05 4:35 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: thierry.reding, jonathanh, linux-kernel, linux-tegra, Kai Song
fix debugfs_simple_attr.cocci warning:
drivers/memory/tegra/tegra210-emc-core.c:1665:0-23: WARNING:tegra210_emc_debug_min_rate_fops
should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Fixes: 6fc5f1adf5a1 ("memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE
with DEFINE_DEBUGFS_ATTRIBUTE"):It reports the same warning, but didn't
fix all matches in this file at once.
Signed-off-by: Kai Song <songkai01@inspur.com>
---
drivers/memory/tegra/tegra210-emc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 3b8284c6678e..13584f9317a4 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -1662,7 +1662,7 @@ static int tegra210_emc_debug_min_rate_set(void *data, u64 rate)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_min_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_min_rate_fops,
tegra210_emc_debug_min_rate_get,
tegra210_emc_debug_min_rate_set, "%llu\n");
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with
2021-10-05 4:35 [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with Kai Song
@ 2021-10-07 17:54 ` Thierry Reding
2021-10-07 18:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-10-07 17:54 UTC (permalink / raw)
To: Kai Song; +Cc: krzysztof.kozlowski, jonathanh, linux-kernel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Tue, Oct 05, 2021 at 12:35:14PM +0800, Kai Song wrote:
> fix debugfs_simple_attr.cocci warning:
> drivers/memory/tegra/tegra210-emc-core.c:1665:0-23: WARNING:tegra210_emc_debug_min_rate_fops
> should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
> Fixes: 6fc5f1adf5a1 ("memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE
> with DEFINE_DEBUGFS_ATTRIBUTE"):It reports the same warning, but didn't
> fix all matches in this file at once.
>
> Signed-off-by: Kai Song <songkai01@inspur.com>
> ---
> drivers/memory/tegra/tegra210-emc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with
2021-10-05 4:35 [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with Kai Song
2021-10-07 17:54 ` Thierry Reding
@ 2021-10-07 18:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-07 18:42 UTC (permalink / raw)
To: Kai Song
Cc: Krzysztof Kozlowski, linux-tegra, linux-kernel, jonathanh,
thierry.reding
On Tue, 5 Oct 2021 12:35:14 +0800, Kai Song wrote:
> fix debugfs_simple_attr.cocci warning:
> drivers/memory/tegra/tegra210-emc-core.c:1665:0-23: WARNING:tegra210_emc_debug_min_rate_fops
> should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
> Fixes: 6fc5f1adf5a1 ("memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE
> with DEFINE_DEBUGFS_ATTRIBUTE"):It reports the same warning, but didn't
> fix all matches in this file at once.
>
> [...]
Applied, thanks!
[1/1] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with
commit: 31b88d85f0432e1c0738fe0714191e8504f505c3
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-07 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 4:35 [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with Kai Song
2021-10-07 17:54 ` Thierry Reding
2021-10-07 18:42 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.