From: Yinbo Zhu <zhuyinbo@loongson.cn>
To: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <greg@kroah.com>,
Patchwork Bot <patchwork-bot@kernel.org>
Cc: zhuyinbo@loongson.cn
Subject: [PATCH v3] usb: ohci: add check for host controller functional states
Date: Fri, 8 Oct 2021 15:26:10 +0800 [thread overview]
Message-ID: <1633677970-10619-1-git-send-email-zhuyinbo@loongson.cn> (raw)
The usb states of ohci controller include UsbOperational, UsbReset,
UsbSuspend and UsbResume. Among them, only the UsbOperational state
supports launching the start of frame for host controller according
the ohci protocol spec, but in S3/S4 press test procedure, it may
happen that the start of frame was launched in other usb states and
cause ohci works abnormally then kernel will allways report rcu
call trace. This patch was to add check for host controller
functional states and if it is not UsbOperational state that need
set INTR_SF in intrdisable register to ensure SOF Token generation
was been disabled.
Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
---
Change in v3:
Rework the commit information.
Move the patch code change to lower down position in ohci_irq.
drivers/usb/host/ohci-hcd.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 1f5e693..87aa9bb 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -879,7 +879,8 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
{
struct ohci_hcd *ohci = hcd_to_ohci (hcd);
struct ohci_regs __iomem *regs = ohci->regs;
- int ints;
+ int ints, ctl;
+
/* Read interrupt status (and flush pending writes). We ignore the
* optimization of checking the LSB of hcca->done_head; it doesn't
@@ -969,9 +970,15 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
* when there's still unlinking to be done (next frame).
*/
ohci_work(ohci);
- if ((ints & OHCI_INTR_SF) != 0 && !ohci->ed_rm_list
- && ohci->rh_state == OHCI_RH_RUNNING)
+
+ ctl = ohci_readl(ohci, ®s->control);
+
+ if (((ints & OHCI_INTR_SF) != 0 && !ohci->ed_rm_list
+ && ohci->rh_state == OHCI_RH_RUNNING) ||
+ ((ctl & OHCI_CTRL_HCFS) != OHCI_USB_OPER)) {
ohci_writel (ohci, OHCI_INTR_SF, ®s->intrdisable);
+ (void)ohci_readl(ohci, ®s->intrdisable);
+ }
if (ohci->rh_state == OHCI_RH_RUNNING) {
ohci_writel (ohci, ints, ®s->intrstatus);
--
1.8.3.1
next reply other threads:[~2021-10-08 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 7:26 Yinbo Zhu [this message]
2021-10-08 14:26 ` [PATCH v3] usb: ohci: add check for host controller functional states Alan Stern
2021-10-09 2:01 ` zhuyinbo
2021-10-09 19:39 ` Alan Stern
2021-10-11 5:10 ` zhuyinbo
2021-10-11 7:22 ` zhuyinbo
2021-10-11 16:17 ` Alan Stern
2021-10-12 8:15 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1633677970-10619-1-git-send-email-zhuyinbo@loongson.cn \
--to=zhuyinbo@loongson.cn \
--cc=greg@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patchwork-bot@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.