All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v3] tests/i915/i915_pm_dc: Fix condition in dc9-test
@ 2021-10-08 12:09 Jigar Bhatt
  2021-10-08 14:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/i915_pm_dc: Fix condition in dc9-test (rev3) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jigar Bhatt @ 2021-10-08 12:09 UTC (permalink / raw)
  To: igt-dev; +Cc: jigar.bhatt, petri.latvala, nischal.varide

Inside dc9_wait_entry, we do not have DC9 counter,
so we rely on dc5/dc6 counter reset
to check if display engine was in DC9.
Test is passed if live counter is less
than the previous counter. Correcting condition
igt_wait(read_dc_counter(debugfs_fd, dc_target) <
			prev_dc, seconds, 100);

Fixes: 2f4e6430a97f04284d1cafb1479e7c1b0b2d596a ("tests/i915/i915_pm_dc: Fix DC9 test")
Signed-off-by: Jigar Bhatt <jigar.bhatt@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
---
 tests/i915/i915_pm_dc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index 4c9b871c..9db66ba2 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -404,7 +404,7 @@ static bool dc9_wait_entry(uint32_t debugfs_fd, int dc_target, int prev_dc, int
 	 * since we do not have DC9 counter,
 	 * so we rely on dc5/dc6 counter reset to check if display engine was in DC9.
 	 */
-	return igt_wait(read_dc_counter(debugfs_fd, dc_target) >
+	return igt_wait(read_dc_counter(debugfs_fd, dc_target) <
 			prev_dc, seconds, 100);
 }
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-11 18:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08 12:09 [igt-dev] [PATCH i-g-t v3] tests/i915/i915_pm_dc: Fix condition in dc9-test Jigar Bhatt
2021-10-08 14:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/i915_pm_dc: Fix condition in dc9-test (rev3) Patchwork
2021-10-11  5:21   ` Bhatt, Jigar
2021-10-11 15:09     ` Vudum, Lakshminarayana
2021-10-11 15:01 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-10-11 18:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.