[PATCH net-next] ionic: no devlink_unregister if not registered

[PATCH net-next] ionic: no devlink_unregister if not registered

[Shannon Nelson]

Don't try to unregister the devlink if it hasn't been registered
yet.  This bit of error cleanup code got missed in the recent
devlink registration changes.

Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command")
Cc: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
---
 drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c
index 2267da95640b..4297ed9024c0 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c
@@ -87,7 +87,6 @@ int ionic_devlink_register(struct ionic *ionic)
 	err = devlink_port_register(dl, &ionic->dl_port, 0);
 	if (err) {
 		dev_err(ionic->dev, "devlink_port_register failed: %d\n", err);
-		devlink_unregister(dl);
 		return err;
 	}
 
-- 
2.17.1

Re: [PATCH net-next] ionic: no devlink_unregister if not registered

[Leon Romanovsky]

On Tue, Oct 12, 2021 at 04:15:20PM -0700, Shannon Nelson wrote:
> Don't try to unregister the devlink if it hasn't been registered
> yet.  This bit of error cleanup code got missed in the recent
> devlink registration changes.
> 
> Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command")
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 1 -
>  1 file changed, 1 deletion(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Re: [PATCH net-next] ionic: no devlink_unregister if not registered

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 12 Oct 2021 16:15:20 -0700 you wrote:
> Don't try to unregister the devlink if it hasn't been registered
> yet.  This bit of error cleanup code got missed in the recent
> devlink registration changes.
> 
> Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command")
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> 
> [...]

Here is the summary with links:
  - [net-next] ionic: no devlink_unregister if not registered
    https://git.kernel.org/netdev/net-next/c/d1f24712a86a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html