* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 1:00 [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation José Roberto de Souza
@ 2021-10-13 0:55 ` Souza, Jose
2021-10-13 1:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove memory frequency calculation (rev2) Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Souza, Jose @ 2021-10-13 0:55 UTC (permalink / raw)
To: intel-gfx; +Cc: Zhao, Yakui, Roper, Matthew D
On Tue, 2021-10-12 at 18:00 -0700, José Roberto de Souza wrote:
> This memory frequency calculated is only used to check if it is zero,
> what is not useful as it will never actually be zero.
>
> Also the calculation is wrong, we should be checking other bit to
> select the appropriate frequency multiplier while this code is stuck
> with a fixed multiplier.
>
> So here dropping it as whole.
>
> v2:
> - Also remove memory frequency calculation for gen9 LP platforms
>
> Cc: Yakui Zhao <yakui.zhao@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: f8112cb9574b ("drm/i915/gen11+: Only load DRAM information from pcode")
Ops hash should be: 5d0c938ec9cc
Will fix in the next version or when applying.
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 8 --------
> drivers/gpu/drm/i915/intel_dram.c | 30 ++----------------------------
> 2 files changed, 2 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index a897f4abea0c3..8825f7ac477b6 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -11109,12 +11109,6 @@ enum skl_power_gate {
> #define DC_STATE_DEBUG_MASK_CORES (1 << 0)
> #define DC_STATE_DEBUG_MASK_MEMORY_UP (1 << 1)
>
> -#define BXT_P_CR_MC_BIOS_REQ_0_0_0 _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x7114)
> -#define BXT_REQ_DATA_MASK 0x3F
> -#define BXT_DRAM_CHANNEL_ACTIVE_SHIFT 12
> -#define BXT_DRAM_CHANNEL_ACTIVE_MASK (0xF << 12)
> -#define BXT_MEMORY_FREQ_MULTIPLIER_HZ 133333333
> -
> #define BXT_D_CR_DRP0_DUNIT8 0x1000
> #define BXT_D_CR_DRP0_DUNIT9 0x1200
> #define BXT_D_CR_DRP0_DUNIT_START 8
> @@ -11145,9 +11139,7 @@ enum skl_power_gate {
> #define BXT_DRAM_TYPE_LPDDR4 (0x2 << 22)
> #define BXT_DRAM_TYPE_DDR4 (0x4 << 22)
>
> -#define SKL_MEMORY_FREQ_MULTIPLIER_HZ 266666666
> #define SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5E04)
> -#define SKL_REQ_DATA_MASK (0xF << 0)
> #define DG1_GEAR_TYPE REG_BIT(16)
>
> #define SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5000)
> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
> index 30a0cab5eff46..0adadfd9528aa 100644
> --- a/drivers/gpu/drm/i915/intel_dram.c
> +++ b/drivers/gpu/drm/i915/intel_dram.c
> @@ -244,7 +244,6 @@ static int
> skl_get_dram_info(struct drm_i915_private *i915)
> {
> struct dram_info *dram_info = &i915->dram_info;
> - u32 mem_freq_khz, val;
> int ret;
>
> dram_info->type = skl_get_dram_type(i915);
> @@ -255,17 +254,6 @@ skl_get_dram_info(struct drm_i915_private *i915)
> if (ret)
> return ret;
>
> - val = intel_uncore_read(&i915->uncore,
> - SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU);
> - mem_freq_khz = DIV_ROUND_UP((val & SKL_REQ_DATA_MASK) *
> - SKL_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> -
> - if (dram_info->num_channels * mem_freq_khz == 0) {
> - drm_info(&i915->drm,
> - "Couldn't get system memory bandwidth\n");
> - return -EINVAL;
> - }
> -
> return 0;
> }
>
> @@ -350,24 +338,10 @@ static void bxt_get_dimm_info(struct dram_dimm_info *dimm, u32 val)
> static int bxt_get_dram_info(struct drm_i915_private *i915)
> {
> struct dram_info *dram_info = &i915->dram_info;
> - u32 dram_channels;
> - u32 mem_freq_khz, val;
> - u8 num_active_channels, valid_ranks = 0;
> + u32 val;
> + u8 valid_ranks = 0;
> int i;
>
> - val = intel_uncore_read(&i915->uncore, BXT_P_CR_MC_BIOS_REQ_0_0_0);
> - mem_freq_khz = DIV_ROUND_UP((val & BXT_REQ_DATA_MASK) *
> - BXT_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> -
> - dram_channels = val & BXT_DRAM_CHANNEL_ACTIVE_MASK;
> - num_active_channels = hweight32(dram_channels);
> -
> - if (mem_freq_khz * num_active_channels == 0) {
> - drm_info(&i915->drm,
> - "Couldn't get system memory bandwidth\n");
> - return -EINVAL;
> - }
> -
> /*
> * Now read each DUNIT8/9/10/11 to check the rank of each dimms.
> */
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove memory frequency calculation (rev2)
2021-10-13 1:00 [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation José Roberto de Souza
2021-10-13 0:55 ` Souza, Jose
@ 2021-10-13 1:20 ` Patchwork
2021-10-13 1:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-10-13 1:20 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove memory frequency calculation (rev2)
URL : https://patchwork.freedesktop.org/series/95748/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e86da89208d6 drm/i915: Remove memory frequency calculation
-:23: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'f8112cb9574b', maybe rebased or not pulled?
#23:
Fixes: f8112cb9574b ("drm/i915/gen11+: Only load DRAM information from pcode")
total: 0 errors, 1 warnings, 0 checks, 71 lines checked
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove memory frequency calculation (rev2)
2021-10-13 1:00 [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation José Roberto de Souza
2021-10-13 0:55 ` Souza, Jose
2021-10-13 1:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove memory frequency calculation (rev2) Patchwork
@ 2021-10-13 1:50 ` Patchwork
2021-10-13 2:54 ` [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation Matt Roper
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-10-13 1:50 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3457 bytes --]
== Series Details ==
Series: drm/i915: Remove memory frequency calculation (rev2)
URL : https://patchwork.freedesktop.org/series/95748/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10728 -> Patchwork_21324
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/index.html
Known issues
------------
Here are the changes found in Patchwork_21324 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@engines@userptr:
- fi-pnv-d510: [PASS][1] -> [INCOMPLETE][2] ([i915#299])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][3] -> [FAIL][4] ([i915#1888]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#4269])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][7] ([i915#2403] / [i915#2722])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/fi-pnv-d510/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@perf:
- {fi-tgl-dsi}: [DMESG-WARN][8] ([i915#2867]) -> [PASS][9] +9 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/fi-tgl-dsi/igt@i915_selftest@live@perf.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/fi-tgl-dsi/igt@i915_selftest@live@perf.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
Participating hosts (41 -> 37)
------------------------------
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10728 -> Patchwork_21324
CI-20190529: 20190529
CI_DRM_10728: 82a9f298afec66c882e710078138891826ce5e22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6242: 721fd85ee95225ed5df322f7182bdfa9b86a3e68 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21324: e86da89208d640c5b2846820ee39637795c5b43c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e86da89208d6 drm/i915: Remove memory frequency calculation
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/index.html
[-- Attachment #2: Type: text/html, Size: 4178 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 1:00 [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation José Roberto de Souza
` (2 preceding siblings ...)
2021-10-13 1:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-10-13 2:54 ` Matt Roper
2021-10-13 8:20 ` Zhao, Yakui
2021-10-13 9:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove memory frequency calculation (rev2) Patchwork
2021-10-13 9:32 ` [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation Ville Syrjälä
5 siblings, 1 reply; 11+ messages in thread
From: Matt Roper @ 2021-10-13 2:54 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx, Yakui Zhao
On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote:
> This memory frequency calculated is only used to check if it is zero,
> what is not useful as it will never actually be zero.
>
> Also the calculation is wrong, we should be checking other bit to
> select the appropriate frequency multiplier while this code is stuck
> with a fixed multiplier.
>
> So here dropping it as whole.
>
> v2:
> - Also remove memory frequency calculation for gen9 LP platforms
>
> Cc: Yakui Zhao <yakui.zhao@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: f8112cb9574b ("drm/i915/gen11+: Only load DRAM information from pcode")
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 8 --------
> drivers/gpu/drm/i915/intel_dram.c | 30 ++----------------------------
> 2 files changed, 2 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index a897f4abea0c3..8825f7ac477b6 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -11109,12 +11109,6 @@ enum skl_power_gate {
> #define DC_STATE_DEBUG_MASK_CORES (1 << 0)
> #define DC_STATE_DEBUG_MASK_MEMORY_UP (1 << 1)
>
> -#define BXT_P_CR_MC_BIOS_REQ_0_0_0 _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x7114)
> -#define BXT_REQ_DATA_MASK 0x3F
> -#define BXT_DRAM_CHANNEL_ACTIVE_SHIFT 12
> -#define BXT_DRAM_CHANNEL_ACTIVE_MASK (0xF << 12)
> -#define BXT_MEMORY_FREQ_MULTIPLIER_HZ 133333333
> -
> #define BXT_D_CR_DRP0_DUNIT8 0x1000
> #define BXT_D_CR_DRP0_DUNIT9 0x1200
> #define BXT_D_CR_DRP0_DUNIT_START 8
> @@ -11145,9 +11139,7 @@ enum skl_power_gate {
> #define BXT_DRAM_TYPE_LPDDR4 (0x2 << 22)
> #define BXT_DRAM_TYPE_DDR4 (0x4 << 22)
>
> -#define SKL_MEMORY_FREQ_MULTIPLIER_HZ 266666666
> #define SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5E04)
> -#define SKL_REQ_DATA_MASK (0xF << 0)
> #define DG1_GEAR_TYPE REG_BIT(16)
>
> #define SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5000)
> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
> index 30a0cab5eff46..0adadfd9528aa 100644
> --- a/drivers/gpu/drm/i915/intel_dram.c
> +++ b/drivers/gpu/drm/i915/intel_dram.c
> @@ -244,7 +244,6 @@ static int
> skl_get_dram_info(struct drm_i915_private *i915)
> {
> struct dram_info *dram_info = &i915->dram_info;
> - u32 mem_freq_khz, val;
> int ret;
>
> dram_info->type = skl_get_dram_type(i915);
> @@ -255,17 +254,6 @@ skl_get_dram_info(struct drm_i915_private *i915)
> if (ret)
> return ret;
>
> - val = intel_uncore_read(&i915->uncore,
> - SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU);
> - mem_freq_khz = DIV_ROUND_UP((val & SKL_REQ_DATA_MASK) *
> - SKL_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> -
> - if (dram_info->num_channels * mem_freq_khz == 0) {
> - drm_info(&i915->drm,
> - "Couldn't get system memory bandwidth\n");
> - return -EINVAL;
> - }
> -
> return 0;
> }
>
> @@ -350,24 +338,10 @@ static void bxt_get_dimm_info(struct dram_dimm_info *dimm, u32 val)
> static int bxt_get_dram_info(struct drm_i915_private *i915)
> {
> struct dram_info *dram_info = &i915->dram_info;
> - u32 dram_channels;
> - u32 mem_freq_khz, val;
> - u8 num_active_channels, valid_ranks = 0;
> + u32 val;
> + u8 valid_ranks = 0;
> int i;
>
> - val = intel_uncore_read(&i915->uncore, BXT_P_CR_MC_BIOS_REQ_0_0_0);
> - mem_freq_khz = DIV_ROUND_UP((val & BXT_REQ_DATA_MASK) *
> - BXT_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> -
> - dram_channels = val & BXT_DRAM_CHANNEL_ACTIVE_MASK;
> - num_active_channels = hweight32(dram_channels);
> -
> - if (mem_freq_khz * num_active_channels == 0) {
> - drm_info(&i915->drm,
> - "Couldn't get system memory bandwidth\n");
> - return -EINVAL;
> - }
> -
> /*
> * Now read each DUNIT8/9/10/11 to check the rank of each dimms.
> */
> --
> 2.33.0
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 2:54 ` [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation Matt Roper
@ 2021-10-13 8:20 ` Zhao, Yakui
0 siblings, 0 replies; 11+ messages in thread
From: Zhao, Yakui @ 2021-10-13 8:20 UTC (permalink / raw)
To: Matt Roper, José Roberto de Souza; +Cc: intel-gfx
On 2021/10/13 10:54, Matt Roper wrote:
> On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote:
>> This memory frequency calculated is only used to check if it is zero,
>> what is not useful as it will never actually be zero.
>>
>> Also the calculation is wrong, we should be checking other bit to
>> select the appropriate frequency multiplier while this code is stuck
>> with a fixed multiplier.
>>
>> So here dropping it as whole.
>>
>> v2:
>> - Also remove memory frequency calculation for gen9 LP platforms
>>
>> Cc: Yakui Zhao <yakui.zhao@intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Fixes: f8112cb9574b ("drm/i915/gen11+: Only load DRAM information from pcode")
>> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
After removing the check of memory frequency, the EHL SBL can work as
expected. Otherwise it will fail some checks in intel_dram_detect
because of incorrect memory frequency calculation.
Add: Tested-by: Zhao Yakui <yakui.zhao@intel.com>
>
>> ---
>> drivers/gpu/drm/i915/i915_reg.h | 8 --------
>> drivers/gpu/drm/i915/intel_dram.c | 30 ++----------------------------
>> 2 files changed, 2 insertions(+), 36 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index a897f4abea0c3..8825f7ac477b6 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -11109,12 +11109,6 @@ enum skl_power_gate {
>> #define DC_STATE_DEBUG_MASK_CORES (1 << 0)
>> #define DC_STATE_DEBUG_MASK_MEMORY_UP (1 << 1)
>>
>> -#define BXT_P_CR_MC_BIOS_REQ_0_0_0 _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x7114)
>> -#define BXT_REQ_DATA_MASK 0x3F
>> -#define BXT_DRAM_CHANNEL_ACTIVE_SHIFT 12
>> -#define BXT_DRAM_CHANNEL_ACTIVE_MASK (0xF << 12)
>> -#define BXT_MEMORY_FREQ_MULTIPLIER_HZ 133333333
>> -
>> #define BXT_D_CR_DRP0_DUNIT8 0x1000
>> #define BXT_D_CR_DRP0_DUNIT9 0x1200
>> #define BXT_D_CR_DRP0_DUNIT_START 8
>> @@ -11145,9 +11139,7 @@ enum skl_power_gate {
>> #define BXT_DRAM_TYPE_LPDDR4 (0x2 << 22)
>> #define BXT_DRAM_TYPE_DDR4 (0x4 << 22)
>>
>> -#define SKL_MEMORY_FREQ_MULTIPLIER_HZ 266666666
>> #define SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5E04)
>> -#define SKL_REQ_DATA_MASK (0xF << 0)
>> #define DG1_GEAR_TYPE REG_BIT(16)
>>
>> #define SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5000)
>> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
>> index 30a0cab5eff46..0adadfd9528aa 100644
>> --- a/drivers/gpu/drm/i915/intel_dram.c
>> +++ b/drivers/gpu/drm/i915/intel_dram.c
>> @@ -244,7 +244,6 @@ static int
>> skl_get_dram_info(struct drm_i915_private *i915)
>> {
>> struct dram_info *dram_info = &i915->dram_info;
>> - u32 mem_freq_khz, val;
>> int ret;
>>
>> dram_info->type = skl_get_dram_type(i915);
>> @@ -255,17 +254,6 @@ skl_get_dram_info(struct drm_i915_private *i915)
>> if (ret)
>> return ret;
>>
>> - val = intel_uncore_read(&i915->uncore,
>> - SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU);
>> - mem_freq_khz = DIV_ROUND_UP((val & SKL_REQ_DATA_MASK) *
>> - SKL_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
>> -
>> - if (dram_info->num_channels * mem_freq_khz == 0) {
>> - drm_info(&i915->drm,
>> - "Couldn't get system memory bandwidth\n");
>> - return -EINVAL;
>> - }
>> -
>> return 0;
>> }
>>
>> @@ -350,24 +338,10 @@ static void bxt_get_dimm_info(struct dram_dimm_info *dimm, u32 val)
>> static int bxt_get_dram_info(struct drm_i915_private *i915)
>> {
>> struct dram_info *dram_info = &i915->dram_info;
>> - u32 dram_channels;
>> - u32 mem_freq_khz, val;
>> - u8 num_active_channels, valid_ranks = 0;
>> + u32 val;
>> + u8 valid_ranks = 0;
>> int i;
>>
>> - val = intel_uncore_read(&i915->uncore, BXT_P_CR_MC_BIOS_REQ_0_0_0);
>> - mem_freq_khz = DIV_ROUND_UP((val & BXT_REQ_DATA_MASK) *
>> - BXT_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
>> -
>> - dram_channels = val & BXT_DRAM_CHANNEL_ACTIVE_MASK;
>> - num_active_channels = hweight32(dram_channels);
>> -
>> - if (mem_freq_khz * num_active_channels == 0) {
>> - drm_info(&i915->drm,
>> - "Couldn't get system memory bandwidth\n");
>> - return -EINVAL;
>> - }
>> -
>> /*
>> * Now read each DUNIT8/9/10/11 to check the rank of each dimms.
>> */
>> --
>> 2.33.0
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove memory frequency calculation (rev2)
2021-10-13 1:00 [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation José Roberto de Souza
` (3 preceding siblings ...)
2021-10-13 2:54 ` [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation Matt Roper
@ 2021-10-13 9:22 ` Patchwork
2021-10-13 9:32 ` [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation Ville Syrjälä
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-10-13 9:22 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30275 bytes --]
== Series Details ==
Series: drm/i915: Remove memory frequency calculation (rev2)
URL : https://patchwork.freedesktop.org/series/95748/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10728_full -> Patchwork_21324_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21324_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21324_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21324_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_edge_walk@pipe-d-128x128-bottom-edge:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb3/igt@kms_cursor_edge_walk@pipe-d-128x128-bottom-edge.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb6/igt@kms_cursor_edge_walk@pipe-d-128x128-bottom-edge.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
Known issues
------------
Here are the changes found in Patchwork_21324_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-snb2/igt@gem_ctx_persistence@engines-mixed-process.html
* igt@gem_ctx_shared@q-in-order:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271]) +294 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-snb5/igt@gem_ctx_shared@q-in-order.html
* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][7] -> [TIMEOUT][8] ([i915#2369] / [i915#3063])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl1/igt@gem_eio@unwedge-stress.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb8/igt@gem_exec_fair@basic-flow@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb8/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-tglb: NOTRUN -> [FAIL][11] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_schedule@u-submit-golden-slice@vecs0:
- shard-skl: NOTRUN -> [INCOMPLETE][15] ([i915#3797])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl3/igt@gem_exec_schedule@u-submit-golden-slice@vecs0.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-tglb: NOTRUN -> [SKIP][16] ([i915#4270]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271]) +125 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl7/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@gem_softpin@evict-snoop:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#109312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@gem_softpin@evict-snoop.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][19] ([i915#3002])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl6/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#3297])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@gen7_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#109289])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@gen7_exec_parse@cmd-crossing-page.html
* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#1902])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@i915_pm_lpsp@screens-disabled.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#111644] / [i915#1397] / [i915#2411])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_query@query-topology-unsupported:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109302])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb5/igt@i915_query@query-topology-unsupported.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][25] ([fdo#111614]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_big_fb@linear-8bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][26] ([i915#3722]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3777])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#111615]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3886]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl2/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3886])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#3689] / [i915#3886]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886]) +11 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl7/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#3689]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_ccs.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#109284] / [fdo#111827]) +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb5/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-snb: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +12 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-snb5/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_color@pipe-c-ctm-0-5:
- shard-skl: [PASS][37] -> [DMESG-WARN][38] ([i915#1982])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl7/igt@kms_color@pipe-c-ctm-0-5.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl2/igt@kms_color@pipe-c-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +17 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl6/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-degamma:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +8 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl6/igt@kms_color_chamelium@pipe-b-degamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_concurrent@pipe-d:
- shard-tglb: NOTRUN -> [FAIL][42] ([i915#1385])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb5/igt@kms_concurrent@pipe-d.html
* igt@kms_content_protection@srm:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111828]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-a-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3359]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-max-size-rapid-movement.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3319])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109279] / [i915#3359]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#4103])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271]) +41 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@kms_cursor_legacy@pipe-d-torture-move.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][51] -> [INCOMPLETE][52] ([i915#180] / [i915#636])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglb: [PASS][53] -> [INCOMPLETE][54] ([i915#456])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb5/igt@kms_fbcon_fbt@psr-suspend.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb7/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-tglb: [PASS][55] -> [FAIL][56] ([i915#79])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][57] -> [DMESG-WARN][58] ([i915#180]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][59] ([i915#180]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111825]) +24 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][61] -> [INCOMPLETE][62] ([i915#2411] / [i915#456])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-suspend.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl6/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][64] ([fdo#108145] / [i915#265]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][65] ([i915#265]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#112054])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#658]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#2920])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr@psr2_primary_blt:
- shard-tglb: NOTRUN -> [FAIL][73] ([i915#132] / [i915#3467]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb5/igt@kms_psr@psr2_primary_blt.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][74] -> [SKIP][75] ([fdo#109441]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_writeback@writeback-check-output:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#2437])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2437])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl8/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271]) +228 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl6/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html
* igt@nouveau_crc@pipe-d-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#2530]) +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@nouveau_crc@pipe-d-source-outp-inactive.html
* igt@perf@blocking:
- shard-skl: [PASS][80] -> [FAIL][81] ([i915#1542])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl7/igt@perf@blocking.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl2/igt@perf@blocking.html
* igt@prime_nv_pcopy@test_semaphore:
- shard-tglb: NOTRUN -> [SKIP][82] ([fdo#109291])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@prime_nv_pcopy@test_semaphore.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl3/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@split-50:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl8/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][85] ([i915#658]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb7/igt@feature_discovery@psr2.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][87] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb3/igt@gem_eio@unwedge-stress.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][89] ([i915#2849]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-apl: [DMESG-WARN][91] ([i915#180]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-apl1/igt@gem_exec_suspend@basic-s3.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-apl3/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][93] ([i915#454]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [FAIL][95] ([i915#4275]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@i915_pm_dc@dc9-dpms.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [INCOMPLETE][97] ([i915#151]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl1/igt@i915_pm_rpm@system-suspend-modeset.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-tglb: [INCOMPLETE][99] ([i915#456] / [i915#750]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb1/igt@i915_suspend@fence-restore-tiled2untiled.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@fence-restore-untiled:
- shard-tglb: [INCOMPLETE][101] ([i915#456]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb7/igt@i915_suspend@fence-restore-untiled.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb3/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][103] ([i915#2521]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl5/igt@kms_async_flips@alternate-sync-async-flip.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][105] ([i915#118]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-glk5/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][107] ([i915#2346] / [i915#533]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][109] ([i915#79]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [INCOMPLETE][111] ([i915#2411] / [i915#456]) -> [PASS][112] +2 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-tglb1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][113] ([i915#2122]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-iclb: [SKIP][115] ([i915#3701]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][117] ([i915#123]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl7/igt@kms_frontbuffer_tracking@psr-suspend.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl2/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120] +4 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][121] ([fdo#108145] / [i915#265]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][123] ([fdo#109441]) -> [PASS][124] +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][125] ([i915#1804] / [i915#2684]) -> [WARN][126] ([i915#2684])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-iclb: [SKIP][127] ([i915#2920]) -> [SKIP][128] ([i915#658]) +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][129] ([i915#658]) -> [SKIP][130] ([i915#2920])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][131] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][132] ([i915#4148])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-iclb7/igt@kms_psr2_su@page_flip.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#92])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl3/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl1/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10728/shard-kbl1/igt@runner@aborted.html
[137]: https://intel-gfx-ci
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21324/index.html
[-- Attachment #2: Type: text/html, Size: 33501 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 1:00 [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation José Roberto de Souza
` (4 preceding siblings ...)
2021-10-13 9:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove memory frequency calculation (rev2) Patchwork
@ 2021-10-13 9:32 ` Ville Syrjälä
2021-10-13 19:17 ` Souza, Jose
5 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2021-10-13 9:32 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx, Yakui Zhao, Matt Roper
On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote:
> This memory frequency calculated is only used to check if it is zero,
> what is not useful as it will never actually be zero.
>
> Also the calculation is wrong, we should be checking other bit to
> select the appropriate frequency multiplier while this code is stuck
> with a fixed multiplier.
I don't think the alternate ref clock was ever used.
At least I don't recall ever seeing it.
The real problem with this is that IIRC this is just the last
requested frequency. So on a system with SAGV this will
change dynamically.
>
> So here dropping it as whole.
We have a second copy of this in gen6_update_ring_freq(). Rather
than removing one and leaving another potentially broken one behind we
should probably just consolidate on a single implementation.
>
> v2:
> - Also remove memory frequency calculation for gen9 LP platforms
>
> Cc: Yakui Zhao <yakui.zhao@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: f8112cb9574b ("drm/i915/gen11+: Only load DRAM information from pcode")
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 8 --------
> drivers/gpu/drm/i915/intel_dram.c | 30 ++----------------------------
> 2 files changed, 2 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index a897f4abea0c3..8825f7ac477b6 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -11109,12 +11109,6 @@ enum skl_power_gate {
> #define DC_STATE_DEBUG_MASK_CORES (1 << 0)
> #define DC_STATE_DEBUG_MASK_MEMORY_UP (1 << 1)
>
> -#define BXT_P_CR_MC_BIOS_REQ_0_0_0 _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x7114)
> -#define BXT_REQ_DATA_MASK 0x3F
> -#define BXT_DRAM_CHANNEL_ACTIVE_SHIFT 12
> -#define BXT_DRAM_CHANNEL_ACTIVE_MASK (0xF << 12)
> -#define BXT_MEMORY_FREQ_MULTIPLIER_HZ 133333333
> -
> #define BXT_D_CR_DRP0_DUNIT8 0x1000
> #define BXT_D_CR_DRP0_DUNIT9 0x1200
> #define BXT_D_CR_DRP0_DUNIT_START 8
> @@ -11145,9 +11139,7 @@ enum skl_power_gate {
> #define BXT_DRAM_TYPE_LPDDR4 (0x2 << 22)
> #define BXT_DRAM_TYPE_DDR4 (0x4 << 22)
>
> -#define SKL_MEMORY_FREQ_MULTIPLIER_HZ 266666666
> #define SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5E04)
> -#define SKL_REQ_DATA_MASK (0xF << 0)
> #define DG1_GEAR_TYPE REG_BIT(16)
>
> #define SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5000)
> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
> index 30a0cab5eff46..0adadfd9528aa 100644
> --- a/drivers/gpu/drm/i915/intel_dram.c
> +++ b/drivers/gpu/drm/i915/intel_dram.c
> @@ -244,7 +244,6 @@ static int
> skl_get_dram_info(struct drm_i915_private *i915)
> {
> struct dram_info *dram_info = &i915->dram_info;
> - u32 mem_freq_khz, val;
> int ret;
>
> dram_info->type = skl_get_dram_type(i915);
> @@ -255,17 +254,6 @@ skl_get_dram_info(struct drm_i915_private *i915)
> if (ret)
> return ret;
>
> - val = intel_uncore_read(&i915->uncore,
> - SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU);
> - mem_freq_khz = DIV_ROUND_UP((val & SKL_REQ_DATA_MASK) *
> - SKL_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> -
> - if (dram_info->num_channels * mem_freq_khz == 0) {
> - drm_info(&i915->drm,
> - "Couldn't get system memory bandwidth\n");
> - return -EINVAL;
> - }
> -
> return 0;
> }
>
> @@ -350,24 +338,10 @@ static void bxt_get_dimm_info(struct dram_dimm_info *dimm, u32 val)
> static int bxt_get_dram_info(struct drm_i915_private *i915)
> {
> struct dram_info *dram_info = &i915->dram_info;
> - u32 dram_channels;
> - u32 mem_freq_khz, val;
> - u8 num_active_channels, valid_ranks = 0;
> + u32 val;
> + u8 valid_ranks = 0;
> int i;
>
> - val = intel_uncore_read(&i915->uncore, BXT_P_CR_MC_BIOS_REQ_0_0_0);
> - mem_freq_khz = DIV_ROUND_UP((val & BXT_REQ_DATA_MASK) *
> - BXT_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> -
> - dram_channels = val & BXT_DRAM_CHANNEL_ACTIVE_MASK;
> - num_active_channels = hweight32(dram_channels);
> -
> - if (mem_freq_khz * num_active_channels == 0) {
> - drm_info(&i915->drm,
> - "Couldn't get system memory bandwidth\n");
> - return -EINVAL;
> - }
> -
> /*
> * Now read each DUNIT8/9/10/11 to check the rank of each dimms.
> */
> --
> 2.33.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 9:32 ` [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation Ville Syrjälä
@ 2021-10-13 19:17 ` Souza, Jose
2021-10-13 19:31 ` Ville Syrjälä
0 siblings, 1 reply; 11+ messages in thread
From: Souza, Jose @ 2021-10-13 19:17 UTC (permalink / raw)
To: ville.syrjala; +Cc: Zhao, Yakui, intel-gfx, Roper, Matthew D
On Wed, 2021-10-13 at 12:32 +0300, Ville Syrjälä wrote:
> On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote:
> > This memory frequency calculated is only used to check if it is zero,
> > what is not useful as it will never actually be zero.
> >
> > Also the calculation is wrong, we should be checking other bit to
> > select the appropriate frequency multiplier while this code is stuck
> > with a fixed multiplier.
>
> I don't think the alternate ref clock was ever used.
> At least I don't recall ever seeing it.
>
> The real problem with this is that IIRC this is just the last
> requested frequency. So on a system with SAGV this will
> change dynamically.
>
> >
> > So here dropping it as whole.
>
> We have a second copy of this in gen6_update_ring_freq(). Rather
> than removing one and leaving another potentially broken one behind we
> should probably just consolidate on a single implementation.
gen6_update_ring_freq() is related to GPU frequency not memory, don't look related at all to me.
>
> >
> > v2:
> > - Also remove memory frequency calculation for gen9 LP platforms
> >
> > Cc: Yakui Zhao <yakui.zhao@intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Fixes: f8112cb9574b ("drm/i915/gen11+: Only load DRAM information from pcode")
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 8 --------
> > drivers/gpu/drm/i915/intel_dram.c | 30 ++----------------------------
> > 2 files changed, 2 insertions(+), 36 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index a897f4abea0c3..8825f7ac477b6 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -11109,12 +11109,6 @@ enum skl_power_gate {
> > #define DC_STATE_DEBUG_MASK_CORES (1 << 0)
> > #define DC_STATE_DEBUG_MASK_MEMORY_UP (1 << 1)
> >
> > -#define BXT_P_CR_MC_BIOS_REQ_0_0_0 _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x7114)
> > -#define BXT_REQ_DATA_MASK 0x3F
> > -#define BXT_DRAM_CHANNEL_ACTIVE_SHIFT 12
> > -#define BXT_DRAM_CHANNEL_ACTIVE_MASK (0xF << 12)
> > -#define BXT_MEMORY_FREQ_MULTIPLIER_HZ 133333333
> > -
> > #define BXT_D_CR_DRP0_DUNIT8 0x1000
> > #define BXT_D_CR_DRP0_DUNIT9 0x1200
> > #define BXT_D_CR_DRP0_DUNIT_START 8
> > @@ -11145,9 +11139,7 @@ enum skl_power_gate {
> > #define BXT_DRAM_TYPE_LPDDR4 (0x2 << 22)
> > #define BXT_DRAM_TYPE_DDR4 (0x4 << 22)
> >
> > -#define SKL_MEMORY_FREQ_MULTIPLIER_HZ 266666666
> > #define SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5E04)
> > -#define SKL_REQ_DATA_MASK (0xF << 0)
> > #define DG1_GEAR_TYPE REG_BIT(16)
> >
> > #define SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5000)
> > diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
> > index 30a0cab5eff46..0adadfd9528aa 100644
> > --- a/drivers/gpu/drm/i915/intel_dram.c
> > +++ b/drivers/gpu/drm/i915/intel_dram.c
> > @@ -244,7 +244,6 @@ static int
> > skl_get_dram_info(struct drm_i915_private *i915)
> > {
> > struct dram_info *dram_info = &i915->dram_info;
> > - u32 mem_freq_khz, val;
> > int ret;
> >
> > dram_info->type = skl_get_dram_type(i915);
> > @@ -255,17 +254,6 @@ skl_get_dram_info(struct drm_i915_private *i915)
> > if (ret)
> > return ret;
> >
> > - val = intel_uncore_read(&i915->uncore,
> > - SKL_MC_BIOS_DATA_0_0_0_MCHBAR_PCU);
> > - mem_freq_khz = DIV_ROUND_UP((val & SKL_REQ_DATA_MASK) *
> > - SKL_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> > -
> > - if (dram_info->num_channels * mem_freq_khz == 0) {
> > - drm_info(&i915->drm,
> > - "Couldn't get system memory bandwidth\n");
> > - return -EINVAL;
> > - }
> > -
> > return 0;
> > }
> >
> > @@ -350,24 +338,10 @@ static void bxt_get_dimm_info(struct dram_dimm_info *dimm, u32 val)
> > static int bxt_get_dram_info(struct drm_i915_private *i915)
> > {
> > struct dram_info *dram_info = &i915->dram_info;
> > - u32 dram_channels;
> > - u32 mem_freq_khz, val;
> > - u8 num_active_channels, valid_ranks = 0;
> > + u32 val;
> > + u8 valid_ranks = 0;
> > int i;
> >
> > - val = intel_uncore_read(&i915->uncore, BXT_P_CR_MC_BIOS_REQ_0_0_0);
> > - mem_freq_khz = DIV_ROUND_UP((val & BXT_REQ_DATA_MASK) *
> > - BXT_MEMORY_FREQ_MULTIPLIER_HZ, 1000);
> > -
> > - dram_channels = val & BXT_DRAM_CHANNEL_ACTIVE_MASK;
> > - num_active_channels = hweight32(dram_channels);
> > -
> > - if (mem_freq_khz * num_active_channels == 0) {
> > - drm_info(&i915->drm,
> > - "Couldn't get system memory bandwidth\n");
> > - return -EINVAL;
> > - }
> > -
> > /*
> > * Now read each DUNIT8/9/10/11 to check the rank of each dimms.
> > */
> > --
> > 2.33.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 19:17 ` Souza, Jose
@ 2021-10-13 19:31 ` Ville Syrjälä
2021-10-13 19:38 ` Souza, Jose
0 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2021-10-13 19:31 UTC (permalink / raw)
To: Souza, Jose; +Cc: Zhao, Yakui, intel-gfx, Roper, Matthew D
On Wed, Oct 13, 2021 at 07:17:14PM +0000, Souza, Jose wrote:
> On Wed, 2021-10-13 at 12:32 +0300, Ville Syrjälä wrote:
> > On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote:
> > > This memory frequency calculated is only used to check if it is zero,
> > > what is not useful as it will never actually be zero.
> > >
> > > Also the calculation is wrong, we should be checking other bit to
> > > select the appropriate frequency multiplier while this code is stuck
> > > with a fixed multiplier.
> >
> > I don't think the alternate ref clock was ever used.
> > At least I don't recall ever seeing it.
> >
> > The real problem with this is that IIRC this is just the last
> > requested frequency. So on a system with SAGV this will
> > change dynamically.
> >
> > >
> > > So here dropping it as whole.
> >
> > We have a second copy of this in gen6_update_ring_freq(). Rather
> > than removing one and leaving another potentially broken one behind we
> > should probably just consolidate on a single implementation.
>
> gen6_update_ring_freq() is related to GPU frequency not memory, don't look related at all to me.
>
GPU, CPU and memory clocks are all needed there, at least on some
platforms. I forget which ones did what exactly.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation
2021-10-13 19:31 ` Ville Syrjälä
@ 2021-10-13 19:38 ` Souza, Jose
0 siblings, 0 replies; 11+ messages in thread
From: Souza, Jose @ 2021-10-13 19:38 UTC (permalink / raw)
To: ville.syrjala; +Cc: Zhao, Yakui, intel-gfx, Roper, Matthew D
On Wed, 2021-10-13 at 22:31 +0300, Ville Syrjälä wrote:
> On Wed, Oct 13, 2021 at 07:17:14PM +0000, Souza, Jose wrote:
> > On Wed, 2021-10-13 at 12:32 +0300, Ville Syrjälä wrote:
> > > On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote:
> > > > This memory frequency calculated is only used to check if it is zero,
> > > > what is not useful as it will never actually be zero.
> > > >
> > > > Also the calculation is wrong, we should be checking other bit to
> > > > select the appropriate frequency multiplier while this code is stuck
> > > > with a fixed multiplier.
> > >
> > > I don't think the alternate ref clock was ever used.
> > > At least I don't recall ever seeing it.
> > >
> > > The real problem with this is that IIRC this is just the last
> > > requested frequency. So on a system with SAGV this will
> > > change dynamically.
> > >
> > > >
> > > > So here dropping it as whole.
> > >
> > > We have a second copy of this in gen6_update_ring_freq(). Rather
> > > than removing one and leaving another potentially broken one behind we
> > > should probably just consolidate on a single implementation.
> >
> > gen6_update_ring_freq() is related to GPU frequency not memory, don't look related at all to me.
> >
>
> GPU, CPU and memory clocks are all needed there, at least on some
> platforms. I forget which ones did what exactly.
But is is not relate with removing this memory frequency calculation, so we can drop it without leaving any code behind.
>
^ permalink raw reply [flat|nested] 11+ messages in thread