All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schemas
@ 2021-10-17 13:06 ` Stefan Wahren
  0 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 13:06 UTC (permalink / raw)
  To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Mwesigwa Guma,
	Ojaswin Mujoo, Phil Elwell, devicetree, linux-arm-kernel,
	linux-staging, Stefan Wahren

This series converts the VCHIQ bindings to YAML format.

Stefan Wahren (2):
  ARM: dts: bcm283x: Drop fallback compatible for vchiq
  dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema

 .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
 .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
 arch/arm/boot/dts/bcm2836-rpi.dtsi                 |  2 +-
 3 files changed, 48 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml

-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 0/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schemas
@ 2021-10-17 13:06 ` Stefan Wahren
  0 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 13:06 UTC (permalink / raw)
  To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Mwesigwa Guma,
	Ojaswin Mujoo, Phil Elwell, devicetree, linux-arm-kernel,
	linux-staging, Stefan Wahren

This series converts the VCHIQ bindings to YAML format.

Stefan Wahren (2):
  ARM: dts: bcm283x: Drop fallback compatible for vchiq
  dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema

 .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
 .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
 arch/arm/boot/dts/bcm2836-rpi.dtsi                 |  2 +-
 3 files changed, 48 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml

-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/2] ARM: dts: bcm283x: Drop fallback compatible for vchiq
  2021-10-17 13:06 ` [PATCH 0/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Stefan Wahren
@ 2021-10-17 13:06   ` Stefan Wahren
  -1 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 13:06 UTC (permalink / raw)
  To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Mwesigwa Guma,
	Ojaswin Mujoo, Phil Elwell, devicetree, linux-arm-kernel,
	linux-staging, Stefan Wahren

With introduction of SoC specific vchiq compatible back in 2018, we kept the
original "brcm,bcm2835-vchiq" as a fallback for older Kernel versions.
Now this fallback isn't necessary anymore. So before we create a DT schema
which also handles this fallback better fix this on the DTS side.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2836-rpi.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2836-rpi.dtsi b/arch/arm/boot/dts/bcm2836-rpi.dtsi
index c4c858b..f98e0e4 100644
--- a/arch/arm/boot/dts/bcm2836-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2836-rpi.dtsi
@@ -2,5 +2,5 @@
 #include "bcm2835-rpi.dtsi"
 
 &vchiq {
-	compatible = "brcm,bcm2836-vchiq", "brcm,bcm2835-vchiq";
+	compatible = "brcm,bcm2836-vchiq";
 };
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 1/2] ARM: dts: bcm283x: Drop fallback compatible for vchiq
@ 2021-10-17 13:06   ` Stefan Wahren
  0 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 13:06 UTC (permalink / raw)
  To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Mwesigwa Guma,
	Ojaswin Mujoo, Phil Elwell, devicetree, linux-arm-kernel,
	linux-staging, Stefan Wahren

With introduction of SoC specific vchiq compatible back in 2018, we kept the
original "brcm,bcm2835-vchiq" as a fallback for older Kernel versions.
Now this fallback isn't necessary anymore. So before we create a DT schema
which also handles this fallback better fix this on the DTS side.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2836-rpi.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2836-rpi.dtsi b/arch/arm/boot/dts/bcm2836-rpi.dtsi
index c4c858b..f98e0e4 100644
--- a/arch/arm/boot/dts/bcm2836-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2836-rpi.dtsi
@@ -2,5 +2,5 @@
 #include "bcm2835-rpi.dtsi"
 
 &vchiq {
-	compatible = "brcm,bcm2836-vchiq", "brcm,bcm2835-vchiq";
+	compatible = "brcm,bcm2836-vchiq";
 };
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema
  2021-10-17 13:06 ` [PATCH 0/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Stefan Wahren
@ 2021-10-17 13:06   ` Stefan Wahren
  -1 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 13:06 UTC (permalink / raw)
  To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Mwesigwa Guma,
	Ojaswin Mujoo, Phil Elwell, devicetree, linux-arm-kernel,
	linux-staging, Stefan Wahren

This converts the VCHIQ bindings to YAML format.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
 .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
 2 files changed, 47 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
deleted file mode 100644
index f331316..0000000
--- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Broadcom VCHIQ firmware services
-
-Required properties:
-
-- compatible:	Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise
-		"brcm,bcm2836-vchiq".
-- reg:		Physical base address and length of the doorbell register pair
-- interrupts:	The interrupt number
-		  See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
-
-Example:
-
-mailbox@7e00b840 {
-	compatible = "brcm,bcm2835-vchiq";
-	reg = <0x7e00b840 0xf>;
-	interrupts = <0 2>;
-};
diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
new file mode 100644
index 0000000..2ef6b21
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2835-vchiq.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom VCHIQ firmware services
+
+maintainers:
+  - Nicolas Saenz Julienne <nsaenz@kernel.org>
+
+description: |
+  The VCHIQ communication channel can be provided by BCM283x and Capri SoCs,
+  to communicate with the VPU-side OS services.
+
+properties:
+  compatible:
+    enum:
+      - brcm,bcm2835-vchiq
+      - brcm,bcm2836-vchiq
+
+  reg:
+    description: Physical base address and length of the doorbell register pair
+    minItems: 1
+
+  interrupts:
+    description: |
+      Interrupt number of the doorbell interrupt
+      see bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
+    minItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    mailbox@7e00b840 {
+      compatible = "brcm,bcm2835-vchiq";
+      reg = <0x7e00b840 0xf>;
+      interrupts = <0 2>;
+    };
+
+...
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
@ 2021-10-17 13:06   ` Stefan Wahren
  0 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 13:06 UTC (permalink / raw)
  To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Mwesigwa Guma,
	Ojaswin Mujoo, Phil Elwell, devicetree, linux-arm-kernel,
	linux-staging, Stefan Wahren

This converts the VCHIQ bindings to YAML format.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
 .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
 2 files changed, 47 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
deleted file mode 100644
index f331316..0000000
--- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Broadcom VCHIQ firmware services
-
-Required properties:
-
-- compatible:	Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise
-		"brcm,bcm2836-vchiq".
-- reg:		Physical base address and length of the doorbell register pair
-- interrupts:	The interrupt number
-		  See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
-
-Example:
-
-mailbox@7e00b840 {
-	compatible = "brcm,bcm2835-vchiq";
-	reg = <0x7e00b840 0xf>;
-	interrupts = <0 2>;
-};
diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
new file mode 100644
index 0000000..2ef6b21
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2835-vchiq.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom VCHIQ firmware services
+
+maintainers:
+  - Nicolas Saenz Julienne <nsaenz@kernel.org>
+
+description: |
+  The VCHIQ communication channel can be provided by BCM283x and Capri SoCs,
+  to communicate with the VPU-side OS services.
+
+properties:
+  compatible:
+    enum:
+      - brcm,bcm2835-vchiq
+      - brcm,bcm2836-vchiq
+
+  reg:
+    description: Physical base address and length of the doorbell register pair
+    minItems: 1
+
+  interrupts:
+    description: |
+      Interrupt number of the doorbell interrupt
+      see bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
+    minItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    mailbox@7e00b840 {
+      compatible = "brcm,bcm2835-vchiq";
+      reg = <0x7e00b840 0xf>;
+      interrupts = <0 2>;
+    };
+
+...
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema
  2021-10-17 13:06   ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Stefan Wahren
@ 2021-10-17 15:29     ` Rob Herring
  -1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-10-17 15:29 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Nicolas Saenz Julienne, Ojaswin Mujoo, Mwesigwa Guma,
	linux-staging, Scott Branden, linux-arm-kernel, Ray Jui,
	devicetree, bcm-kernel-feedback-list, Phil Elwell, Rob Herring,
	Florian Fainelli

On Sun, 17 Oct 2021 15:06:36 +0200, Stefan Wahren wrote:
> This converts the VCHIQ bindings to YAML format.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1542230


mailbox@7e00b840: compatible: Additional items are not allowed ('brcm,bcm2835-vchiq' was unexpected)
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml

mailbox@7e00b840: compatible: ['brcm,bcm2836-vchiq', 'brcm,bcm2835-vchiq'] is too long
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
@ 2021-10-17 15:29     ` Rob Herring
  0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-10-17 15:29 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Nicolas Saenz Julienne, Ojaswin Mujoo, Mwesigwa Guma,
	linux-staging, Scott Branden, linux-arm-kernel, Ray Jui,
	devicetree, bcm-kernel-feedback-list, Phil Elwell, Rob Herring,
	Florian Fainelli

On Sun, 17 Oct 2021 15:06:36 +0200, Stefan Wahren wrote:
> This converts the VCHIQ bindings to YAML format.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1542230


mailbox@7e00b840: compatible: Additional items are not allowed ('brcm,bcm2835-vchiq' was unexpected)
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml

mailbox@7e00b840: compatible: ['brcm,bcm2836-vchiq', 'brcm,bcm2835-vchiq'] is too long
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
  2021-10-17 15:29     ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Rob Herring
@ 2021-10-17 16:31       ` Stefan Wahren
  -1 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 16:31 UTC (permalink / raw)
  To: Rob Herring
  Cc: Nicolas Saenz Julienne, Ojaswin Mujoo, Mwesigwa Guma,
	linux-staging, Scott Branden, linux-arm-kernel, Ray Jui,
	devicetree, bcm-kernel-feedback-list, Phil Elwell, Rob Herring,
	Florian Fainelli

Hi Rob,

Am 17.10.21 um 17:29 schrieb Rob Herring:
> On Sun, 17 Oct 2021 15:06:36 +0200, Stefan Wahren wrote:
>> This converts the VCHIQ bindings to YAML format.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
>>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
>>  2 files changed, 47 insertions(+), 17 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
>>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1542230
>
>
> mailbox@7e00b840: compatible: Additional items are not allowed ('brcm,bcm2835-vchiq' was unexpected)
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> 	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml
>
> mailbox@7e00b840: compatible: ['brcm,bcm2836-vchiq', 'brcm,bcm2835-vchiq'] is too long
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> 	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml

i'm confused patch 1/2 ( "ARM: dts: bcm283x: Drop fallback compatible
for vchiq" ) of this series should prevent this warning. Was it applied
before running dtbs_check?

Best regards

>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
@ 2021-10-17 16:31       ` Stefan Wahren
  0 siblings, 0 replies; 14+ messages in thread
From: Stefan Wahren @ 2021-10-17 16:31 UTC (permalink / raw)
  To: Rob Herring
  Cc: Nicolas Saenz Julienne, Ojaswin Mujoo, Mwesigwa Guma,
	linux-staging, Scott Branden, linux-arm-kernel, Ray Jui,
	devicetree, bcm-kernel-feedback-list, Phil Elwell, Rob Herring,
	Florian Fainelli

Hi Rob,

Am 17.10.21 um 17:29 schrieb Rob Herring:
> On Sun, 17 Oct 2021 15:06:36 +0200, Stefan Wahren wrote:
>> This converts the VCHIQ bindings to YAML format.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
>>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
>>  2 files changed, 47 insertions(+), 17 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
>>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1542230
>
>
> mailbox@7e00b840: compatible: Additional items are not allowed ('brcm,bcm2835-vchiq' was unexpected)
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> 	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml
>
> mailbox@7e00b840: compatible: ['brcm,bcm2836-vchiq', 'brcm,bcm2835-vchiq'] is too long
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> 	arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> 	arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml

i'm confused patch 1/2 ( "ARM: dts: bcm283x: Drop fallback compatible
for vchiq" ) of this series should prevent this warning. Was it applied
before running dtbs_check?

Best regards

>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
  2021-10-17 16:31       ` Stefan Wahren
@ 2021-10-18 12:44         ` Rob Herring
  -1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-10-18 12:44 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Nicolas Saenz Julienne, Ojaswin Mujoo, Mwesigwa Guma,
	linux-staging, Scott Branden, linux-arm-kernel, Ray Jui,
	devicetree, maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE,
	Phil Elwell, Florian Fainelli

On Sun, Oct 17, 2021 at 11:31 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Hi Rob,
>
> Am 17.10.21 um 17:29 schrieb Rob Herring:
> > On Sun, 17 Oct 2021 15:06:36 +0200, Stefan Wahren wrote:
> >> This converts the VCHIQ bindings to YAML format.
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >> ---
> >>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
> >>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
> >>  2 files changed, 47 insertions(+), 17 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
> >>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> >>
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1542230
> >
> >
> > mailbox@7e00b840: compatible: Additional items are not allowed ('brcm,bcm2835-vchiq' was unexpected)
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> >       arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml
> >
> > mailbox@7e00b840: compatible: ['brcm,bcm2836-vchiq', 'brcm,bcm2835-vchiq'] is too long
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> >       arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml
>
> i'm confused patch 1/2 ( "ARM: dts: bcm283x: Drop fallback compatible
> for vchiq" ) of this series should prevent this warning. Was it applied
> before running dtbs_check?

No, so you can ignore this.

Rob

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
@ 2021-10-18 12:44         ` Rob Herring
  0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-10-18 12:44 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Nicolas Saenz Julienne, Ojaswin Mujoo, Mwesigwa Guma,
	linux-staging, Scott Branden, linux-arm-kernel, Ray Jui,
	devicetree, maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE,
	Phil Elwell, Florian Fainelli

On Sun, Oct 17, 2021 at 11:31 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Hi Rob,
>
> Am 17.10.21 um 17:29 schrieb Rob Herring:
> > On Sun, 17 Oct 2021 15:06:36 +0200, Stefan Wahren wrote:
> >> This converts the VCHIQ bindings to YAML format.
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >> ---
> >>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
> >>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
> >>  2 files changed, 47 insertions(+), 17 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
> >>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> >>
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1542230
> >
> >
> > mailbox@7e00b840: compatible: Additional items are not allowed ('brcm,bcm2835-vchiq' was unexpected)
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> >       arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml
> >
> > mailbox@7e00b840: compatible: ['brcm,bcm2836-vchiq', 'brcm,bcm2835-vchiq'] is too long
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dt.yaml
> >       arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dt.yaml
> >       arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dt.yaml
>
> i'm confused patch 1/2 ( "ARM: dts: bcm283x: Drop fallback compatible
> for vchiq" ) of this series should prevent this warning. Was it applied
> before running dtbs_check?

No, so you can ignore this.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema
  2021-10-17 13:06   ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Stefan Wahren
@ 2021-10-26 23:30     ` Rob Herring
  -1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-10-26 23:30 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Florian Fainelli, Nicolas Saenz Julienne, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, Mwesigwa Guma, Ojaswin Mujoo,
	Phil Elwell, devicetree, linux-arm-kernel, linux-staging

On Sun, Oct 17, 2021 at 03:06:36PM +0200, Stefan Wahren wrote:
> This converts the VCHIQ bindings to YAML format.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
> deleted file mode 100644
> index f331316..0000000
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -Broadcom VCHIQ firmware services
> -
> -Required properties:
> -
> -- compatible:	Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise
> -		"brcm,bcm2836-vchiq".
> -- reg:		Physical base address and length of the doorbell register pair
> -- interrupts:	The interrupt number
> -		  See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
> -
> -Example:
> -
> -mailbox@7e00b840 {
> -	compatible = "brcm,bcm2835-vchiq";
> -	reg = <0x7e00b840 0xf>;
> -	interrupts = <0 2>;
> -};
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> new file mode 100644
> index 0000000..2ef6b21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2835-vchiq.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom VCHIQ firmware services
> +
> +maintainers:
> +  - Nicolas Saenz Julienne <nsaenz@kernel.org>
> +
> +description: |

Don't need '|' if there is no formatting to preserve.

> +  The VCHIQ communication channel can be provided by BCM283x and Capri SoCs,
> +  to communicate with the VPU-side OS services.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm2835-vchiq
> +      - brcm,bcm2836-vchiq
> +
> +  reg:
> +    description: Physical base address and length of the doorbell register pair
> +    minItems: 1
> +
> +  interrupts:
> +    description: |
> +      Interrupt number of the doorbell interrupt
> +      see bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt

What interrupt controller you are attached to is outside the scope of a 
binding, so drop the ref. Plus, then we don't have to update it later.

> +    minItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    mailbox@7e00b840 {
> +      compatible = "brcm,bcm2835-vchiq";
> +      reg = <0x7e00b840 0xf>;
> +      interrupts = <0 2>;
> +    };
> +
> +...
> -- 
> 2.7.4
> 
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq to json-schema
@ 2021-10-26 23:30     ` Rob Herring
  0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-10-26 23:30 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Florian Fainelli, Nicolas Saenz Julienne, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, Mwesigwa Guma, Ojaswin Mujoo,
	Phil Elwell, devicetree, linux-arm-kernel, linux-staging

On Sun, Oct 17, 2021 at 03:06:36PM +0200, Stefan Wahren wrote:
> This converts the VCHIQ bindings to YAML format.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt        | 17 --------
>  .../bindings/soc/bcm/brcm,bcm2835-vchiq.yaml       | 47 ++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
> deleted file mode 100644
> index f331316..0000000
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -Broadcom VCHIQ firmware services
> -
> -Required properties:
> -
> -- compatible:	Should be "brcm,bcm2835-vchiq" on BCM2835, otherwise
> -		"brcm,bcm2836-vchiq".
> -- reg:		Physical base address and length of the doorbell register pair
> -- interrupts:	The interrupt number
> -		  See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
> -
> -Example:
> -
> -mailbox@7e00b840 {
> -	compatible = "brcm,bcm2835-vchiq";
> -	reg = <0x7e00b840 0xf>;
> -	interrupts = <0 2>;
> -};
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> new file mode 100644
> index 0000000..2ef6b21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2835-vchiq.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom VCHIQ firmware services
> +
> +maintainers:
> +  - Nicolas Saenz Julienne <nsaenz@kernel.org>
> +
> +description: |

Don't need '|' if there is no formatting to preserve.

> +  The VCHIQ communication channel can be provided by BCM283x and Capri SoCs,
> +  to communicate with the VPU-side OS services.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm2835-vchiq
> +      - brcm,bcm2836-vchiq
> +
> +  reg:
> +    description: Physical base address and length of the doorbell register pair
> +    minItems: 1
> +
> +  interrupts:
> +    description: |
> +      Interrupt number of the doorbell interrupt
> +      see bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt

What interrupt controller you are attached to is outside the scope of a 
binding, so drop the ref. Plus, then we don't have to update it later.

> +    minItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    mailbox@7e00b840 {
> +      compatible = "brcm,bcm2835-vchiq";
> +      reg = <0x7e00b840 0xf>;
> +      interrupts = <0 2>;
> +    };
> +
> +...
> -- 
> 2.7.4
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-10-26 23:32 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-17 13:06 [PATCH 0/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schemas Stefan Wahren
2021-10-17 13:06 ` [PATCH 0/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Stefan Wahren
2021-10-17 13:06 ` [PATCH 1/2] ARM: dts: bcm283x: Drop fallback compatible for vchiq Stefan Wahren
2021-10-17 13:06   ` Stefan Wahren
2021-10-17 13:06 ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq to json-schema Stefan Wahren
2021-10-17 13:06   ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Stefan Wahren
2021-10-17 15:29   ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq " Rob Herring
2021-10-17 15:29     ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Rob Herring
2021-10-17 16:31     ` Stefan Wahren
2021-10-17 16:31       ` Stefan Wahren
2021-10-18 12:44       ` Rob Herring
2021-10-18 12:44         ` Rob Herring
2021-10-26 23:30   ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm,bcm2835-vchiq " Rob Herring
2021-10-26 23:30     ` [PATCH 2/2] dt-bindings: soc: bcm: Convert brcm, bcm2835-vchiq " Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.