* [Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions.
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
@ 2021-10-17 23:41 ` Dave Airlie
2021-10-19 8:34 ` Ville Syrjälä
2021-10-17 23:41 ` [Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin Dave Airlie
` (6 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Dave Airlie @ 2021-10-17 23:41 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, ville.syrjala, Dave Airlie
From: Dave Airlie <airlied@redhat.com>
This just cleans up the calls a bit.
v2: fix unpin in vaddr fail path (Jani)
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/i915/display/intel_fbdev.c | 67 +++++++++++++---------
1 file changed, 41 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index adc3a81be9f7..c3ea9639a4ed 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -171,6 +171,38 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
return 0;
}
+static void intel_fbdev_unpin(struct intel_fbdev *ifbdev)
+{
+ if (ifbdev->vma)
+ intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
+ ifbdev->vma = NULL;
+ ifbdev->vma_flags = 0;
+}
+
+static int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
+ struct intel_fbdev *ifbdev,
+ void **vaddr)
+{
+ const struct i915_ggtt_view view = {
+ .type = I915_GGTT_VIEW_NORMAL,
+ };
+ ifbdev->vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
+ &view, false, &ifbdev->vma_flags);
+
+ if (IS_ERR(ifbdev->vma)) {
+ return PTR_ERR(ifbdev->vma);
+ }
+
+ *vaddr = i915_vma_pin_iomap(ifbdev->vma);
+ if (IS_ERR(*vaddr)) {
+ intel_fbdev_unpin(ifbdev);
+ drm_err(&dev_priv->drm,
+ "Failed to remap framebuffer into virtual memory\n");
+ return PTR_ERR(vaddr);
+ }
+ return 0;
+}
+
static int intelfb_create(struct drm_fb_helper *helper,
struct drm_fb_helper_surface_size *sizes)
{
@@ -181,13 +213,8 @@ static int intelfb_create(struct drm_fb_helper *helper,
struct drm_i915_private *dev_priv = to_i915(dev);
struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
struct i915_ggtt *ggtt = &dev_priv->ggtt;
- const struct i915_ggtt_view view = {
- .type = I915_GGTT_VIEW_NORMAL,
- };
intel_wakeref_t wakeref;
struct fb_info *info;
- struct i915_vma *vma;
- unsigned long flags = 0;
bool prealloc = false;
void __iomem *vaddr;
struct drm_i915_gem_object *obj;
@@ -224,10 +251,8 @@ static int intelfb_create(struct drm_fb_helper *helper,
* This also validates that any existing fb inherited from the
* BIOS is suitable for own access.
*/
- vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
- &view, false, &flags);
- if (IS_ERR(vma)) {
- ret = PTR_ERR(vma);
+ ret = intel_fbdev_pin_and_fence(dev_priv, ifbdev, &vaddr);
+ if (ret) {
goto out_unlock;
}
@@ -261,19 +286,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
/* Our framebuffer is the entirety of fbdev's system memory */
info->fix.smem_start =
- (unsigned long)(ggtt->gmadr.start + vma->node.start);
- info->fix.smem_len = vma->node.size;
+ (unsigned long)(ggtt->gmadr.start + ifbdev->vma->node.start);
+ info->fix.smem_len = ifbdev->vma->node.size;
}
- vaddr = i915_vma_pin_iomap(vma);
- if (IS_ERR(vaddr)) {
- drm_err(&dev_priv->drm,
- "Failed to remap framebuffer into virtual memory\n");
- ret = PTR_ERR(vaddr);
- goto out_unpin;
- }
info->screen_base = vaddr;
- info->screen_size = vma->node.size;
+ info->screen_size = ifbdev->vma->node.size;
drm_fb_helper_fill_info(info, &ifbdev->helper, sizes);
@@ -281,23 +299,21 @@ static int intelfb_create(struct drm_fb_helper *helper,
* If the object is stolen however, it will be full of whatever
* garbage was left in there.
*/
- if (!i915_gem_object_is_shmem(vma->obj) && !prealloc)
+ if (!i915_gem_object_is_shmem(ifbdev->vma->obj) && !prealloc)
memset_io(info->screen_base, 0, info->screen_size);
/* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
drm_dbg_kms(&dev_priv->drm, "allocated %dx%d fb: 0x%08x\n",
ifbdev->fb->base.width, ifbdev->fb->base.height,
- i915_ggtt_offset(vma));
- ifbdev->vma = vma;
- ifbdev->vma_flags = flags;
+ i915_ggtt_offset(ifbdev->vma));
intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
vga_switcheroo_client_fb_set(pdev, info);
return 0;
out_unpin:
- intel_unpin_fb_vma(vma, flags);
+ intel_fbdev_unpin(ifbdev);
out_unlock:
intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
return ret;
@@ -316,8 +332,7 @@ static void intel_fbdev_destroy(struct intel_fbdev *ifbdev)
drm_fb_helper_fini(&ifbdev->helper);
- if (ifbdev->vma)
- intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
+ intel_fbdev_unpin(ifbdev);
if (ifbdev->fb)
drm_framebuffer_remove(&ifbdev->fb->base);
--
2.25.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions.
2021-10-17 23:41 ` [Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions Dave Airlie
@ 2021-10-19 8:34 ` Ville Syrjälä
0 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2021-10-19 8:34 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx, jani.nikula, Dave Airlie
On Mon, Oct 18, 2021 at 09:41:03AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This just cleans up the calls a bit.
>
> v2: fix unpin in vaddr fail path (Jani)
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbdev.c | 67 +++++++++++++---------
> 1 file changed, 41 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index adc3a81be9f7..c3ea9639a4ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -171,6 +171,38 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
> return 0;
> }
>
> +static void intel_fbdev_unpin(struct intel_fbdev *ifbdev)
> +{
> + if (ifbdev->vma)
> + intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
> + ifbdev->vma = NULL;
> + ifbdev->vma_flags = 0;
> +}
> +
> +static int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
> + struct intel_fbdev *ifbdev,
> + void **vaddr)
__iomem ?
Was wonder why sparse didn't catch this, but looks like it did.
> +{
> + const struct i915_ggtt_view view = {
> + .type = I915_GGTT_VIEW_NORMAL,
> + };
Surprised checkpatch didn't complain about lack of an empty line
after the variable declarations. Pretty sure I've seen it do that,
or was it perhaps some other checker?
> + ifbdev->vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
> + &view, false, &ifbdev->vma_flags);
> +
> + if (IS_ERR(ifbdev->vma)) {
> + return PTR_ERR(ifbdev->vma);
> + }
A few trivial checkpatch warns around single line if-statements
vs. braces. Should be easy to clear those out.
Looks good otherwise
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> +
> + *vaddr = i915_vma_pin_iomap(ifbdev->vma);
> + if (IS_ERR(*vaddr)) {
> + intel_fbdev_unpin(ifbdev);
> + drm_err(&dev_priv->drm,
> + "Failed to remap framebuffer into virtual memory\n");
> + return PTR_ERR(vaddr);
> + }
> + return 0;
> +}
> +
> static int intelfb_create(struct drm_fb_helper *helper,
> struct drm_fb_helper_surface_size *sizes)
> {
> @@ -181,13 +213,8 @@ static int intelfb_create(struct drm_fb_helper *helper,
> struct drm_i915_private *dev_priv = to_i915(dev);
> struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
> struct i915_ggtt *ggtt = &dev_priv->ggtt;
> - const struct i915_ggtt_view view = {
> - .type = I915_GGTT_VIEW_NORMAL,
> - };
> intel_wakeref_t wakeref;
> struct fb_info *info;
> - struct i915_vma *vma;
> - unsigned long flags = 0;
> bool prealloc = false;
> void __iomem *vaddr;
> struct drm_i915_gem_object *obj;
> @@ -224,10 +251,8 @@ static int intelfb_create(struct drm_fb_helper *helper,
> * This also validates that any existing fb inherited from the
> * BIOS is suitable for own access.
> */
> - vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
> - &view, false, &flags);
> - if (IS_ERR(vma)) {
> - ret = PTR_ERR(vma);
> + ret = intel_fbdev_pin_and_fence(dev_priv, ifbdev, &vaddr);
> + if (ret) {
> goto out_unlock;
> }
>
> @@ -261,19 +286,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
>
> /* Our framebuffer is the entirety of fbdev's system memory */
> info->fix.smem_start =
> - (unsigned long)(ggtt->gmadr.start + vma->node.start);
> - info->fix.smem_len = vma->node.size;
> + (unsigned long)(ggtt->gmadr.start + ifbdev->vma->node.start);
> + info->fix.smem_len = ifbdev->vma->node.size;
> }
>
> - vaddr = i915_vma_pin_iomap(vma);
> - if (IS_ERR(vaddr)) {
> - drm_err(&dev_priv->drm,
> - "Failed to remap framebuffer into virtual memory\n");
> - ret = PTR_ERR(vaddr);
> - goto out_unpin;
> - }
> info->screen_base = vaddr;
> - info->screen_size = vma->node.size;
> + info->screen_size = ifbdev->vma->node.size;
>
> drm_fb_helper_fill_info(info, &ifbdev->helper, sizes);
>
> @@ -281,23 +299,21 @@ static int intelfb_create(struct drm_fb_helper *helper,
> * If the object is stolen however, it will be full of whatever
> * garbage was left in there.
> */
> - if (!i915_gem_object_is_shmem(vma->obj) && !prealloc)
> + if (!i915_gem_object_is_shmem(ifbdev->vma->obj) && !prealloc)
> memset_io(info->screen_base, 0, info->screen_size);
>
> /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
>
> drm_dbg_kms(&dev_priv->drm, "allocated %dx%d fb: 0x%08x\n",
> ifbdev->fb->base.width, ifbdev->fb->base.height,
> - i915_ggtt_offset(vma));
> - ifbdev->vma = vma;
> - ifbdev->vma_flags = flags;
> + i915_ggtt_offset(ifbdev->vma));
>
> intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
> vga_switcheroo_client_fb_set(pdev, info);
> return 0;
>
> out_unpin:
> - intel_unpin_fb_vma(vma, flags);
> + intel_fbdev_unpin(ifbdev);
> out_unlock:
> intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
> return ret;
> @@ -316,8 +332,7 @@ static void intel_fbdev_destroy(struct intel_fbdev *ifbdev)
>
> drm_fb_helper_fini(&ifbdev->helper);
>
> - if (ifbdev->vma)
> - intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
> + intel_fbdev_unpin(ifbdev);
>
> if (ifbdev->fb)
> drm_framebuffer_remove(&ifbdev->fb->base);
> --
> 2.25.4
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
2021-10-17 23:41 ` [Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions Dave Airlie
@ 2021-10-17 23:41 ` Dave Airlie
2021-10-19 9:15 ` Ville Syrjälä
2021-10-17 23:41 ` [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin Dave Airlie
` (5 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Dave Airlie @ 2021-10-17 23:41 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, ville.syrjala, Dave Airlie
From: Dave Airlie <airlied@redhat.com>
This moves the fbdev pin code over and moves the internal
interfaces to static.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 37 +++++++++++++++++++--
drivers/gpu/drm/i915/display/intel_fb_pin.h | 15 ++++-----
drivers/gpu/drm/i915/display/intel_fbdev.c | 32 ------------------
3 files changed, 41 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
index 3f77f3013584..0beb0aa33337 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
+++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
@@ -71,7 +71,7 @@ intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
return vma;
}
-struct i915_vma *
+static struct i915_vma *
intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
bool phys_cursor,
const struct i915_ggtt_view *view,
@@ -199,7 +199,8 @@ intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
return vma;
}
-void intel_unpin_fb_vma(struct i915_vma *vma, unsigned long flags)
+static void
+intel_unpin_fb_vma(struct i915_vma *vma, unsigned long flags)
{
if (flags & PLANE_HAS_FENCE)
i915_vma_unpin_fence(vma);
@@ -272,3 +273,35 @@ void intel_plane_unpin_fb(struct intel_plane_state *old_plane_state)
intel_dpt_unpin(intel_fb->dpt_vm);
}
}
+
+void intel_fbdev_unpin(struct intel_fbdev *ifbdev)
+{
+ if (ifbdev->vma)
+ intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
+ ifbdev->vma = NULL;
+ ifbdev->vma_flags = 0;
+}
+
+int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
+ struct intel_fbdev *ifbdev,
+ void **vaddr)
+{
+ const struct i915_ggtt_view view = {
+ .type = I915_GGTT_VIEW_NORMAL,
+ };
+ ifbdev->vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
+ &view, false, &ifbdev->vma_flags);
+
+ if (IS_ERR(ifbdev->vma)) {
+ return PTR_ERR(ifbdev->vma);
+ }
+
+ *vaddr = i915_vma_pin_iomap(ifbdev->vma);
+ if (IS_ERR(*vaddr)) {
+ intel_fbdev_unpin(ifbdev);
+ drm_err(&dev_priv->drm,
+ "Failed to remap framebuffer into virtual memory\n");
+ return PTR_ERR(vaddr);
+ }
+ return 0;
+}
diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.h b/drivers/gpu/drm/i915/display/intel_fb_pin.h
index e4fcd0218d9d..88d736264348 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_pin.h
+++ b/drivers/gpu/drm/i915/display/intel_fb_pin.h
@@ -8,21 +8,18 @@
#include <linux/types.h>
+struct drm_i915_private;
struct drm_framebuffer;
+struct intel_fbdev;
struct i915_vma;
struct intel_plane_state;
struct i915_ggtt_view;
-struct i915_vma *
-intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
- bool phys_cursor,
- const struct i915_ggtt_view *view,
- bool uses_fence,
- unsigned long *out_flags);
-
-void intel_unpin_fb_vma(struct i915_vma *vma, unsigned long flags);
-
int intel_plane_pin_fb(struct intel_plane_state *plane_state);
void intel_plane_unpin_fb(struct intel_plane_state *old_plane_state);
+int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
+ struct intel_fbdev *ifbdev,
+ void **vaddr);
+void intel_fbdev_unpin(struct intel_fbdev *ifbdev);
#endif
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index c3ea9639a4ed..cee85fcc2085 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -171,38 +171,6 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
return 0;
}
-static void intel_fbdev_unpin(struct intel_fbdev *ifbdev)
-{
- if (ifbdev->vma)
- intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
- ifbdev->vma = NULL;
- ifbdev->vma_flags = 0;
-}
-
-static int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
- struct intel_fbdev *ifbdev,
- void **vaddr)
-{
- const struct i915_ggtt_view view = {
- .type = I915_GGTT_VIEW_NORMAL,
- };
- ifbdev->vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
- &view, false, &ifbdev->vma_flags);
-
- if (IS_ERR(ifbdev->vma)) {
- return PTR_ERR(ifbdev->vma);
- }
-
- *vaddr = i915_vma_pin_iomap(ifbdev->vma);
- if (IS_ERR(*vaddr)) {
- intel_fbdev_unpin(ifbdev);
- drm_err(&dev_priv->drm,
- "Failed to remap framebuffer into virtual memory\n");
- return PTR_ERR(vaddr);
- }
- return 0;
-}
-
static int intelfb_create(struct drm_fb_helper *helper,
struct drm_fb_helper_surface_size *sizes)
{
--
2.25.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin
2021-10-17 23:41 ` [Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin Dave Airlie
@ 2021-10-19 9:15 ` Ville Syrjälä
0 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2021-10-19 9:15 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx, jani.nikula, Dave Airlie
On Mon, Oct 18, 2021 at 09:41:04AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This moves the fbdev pin code over and moves the internal
> interfaces to static.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb_pin.c | 37 +++++++++++++++++++--
> drivers/gpu/drm/i915/display/intel_fb_pin.h | 15 ++++-----
> drivers/gpu/drm/i915/display/intel_fbdev.c | 32 ------------------
> 3 files changed, 41 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> index 3f77f3013584..0beb0aa33337 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> @@ -71,7 +71,7 @@ intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
> return vma;
> }
>
> -struct i915_vma *
> +static struct i915_vma *
> intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
> bool phys_cursor,
> const struct i915_ggtt_view *view,
> @@ -199,7 +199,8 @@ intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
> return vma;
> }
>
> -void intel_unpin_fb_vma(struct i915_vma *vma, unsigned long flags)
> +static void
> +intel_unpin_fb_vma(struct i915_vma *vma, unsigned long flags)
> {
> if (flags & PLANE_HAS_FENCE)
> i915_vma_unpin_fence(vma);
> @@ -272,3 +273,35 @@ void intel_plane_unpin_fb(struct intel_plane_state *old_plane_state)
> intel_dpt_unpin(intel_fb->dpt_vm);
> }
> }
> +
> +void intel_fbdev_unpin(struct intel_fbdev *ifbdev)
> +{
> + if (ifbdev->vma)
> + intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
> + ifbdev->vma = NULL;
> + ifbdev->vma_flags = 0;
> +}
> +
> +int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
> + struct intel_fbdev *ifbdev,
> + void **vaddr)
> +{
> + const struct i915_ggtt_view view = {
> + .type = I915_GGTT_VIEW_NORMAL,
> + };
> + ifbdev->vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
> + &view, false, &ifbdev->vma_flags);
> +
> + if (IS_ERR(ifbdev->vma)) {
> + return PTR_ERR(ifbdev->vma);
> + }
I suppose easiest to just regenrate this one after fixing the
sparse/checkpatch issues in the previous patch.
Also the fbdev code still has to root around inside the vma/etc.
so the abstraction is pretty weak. So not sure how much this
buys us.
But I guess no real harm in it either.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> +
> + *vaddr = i915_vma_pin_iomap(ifbdev->vma);
> + if (IS_ERR(*vaddr)) {
> + intel_fbdev_unpin(ifbdev);
> + drm_err(&dev_priv->drm,
> + "Failed to remap framebuffer into virtual memory\n");
> + return PTR_ERR(vaddr);
> + }
> + return 0;
> +}
> diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.h b/drivers/gpu/drm/i915/display/intel_fb_pin.h
> index e4fcd0218d9d..88d736264348 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb_pin.h
> +++ b/drivers/gpu/drm/i915/display/intel_fb_pin.h
> @@ -8,21 +8,18 @@
>
> #include <linux/types.h>
>
> +struct drm_i915_private;
> struct drm_framebuffer;
> +struct intel_fbdev;
> struct i915_vma;
> struct intel_plane_state;
> struct i915_ggtt_view;
>
> -struct i915_vma *
> -intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
> - bool phys_cursor,
> - const struct i915_ggtt_view *view,
> - bool uses_fence,
> - unsigned long *out_flags);
> -
> -void intel_unpin_fb_vma(struct i915_vma *vma, unsigned long flags);
> -
> int intel_plane_pin_fb(struct intel_plane_state *plane_state);
> void intel_plane_unpin_fb(struct intel_plane_state *old_plane_state);
>
> +int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
> + struct intel_fbdev *ifbdev,
> + void **vaddr);
> +void intel_fbdev_unpin(struct intel_fbdev *ifbdev);
> #endif
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index c3ea9639a4ed..cee85fcc2085 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -171,38 +171,6 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
> return 0;
> }
>
> -static void intel_fbdev_unpin(struct intel_fbdev *ifbdev)
> -{
> - if (ifbdev->vma)
> - intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags);
> - ifbdev->vma = NULL;
> - ifbdev->vma_flags = 0;
> -}
> -
> -static int intel_fbdev_pin_and_fence(struct drm_i915_private *dev_priv,
> - struct intel_fbdev *ifbdev,
> - void **vaddr)
> -{
> - const struct i915_ggtt_view view = {
> - .type = I915_GGTT_VIEW_NORMAL,
> - };
> - ifbdev->vma = intel_pin_and_fence_fb_obj(&ifbdev->fb->base, false,
> - &view, false, &ifbdev->vma_flags);
> -
> - if (IS_ERR(ifbdev->vma)) {
> - return PTR_ERR(ifbdev->vma);
> - }
> -
> - *vaddr = i915_vma_pin_iomap(ifbdev->vma);
> - if (IS_ERR(*vaddr)) {
> - intel_fbdev_unpin(ifbdev);
> - drm_err(&dev_priv->drm,
> - "Failed to remap framebuffer into virtual memory\n");
> - return PTR_ERR(vaddr);
> - }
> - return 0;
> -}
> -
> static int intelfb_create(struct drm_fb_helper *helper,
> struct drm_fb_helper_surface_size *sizes)
> {
> --
> 2.25.4
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
2021-10-17 23:41 ` [Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions Dave Airlie
2021-10-17 23:41 ` [Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin Dave Airlie
@ 2021-10-17 23:41 ` Dave Airlie
2021-10-19 8:14 ` Ville Syrjälä
2021-10-17 23:41 ` [Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes Dave Airlie
` (4 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Dave Airlie @ 2021-10-17 23:41 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, ville.syrjala, Dave Airlie
From: Dave Airlie <airlied@redhat.com>
The uses_fence isn't used.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
index 0beb0aa33337..721a1477e8b1 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
+++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
@@ -18,7 +18,6 @@
static struct i915_vma *
intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
const struct i915_ggtt_view *view,
- bool uses_fence,
unsigned long *out_flags,
struct i915_address_space *vm)
{
@@ -236,7 +235,7 @@ int intel_plane_pin_fb(struct intel_plane_state *plane_state)
plane_state->ggtt_vma = vma;
- vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt, false,
+ vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt,
&plane_state->flags, intel_fb->dpt_vm);
if (IS_ERR(vma)) {
intel_dpt_unpin(intel_fb->dpt_vm);
--
2.25.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin
2021-10-17 23:41 ` [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin Dave Airlie
@ 2021-10-19 8:14 ` Ville Syrjälä
0 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2021-10-19 8:14 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx, jani.nikula, Dave Airlie
On Mon, Oct 18, 2021 at 09:41:05AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> The uses_fence isn't used.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb_pin.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> index 0beb0aa33337..721a1477e8b1 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> @@ -18,7 +18,6 @@
> static struct i915_vma *
> intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
> const struct i915_ggtt_view *view,
> - bool uses_fence,
> unsigned long *out_flags,
> struct i915_address_space *vm)
> {
> @@ -236,7 +235,7 @@ int intel_plane_pin_fb(struct intel_plane_state *plane_state)
>
> plane_state->ggtt_vma = vma;
>
> - vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt, false,
> + vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt,
> &plane_state->flags, intel_fb->dpt_vm);
> if (IS_ERR(vma)) {
> intel_dpt_unpin(intel_fb->dpt_vm);
> --
> 2.25.4
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
` (2 preceding siblings ...)
2021-10-17 23:41 ` [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin Dave Airlie
@ 2021-10-17 23:41 ` Dave Airlie
2021-10-19 8:24 ` Ville Syrjälä
2021-10-18 0:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for finish/rebase fbdev pin refactor Patchwork
` (3 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Dave Airlie @ 2021-10-17 23:41 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, ville.syrjala, Dave Airlie
From: Dave Airlie <airlied@redhat.com>
These aren't used since refactoring.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index ff598b6cd953..73f8c893d52e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -65,11 +65,8 @@
#include "display/intel_vdsc.h"
#include "display/intel_vrr.h"
-#include "gem/i915_gem_lmem.h"
#include "gem/i915_gem_object.h"
-#include "gt/gen8_ppgtt.h"
-
#include "pxp/intel_pxp.h"
#include "g4x_dp.h"
--
2.25.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes
2021-10-17 23:41 ` [Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes Dave Airlie
@ 2021-10-19 8:24 ` Ville Syrjälä
0 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2021-10-19 8:24 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx, jani.nikula, Dave Airlie
On Mon, Oct 18, 2021 at 09:41:06AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> These aren't used since refactoring.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index ff598b6cd953..73f8c893d52e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -65,11 +65,8 @@
> #include "display/intel_vdsc.h"
> #include "display/intel_vrr.h"
>
> -#include "gem/i915_gem_lmem.h"
> #include "gem/i915_gem_object.h"
>
> -#include "gt/gen8_ppgtt.h"
> -
I was wonder who even added that to a display file.
Turns out it was me :)
I guess the pte_encode() was there. Hmm, looks like it
still is actually.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> #include "pxp/intel_pxp.h"
>
> #include "g4x_dp.h"
> --
> 2.25.4
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for finish/rebase fbdev pin refactor.
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
` (3 preceding siblings ...)
2021-10-17 23:41 ` [Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes Dave Airlie
@ 2021-10-18 0:00 ` Patchwork
2021-10-18 0:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-10-18 0:00 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f1c4731db194 drm/i915/display: refactor fbdev pin/unpin out into functions.
-:38: WARNING:BRACES: braces {} are not necessary for single statement blocks
#38: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:192:
+ if (IS_ERR(ifbdev->vma)) {
+ return PTR_ERR(ifbdev->vma);
+ }
-:78: WARNING:BRACES: braces {} are not necessary for single statement blocks
#78: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:255:
+ if (ret) {
goto out_unlock;
}
total: 0 errors, 2 warnings, 0 checks, 120 lines checked
58e642c8a077 drm/i915/display: move fbdev pin code into fb_pin
-:57: WARNING:BRACES: braces {} are not necessary for single statement blocks
#57: FILE: drivers/gpu/drm/i915/display/intel_fb_pin.c:295:
+ if (IS_ERR(ifbdev->vma)) {
+ return PTR_ERR(ifbdev->vma);
+ }
total: 0 errors, 1 warnings, 0 checks, 117 lines checked
f17b77fe86cd drm/i915/display: drop unused parameter to dpt pin
8f99fb9fce14 drm/i915/display: drop some unused includes
^ permalink raw reply [flat|nested] 13+ messages in thread* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for finish/rebase fbdev pin refactor.
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
` (4 preceding siblings ...)
2021-10-18 0:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for finish/rebase fbdev pin refactor Patchwork
@ 2021-10-18 0:01 ` Patchwork
2021-10-18 0:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-18 1:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-10-18 0:01 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_fbdev.c:222:60: expected void **vaddr
+drivers/gpu/drm/i915/display/intel_fbdev.c:222:60: got void [noderef] __iomem **
+drivers/gpu/drm/i915/display/intel_fbdev.c:222:60: warning: incorrect type in argument 3 (different address spaces)
+drivers/gpu/drm/i915/display/intel_fb_pin.c:298:16: expected void *
+drivers/gpu/drm/i915/display/intel_fb_pin.c:298:16: got void [noderef] __iomem *
+drivers/gpu/drm/i915/display/intel_fb_pin.c:298:16: warning: incorrect type in assignment (different address spaces)
^ permalink raw reply [flat|nested] 13+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for finish/rebase fbdev pin refactor.
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
` (5 preceding siblings ...)
2021-10-18 0:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-10-18 0:32 ` Patchwork
2021-10-18 1:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-10-18 0:32 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3426 bytes --]
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21362
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/index.html
Known issues
------------
Here are the changes found in Patchwork_21362 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/fi-kbl-soraka/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/fi-bsw-n3050/igt@amdgpu/amd_cs_nop@sync-gfx0.html
#### Possible fixes ####
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [DMESG-FAIL][3] ([i915#2927] / [i915#3428]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_flip@basic-plain-flip@c-dp1:
- fi-cfl-8109u: [FAIL][5] ([i915#4165]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][7] ([i915#295]) -> [PASS][8] +14 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165
Participating hosts (41 -> 36)
------------------------------
Missing (5): bat-dg1-6 fi-hsw-4200u bat-dg1-5 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10750 -> Patchwork_21362
CI-20190529: 20190529
CI_DRM_10750: 7df3fd87528d6d245e5101cc32518ac649aeea98 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6251: 01b6be842d74fb86f3226acb4ddcb85231f4b161 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21362: 8f99fb9fce141567186aabfb79af456208cfc978 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8f99fb9fce14 drm/i915/display: drop some unused includes
f17b77fe86cd drm/i915/display: drop unused parameter to dpt pin
58e642c8a077 drm/i915/display: move fbdev pin code into fb_pin
f1c4731db194 drm/i915/display: refactor fbdev pin/unpin out into functions.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/index.html
[-- Attachment #2: Type: text/html, Size: 4229 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* [Intel-gfx] ✗ Fi.CI.IGT: failure for finish/rebase fbdev pin refactor.
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
` (6 preceding siblings ...)
2021-10-18 0:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-10-18 1:56 ` Patchwork
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-10-18 1:56 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30256 bytes --]
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10750_full -> Patchwork_21362_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21362_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21362_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21362_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@system-suspend:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb2/igt@i915_pm_rpm@system-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb4/igt@i915_pm_rpm@system-suspend.html
* igt@kms_bw@linear-tiling-1-displays-3840x2160p:
- shard-snb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-snb7/igt@kms_bw@linear-tiling-1-displays-3840x2160p.html
* igt@kms_bw@linear-tiling-3-displays-3840x2160p:
- shard-skl: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@kms_bw@linear-tiling-3-displays-3840x2160p.html
Known issues
------------
Here are the changes found in Patchwork_21362_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-2x:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#1839])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb8/igt@feature_discovery@display-2x.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +5 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-snb7/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][7] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb2/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][14] ([i915#3002])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl6/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][15] ([i915#3318])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271]) +179 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl2/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@bb-secure:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#2856])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb3/igt@gen9_exec_parse@bb-secure.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][20] ([i915#454])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][21] -> [INCOMPLETE][22] ([i915#3921])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-snb7/igt@i915_selftest@live@hangcheck.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@forcewake:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([i915#2411] / [i915#456])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-tglb3/igt@i915_suspend@forcewake.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb7/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][25] ([i915#3743])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3777]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#3886]) +9 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3886]) +4 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109278] / [i915#3886])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb3/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271]) +295 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-snb6/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_chamelium@vga-edid-read:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109284] / [fdo#111827])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb3/igt@kms_chamelium@vga-edid-read.html
* igt@kms_chamelium@vga-frame-dump:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@kms_chamelium@vga-frame-dump.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +14 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +14 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_content_protection@mei_interface:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111828])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb8/igt@kms_content_protection@mei_interface.html
* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][39] ([i915#1319])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl6/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
- shard-glk: [PASS][40] -> [FAIL][41] ([i915#3444])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-glk1/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-glk4/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278]) +4 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding.html
* igt@kms_cursor_legacy@pipe-a-single-bo:
- shard-apl: [PASS][43] -> [DMESG-WARN][44] ([i915#203] / [i915#62]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-apl8/igt@kms_cursor_legacy@pipe-a-single-bo.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl3/igt@kms_cursor_legacy@pipe-a-single-bo.html
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271]) +49 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@kms_flip@2x-flip-vs-panning-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [PASS][46] -> [FAIL][47] ([i915#79])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][48] ([i915#180]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2672])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#2672])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-iclb: [PASS][51] -> [SKIP][52] ([i915#3701]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html
* igt@kms_flip_tiling@flip-changes-tiling@dp-1-pipe-b:
- shard-apl: [PASS][53] -> [DMESG-WARN][54] ([i915#165] / [i915#180] / [i915#62]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-apl8/igt@kms_flip_tiling@flip-changes-tiling@dp-1-pipe-b.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl3/igt@kms_flip_tiling@flip-changes-tiling@dp-1-pipe-b.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109280])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-msflip-blt:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#111825]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271]) +65 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#1188])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-skl3/igt@kms_hdr@bpc-switch.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl1/igt@kms_hdr@bpc-switch.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#533]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][62] -> [FAIL][63] ([fdo#108145] / [i915#265])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][64] ([fdo#108145] / [i915#265]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
- shard-kbl: NOTRUN -> [FAIL][65] ([fdo#108145] / [i915#265]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_lowres@pipe-a-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#3536])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-yf.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2733])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2733])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#2920])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
- shard-kbl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][73] -> [SKIP][74] ([fdo#109441]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_sysfs_edid_timing:
- shard-kbl: NOTRUN -> [FAIL][75] ([IGT#2])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl2/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-skl: [PASS][76] -> [INCOMPLETE][77] ([i915#198])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-skl10/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][78] -> [DMESG-WARN][79] ([i915#180]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl3/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-wait-idle-hang:
- shard-apl: [PASS][80] -> [DMESG-WARN][81] ([i915#180] / [i915#203] / [i915#62]) +18 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-apl8/igt@kms_vblank@pipe-b-wait-idle-hang.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl3/igt@kms_vblank@pipe-b-wait-idle-hang.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2437])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl8/igt@kms_writeback@writeback-fb-id.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl1/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@pidname:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb8/igt@sysfs_clients@pidname.html
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2994])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl3/igt@sysfs_clients@pidname.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [FAIL][86] ([i915#2842]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl2/igt@gem_exec_fair@basic-none-vip@rcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl2/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][88] ([i915#2842]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][90] ([i915#2842]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-tglb5/igt@gem_exec_fair@basic-pace@rcs0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][92] ([i915#2849]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [DMESG-WARN][94] ([i915#118]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-glk9/igt@gem_exec_whisper@basic-queues-all.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][96] ([i915#454]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@fences-dpms:
- shard-iclb: [INCOMPLETE][98] ([i915#2910]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb7/igt@i915_pm_rpm@fences-dpms.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@i915_pm_rpm@fences-dpms.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][100] ([i915#180]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-apl2/igt@i915_suspend@sysfs-reader.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-apl1/igt@i915_suspend@sysfs-reader.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-iclb: [FAIL][102] ([i915#79]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-tglb: [INCOMPLETE][104] ([i915#2411] / [i915#456]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-tglb7/igt@kms_flip@flip-vs-suspend@a-edp1.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-tglb8/igt@kms_flip@flip-vs-suspend@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][106] ([i915#180]) -> [PASS][107] +5 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][108] ([i915#2122]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][110] ([fdo#108145] / [i915#265]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][112] ([fdo#109441]) -> [PASS][113] +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@perf@blocking:
- shard-skl: [FAIL][114] ([i915#1542]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-skl8/igt@perf@blocking.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-skl2/igt@perf@blocking.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][116] ([i915#2842]) -> [SKIP][117] ([fdo#109271])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][118] ([i915#2684]) -> [WARN][119] ([i915#1804] / [i915#2684])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][120] ([i915#1804] / [i915#2684]) -> [WARN][121] ([i915#2684])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [INCOMPLETE][122] ([i915#3614]) -> [DMESG-WARN][123] ([i915#180])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl3/igt@i915_suspend@debugfs-reader.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][124] ([i915#658]) -> [SKIP][125] ([i915#2920]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][126] ([i915#2920]) -> [SKIP][127] ([i915#658])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][128] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][129] ([i915#4148])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-iclb7/igt@kms_psr2_su@page_flip.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl7/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl7/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl4/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl7/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl4/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl3/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl1/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl2/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/shard-kbl3/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl1/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl1/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl7/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl7/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl4/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl4/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/shard-kbl7/igt@runner@aborted.html
- shard-apl: ([FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164]) ([fdo#109271] / [i915#180] /
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21362/index.html
[-- Attachment #2: Type: text/html, Size: 33860 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread