* [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish
@ 2021-10-18 3:42 Oak Zeng
2021-10-18 2:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Oak Zeng @ 2021-10-18 3:42 UTC (permalink / raw)
To: intel-gfx; +Cc: srinivasan.s, sudeep.dutt, cq.tang, chris, matthew.auld
Caller of function igt_gpu_fill_dw assumes when this function
returns, the gpu command to fill dword is already finished.
Caller usually checks the GPU filling result immediately, see
the usage in function __igt_write_huge. If there is no wait,
when function igt_gpu_fill_dw returns, the GPU command is not
guaranteed to be finished. So wait for request to finish.
Signed-off-by: Oak Zeng <oak.zeng@intel.com>
---
drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c
index b35c1219c852..5fa595ed30b1 100644
--- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c
+++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c
@@ -157,6 +157,7 @@ int igt_gpu_fill_dw(struct intel_context *ce,
if (err)
i915_request_set_error_once(rq, err);
i915_request_add(rq);
+ err = i915_request_wait(rq, 0, HZ/5);
err_batch:
i915_vma_unpin_and_release(&batch, 0);
return err;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Wait request to finish 2021-10-18 3:42 [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish Oak Zeng @ 2021-10-18 2:54 ` Patchwork 2021-10-18 3:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-10-18 2:54 UTC (permalink / raw) To: Oak Zeng; +Cc: intel-gfx == Series Details == Series: drm/i915/selftests: Wait request to finish URL : https://patchwork.freedesktop.org/series/95926/ State : warning == Summary == $ dim checkpatch origin/drm-tip cc4b6b8dafe9 drm/i915/selftests: Wait request to finish -:23: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #23: FILE: drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c:160: + err = i915_request_wait(rq, 0, HZ/5); ^ total: 0 errors, 0 warnings, 1 checks, 7 lines checked ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Wait request to finish 2021-10-18 3:42 [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish Oak Zeng 2021-10-18 2:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2021-10-18 3:27 ` Patchwork 2021-10-18 7:49 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2021-10-18 7:54 ` Matthew Auld 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-10-18 3:27 UTC (permalink / raw) To: Oak Zeng; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 18355 bytes --] == Series Details == Series: drm/i915/selftests: Wait request to finish URL : https://patchwork.freedesktop.org/series/95926/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21363 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_21363 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_21363, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_21363: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@gem_contexts: - fi-elk-e7500: [PASS][1] -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-elk-e7500/igt@i915_selftest@live@gem_contexts.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-elk-e7500/igt@i915_selftest@live@gem_contexts.html - fi-ilk-650: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-ilk-650/igt@i915_selftest@live@gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-ilk-650/igt@i915_selftest@live@gem_contexts.html * igt@i915_selftest@live@hugepages: - fi-bsw-n3050: [PASS][5] -> [DMESG-FAIL][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bsw-n3050/igt@i915_selftest@live@hugepages.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bsw-n3050/igt@i915_selftest@live@hugepages.html - fi-skl-6700k2: [PASS][7] -> [DMESG-FAIL][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-skl-6700k2/igt@i915_selftest@live@hugepages.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-skl-6700k2/igt@i915_selftest@live@hugepages.html - fi-hsw-4770: [PASS][9] -> [DMESG-FAIL][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-hsw-4770/igt@i915_selftest@live@hugepages.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-hsw-4770/igt@i915_selftest@live@hugepages.html - fi-cfl-guc: [PASS][11] -> [DMESG-FAIL][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-guc/igt@i915_selftest@live@hugepages.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-guc/igt@i915_selftest@live@hugepages.html - fi-rkl-11600: [PASS][13] -> [DMESG-FAIL][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-rkl-11600/igt@i915_selftest@live@hugepages.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-rkl-11600/igt@i915_selftest@live@hugepages.html - fi-skl-guc: [PASS][15] -> [DMESG-FAIL][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-skl-guc/igt@i915_selftest@live@hugepages.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-skl-guc/igt@i915_selftest@live@hugepages.html - fi-kbl-7567u: [PASS][17] -> [DMESG-FAIL][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-kbl-7567u/igt@i915_selftest@live@hugepages.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-7567u/igt@i915_selftest@live@hugepages.html - fi-icl-y: [PASS][19] -> [DMESG-FAIL][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-icl-y/igt@i915_selftest@live@hugepages.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-icl-y/igt@i915_selftest@live@hugepages.html - fi-snb-2520m: [PASS][21] -> [DMESG-FAIL][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-snb-2520m/igt@i915_selftest@live@hugepages.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-snb-2520m/igt@i915_selftest@live@hugepages.html - fi-glk-dsi: [PASS][23] -> [DMESG-FAIL][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-glk-dsi/igt@i915_selftest@live@hugepages.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-glk-dsi/igt@i915_selftest@live@hugepages.html - fi-ivb-3770: [PASS][25] -> [DMESG-FAIL][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-ivb-3770/igt@i915_selftest@live@hugepages.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-ivb-3770/igt@i915_selftest@live@hugepages.html - fi-skl-6600u: [PASS][27] -> [DMESG-FAIL][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-skl-6600u/igt@i915_selftest@live@hugepages.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-skl-6600u/igt@i915_selftest@live@hugepages.html - fi-cfl-8700k: [PASS][29] -> [DMESG-FAIL][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8700k/igt@i915_selftest@live@hugepages.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8700k/igt@i915_selftest@live@hugepages.html - fi-bsw-kefka: [PASS][31] -> [DMESG-FAIL][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bsw-kefka/igt@i915_selftest@live@hugepages.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bsw-kefka/igt@i915_selftest@live@hugepages.html - fi-kbl-7500u: [PASS][33] -> [DMESG-FAIL][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-kbl-7500u/igt@i915_selftest@live@hugepages.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-7500u/igt@i915_selftest@live@hugepages.html - fi-bdw-samus: [PASS][35] -> [DMESG-FAIL][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bdw-samus/igt@i915_selftest@live@hugepages.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bdw-samus/igt@i915_selftest@live@hugepages.html - fi-bdw-5557u: [PASS][37] -> [DMESG-FAIL][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bdw-5557u/igt@i915_selftest@live@hugepages.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bdw-5557u/igt@i915_selftest@live@hugepages.html - fi-kbl-soraka: [PASS][39] -> [DMESG-FAIL][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-kbl-soraka/igt@i915_selftest@live@hugepages.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-soraka/igt@i915_selftest@live@hugepages.html - fi-kbl-8809g: [PASS][41] -> [DMESG-FAIL][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-kbl-8809g/igt@i915_selftest@live@hugepages.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-8809g/igt@i915_selftest@live@hugepages.html - fi-bsw-nick: [PASS][43] -> [DMESG-FAIL][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bsw-nick/igt@i915_selftest@live@hugepages.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bsw-nick/igt@i915_selftest@live@hugepages.html - fi-tgl-1115g4: [PASS][45] -> [DMESG-FAIL][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-tgl-1115g4/igt@i915_selftest@live@hugepages.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-tgl-1115g4/igt@i915_selftest@live@hugepages.html - fi-cfl-8109u: [PASS][47] -> [DMESG-FAIL][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@i915_selftest@live@hugepages.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8109u/igt@i915_selftest@live@hugepages.html - fi-bxt-dsi: [PASS][49] -> [DMESG-FAIL][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-bxt-dsi/igt@i915_selftest@live@hugepages.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bxt-dsi/igt@i915_selftest@live@hugepages.html - fi-snb-2600: [PASS][51] -> [DMESG-FAIL][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-snb-2600/igt@i915_selftest@live@hugepages.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-snb-2600/igt@i915_selftest@live@hugepages.html - fi-cml-u2: [PASS][53] -> [DMESG-FAIL][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cml-u2/igt@i915_selftest@live@hugepages.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cml-u2/igt@i915_selftest@live@hugepages.html - fi-rkl-guc: [PASS][55] -> [DMESG-FAIL][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-rkl-guc/igt@i915_selftest@live@hugepages.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-rkl-guc/igt@i915_selftest@live@hugepages.html * igt@runner@aborted: - fi-snb-2600: NOTRUN -> [FAIL][57] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-snb-2600/igt@runner@aborted.html - fi-snb-2520m: NOTRUN -> [FAIL][58] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-snb-2520m/igt@runner@aborted.html - fi-bdw-5557u: NOTRUN -> [FAIL][59] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bdw-5557u/igt@runner@aborted.html - fi-bdw-samus: NOTRUN -> [FAIL][60] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bdw-samus/igt@runner@aborted.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_selftest@live@hugepages: - {fi-ehl-2}: [PASS][61] -> [DMESG-FAIL][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-ehl-2/igt@i915_selftest@live@hugepages.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-ehl-2/igt@i915_selftest@live@hugepages.html - {fi-tgl-dsi}: [PASS][63] -> [DMESG-FAIL][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-tgl-dsi/igt@i915_selftest@live@hugepages.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-tgl-dsi/igt@i915_selftest@live@hugepages.html - {fi-hsw-gt1}: [PASS][65] -> [DMESG-FAIL][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-hsw-gt1/igt@i915_selftest@live@hugepages.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-hsw-gt1/igt@i915_selftest@live@hugepages.html - {fi-jsl-1}: [PASS][67] -> [DMESG-FAIL][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-jsl-1/igt@i915_selftest@live@hugepages.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-jsl-1/igt@i915_selftest@live@hugepages.html Known issues ------------ Here are the changes found in Patchwork_21363 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_flip@basic-flip-vs-modeset@c-dp1: - fi-cfl-8109u: [PASS][69] -> [FAIL][70] ([i915#4165]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html * igt@runner@aborted: - fi-rkl-11600: NOTRUN -> [FAIL][71] ([i915#3928]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-rkl-11600/igt@runner@aborted.html - fi-ilk-650: NOTRUN -> [FAIL][72] ([fdo#109271]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-ilk-650/igt@runner@aborted.html - fi-bsw-kefka: NOTRUN -> [FAIL][73] ([fdo#109271] / [i915#1436] / [i915#3428]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bsw-kefka/igt@runner@aborted.html - fi-cfl-8700k: NOTRUN -> [FAIL][74] ([i915#3363]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8700k/igt@runner@aborted.html - fi-skl-6600u: NOTRUN -> [FAIL][75] ([i915#1436] / [i915#3363]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-skl-6600u/igt@runner@aborted.html - fi-cfl-8109u: NOTRUN -> [FAIL][76] ([i915#3363]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8109u/igt@runner@aborted.html - fi-glk-dsi: NOTRUN -> [FAIL][77] ([i915#3363] / [k.org#202321]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-glk-dsi/igt@runner@aborted.html - fi-bsw-nick: NOTRUN -> [FAIL][78] ([fdo#109271] / [i915#1436] / [i915#3428]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bsw-nick/igt@runner@aborted.html - fi-kbl-8809g: NOTRUN -> [FAIL][79] ([i915#1436] / [i915#3363]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-8809g/igt@runner@aborted.html - fi-kbl-soraka: NOTRUN -> [FAIL][80] ([i915#1436] / [i915#3363]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-soraka/igt@runner@aborted.html - fi-hsw-4770: NOTRUN -> [FAIL][81] ([fdo#109271] / [i915#1436]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-hsw-4770/igt@runner@aborted.html - fi-kbl-7500u: NOTRUN -> [FAIL][82] ([i915#1436] / [i915#3363]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-7500u/igt@runner@aborted.html - fi-cml-u2: NOTRUN -> [FAIL][83] ([i915#3363]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cml-u2/igt@runner@aborted.html - fi-rkl-guc: NOTRUN -> [FAIL][84] ([i915#3928]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-rkl-guc/igt@runner@aborted.html - fi-ivb-3770: NOTRUN -> [FAIL][85] ([fdo#109271]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-ivb-3770/igt@runner@aborted.html - fi-bxt-dsi: NOTRUN -> [FAIL][86] ([i915#3363]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-bxt-dsi/igt@runner@aborted.html - fi-tgl-1115g4: NOTRUN -> [FAIL][87] ([i915#1436] / [i915#2966]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-tgl-1115g4/igt@runner@aborted.html - fi-elk-e7500: NOTRUN -> [FAIL][88] ([fdo#109271]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-elk-e7500/igt@runner@aborted.html - fi-cfl-guc: NOTRUN -> [FAIL][89] ([i915#3363]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-guc/igt@runner@aborted.html - fi-icl-y: NOTRUN -> [FAIL][90] ([i915#4006]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-icl-y/igt@runner@aborted.html - fi-kbl-7567u: NOTRUN -> [FAIL][91] ([i915#1436] / [i915#3363]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-kbl-7567u/igt@runner@aborted.html - fi-skl-guc: NOTRUN -> [FAIL][92] ([i915#1436] / [i915#3363]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-skl-guc/igt@runner@aborted.html - fi-skl-6700k2: NOTRUN -> [FAIL][93] ([i915#1436] / [i915#3363]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-skl-6700k2/igt@runner@aborted.html #### Possible fixes #### * igt@kms_flip@basic-plain-flip@c-dp1: - fi-cfl-8109u: [FAIL][94] ([i915#4165]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b: - fi-cfl-8109u: [DMESG-WARN][96] ([i915#295]) -> [PASS][97] +13 similar issues [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html #### Warnings #### * igt@kms_frontbuffer_tracking@basic: - fi-cfl-8109u: [DMESG-WARN][98] ([i915#295]) -> [FAIL][99] ([i915#2546]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10750/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546 [i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295 [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428 [i915#3918]: https://gitlab.freedesktop.org/drm/intel/issues/3918 [i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928 [i915#3970]: https://gitlab.freedesktop.org/drm/intel/issues/3970 [i915#4006]: https://gitlab.freedesktop.org/drm/intel/issues/4006 [i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (41 -> 37) ------------------------------ Missing (4): fi-bsw-cyan fi-hsw-4200u bat-dg1-6 bat-dg1-5 Build changes ------------- * Linux: CI_DRM_10750 -> Patchwork_21363 CI-20190529: 20190529 CI_DRM_10750: 7df3fd87528d6d245e5101cc32518ac649aeea98 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6251: 01b6be842d74fb86f3226acb4ddcb85231f4b161 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21363: cc4b6b8dafe9c43e7b818e5697c03067826a3e33 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == cc4b6b8dafe9 drm/i915/selftests: Wait request to finish == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21363/index.html [-- Attachment #2: Type: text/html, Size: 21855 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish 2021-10-18 3:42 [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish Oak Zeng 2021-10-18 2:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-10-18 3:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork @ 2021-10-18 7:49 ` Tvrtko Ursulin 2021-10-18 7:54 ` Matthew Auld 3 siblings, 0 replies; 5+ messages in thread From: Tvrtko Ursulin @ 2021-10-18 7:49 UTC (permalink / raw) To: Oak Zeng, intel-gfx Cc: srinivasan.s, sudeep.dutt, cq.tang, chris, matthew.auld On 18/10/2021 04:42, Oak Zeng wrote: > Caller of function igt_gpu_fill_dw assumes when this function > returns, the gpu command to fill dword is already finished. > Caller usually checks the GPU filling result immediately, see > the usage in function __igt_write_huge. If there is no wait, > when function igt_gpu_fill_dw returns, the GPU command is not > guaranteed to be finished. So wait for request to finish. There is more than one caller and the first one I looked at already does wait so the above is not fully accurate. I your example of __igt_write_huge you have i915_gem_object_prepare_read called before the assert which does object wait, so that too is not a missing wait. I haven't checked the rest. So perhaps say what failure you are trying to fix with a link to a CI report or something? > > Signed-off-by: Oak Zeng <oak.zeng@intel.com> > --- > drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c > index b35c1219c852..5fa595ed30b1 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c > +++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c > @@ -157,6 +157,7 @@ int igt_gpu_fill_dw(struct intel_context *ce, > if (err) > i915_request_set_error_once(rq, err); > i915_request_add(rq); > + err = i915_request_wait(rq, 0, HZ/5); For you reference this exploded in CI because as soon as i915_request_add() you are giving your rq reference to the backend and i915_request_wait can/will therefore ooops. If you used this pattern somewhere you'd need to do: i915_request_get() i915_request_add() i915_request_wait() i915_request_put() Regards, Tvrtko > err_batch: > i915_vma_unpin_and_release(&batch, 0); > return err; > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish 2021-10-18 3:42 [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish Oak Zeng ` (2 preceding siblings ...) 2021-10-18 7:49 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin @ 2021-10-18 7:54 ` Matthew Auld 3 siblings, 0 replies; 5+ messages in thread From: Matthew Auld @ 2021-10-18 7:54 UTC (permalink / raw) To: Oak Zeng, intel-gfx; +Cc: srinivasan.s, sudeep.dutt, cq.tang, chris On 18/10/2021 04:42, Oak Zeng wrote: > Caller of function igt_gpu_fill_dw assumes when this function > returns, the gpu command to fill dword is already finished. > Caller usually checks the GPU filling result immediately, see > the usage in function __igt_write_huge. If there is no wait, > when function igt_gpu_fill_dw returns, the GPU command is not > guaranteed to be finished. So wait for request to finish. AFAIK the existing callers only expect that the request will be scheduled to run at some point, like in the case of __igt_write_huge(), before we read the page contents via the CPU, there is an object_wait(). Also in the shrink_thp test I guess we intentionally don't want to wait directly in the test, since part of what we are testing is that the shrinker ensures the object is idle before unbinding it. > > Signed-off-by: Oak Zeng <oak.zeng@intel.com> > --- > drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c > index b35c1219c852..5fa595ed30b1 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c > +++ b/drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c > @@ -157,6 +157,7 @@ int igt_gpu_fill_dw(struct intel_context *ce, > if (err) > i915_request_set_error_once(rq, err); > i915_request_add(rq); > + err = i915_request_wait(rq, 0, HZ/5); > err_batch: > i915_vma_unpin_and_release(&batch, 0); > return err; > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-18 7:54 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-18 3:42 [Intel-gfx] [PATCH] drm/i915/selftests: Wait request to finish Oak Zeng 2021-10-18 2:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-10-18 3:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2021-10-18 7:49 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2021-10-18 7:54 ` Matthew Auld
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.