* [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
The tsadc node in rk356x.dtsi has more resets defined then currently
allowed by rockchip-thermal.yaml, so fix that in the documentation.
The driver now uses the devm_reset_control_array_get() function,
so reset-names is no longer required, but keep it for legacy reasons.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Changed V2:
Remove deprecated
---
.../devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index b96ea277b..3c074706e 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -37,11 +37,15 @@ properties:
- const: apb_pclk
resets:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
reset-names:
+ minItems: 1
items:
- const: tsadc-apb
+ - const: tsadc
+ - const: tsadc-phy
"#thermal-sensor-cells":
const: 1
@@ -71,7 +75,6 @@ required:
- clocks
- clock-names
- resets
- - reset-names
- "#thermal-sensor-cells"
additionalProperties: false
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
The tsadc node in rk356x.dtsi has more resets defined then currently
allowed by rockchip-thermal.yaml, so fix that in the documentation.
The driver now uses the devm_reset_control_array_get() function,
so reset-names is no longer required, but keep it for legacy reasons.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Changed V2:
Remove deprecated
---
.../devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index b96ea277b..3c074706e 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -37,11 +37,15 @@ properties:
- const: apb_pclk
resets:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
reset-names:
+ minItems: 1
items:
- const: tsadc-apb
+ - const: tsadc
+ - const: tsadc-phy
"#thermal-sensor-cells":
const: 1
@@ -71,7 +75,6 @@ required:
- clocks
- clock-names
- resets
- - reset-names
- "#thermal-sensor-cells"
additionalProperties: false
--
2.20.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
The tsadc node in rk356x.dtsi has more resets defined then currently
allowed by rockchip-thermal.yaml, so fix that in the documentation.
The driver now uses the devm_reset_control_array_get() function,
so reset-names is no longer required, but keep it for legacy reasons.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Changed V2:
Remove deprecated
---
.../devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index b96ea277b..3c074706e 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -37,11 +37,15 @@ properties:
- const: apb_pclk
resets:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
reset-names:
+ minItems: 1
items:
- const: tsadc-apb
+ - const: tsadc
+ - const: tsadc-phy
"#thermal-sensor-cells":
const: 1
@@ -71,7 +75,6 @@ required:
- clocks
- clock-names
- resets
- - reset-names
- "#thermal-sensor-cells"
additionalProperties: false
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/4] dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml
2021-09-30 11:05 ` Johan Jonker
(?)
@ 2021-09-30 11:05 ` Johan Jonker
-1 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Remove redundent comments from rockchip-thermal.yaml
Sort compatibles in alphabetical order.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../bindings/thermal/rockchip-thermal.yaml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index 3c074706e..f6c1be226 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -12,14 +12,14 @@ maintainers:
properties:
compatible:
enum:
- - rockchip,px30-tsadc # PX30 SoCs
- - rockchip,rv1108-tsadc # RV1108 SoCs
- - rockchip,rk3228-tsadc # RK3228 SoCs
- - rockchip,rk3288-tsadc # RK3288 SoCs
- - rockchip,rk3328-tsadc # RK3328 SoCs
- - rockchip,rk3368-tsadc # RK3368 SoCs
- - rockchip,rk3399-tsadc # RK3399 SoCs
- - rockchip,rk3568-tsadc # RK3568 SoCs
+ - rockchip,px30-tsadc
+ - rockchip,rk3228-tsadc
+ - rockchip,rk3288-tsadc
+ - rockchip,rk3328-tsadc
+ - rockchip,rk3368-tsadc
+ - rockchip,rk3399-tsadc
+ - rockchip,rk3568-tsadc
+ - rockchip,rv1108-tsadc
reg:
maxItems: 1
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/4] dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Remove redundent comments from rockchip-thermal.yaml
Sort compatibles in alphabetical order.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../bindings/thermal/rockchip-thermal.yaml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index 3c074706e..f6c1be226 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -12,14 +12,14 @@ maintainers:
properties:
compatible:
enum:
- - rockchip,px30-tsadc # PX30 SoCs
- - rockchip,rv1108-tsadc # RV1108 SoCs
- - rockchip,rk3228-tsadc # RK3228 SoCs
- - rockchip,rk3288-tsadc # RK3288 SoCs
- - rockchip,rk3328-tsadc # RK3328 SoCs
- - rockchip,rk3368-tsadc # RK3368 SoCs
- - rockchip,rk3399-tsadc # RK3399 SoCs
- - rockchip,rk3568-tsadc # RK3568 SoCs
+ - rockchip,px30-tsadc
+ - rockchip,rk3228-tsadc
+ - rockchip,rk3288-tsadc
+ - rockchip,rk3328-tsadc
+ - rockchip,rk3368-tsadc
+ - rockchip,rk3399-tsadc
+ - rockchip,rk3568-tsadc
+ - rockchip,rv1108-tsadc
reg:
maxItems: 1
--
2.20.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/4] dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Remove redundent comments from rockchip-thermal.yaml
Sort compatibles in alphabetical order.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../bindings/thermal/rockchip-thermal.yaml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index 3c074706e..f6c1be226 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -12,14 +12,14 @@ maintainers:
properties:
compatible:
enum:
- - rockchip,px30-tsadc # PX30 SoCs
- - rockchip,rv1108-tsadc # RV1108 SoCs
- - rockchip,rk3228-tsadc # RK3228 SoCs
- - rockchip,rk3288-tsadc # RK3288 SoCs
- - rockchip,rk3328-tsadc # RK3328 SoCs
- - rockchip,rk3368-tsadc # RK3368 SoCs
- - rockchip,rk3399-tsadc # RK3399 SoCs
- - rockchip,rk3568-tsadc # RK3568 SoCs
+ - rockchip,px30-tsadc
+ - rockchip,rk3228-tsadc
+ - rockchip,rk3288-tsadc
+ - rockchip,rk3328-tsadc
+ - rockchip,rk3368-tsadc
+ - rockchip,rk3399-tsadc
+ - rockchip,rk3568-tsadc
+ - rockchip,rv1108-tsadc
reg:
maxItems: 1
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 3/4] thermal: rockchip_thermal: allow more resets for tsadc node
2021-09-30 11:05 ` Johan Jonker
(?)
@ 2021-09-30 11:05 ` Johan Jonker
-1 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
The tsadc node in rk356x.dtsi has more resets then currently
supported by the rockchip_thermal.c driver, so use
devm_reset_control_array_get() to reset them all.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
drivers/thermal/rockchip_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 657d84b99..dc3a9c276 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1383,7 +1383,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
if (IS_ERR(thermal->regs))
return PTR_ERR(thermal->regs);
- thermal->reset = devm_reset_control_get(&pdev->dev, "tsadc-apb");
+ thermal->reset = devm_reset_control_array_get(&pdev->dev, false, false);
if (IS_ERR(thermal->reset)) {
error = PTR_ERR(thermal->reset);
dev_err(&pdev->dev, "failed to get tsadc reset: %d\n", error);
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 3/4] thermal: rockchip_thermal: allow more resets for tsadc node
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
The tsadc node in rk356x.dtsi has more resets then currently
supported by the rockchip_thermal.c driver, so use
devm_reset_control_array_get() to reset them all.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
drivers/thermal/rockchip_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 657d84b99..dc3a9c276 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1383,7 +1383,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
if (IS_ERR(thermal->regs))
return PTR_ERR(thermal->regs);
- thermal->reset = devm_reset_control_get(&pdev->dev, "tsadc-apb");
+ thermal->reset = devm_reset_control_array_get(&pdev->dev, false, false);
if (IS_ERR(thermal->reset)) {
error = PTR_ERR(thermal->reset);
dev_err(&pdev->dev, "failed to get tsadc reset: %d\n", error);
--
2.20.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 3/4] thermal: rockchip_thermal: allow more resets for tsadc node
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
The tsadc node in rk356x.dtsi has more resets then currently
supported by the rockchip_thermal.c driver, so use
devm_reset_control_array_get() to reset them all.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
drivers/thermal/rockchip_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 657d84b99..dc3a9c276 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1383,7 +1383,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
if (IS_ERR(thermal->regs))
return PTR_ERR(thermal->regs);
- thermal->reset = devm_reset_control_get(&pdev->dev, "tsadc-apb");
+ thermal->reset = devm_reset_control_array_get(&pdev->dev, false, false);
if (IS_ERR(thermal->reset)) {
error = PTR_ERR(thermal->reset);
dev_err(&pdev->dev, "failed to get tsadc reset: %d\n", error);
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi
2021-09-30 11:05 ` Johan Jonker
(?)
@ 2021-09-30 11:05 ` Johan Jonker
-1 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
In the rockchip_thermal.c driver we now get the resets with
a devm_reset_control_array_get() function, so remove
the reset-names property as it is no longer needed.
Although no longer required in rockchip-thermal.yaml
sort tsadc-apb as first item.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index e42fbac61..d013348bc 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -838,9 +838,8 @@
assigned-clock-rates = <17000000>, <700000>;
clocks = <&cru CLK_TSADC>, <&cru PCLK_TSADC>;
clock-names = "tsadc", "apb_pclk";
- resets = <&cru SRST_TSADC>, <&cru SRST_P_TSADC>,
+ resets = <&cru SRST_P_TSADC>, <&cru SRST_TSADC>,
<&cru SRST_TSADCPHY>;
- reset-names = "tsadc", "tsadc-apb", "tsadc-phy";
rockchip,grf = <&grf>;
rockchip,hw-tshut-temp = <95000>;
pinctrl-names = "init", "default", "sleep";
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
In the rockchip_thermal.c driver we now get the resets with
a devm_reset_control_array_get() function, so remove
the reset-names property as it is no longer needed.
Although no longer required in rockchip-thermal.yaml
sort tsadc-apb as first item.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index e42fbac61..d013348bc 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -838,9 +838,8 @@
assigned-clock-rates = <17000000>, <700000>;
clocks = <&cru CLK_TSADC>, <&cru PCLK_TSADC>;
clock-names = "tsadc", "apb_pclk";
- resets = <&cru SRST_TSADC>, <&cru SRST_P_TSADC>,
+ resets = <&cru SRST_P_TSADC>, <&cru SRST_TSADC>,
<&cru SRST_TSADCPHY>;
- reset-names = "tsadc", "tsadc-apb", "tsadc-phy";
rockchip,grf = <&grf>;
rockchip,hw-tshut-temp = <95000>;
pinctrl-names = "init", "default", "sleep";
--
2.20.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi
@ 2021-09-30 11:05 ` Johan Jonker
0 siblings, 0 replies; 21+ messages in thread
From: Johan Jonker @ 2021-09-30 11:05 UTC (permalink / raw)
To: heiko
Cc: robh+dt, rui.zhang, daniel.lezcano, amitk, p.zabel, linux-pm,
linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
In the rockchip_thermal.c driver we now get the resets with
a devm_reset_control_array_get() function, so remove
the reset-names property as it is no longer needed.
Although no longer required in rockchip-thermal.yaml
sort tsadc-apb as first item.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index e42fbac61..d013348bc 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -838,9 +838,8 @@
assigned-clock-rates = <17000000>, <700000>;
clocks = <&cru CLK_TSADC>, <&cru PCLK_TSADC>;
clock-names = "tsadc", "apb_pclk";
- resets = <&cru SRST_TSADC>, <&cru SRST_P_TSADC>,
+ resets = <&cru SRST_P_TSADC>, <&cru SRST_TSADC>,
<&cru SRST_TSADCPHY>;
- reset-names = "tsadc", "tsadc-apb", "tsadc-phy";
rockchip,grf = <&grf>;
rockchip,hw-tshut-temp = <95000>;
pinctrl-names = "init", "default", "sleep";
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
2021-09-30 11:05 ` Johan Jonker
(?)
@ 2021-10-06 21:13 ` Rob Herring
-1 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2021-10-06 21:13 UTC (permalink / raw)
To: Johan Jonker
Cc: daniel.lezcano, devicetree, p.zabel, amitk, robh+dt,
linux-arm-kernel, linux-kernel, rui.zhang, heiko, linux-pm,
linux-rockchip
On Thu, 30 Sep 2021 13:05:14 +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>
> Changed V2:
> Remove deprecated
> ---
> .../devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-10-06 21:13 ` Rob Herring
0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2021-10-06 21:13 UTC (permalink / raw)
To: Johan Jonker
Cc: daniel.lezcano, devicetree, p.zabel, amitk, robh+dt,
linux-arm-kernel, linux-kernel, rui.zhang, heiko, linux-pm,
linux-rockchip
On Thu, 30 Sep 2021 13:05:14 +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>
> Changed V2:
> Remove deprecated
> ---
> .../devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-10-06 21:13 ` Rob Herring
0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2021-10-06 21:13 UTC (permalink / raw)
To: Johan Jonker
Cc: daniel.lezcano, devicetree, p.zabel, amitk, robh+dt,
linux-arm-kernel, linux-kernel, rui.zhang, heiko, linux-pm,
linux-rockchip
On Thu, 30 Sep 2021 13:05:14 +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>
> Changed V2:
> Remove deprecated
> ---
> .../devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [thermal: thermal/next] thermal/drivers/rockchip_thermal: Allow more resets for tsadc node
2021-09-30 11:05 ` Johan Jonker
(?)
(?)
@ 2021-10-18 11:45 ` thermal-bot for Johan Jonker
-1 siblings, 0 replies; 21+ messages in thread
From: thermal-bot for Johan Jonker @ 2021-10-18 11:45 UTC (permalink / raw)
To: linux-pm; +Cc: Johan Jonker, Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 02832ed8ae2c8b130efea4e43d3ecac50b4b7933
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//02832ed8ae2c8b130efea4e43d3ecac50b4b7933
Author: Johan Jonker <jbx6244@gmail.com>
AuthorDate: Thu, 30 Sep 2021 13:05:16 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Sun, 17 Oct 2021 00:15:09 +02:00
thermal/drivers/rockchip_thermal: Allow more resets for tsadc node
The tsadc node in rk356x.dtsi has more resets then currently supported
by the rockchip_thermal.c driver, so use
devm_reset_control_array_get() to reset them all.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://lore.kernel.org/r/20210930110517.14323-3-jbx6244@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/rockchip_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 657d84b..dc3a9c2 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1383,7 +1383,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
if (IS_ERR(thermal->regs))
return PTR_ERR(thermal->regs);
- thermal->reset = devm_reset_control_get(&pdev->dev, "tsadc-apb");
+ thermal->reset = devm_reset_control_array_get(&pdev->dev, false, false);
if (IS_ERR(thermal->reset)) {
error = PTR_ERR(thermal->reset);
dev_err(&pdev->dev, "failed to get tsadc reset: %d\n", error);
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [thermal: thermal/next] dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml
2021-09-30 11:05 ` Johan Jonker
(?)
(?)
@ 2021-10-18 11:45 ` thermal-bot for Johan Jonker
-1 siblings, 0 replies; 21+ messages in thread
From: thermal-bot for Johan Jonker @ 2021-10-18 11:45 UTC (permalink / raw)
To: linux-pm; +Cc: Johan Jonker, Rob Herring, Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 5f553ac2325456f484806df5aa695392364d39f5
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//5f553ac2325456f484806df5aa695392364d39f5
Author: Johan Jonker <jbx6244@gmail.com>
AuthorDate: Thu, 30 Sep 2021 13:05:15 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Sun, 17 Oct 2021 00:14:55 +02:00
dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml
Remove redundent comments from rockchip-thermal.yaml
Sort compatibles in alphabetical order.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210930110517.14323-2-jbx6244@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index 3c07470..f6c1be2 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -12,14 +12,14 @@ maintainers:
properties:
compatible:
enum:
- - rockchip,px30-tsadc # PX30 SoCs
- - rockchip,rv1108-tsadc # RV1108 SoCs
- - rockchip,rk3228-tsadc # RK3228 SoCs
- - rockchip,rk3288-tsadc # RK3288 SoCs
- - rockchip,rk3328-tsadc # RK3328 SoCs
- - rockchip,rk3368-tsadc # RK3368 SoCs
- - rockchip,rk3399-tsadc # RK3399 SoCs
- - rockchip,rk3568-tsadc # RK3568 SoCs
+ - rockchip,px30-tsadc
+ - rockchip,rk3228-tsadc
+ - rockchip,rk3288-tsadc
+ - rockchip,rk3328-tsadc
+ - rockchip,rk3368-tsadc
+ - rockchip,rk3399-tsadc
+ - rockchip,rk3568-tsadc
+ - rockchip,rv1108-tsadc
reg:
maxItems: 1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [thermal: thermal/next] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
2021-09-30 11:05 ` Johan Jonker
` (5 preceding siblings ...)
(?)
@ 2021-10-18 11:45 ` thermal-bot for Johan Jonker
-1 siblings, 0 replies; 21+ messages in thread
From: thermal-bot for Johan Jonker @ 2021-10-18 11:45 UTC (permalink / raw)
To: linux-pm; +Cc: Johan Jonker, Rob Herring, Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 07c54d9a409f1fd54df328ec742f156547594347
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//07c54d9a409f1fd54df328ec742f156547594347
Author: Johan Jonker <jbx6244@gmail.com>
AuthorDate: Thu, 30 Sep 2021 13:05:14 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Sun, 17 Oct 2021 00:14:55 +02:00
dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
The tsadc node in rk356x.dtsi has more resets defined then currently
allowed by rockchip-thermal.yaml, so fix that in the documentation.
The driver now uses the devm_reset_control_array_get() function,
so reset-names is no longer required, but keep it for legacy reasons.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210930110517.14323-1-jbx6244@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
index b96ea27..3c07470 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
@@ -37,11 +37,15 @@ properties:
- const: apb_pclk
resets:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
reset-names:
+ minItems: 1
items:
- const: tsadc-apb
+ - const: tsadc
+ - const: tsadc-phy
"#thermal-sensor-cells":
const: 1
@@ -71,7 +75,6 @@ required:
- clocks
- clock-names
- resets
- - reset-names
- "#thermal-sensor-cells"
additionalProperties: false
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: (subset) [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
2021-09-30 11:05 ` Johan Jonker
(?)
@ 2021-10-18 18:20 ` Heiko Stuebner
-1 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2021-10-18 18:20 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, p.zabel, amitk,
linux-kernel, robh+dt, rui.zhang, linux-rockchip, daniel.lezcano,
linux-pm
On Thu, 30 Sep 2021 13:05:14 +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.
Applied, thanks!
Fixed the patch subject to the regular prefixes.
[4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi
commit: 5c9e66c6b75a754025c74bde7b7a6c52674d8aa1
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: (subset) [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-10-18 18:20 ` Heiko Stuebner
0 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2021-10-18 18:20 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, p.zabel, amitk,
linux-kernel, robh+dt, rui.zhang, linux-rockchip, daniel.lezcano,
linux-pm
On Thu, 30 Sep 2021 13:05:14 +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.
Applied, thanks!
Fixed the patch subject to the regular prefixes.
[4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi
commit: 5c9e66c6b75a754025c74bde7b7a6c52674d8aa1
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: (subset) [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml
@ 2021-10-18 18:20 ` Heiko Stuebner
0 siblings, 0 replies; 21+ messages in thread
From: Heiko Stuebner @ 2021-10-18 18:20 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, p.zabel, amitk,
linux-kernel, robh+dt, rui.zhang, linux-rockchip, daniel.lezcano,
linux-pm
On Thu, 30 Sep 2021 13:05:14 +0200, Johan Jonker wrote:
> The tsadc node in rk356x.dtsi has more resets defined then currently
> allowed by rockchip-thermal.yaml, so fix that in the documentation.
> The driver now uses the devm_reset_control_array_get() function,
> so reset-names is no longer required, but keep it for legacy reasons.
Applied, thanks!
Fixed the patch subject to the regular prefixes.
[4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi
commit: 5c9e66c6b75a754025c74bde7b7a6c52674d8aa1
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2021-10-18 18:22 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 11:05 [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-09-30 11:05 ` [PATCH v2 2/4] dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-10-18 11:45 ` [thermal: thermal/next] " thermal-bot for Johan Jonker
2021-09-30 11:05 ` [PATCH v2 3/4] thermal: rockchip_thermal: allow more resets for tsadc node Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-10-18 11:45 ` [thermal: thermal/next] thermal/drivers/rockchip_thermal: Allow " thermal-bot for Johan Jonker
2021-09-30 11:05 ` [PATCH v2 4/4] arm64: dts: fix resets in tsadc node for rk356x.dtsi Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-09-30 11:05 ` Johan Jonker
2021-10-06 21:13 ` [PATCH v2 1/4] dt-bindings: thermal: allow more resets for tsadc node in rockchip-thermal.yaml Rob Herring
2021-10-06 21:13 ` Rob Herring
2021-10-06 21:13 ` Rob Herring
2021-10-18 11:45 ` [thermal: thermal/next] " thermal-bot for Johan Jonker
2021-10-18 18:20 ` (subset) [PATCH v2 1/4] " Heiko Stuebner
2021-10-18 18:20 ` Heiko Stuebner
2021-10-18 18:20 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.