All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] rtw89: remove unneeded semicolon
@ 2021-10-19  7:54 Yang Li
  2021-10-19  9:13 ` Pkshih
  2021-10-20  8:51 ` Kalle Valo
  0 siblings, 2 replies; 6+ messages in thread
From: Yang Li @ 2021-10-19  7:54 UTC (permalink / raw)
  To: davem; +Cc: kuba, pkshih, kvalo, linux-wireless, netdev, linux-kernel, Yang Li

Eliminate the following coccicheck warning:
./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index e973101..2c94762 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -1345,7 +1345,7 @@ static int rtw89_pci_check_mdio(struct rtw89_dev *rtwdev, u8 addr, u8 speed, u16
 	default:
 		rtw89_err(rtwdev, "[ERR]Error Speed %d!\n", speed);
 		return -EINVAL;
-	};
+	}
 	rtw89_write16(rtwdev, R_AX_MDIO_CFG, val);
 	rtw89_write16_set(rtwdev, R_AX_MDIO_CFG, rw_bit);
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH -next] rtw89: remove unneeded semicolon
  2021-10-19  7:54 [PATCH -next] rtw89: remove unneeded semicolon Yang Li
@ 2021-10-19  9:13 ` Pkshih
  2021-10-20  8:51 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Pkshih @ 2021-10-19  9:13 UTC (permalink / raw)
  To: Yang Li, davem; +Cc: kuba, kvalo, linux-wireless, netdev, linux-kernel


> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
> Sent: Tuesday, October 19, 2021 3:55 PM
> To: davem@davemloft.net
> Cc: kuba@kernel.org; Pkshih <pkshih@realtek.com>; kvalo@codeaurora.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yang Li <yang.lee@linux.alibaba.com>
> Subject: [PATCH -next] rtw89: remove unneeded semicolon
> 
> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
> index e973101..2c94762 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.c
> +++ b/drivers/net/wireless/realtek/rtw89/pci.c
> @@ -1345,7 +1345,7 @@ static int rtw89_pci_check_mdio(struct rtw89_dev *rtwdev, u8 addr, u8 speed, u16
>  	default:
>  		rtw89_err(rtwdev, "[ERR]Error Speed %d!\n", speed);
>  		return -EINVAL;
> -	};
> +	}
>  	rtw89_write16(rtwdev, R_AX_MDIO_CFG, val);
>  	rtw89_write16_set(rtwdev, R_AX_MDIO_CFG, rw_bit);
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] rtw89: remove unneeded semicolon
  2021-10-19  7:54 [PATCH -next] rtw89: remove unneeded semicolon Yang Li
  2021-10-19  9:13 ` Pkshih
@ 2021-10-20  8:51 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2021-10-20  8:51 UTC (permalink / raw)
  To: Yang Li
  Cc: davem, kuba, pkshih, linux-wireless, netdev, linux-kernel, Yang Li

Yang Li <yang.lee@linux.alibaba.com> wrote:

> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

e0e037b9fe5f rtw89: remove unneeded semicolon

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1634630094-1156-1-git-send-email-yang.lee@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] rtw89: remove unneeded semicolon
  2022-04-27  0:31 Yang Li
  2022-04-27  1:29 ` Pkshih
@ 2022-04-29  5:56 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-04-29  5:56 UTC (permalink / raw)
  To: Yang Li
  Cc: davem, kuba, pabeni, pkshih, linux-wireless, netdev,
	linux-kernel, Yang Li, Abaci Robot

Yang Li <yang.lee@linux.alibaba.com> wrote:

> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/rtw8852c.c:2556:2-3: Unneeded
> semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

11dc130b4ee0 rtw89: remove unneeded semicolon

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220427003142.107916-1-yang.lee@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH -next] rtw89: remove unneeded semicolon
  2022-04-27  0:31 Yang Li
@ 2022-04-27  1:29 ` Pkshih
  2022-04-29  5:56 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Pkshih @ 2022-04-27  1:29 UTC (permalink / raw)
  To: Yang Li, davem
  Cc: kuba, pabeni, kvalo, linux-wireless, netdev, linux-kernel, Abaci Robot



> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
> Sent: Wednesday, April 27, 2022 8:32 AM
> To: davem@davemloft.net
> Cc: kuba@kernel.org; pabeni@redhat.com; kvalo@kernel.org; Pkshih <pkshih@realtek.com>;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yang Li
> <yang.lee@linux.alibaba.com>; Abaci Robot <abaci@linux.alibaba.com>
> Subject: [PATCH -next] rtw89: remove unneeded semicolon
> 
> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/rtw8852c.c:2556:2-3: Unneeded
> semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/rtw8852c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> index 858611c64e6b..275568468212 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> @@ -2553,7 +2553,7 @@ do {								\
>  	default:
>  		val = arg.gnt_bt.data;
>  		break;
> -	};
> +	}
> 
>  	__write_ctrl(R_AX_PWR_COEXT_CTRL, B_AX_TXAGC_BT_MASK, val,
>  		     B_AX_TXAGC_BT_EN, arg.ctrl_gnt_bt != 0xffff);
> --
> 2.20.1.7.g153144c


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH -next] rtw89: remove unneeded semicolon
@ 2022-04-27  0:31 Yang Li
  2022-04-27  1:29 ` Pkshih
  2022-04-29  5:56 ` Kalle Valo
  0 siblings, 2 replies; 6+ messages in thread
From: Yang Li @ 2022-04-27  0:31 UTC (permalink / raw)
  To: davem
  Cc: kuba, pabeni, kvalo, pkshih, linux-wireless, netdev,
	linux-kernel, Yang Li, Abaci Robot

Eliminate the following coccicheck warning:
./drivers/net/wireless/realtek/rtw89/rtw8852c.c:2556:2-3: Unneeded
semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/wireless/realtek/rtw89/rtw8852c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
index 858611c64e6b..275568468212 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
@@ -2553,7 +2553,7 @@ do {								\
 	default:
 		val = arg.gnt_bt.data;
 		break;
-	};
+	}
 
 	__write_ctrl(R_AX_PWR_COEXT_CTRL, B_AX_TXAGC_BT_MASK, val,
 		     B_AX_TXAGC_BT_EN, arg.ctrl_gnt_bt != 0xffff);
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-29  5:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19  7:54 [PATCH -next] rtw89: remove unneeded semicolon Yang Li
2021-10-19  9:13 ` Pkshih
2021-10-20  8:51 ` Kalle Valo
2022-04-27  0:31 Yang Li
2022-04-27  1:29 ` Pkshih
2022-04-29  5:56 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.