All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: airlied@linux.ie, daniel@ffwll.ch, hjc@rock-chips.com,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Implement mmap as GEM object function
Date: Thu, 21 Oct 2021 15:32:35 +0200	[thread overview]
Message-ID: <163482299856.848182.3787182193550815425.b4-ty@sntech.de> (raw)
In-Reply-To: <20210624095502.8945-1-tzimmermann@suse.de>

On Thu, 24 Jun 2021 11:55:02 +0200, Thomas Zimmermann wrote:
> Moving the driver-specific mmap code into a GEM object function allows
> for using DRM helpers for various mmap callbacks.
> 
> The respective rockchip functions are being removed. The file_operations
> structure fops is now being created by the helper macro
> DEFINE_DRM_GEM_FOPS().

Applied, thanks!

Looks good on a general glance, but of course I don't have a firm
grasp on all drm internals, so hopefully all these tests we
have will suffice :-) .

[1/1] drm/rockchip: Implement mmap as GEM object function
      commit: f8b5307074f8be80a9806d85b01e5ba933dd0360

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: airlied@linux.ie, daniel@ffwll.ch, hjc@rock-chips.com,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Implement mmap as GEM object function
Date: Thu, 21 Oct 2021 15:32:35 +0200	[thread overview]
Message-ID: <163482299856.848182.3787182193550815425.b4-ty@sntech.de> (raw)
In-Reply-To: <20210624095502.8945-1-tzimmermann@suse.de>

On Thu, 24 Jun 2021 11:55:02 +0200, Thomas Zimmermann wrote:
> Moving the driver-specific mmap code into a GEM object function allows
> for using DRM helpers for various mmap callbacks.
> 
> The respective rockchip functions are being removed. The file_operations
> structure fops is now being created by the helper macro
> DEFINE_DRM_GEM_FOPS().

Applied, thanks!

Looks good on a general glance, but of course I don't have a firm
grasp on all drm internals, so hopefully all these tests we
have will suffice :-) .

[1/1] drm/rockchip: Implement mmap as GEM object function
      commit: f8b5307074f8be80a9806d85b01e5ba933dd0360

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: airlied@linux.ie, daniel@ffwll.ch, hjc@rock-chips.com,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Implement mmap as GEM object function
Date: Thu, 21 Oct 2021 15:32:35 +0200	[thread overview]
Message-ID: <163482299856.848182.3787182193550815425.b4-ty@sntech.de> (raw)
In-Reply-To: <20210624095502.8945-1-tzimmermann@suse.de>

On Thu, 24 Jun 2021 11:55:02 +0200, Thomas Zimmermann wrote:
> Moving the driver-specific mmap code into a GEM object function allows
> for using DRM helpers for various mmap callbacks.
> 
> The respective rockchip functions are being removed. The file_operations
> structure fops is now being created by the helper macro
> DEFINE_DRM_GEM_FOPS().

Applied, thanks!

Looks good on a general glance, but of course I don't have a firm
grasp on all drm internals, so hopefully all these tests we
have will suffice :-) .

[1/1] drm/rockchip: Implement mmap as GEM object function
      commit: f8b5307074f8be80a9806d85b01e5ba933dd0360

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-21 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  9:55 [PATCH] drm/rockchip: Implement mmap as GEM object function Thomas Zimmermann
2021-06-24  9:55 ` Thomas Zimmermann
2021-06-24  9:55 ` Thomas Zimmermann
2021-07-08 12:01 ` Thomas Zimmermann
2021-07-08 12:01   ` Thomas Zimmermann
2021-07-08 12:01   ` Thomas Zimmermann
2021-07-17 23:29 ` Heiko Stübner
2021-07-17 23:29   ` Heiko Stübner
2021-07-17 23:29   ` Heiko Stübner
2021-10-19 14:02 ` Alex Bee
2021-10-19 14:02   ` Alex Bee
2021-10-19 14:02   ` Alex Bee
2021-10-20 14:06   ` Thomas Zimmermann
2021-10-20 14:06     ` Thomas Zimmermann
2021-10-20 14:06     ` Thomas Zimmermann
2021-10-21 13:32 ` Heiko Stuebner [this message]
2021-10-21 13:32   ` [PATCH] " Heiko Stuebner
2021-10-21 13:32   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163482299856.848182.3787182193550815425.b4-ty@sntech.de \
    --to=heiko@sntech.de \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.