* [PATCH net-next] mpt fusion: use dev_addr_set()
@ 2021-10-26 17:55 Jakub Kicinski
2021-10-28 3:14 ` Martin K. Petersen
2021-10-28 12:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-10-26 17:55 UTC (permalink / raw)
To: davem
Cc: netdev, sathya.prakash, sreekanth.reddy,
suganath-prabu.subramani, MPT-FusionLinux.pdl, linux-scsi,
Jakub Kicinski
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it go through appropriate helpers.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/message/fusion/mptlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptlan.c b/drivers/message/fusion/mptlan.c
index 3261cac762de..acdc257a900e 100644
--- a/drivers/message/fusion/mptlan.c
+++ b/drivers/message/fusion/mptlan.c
@@ -1350,7 +1350,7 @@ mpt_register_lan_device (MPT_ADAPTER *mpt_dev, int pnum)
HWaddr[5] = a[0];
dev->addr_len = FC_ALEN;
- memcpy(dev->dev_addr, HWaddr, FC_ALEN);
+ dev_addr_set(dev, HWaddr);
memset(dev->broadcast, 0xff, FC_ALEN);
/* The Tx queue is 127 deep on the 909.
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mpt fusion: use dev_addr_set()
2021-10-26 17:55 [PATCH net-next] mpt fusion: use dev_addr_set() Jakub Kicinski
@ 2021-10-28 3:14 ` Martin K. Petersen
2021-10-28 12:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-10-28 3:14 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, sathya.prakash, sreekanth.reddy,
suganath-prabu.subramani, MPT-FusionLinux.pdl, linux-scsi
Jakub,
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it go through appropriate helpers.
No objections from me although I sincerely doubt anybody is using
mptlan.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mpt fusion: use dev_addr_set()
2021-10-26 17:55 [PATCH net-next] mpt fusion: use dev_addr_set() Jakub Kicinski
2021-10-28 3:14 ` Martin K. Petersen
@ 2021-10-28 12:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-28 12:20 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, sathya.prakash, sreekanth.reddy,
suganath-prabu.subramani, MPT-FusionLinux.pdl, linux-scsi
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 26 Oct 2021 10:55:00 -0700 you wrote:
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it go through appropriate helpers.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] mpt fusion: use dev_addr_set()
https://git.kernel.org/netdev/net-next/c/e0b4f1cd36bf
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-28 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 17:55 [PATCH net-next] mpt fusion: use dev_addr_set() Jakub Kicinski
2021-10-28 3:14 ` Martin K. Petersen
2021-10-28 12:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.