* [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once
@ 2021-10-28 20:34 José Roberto de Souza
2021-10-28 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: José Roberto de Souza @ 2021-10-28 20:34 UTC (permalink / raw)
To: intel-gfx
Cc: Karthik B S, Vandita Kulkarni, Ville Syrjälä,
José Roberto de Souza
For every crtc in state, intel_atomic_check_async() was checking all
the crtc and plane states again.
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 38 ++++++++++----------
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 79cd158503b37..3b5a8e971343f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7707,35 +7707,37 @@ static void kill_bigjoiner_slave(struct intel_atomic_state *state,
* correspond to the last vblank and have no relation to the actual time when
* the flip done event was sent.
*/
-static int intel_atomic_check_async(struct intel_atomic_state *state)
+static int intel_atomic_check_async(struct intel_atomic_state *state, struct intel_crtc *crtc)
{
struct drm_i915_private *i915 = to_i915(state->base.dev);
const struct intel_crtc_state *old_crtc_state, *new_crtc_state;
const struct intel_plane_state *new_plane_state, *old_plane_state;
- struct intel_crtc *crtc;
struct intel_plane *plane;
int i;
- for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
- new_crtc_state, i) {
- if (intel_crtc_needs_modeset(new_crtc_state)) {
- drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
- return -EINVAL;
- }
+ old_crtc_state = intel_atomic_get_old_crtc_state(state, crtc);
+ new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
- if (!new_crtc_state->hw.active) {
- drm_dbg_kms(&i915->drm, "CRTC inactive\n");
- return -EINVAL;
- }
- if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
- drm_dbg_kms(&i915->drm,
- "Active planes cannot be changed during async flip\n");
- return -EINVAL;
- }
+ if (intel_crtc_needs_modeset(new_crtc_state)) {
+ drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
+ return -EINVAL;
+ }
+
+ if (!new_crtc_state->hw.active) {
+ drm_dbg_kms(&i915->drm, "CRTC inactive\n");
+ return -EINVAL;
+ }
+ if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
+ drm_dbg_kms(&i915->drm,
+ "Active planes cannot be changed during async flip\n");
+ return -EINVAL;
}
for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state,
new_plane_state, i) {
+ if (plane->base.crtc != &crtc->base)
+ continue;
+
/*
* TODO: Async flip is only supported through the page flip IOCTL
* as of now. So support currently added for primary plane only.
@@ -8054,7 +8056,7 @@ static int intel_atomic_check(struct drm_device *dev,
for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
new_crtc_state, i) {
if (new_crtc_state->uapi.async_flip) {
- ret = intel_atomic_check_async(state);
+ ret = intel_atomic_check_async(state, crtc);
if (ret)
goto fail;
}
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Check async flip state of every crtc and plane once
2021-10-28 20:34 [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once José Roberto de Souza
@ 2021-10-28 22:20 ` Patchwork
2021-10-29 6:24 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2021-10-29 6:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-10-28 22:20 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
== Series Details ==
Series: drm/i915/display: Check async flip state of every crtc and plane once
URL : https://patchwork.freedesktop.org/series/96402/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10809 -> Patchwork_21480
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/index.html
Participating hosts (36 -> 34)
------------------------------
Additional (1): fi-pnv-d510
Missing (3): bat-adlp-4 bat-dg1-6 bat-dg1-5
Known issues
------------
Here are the changes found in Patchwork_21480 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][1] ([fdo#109271]) +53 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-ivb-3770: NOTRUN -> [FAIL][2] ([i915#2426] / [i915#4312])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/fi-ivb-3770/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
Build changes
-------------
* Linux: CI_DRM_10809 -> Patchwork_21480
CI-20190529: 20190529
CI_DRM_10809: 9959c5de92d04f2336d749a5a331799aa41cfb1f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6264: 3458490c14afe3cb8aa873fa9e520e1c815ea068 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21480: 0357c9b1ff59793efe41165ba24d85a65cd04ac1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
0357c9b1ff59 drm/i915/display: Check async flip state of every crtc and plane once
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/index.html
[-- Attachment #2: Type: text/html, Size: 2622 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once
2021-10-28 20:34 [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once José Roberto de Souza
2021-10-28 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-10-29 6:24 ` Ville Syrjälä
2021-10-29 17:47 ` Souza, Jose
2021-10-29 6:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2021-10-29 6:24 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx, Karthik B S, Vandita Kulkarni
On Thu, Oct 28, 2021 at 01:34:18PM -0700, José Roberto de Souza wrote:
> For every crtc in state, intel_atomic_check_async() was checking all
> the crtc and plane states again.
>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 38 ++++++++++----------
> 1 file changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 79cd158503b37..3b5a8e971343f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7707,35 +7707,37 @@ static void kill_bigjoiner_slave(struct intel_atomic_state *state,
> * correspond to the last vblank and have no relation to the actual time when
> * the flip done event was sent.
> */
> -static int intel_atomic_check_async(struct intel_atomic_state *state)
> +static int intel_atomic_check_async(struct intel_atomic_state *state, struct intel_crtc *crtc)
> {
> struct drm_i915_private *i915 = to_i915(state->base.dev);
> const struct intel_crtc_state *old_crtc_state, *new_crtc_state;
> const struct intel_plane_state *new_plane_state, *old_plane_state;
> - struct intel_crtc *crtc;
> struct intel_plane *plane;
> int i;
>
> - for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> - new_crtc_state, i) {
> - if (intel_crtc_needs_modeset(new_crtc_state)) {
> - drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
> - return -EINVAL;
> - }
> + old_crtc_state = intel_atomic_get_old_crtc_state(state, crtc);
> + new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
>
> - if (!new_crtc_state->hw.active) {
> - drm_dbg_kms(&i915->drm, "CRTC inactive\n");
> - return -EINVAL;
> - }
> - if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
> - drm_dbg_kms(&i915->drm,
> - "Active planes cannot be changed during async flip\n");
> - return -EINVAL;
> - }
> + if (intel_crtc_needs_modeset(new_crtc_state)) {
> + drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
> + return -EINVAL;
> + }
> +
> + if (!new_crtc_state->hw.active) {
> + drm_dbg_kms(&i915->drm, "CRTC inactive\n");
> + return -EINVAL;
> + }
> + if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
> + drm_dbg_kms(&i915->drm,
> + "Active planes cannot be changed during async flip\n");
> + return -EINVAL;
> }
>
> for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state,
> new_plane_state, i) {
> + if (plane->base.crtc != &crtc->base)
> + continue;
Not the pointer you want to be looking at.
> +
> /*
> * TODO: Async flip is only supported through the page flip IOCTL
> * as of now. So support currently added for primary plane only.
> @@ -8054,7 +8056,7 @@ static int intel_atomic_check(struct drm_device *dev,
> for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> new_crtc_state, i) {
> if (new_crtc_state->uapi.async_flip) {
> - ret = intel_atomic_check_async(state);
> + ret = intel_atomic_check_async(state, crtc);
> if (ret)
> goto fail;
> }
> --
> 2.33.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Check async flip state of every crtc and plane once
2021-10-28 20:34 [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once José Roberto de Souza
2021-10-28 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-29 6:24 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2021-10-29 6:26 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-10-29 6:26 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30292 bytes --]
== Series Details ==
Series: drm/i915/display: Check async flip state of every crtc and plane once
URL : https://patchwork.freedesktop.org/series/96402/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10809_full -> Patchwork_21480_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21480_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21480_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21480_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl1/igt@i915_pm_sseu@full-enable.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl2/igt@i915_pm_sseu@full-enable.html
* igt@kms_async_flips@invalid-async-flip:
- shard-tglb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb3/igt@kms_async_flips@invalid-async-flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb1/igt@kms_async_flips@invalid-async-flip.html
- shard-kbl: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-kbl7/igt@kms_async_flips@invalid-async-flip.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_async_flips@invalid-async-flip.html
- shard-iclb: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-iclb5/igt@kms_async_flips@invalid-async-flip.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb6/igt@kms_async_flips@invalid-async-flip.html
- shard-glk: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-glk3/igt@kms_async_flips@invalid-async-flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-glk3/igt@kms_async_flips@invalid-async-flip.html
- shard-apl: [PASS][11] -> [FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-apl1/igt@kms_async_flips@invalid-async-flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl3/igt@kms_async_flips@invalid-async-flip.html
Known issues
------------
Here are the changes found in Patchwork_21480_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][13] ([i915#1982] / [i915#3002])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl1/igt@gem_create@create-massive.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][14] -> [SKIP][15] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-apl3/igt@gem_exec_fair@basic-none-share@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-kbl7/igt@gem_exec_fair@basic-none@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl7/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][21] -> [SKIP][22] ([i915#2190])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb1/igt@gem_huc_copy@huc-copy.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3323])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl10/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][24] ([i915#3002])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@gem_userptr_blits@input-checking.html
- shard-tglb: NOTRUN -> [DMESG-WARN][25] ([i915#3002])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#3297])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@gem_userptr_blits@readonly-unsync.html
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][27] ([i915#3318])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl4/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume:
- shard-kbl: NOTRUN -> [DMESG-WARN][28] ([i915#180])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl4/igt@gem_workarounds@suspend-resume.html
* igt@gen7_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#109289])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@gen7_exec_parse@cmd-crossing-page.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#2856])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-tglb: NOTRUN -> [SKIP][31] ([fdo#109289] / [fdo#111719])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb5/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: NOTRUN -> [WARN][32] ([i915#2681] / [i915#2684])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-apl3/igt@i915_suspend@sysfs-reader.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl3/igt@i915_suspend@sysfs-reader.html
* igt@kms_async_flips@invalid-async-flip:
- shard-skl: [PASS][35] -> [DMESG-FAIL][36] ([i915#1226] / [i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl4/igt@kms_async_flips@invalid-async-flip.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl8/igt@kms_async_flips@invalid-async-flip.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111614]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [PASS][38] -> [DMESG-WARN][39] ([i915#118])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-glk6/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3777]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#110725] / [fdo#111614])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb8/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][42] ([i915#3743])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111615]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_joiner@2x-modeset:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#2705])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_big_joiner@2x-modeset.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#3689]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +7 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl4/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +5 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#3689] / [i915#3886]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_chamelium@vga-hpd-fast:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb8/igt@kms_chamelium@vga-hpd-fast.html
* igt@kms_color_chamelium@pipe-b-ctm-blue-to-red:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl3/igt@kms_color_chamelium@pipe-b-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +13 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_color_chamelium@pipe-b-ctm-negative:
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +7 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_color_chamelium@pipe-b-ctm-negative.html
* igt@kms_content_protection@lic:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111828]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb2/igt@kms_content_protection@lic.html
- shard-kbl: NOTRUN -> [TIMEOUT][56] ([i915#1319])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl4/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-a-cursor-32x32-random:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb8/igt@kms_cursor_crc@pipe-a-cursor-32x32-random.html
* igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271]) +104 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [PASS][59] -> [INCOMPLETE][60] ([i915#2828] / [i915#456])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3319]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [PASS][62] -> [INCOMPLETE][63] ([i915#456])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-max-size-random:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#3359])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-max-size-random.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-onscreen:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109279] / [i915#3359])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@kms_cursor_crc@pipe-d-cursor-512x170-onscreen.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#533])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#4103])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][68] -> [INCOMPLETE][69] ([i915#180] / [i915#636])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][70] -> [FAIL][71] ([i915#79])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][72] -> [DMESG-WARN][73] ([i915#180]) +5 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [PASS][74] -> [INCOMPLETE][75] ([i915#2411] / [i915#456])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: NOTRUN -> [FAIL][76] ([i915#2122])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271]) +144 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl4/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111825]) +11 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-move.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109280]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- shard-skl: [PASS][80] -> [DMESG-WARN][81] ([i915#1982]) +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl10/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][82] -> [FAIL][83] ([i915#1188])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271]) +52 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl8/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][85] ([i915#265])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2920])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@frontbuffer:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#658]) +4 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr2_su@page_flip:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#1911])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][94] -> [SKIP][95] ([fdo#109441]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_sprite_render:
- shard-tglb: NOTRUN -> [FAIL][96] ([i915#132] / [i915#3467])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@kms_psr@psr2_sprite_render.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][97] ([IGT#2])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_sysfs_edid_timing.html
* igt@kms_vrr@flip-suspend:
- shard-tglb: NOTRUN -> [SKIP][98] ([fdo#109502])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb2/igt@kms_vrr@flip-suspend.html
* igt@nouveau_crc@pipe-c-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@nouveau_crc@pipe-c-ctx-flip-detection.html
* igt@perf@short-reads:
- shard-skl: [PASS][100] -> [FAIL][101] ([i915#51])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl9/igt@perf@short-reads.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl10/igt@perf@short-reads.html
* igt@prime_nv_test@nv_write_i915_cpu_mmap_read:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#109291]) +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@prime_nv_test@nv_write_i915_cpu_mmap_read.html
* igt@sysfs_clients@busy:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#2994])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@sysfs_clients@busy.html
- shard-skl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#2994]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@sysfs_clients@busy.html
* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2994])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl3/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][106] ([i915#2842]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb3/igt@gem_exec_fair@basic-pace@rcs0.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb6/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][108] ([i915#2842]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_spin_batch@user-each:
- shard-skl: [FAIL][110] -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl7/igt@gem_spin_batch@user-each.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl6/igt@gem_spin_batch@user-each.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][112] ([i915#454]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl7/igt@i915_pm_dc@dc6-psr.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [INCOMPLETE][116] ([i915#456]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb7/igt@i915_suspend@sysfs-reader.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb2/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-b-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][118] ([i915#1982]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl10/igt@kms_color@pipe-b-ctm-red-to-blue.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl9/igt@kms_color@pipe-b-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [INCOMPLETE][120] ([i915#2828] / [i915#300]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-suspend:
- shard-tglb: [INCOMPLETE][122] ([i915#2411] / [i915#4211]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-iclb: [FAIL][124] ([i915#2346]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-skl: [FAIL][126] ([i915#2346]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][128] ([i915#2346] / [i915#533]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][130] ([i915#79]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][132] ([i915#2122]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][134] ([i915#1188]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][136] ([i915#180]) -> [PASS][137] +3 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][138] ([fdo#109441]) -> [PASS][139] +2 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-iclb: [SKIP][140] ([fdo#109278]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10809/shard-iclb5/igt@kms_vblank@pipe-c-ts-continuation-susp
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21480/index.html
[-- Attachment #2: Type: text/html, Size: 33562 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once
2021-10-29 6:24 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2021-10-29 17:47 ` Souza, Jose
2021-10-29 19:33 ` Ville Syrjälä
0 siblings, 1 reply; 6+ messages in thread
From: Souza, Jose @ 2021-10-29 17:47 UTC (permalink / raw)
To: ville.syrjala; +Cc: Kulkarni, Vandita, B S, Karthik, intel-gfx
On Fri, 2021-10-29 at 09:24 +0300, Ville Syrjälä wrote:
> On Thu, Oct 28, 2021 at 01:34:18PM -0700, José Roberto de Souza wrote:
> > For every crtc in state, intel_atomic_check_async() was checking all
> > the crtc and plane states again.
> >
> > Cc: Karthik B S <karthik.b.s@intel.com>
> > Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 38 ++++++++++----------
> > 1 file changed, 20 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 79cd158503b37..3b5a8e971343f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -7707,35 +7707,37 @@ static void kill_bigjoiner_slave(struct intel_atomic_state *state,
> > * correspond to the last vblank and have no relation to the actual time when
> > * the flip done event was sent.
> > */
> > -static int intel_atomic_check_async(struct intel_atomic_state *state)
> > +static int intel_atomic_check_async(struct intel_atomic_state *state, struct intel_crtc *crtc)
> > {
> > struct drm_i915_private *i915 = to_i915(state->base.dev);
> > const struct intel_crtc_state *old_crtc_state, *new_crtc_state;
> > const struct intel_plane_state *new_plane_state, *old_plane_state;
> > - struct intel_crtc *crtc;
> > struct intel_plane *plane;
> > int i;
> >
> > - for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> > - new_crtc_state, i) {
> > - if (intel_crtc_needs_modeset(new_crtc_state)) {
> > - drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
> > - return -EINVAL;
> > - }
> > + old_crtc_state = intel_atomic_get_old_crtc_state(state, crtc);
> > + new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> >
> > - if (!new_crtc_state->hw.active) {
> > - drm_dbg_kms(&i915->drm, "CRTC inactive\n");
> > - return -EINVAL;
> > - }
> > - if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
> > - drm_dbg_kms(&i915->drm,
> > - "Active planes cannot be changed during async flip\n");
> > - return -EINVAL;
> > - }
> > + if (intel_crtc_needs_modeset(new_crtc_state)) {
> > + drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
> > + return -EINVAL;
> > + }
> > +
> > + if (!new_crtc_state->hw.active) {
> > + drm_dbg_kms(&i915->drm, "CRTC inactive\n");
> > + return -EINVAL;
> > + }
> > + if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
> > + drm_dbg_kms(&i915->drm,
> > + "Active planes cannot be changed during async flip\n");
> > + return -EINVAL;
> > }
> >
> > for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state,
> > new_plane_state, i) {
> > + if (plane->base.crtc != &crtc->base)
> > + continue;
>
> Not the pointer you want to be looking at.
new_plane_state->hw.crtc?
>
> > +
> > /*
> > * TODO: Async flip is only supported through the page flip IOCTL
> > * as of now. So support currently added for primary plane only.
> > @@ -8054,7 +8056,7 @@ static int intel_atomic_check(struct drm_device *dev,
> > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> > new_crtc_state, i) {
> > if (new_crtc_state->uapi.async_flip) {
> > - ret = intel_atomic_check_async(state);
> > + ret = intel_atomic_check_async(state, crtc);
> > if (ret)
> > goto fail;
> > }
> > --
> > 2.33.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once
2021-10-29 17:47 ` Souza, Jose
@ 2021-10-29 19:33 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2021-10-29 19:33 UTC (permalink / raw)
To: Souza, Jose; +Cc: Kulkarni, Vandita, B S, Karthik, intel-gfx
On Fri, Oct 29, 2021 at 05:47:22PM +0000, Souza, Jose wrote:
> On Fri, 2021-10-29 at 09:24 +0300, Ville Syrjälä wrote:
> > On Thu, Oct 28, 2021 at 01:34:18PM -0700, José Roberto de Souza wrote:
> > > For every crtc in state, intel_atomic_check_async() was checking all
> > > the crtc and plane states again.
> > >
> > > Cc: Karthik B S <karthik.b.s@intel.com>
> > > Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 38 ++++++++++----------
> > > 1 file changed, 20 insertions(+), 18 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > > index 79cd158503b37..3b5a8e971343f 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -7707,35 +7707,37 @@ static void kill_bigjoiner_slave(struct intel_atomic_state *state,
> > > * correspond to the last vblank and have no relation to the actual time when
> > > * the flip done event was sent.
> > > */
> > > -static int intel_atomic_check_async(struct intel_atomic_state *state)
> > > +static int intel_atomic_check_async(struct intel_atomic_state *state, struct intel_crtc *crtc)
> > > {
> > > struct drm_i915_private *i915 = to_i915(state->base.dev);
> > > const struct intel_crtc_state *old_crtc_state, *new_crtc_state;
> > > const struct intel_plane_state *new_plane_state, *old_plane_state;
> > > - struct intel_crtc *crtc;
> > > struct intel_plane *plane;
> > > int i;
> > >
> > > - for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> > > - new_crtc_state, i) {
> > > - if (intel_crtc_needs_modeset(new_crtc_state)) {
> > > - drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
> > > - return -EINVAL;
> > > - }
> > > + old_crtc_state = intel_atomic_get_old_crtc_state(state, crtc);
> > > + new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> > >
> > > - if (!new_crtc_state->hw.active) {
> > > - drm_dbg_kms(&i915->drm, "CRTC inactive\n");
> > > - return -EINVAL;
> > > - }
> > > - if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
> > > - drm_dbg_kms(&i915->drm,
> > > - "Active planes cannot be changed during async flip\n");
> > > - return -EINVAL;
> > > - }
> > > + if (intel_crtc_needs_modeset(new_crtc_state)) {
> > > + drm_dbg_kms(&i915->drm, "Modeset Required. Async flip not supported\n");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + if (!new_crtc_state->hw.active) {
> > > + drm_dbg_kms(&i915->drm, "CRTC inactive\n");
> > > + return -EINVAL;
> > > + }
> > > + if (old_crtc_state->active_planes != new_crtc_state->active_planes) {
> > > + drm_dbg_kms(&i915->drm,
> > > + "Active planes cannot be changed during async flip\n");
> > > + return -EINVAL;
> > > }
> > >
> > > for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state,
> > > new_plane_state, i) {
> > > + if (plane->base.crtc != &crtc->base)
> > > + continue;
> >
> > Not the pointer you want to be looking at.
>
> new_plane_state->hw.crtc?
That looks like it should work here. The trouble with that pointer in
general is that when the plane is getting disabled the pointer is already
NULL while some bits of code will still want to consider planes that are
just about to get disabled. So sometimes you'll have to look at both the
old and new plane states, or just take a shortcut and check ->pipe since
we don't support moving planes between pipes anyway.
It's also a bit scary that intel_atomic_check_async() doesn't check
whether the plane is actually enabled or not currently. But I guess
we're saved by the fact that the async flip uapi is too limited to
allow that to happen.
>
> >
> > > +
> > > /*
> > > * TODO: Async flip is only supported through the page flip IOCTL
> > > * as of now. So support currently added for primary plane only.
> > > @@ -8054,7 +8056,7 @@ static int intel_atomic_check(struct drm_device *dev,
> > > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> > > new_crtc_state, i) {
> > > if (new_crtc_state->uapi.async_flip) {
> > > - ret = intel_atomic_check_async(state);
> > > + ret = intel_atomic_check_async(state, crtc);
> > > if (ret)
> > > goto fail;
> > > }
> > > --
> > > 2.33.1
> >
>
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-29 19:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 20:34 [Intel-gfx] [PATCH] drm/i915/display: Check async flip state of every crtc and plane once José Roberto de Souza
2021-10-28 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-29 6:24 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2021-10-29 17:47 ` Souza, Jose
2021-10-29 19:33 ` Ville Syrjälä
2021-10-29 6:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.