* [PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF
@ 2021-11-04 17:55 Jakub Kicinski
2021-11-05 10:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2021-11-04 17:55 UTC (permalink / raw)
To: davem; +Cc: netdev, l.stelmach, Jakub Kicinski, kernel test robot
Build bot says:
>> drivers/net/ethernet/asix/ax88796c_main.c:1116:34: warning: unused variable 'ax88796c_dt_ids' [-Wunused-const-variable]
static const struct of_device_id ax88796c_dt_ids[] = {
^
The only reference to this array is wrapped in of_match_ptr().
Reported-by: kernel test robot <lkp@intel.com>
Fixes: a97c69ba4f30 ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/asix/ax88796c_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c
index 4b0c5a09fd57..2086de05385c 100644
--- a/drivers/net/ethernet/asix/ax88796c_main.c
+++ b/drivers/net/ethernet/asix/ax88796c_main.c
@@ -1114,11 +1114,13 @@ static int ax88796c_remove(struct spi_device *spi)
return 0;
}
+#ifdef CONFIG_OF
static const struct of_device_id ax88796c_dt_ids[] = {
{ .compatible = "asix,ax88796c" },
{},
};
MODULE_DEVICE_TABLE(of, ax88796c_dt_ids);
+#endif
static const struct spi_device_id asix_id[] = {
{ "ax88796c", 0 },
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF
2021-11-04 17:55 [PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF Jakub Kicinski
@ 2021-11-05 10:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-05 10:50 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, l.stelmach, lkp
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 4 Nov 2021 10:55:27 -0700 you wrote:
> Build bot says:
>
> >> drivers/net/ethernet/asix/ax88796c_main.c:1116:34: warning: unused variable 'ax88796c_dt_ids' [-Wunused-const-variable]
> static const struct of_device_id ax88796c_dt_ids[] = {
> ^
>
> The only reference to this array is wrapped in of_match_ptr().
>
> [...]
Here is the summary with links:
- [net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF
https://git.kernel.org/netdev/net/c/6789a4c05127
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-05 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 17:55 [PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF Jakub Kicinski
2021-11-05 10:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.