[PATCH v2 0/3] r8a7793 Gose video input support

[PATCH v2 0/3] r8a7793 Gose video input support

[Ulrich Hecht]

Hi!

This is a by-the-datasheet implementation of analog and digital video input
on the Gose board.

I have tried to address all concerns raised by reviewers, with the exception
of the composite input patch, which has been left as is for now.

CU
Uli


Changes since v1:
- r8a7793.dtsi: added VIN2
- modeled HDMI decoder input/output and connector
- added "renesas,rcar-gen2-vin" compat strings
- removed unnecessary "remote" node and aliases
- set ADV7612 interrupt to GP4_2


Ulrich Hecht (3):
  ARM: dts: r8a7793: Enable VIN0-VIN2
  ARM: dts: gose: add HDMI input
  ARM: dts: gose: add composite video input

 arch/arm/boot/dts/r8a7793-gose.dts | 100 +++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/r8a7793.dtsi     |  27 ++++++++++
 2 files changed, 127 insertions(+)

-- 
2.7.4

[PATCH v2 1/3] ARM: dts: r8a7793: Enable VIN0-VIN2

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm/boot/dts/r8a7793.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index a7d11b9..629d3d6 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -852,6 +852,33 @@
 		status = "disabled";
 	};
 
+	vin0: video@e6ef0000 {
+		compatible = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
+		reg = <0 0xe6ef0000 0 0x1000>;
+		interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp8_clks R8A7793_CLK_VIN0>;
+		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+		status = "disabled";
+	};
+
+	vin1: video@e6ef1000 {
+		compatible = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
+		reg = <0 0xe6ef1000 0 0x1000>;
+		interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp8_clks R8A7793_CLK_VIN1>;
+		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+		status = "disabled";
+	};
+
+	vin2: video@e6ef2000 {
+		compatible = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
+		reg = <0 0xe6ef2000 0 0x1000>;
+		interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp8_clks R8A7793_CLK_VIN2>;
+		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+		status = "disabled";
+	};
+
 	qspi: spi@e6b10000 {
 		compatible = "renesas,qspi-r8a7793", "renesas,qspi";
 		reg = <0 0xe6b10000 0 0x2c>;
-- 
2.7.4

[PATCH v2 2/3] ARM: dts: gose: add HDMI input

[Ulrich Hecht]

Identical to the setup on Lager.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 64 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index dc311eb..a47ea4b 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -253,6 +253,17 @@
 		};
 	};
 
+	hdmi-in {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&adv7612_in>;
+			};
+		};
+	};
+
 	hdmi-out {
 		compatible = "hdmi-connector";
 		type = "a";
@@ -374,6 +385,11 @@
 		groups = "audio_clk_a";
 		function = "audio_clk";
 	};
+
+	vin0_pins: vin0 {
+		groups = "vin0_data24", "vin0_sync", "vin0_clkenb", "vin0_clk";
+		function = "vin0";
+	};
 };
 
 &ether {
@@ -531,6 +547,33 @@
 		};
 	};
 
+	hdmi-in@4c {
+		compatible = "adi,adv7612";
+		reg = <0x4c>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		default-input = <0>;
+
+		port {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7612_in: endpoint {
+					remote-endpoint = <&hdmi_con_in>;
+				};
+			};
+
+			port@2 {
+				reg = <2>;
+				adv7612_out: endpoint {
+					remote-endpoint = <&vin0ep2>;
+				};
+			};
+		};
+	};
+
 	eeprom@50 {
 		compatible = "renesas,r1ex24002", "atmel,24c02";
 		reg = <0x50>;
@@ -558,3 +601,24 @@
 &ssi1 {
 	shared-pin;
 };
+
+/* HDMI video input */
+&vin0 {
+	status = "okay";
+	pinctrl-0 = <&vin0_pins>;
+	pinctrl-names = "default";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		vin0ep2: endpoint {
+			remote-endpoint = <&adv7612_out>;
+			bus-width = <24>;
+			hsync-active = <0>;
+			vsync-active = <0>;
+			pclk-sample = <1>;
+			data-active = <1>;
+		};
+	};
+};
-- 
2.7.4

[PATCH v2 3/3] ARM: dts: gose: add composite video input

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index a47ea4b..2606021 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -390,6 +390,11 @@
 		groups = "vin0_data24", "vin0_sync", "vin0_clkenb", "vin0_clk";
 		function = "vin0";
 	};
+
+	vin1_pins: vin1 {
+		groups = "vin1_data8", "vin1_clk";
+		function = "vin1";
+	};
 };
 
 &ether {
@@ -515,6 +520,19 @@
 		reg = <0x12>;
 	};
 
+	composite-in@20 {
+		compatible = "adi,adv7180";
+		reg = <0x20>;
+		remote = <&vin1>;
+
+		port {
+			adv7180: endpoint {
+				bus-width = <8>;
+				remote-endpoint = <&vin1ep>;
+			};
+		};
+	};
+
 	hdmi@39 {
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
@@ -622,3 +640,21 @@
 		};
 	};
 };
+
+/* composite video input */
+&vin1 {
+	pinctrl-0 = <&vin1_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		vin1ep: endpoint {
+			remote-endpoint = <&adv7180>;
+			bus-width = <8>;
+		};
+	};
+};
-- 
2.7.4

Re: [PATCH v2 1/3] ARM: dts: r8a7793: Enable VIN0-VIN2

[Laurent Pinchart]

Hi Ulrich,

Thank you for the patch.

On Tuesday 18 Oct 2016 17:02:21 Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7793.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> index a7d11b9..629d3d6 100644
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -852,6 +852,33 @@
>  		status = "disabled";
>  	};
> 
> +	vin0: video@e6ef0000 {
> +		compatible = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
> +		reg = <0 0xe6ef0000 0 0x1000>;
> +		interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp8_clks R8A7793_CLK_VIN0>;
> +		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> +		status = "disabled";
> +	};
> +
> +	vin1: video@e6ef1000 {
> +		compatible = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
> +		reg = <0 0xe6ef1000 0 0x1000>;
> +		interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp8_clks R8A7793_CLK_VIN1>;
> +		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> +		status = "disabled";
> +	};
> +
> +	vin2: video@e6ef2000 {
> +		compatible = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
> +		reg = <0 0xe6ef2000 0 0x1000>;
> +		interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp8_clks R8A7793_CLK_VIN2>;
> +		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> +		status = "disabled";
> +	};
> +
>  	qspi: spi@e6b10000 {
>  		compatible = "renesas,qspi-r8a7793", "renesas,qspi";
>  		reg = <0 0xe6b10000 0 0x2c>;

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 2/3] ARM: dts: gose: add HDMI input

[Laurent Pinchart]

Hi Ulrich,

Thank you for the patch.

On Tuesday 18 Oct 2016 17:02:22 Ulrich Hecht wrote:
> Identical to the setup on Lager.

You probably mean on Koelsch ?

> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm/boot/dts/r8a7793-gose.dts | 64 +++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> b/arch/arm/boot/dts/r8a7793-gose.dts index dc311eb..a47ea4b 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -253,6 +253,17 @@
>  		};
>  	};
> 
> +	hdmi-in {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&adv7612_in>;
> +			};
> +		};
> +	};
> +
>  	hdmi-out {
>  		compatible = "hdmi-connector";
>  		type = "a";

For consistency you might want to rename the hdmi-out endpoint like you did 
for Lager and Koelsch.

With that fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> @@ -374,6 +385,11 @@
>  		groups = "audio_clk_a";
>  		function = "audio_clk";
>  	};
> +
> +	vin0_pins: vin0 {
> +		groups = "vin0_data24", "vin0_sync", "vin0_clkenb", 
"vin0_clk";
> +		function = "vin0";
> +	};
>  };
> 
>  &ether {
> @@ -531,6 +547,33 @@
>  		};
>  	};
> 
> +	hdmi-in@4c {
> +		compatible = "adi,adv7612";
> +		reg = <0x4c>;
> +		interrupt-parent = <&gpio4>;
> +		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		default-input = <0>;
> +
> +		port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				adv7612_in: endpoint {
> +					remote-endpoint = <&hdmi_con_in>;
> +				};
> +			};
> +
> +			port@2 {
> +				reg = <2>;
> +				adv7612_out: endpoint {
> +					remote-endpoint = <&vin0ep2>;
> +				};
> +			};
> +		};
> +	};
> +
>  	eeprom@50 {
>  		compatible = "renesas,r1ex24002", "atmel,24c02";
>  		reg = <0x50>;
> @@ -558,3 +601,24 @@
>  &ssi1 {
>  	shared-pin;
>  };
> +
> +/* HDMI video input */
> +&vin0 {
> +	status = "okay";
> +	pinctrl-0 = <&vin0_pins>;
> +	pinctrl-names = "default";
> +
> +	port {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		vin0ep2: endpoint {
> +			remote-endpoint = <&adv7612_out>;
> +			bus-width = <24>;
> +			hsync-active = <0>;
> +			vsync-active = <0>;
> +			pclk-sample = <1>;
> +			data-active = <1>;
> +		};
> +	};
> +};

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 3/3] ARM: dts: gose: add composite video input

[Laurent Pinchart]

Hi Ulrich,

(CC'ing the device tree mailing list)

Thank you for the patch.

On Tuesday 18 Oct 2016 17:02:23 Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm/boot/dts/r8a7793-gose.dts | 36 ++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> b/arch/arm/boot/dts/r8a7793-gose.dts index a47ea4b..2606021 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -390,6 +390,11 @@
>  		groups = "vin0_data24", "vin0_sync", "vin0_clkenb", 
"vin0_clk";
>  		function = "vin0";
>  	};
> +
> +	vin1_pins: vin1 {
> +		groups = "vin1_data8", "vin1_clk";
> +		function = "vin1";
> +	};
>  };
> 
>  &ether {
> @@ -515,6 +520,19 @@
>  		reg = <0x12>;
>  	};
> 
> +	composite-in@20 {
> +		compatible = "adi,adv7180";
> +		reg = <0x20>;
> +		remote = <&vin1>;
> +
> +		port {
> +			adv7180: endpoint {
> +				bus-width = <8>;
> +				remote-endpoint = <&vin1ep>;
> +			};
> +		};

As explained before, you need to update the ADV7180 DT bindings first to 
document ports. I've discussed this with Hans last week, and we agreed that DT 
should model physical ports. Unfortunately the ADV7180 comes in four different 
packages with different feature sets that affect ports.

ADV7180  K CP32 Z               32-Lead Lead Frame Chip Scale Package
ADV7180  B CP32 Z               32-Lead Lead Frame Chip Scale Package
ADV7180 WB CP32 Z               32-Lead Lead Frame Chip Scale Package

ADV7180  B CP   Z               40-Lead Lead Frame Chip Scale Package
ADV7180 WB CP   Z               40-Lead Lead Frame Chip Scale Package

ADV7180  K ST48 Z               48-Lead Low Profile Quad Flat Package
ADV7180  B ST48 Z               48-Lead Low Profile Quad Flat Package
ADV7180 WB ST48 Z               48-Lead Low Profile Quad Flat Package

ADV7180  B ST   Z               64-Lead Low Profile Quad Flat Package
ADV7180 WB ST   Z               64-Lead Low Profile Quad Flat Package

W tells whether the part is qualified for automotive applications. It has no 
impact from a software point of view. K and B indicate the temperature range, 
and also have no software impact. The Z suffix indicates that the part is RoHS 
compliant (they all are) and also has no impact.

Unfortunately the W and K/B qualifiers come before the package qualifier. I'm 
not sure whether we could simply drop W, K/B and W and specify the following 
compatible strings

- adv7180cp32
- adv7180cp
- adv7180st48
- adv7180st

or if we need more compatible strings that would match the full chip name. 
Feedback on that from the device tree maintainers would be appreciated.

Regardless of what compatible strings end up being used, the bindings should 
document 3 or 6 input ports depending on the model, and one output port. You 
can number the input ports from 0 to 2 or 0 to 5 depending on the model and 
the output port 3 or 6. Another option would be to number the output port 0 
and the input ports 1 to 3 or 1 to 6 depending on the model. That would give a 
fixed number for the output port across all models, but might be a bit 
consuming as most bindings number input ports before output ports.

For the Gose board you should then add one composite connector to the device 
tree ("composite-video-connector") and connect it to port 0 of the 
ADV7180WBCP32.

> +	};
> +
>  	hdmi@39 {
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;
> @@ -622,3 +640,21 @@
>  		};
>  	};
>  };
> +
> +/* composite video input */
> +&vin1 {
> +	pinctrl-0 = <&vin1_pins>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	port {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		vin1ep: endpoint {
> +			remote-endpoint = <&adv7180>;
> +			bus-width = <8>;
> +		};
> +	};
> +};

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 3/3] ARM: dts: gose: add composite video input

[Laurent Pinchart]

Hi Ulrich,

(CC'ing the device tree mailing list - for real this time)

Thank you for the patch.

On Tuesday 18 Oct 2016 17:02:23 Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm/boot/dts/r8a7793-gose.dts | 36 ++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> b/arch/arm/boot/dts/r8a7793-gose.dts index a47ea4b..2606021 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -390,6 +390,11 @@
>  		groups = "vin0_data24", "vin0_sync", "vin0_clkenb", 
"vin0_clk";
>  		function = "vin0";
>  	};
> +
> +	vin1_pins: vin1 {
> +		groups = "vin1_data8", "vin1_clk";
> +		function = "vin1";
> +	};
>  };
> 
>  &ether {
> @@ -515,6 +520,19 @@
>  		reg = <0x12>;
>  	};
> 
> +	composite-in@20 {
> +		compatible = "adi,adv7180";
> +		reg = <0x20>;
> +		remote = <&vin1>;
> +
> +		port {
> +			adv7180: endpoint {
> +				bus-width = <8>;
> +				remote-endpoint = <&vin1ep>;
> +			};
> +		};

As explained before, you need to update the ADV7180 DT bindings first to 
document ports. I've discussed this with Hans last week, and we agreed that DT 
should model physical ports. Unfortunately the ADV7180 comes in four different 
packages with different feature sets that affect ports.

ADV7180  K CP32 Z               32-Lead Lead Frame Chip Scale Package
ADV7180  B CP32 Z               32-Lead Lead Frame Chip Scale Package
ADV7180 WB CP32 Z               32-Lead Lead Frame Chip Scale Package

ADV7180  B CP   Z               40-Lead Lead Frame Chip Scale Package
ADV7180 WB CP   Z               40-Lead Lead Frame Chip Scale Package

ADV7180  K ST48 Z               48-Lead Low Profile Quad Flat Package
ADV7180  B ST48 Z               48-Lead Low Profile Quad Flat Package
ADV7180 WB ST48 Z               48-Lead Low Profile Quad Flat Package

ADV7180  B ST   Z               64-Lead Low Profile Quad Flat Package
ADV7180 WB ST   Z               64-Lead Low Profile Quad Flat Package

W tells whether the part is qualified for automotive applications. It has no 
impact from a software point of view. K and B indicate the temperature range, 
and also have no software impact. The Z suffix indicates that the part is RoHS 
compliant (they all are) and also has no impact.

Unfortunately the W and K/B qualifiers come before the package qualifier. I'm 
not sure whether we could simply drop W, K/B and W and specify the following 
compatible strings

- adv7180cp32
- adv7180cp
- adv7180st48
- adv7180st

or if we need more compatible strings that would match the full chip name. 
Feedback on that from the device tree maintainers would be appreciated.

Regardless of what compatible strings end up being used, the bindings should 
document 3 or 6 input ports depending on the model, and one output port. You 
can number the input ports from 0 to 2 or 0 to 5 depending on the model and 
the output port 3 or 6. Another option would be to number the output port 0 
and the input ports 1 to 3 or 1 to 6 depending on the model. That would give a 
fixed number for the output port across all models, but might be a bit 
consuming as most bindings number input ports before output ports.

For the Gose board you should then add one composite connector to the device 
tree ("composite-video-connector") and connect it to port 0 of the 
ADV7180WBCP32.

> +	};
> +
>  	hdmi@39 {
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;
> @@ -622,3 +640,21 @@
>  		};
>  	};
>  };
> +
> +/* composite video input */
> +&vin1 {
> +	pinctrl-0 = <&vin1_pins>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	port {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		vin1ep: endpoint {
> +			remote-endpoint = <&adv7180>;
> +			bus-width = <8>;
> +		};
> +	};
> +};

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 1/3] ARM: dts: r8a7793: Enable VIN0-VIN2

[Geert Uytterhoeven]

On Tue, Oct 18, 2016 at 5:02 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/3] r8a7793 Gose video input support

[Simon Horman]

Hi Ulrich,

On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> This is a by-the-datasheet implementation of analog and digital video input
> on the Gose board.
> 
> I have tried to address all concerns raised by reviewers, with the exception
> of the composite input patch, which has been left as is for now.
> 
> CU
> Uli
> 
> 
> Changes since v1:
> - r8a7793.dtsi: added VIN2
> - modeled HDMI decoder input/output and connector
> - added "renesas,rcar-gen2-vin" compat strings
> - removed unnecessary "remote" node and aliases
> - set ADV7612 interrupt to GP4_2
> 
> 
> Ulrich Hecht (3):
>   ARM: dts: r8a7793: Enable VIN0-VIN2

I have queued up the above patch with Laurent and Geert's tags.

>   ARM: dts: gose: add HDMI input
>   ARM: dts: gose: add composite video input

Please address the review of the above two patches and repost.

Thanks!

> 
>  arch/arm/boot/dts/r8a7793-gose.dts | 100 +++++++++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/r8a7793.dtsi     |  27 ++++++++++
>  2 files changed, 127 insertions(+)
> 
> -- 
> 2.7.4
> 

Re: [PATCH v2 3/3] ARM: dts: gose: add composite video input

[Laurent Pinchart]

Hello device tree maintainers,

On Tuesday 18 Oct 2016 18:50:39 Laurent Pinchart wrote:
> On Tuesday 18 Oct 2016 17:02:23 Ulrich Hecht wrote:
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7793-gose.dts | 36 +++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> > b/arch/arm/boot/dts/r8a7793-gose.dts index a47ea4b..2606021 100644
> > --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > +++ b/arch/arm/boot/dts/r8a7793-gose.dts

[snip]

> > +	composite-in@20 {
> > +		compatible = "adi,adv7180";
> > +		reg = <0x20>;
> > +		remote = <&vin1>;
> > +
> > +		port {
> > +			adv7180: endpoint {
> > +				bus-width = <8>;
> > +				remote-endpoint = <&vin1ep>;
> > +			};
> > +		};
> 
> As explained before, you need to update the ADV7180 DT bindings first to
> document ports. I've discussed this with Hans last week, and we agreed that
> DT should model physical ports. Unfortunately the ADV7180 comes in four
> different packages with different feature sets that affect ports.
> 
> ADV7180  K CP32 Z               32-Lead Lead Frame Chip Scale Package
> ADV7180  B CP32 Z               32-Lead Lead Frame Chip Scale Package
> ADV7180 WB CP32 Z               32-Lead Lead Frame Chip Scale Package
> 
> ADV7180  B CP   Z               40-Lead Lead Frame Chip Scale Package
> ADV7180 WB CP   Z               40-Lead Lead Frame Chip Scale Package
> 
> ADV7180  K ST48 Z               48-Lead Low Profile Quad Flat Package
> ADV7180  B ST48 Z               48-Lead Low Profile Quad Flat Package
> ADV7180 WB ST48 Z               48-Lead Low Profile Quad Flat Package
> 
> ADV7180  B ST   Z               64-Lead Low Profile Quad Flat Package
> ADV7180 WB ST   Z               64-Lead Low Profile Quad Flat Package
> 
> W tells whether the part is qualified for automotive applications. It has no
> impact from a software point of view. K and B indicate the temperature
> range, and also have no software impact. The Z suffix indicates that the
> part is RoHS compliant (they all are) and also has no impact.
> 
> Unfortunately the W and K/B qualifiers come before the package qualifier.
> I'm not sure whether we could simply drop W, K/B and W and specify the
> following compatible strings
> 
> - adv7180cp32
> - adv7180cp
> - adv7180st48
> - adv7180st
> 
> or if we need more compatible strings that would match the full chip name.
> Feedback on that from the device tree maintainers would be appreciated.

Your input would be appreciated on this.

> Regardless of what compatible strings end up being used, the bindings should
> document 3 or 6 input ports depending on the model, and one output port.
> You can number the input ports from 0 to 2 or 0 to 5 depending on the model
> and the output port 3 or 6. Another option would be to number the output
> port 0 and the input ports 1 to 3 or 1 to 6 depending on the model. That
> would give a fixed number for the output port across all models, but might
> be a bit consuming as most bindings number input ports before output ports.
> 
> For the Gose board you should then add one composite connector to the device
> tree ("composite-video-connector") and connect it to port 0 of the
> ADV7180WBCP32.
> 
> > +	};
> > +

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 0/3] r8a7793 Gose video input support

[Laurent Pinchart]

Hi Ulrich,

On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote:
> On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote:
> > Hi!
> > 
> > This is a by-the-datasheet implementation of analog and digital video
> > input on the Gose board.
> > 
> > I have tried to address all concerns raised by reviewers, with the
> > exception of the composite input patch, which has been left as is for
> > now.
> > 
> > CU
> > Uli
> > 
> > 
> > Changes since v1:
> > - r8a7793.dtsi: added VIN2
> > - modeled HDMI decoder input/output and connector
> > - added "renesas,rcar-gen2-vin" compat strings
> > - removed unnecessary "remote" node and aliases
> > - set ADV7612 interrupt to GP4_2
> > 
> > Ulrich Hecht (3):
> >   ARM: dts: r8a7793: Enable VIN0-VIN2
> 
> I have queued up the above patch with Laurent and Geert's tags.
> 
> >   ARM: dts: gose: add HDMI input
> >   ARM: dts: gose: add composite video input
> 
> Please address the review of the above two patches and repost.

Could you please do so ? Feedback on 2/3 should be easy to handle. For 3/3, 
you might need to ping the DT maintainers.

> >  arch/arm/boot/dts/r8a7793-gose.dts | 100 +++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/r8a7793.dtsi     |  27 ++++++++++
> >  2 files changed, 127 insertions(+)

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 0/3] r8a7793 Gose video input support

[Laurent Pinchart]

Hi Ulrich,

On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote:
> On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote:
> > On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote:
> >> Hi!
> >> 
> >> This is a by-the-datasheet implementation of analog and digital video
> >> input on the Gose board.
> >> 
> >> I have tried to address all concerns raised by reviewers, with the
> >> exception of the composite input patch, which has been left as is for
> >> now.
> >> 
> >> CU
> >> Uli
> >> 
> >> 
> >> Changes since v1:
> >> - r8a7793.dtsi: added VIN2
> >> - modeled HDMI decoder input/output and connector
> >> - added "renesas,rcar-gen2-vin" compat strings
> >> - removed unnecessary "remote" node and aliases
> >> - set ADV7612 interrupt to GP4_2
> >> 
> >> Ulrich Hecht (3):
> >>   ARM: dts: r8a7793: Enable VIN0-VIN2
> > 
> > I have queued up the above patch with Laurent and Geert's tags.
> > 
> >>   ARM: dts: gose: add HDMI input
> >>   ARM: dts: gose: add composite video input
> > 
> > Please address the review of the above two patches and repost.
> 
> Could you please do so ? Feedback on 2/3 should be easy to handle. For 3/3,
> you might need to ping the DT maintainers.

Ping. These are the only two patches that block

VIN,v4.12,public,ulrich,Gen2 VIN integration

> >>  arch/arm/boot/dts/r8a7793-gose.dts | 100 +++++++++++++++++++++++++++++
> >>  arch/arm/boot/dts/r8a7793.dtsi     |  27 ++++++++++
> >>  2 files changed, 127 insertions(+)

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 0/3] r8a7793 Gose video input support

[Simon Horman]

On Wed, Apr 26, 2017 at 06:56:06PM +0300, Laurent Pinchart wrote:
> Hi Ulrich,
> 
> On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote:
> > On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote:
> > > On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote:
> > >> Hi!
> > >> 
> > >> This is a by-the-datasheet implementation of analog and digital video
> > >> input on the Gose board.
> > >> 
> > >> I have tried to address all concerns raised by reviewers, with the
> > >> exception of the composite input patch, which has been left as is for
> > >> now.
> > >> 
> > >> CU
> > >> Uli
> > >> 
> > >> 
> > >> Changes since v1:
> > >> - r8a7793.dtsi: added VIN2
> > >> - modeled HDMI decoder input/output and connector
> > >> - added "renesas,rcar-gen2-vin" compat strings
> > >> - removed unnecessary "remote" node and aliases
> > >> - set ADV7612 interrupt to GP4_2
> > >> 
> > >> Ulrich Hecht (3):
> > >>   ARM: dts: r8a7793: Enable VIN0-VIN2
> > > 
> > > I have queued up the above patch with Laurent and Geert's tags.
> > > 
> > >>   ARM: dts: gose: add HDMI input
> > >>   ARM: dts: gose: add composite video input
> > > 
> > > Please address the review of the above two patches and repost.
> > 
> > Could you please do so ? Feedback on 2/3 should be easy to handle. For 3/3,
> > you might need to ping the DT maintainers.
> 
> Ping. These are the only two patches that block
> 
> VIN,v4.12,public,ulrich,Gen2 VIN integration

Sorry, I'm unsure how these slipped through the cracks.
I now have them queued up locally for v4.13 and I plan to push this morning.

Re: [PATCH v2 0/3] r8a7793 Gose video input support

[Laurent Pinchart]

Hi Simon,

On Friday 28 Apr 2017 07:16:24 Simon Horman wrote:
> On Wed, Apr 26, 2017 at 06:56:06PM +0300, Laurent Pinchart wrote:
> > On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote:
> >> On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote:
> >>> On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote:
> >>>> Hi!
> >>>> 
> >>>> This is a by-the-datasheet implementation of analog and digital video
> >>>> input on the Gose board.
> >>>> 
> >>>> I have tried to address all concerns raised by reviewers, with the
> >>>> exception of the composite input patch, which has been left as is for
> >>>> now.
> >>>> 
> >>>> CU
> >>>> Uli
> >>>> 
> >>>> 
> >>>> Changes since v1:
> >>>> - r8a7793.dtsi: added VIN2
> >>>> - modeled HDMI decoder input/output and connector
> >>>> - added "renesas,rcar-gen2-vin" compat strings
> >>>> - removed unnecessary "remote" node and aliases
> >>>> - set ADV7612 interrupt to GP4_2
> >>>> 
> >>>> Ulrich Hecht (3):
> >>>>   ARM: dts: r8a7793: Enable VIN0-VIN2
> >>> 
> >>> I have queued up the above patch with Laurent and Geert's tags.
> >>> 
> >>>>   ARM: dts: gose: add HDMI input
> >>>>   ARM: dts: gose: add composite video input
> >>> 
> >>> Please address the review of the above two patches and repost.
> >> 
> >> Could you please do so ? Feedback on 2/3 should be easy to handle. For
> >> 3/3, you might need to ping the DT maintainers.
> > 
> > Ping. These are the only two patches that block
> > 
> > VIN,v4.12,public,ulrich,Gen2 VIN integration
> 
> Sorry, I'm unsure how these slipped through the cracks.
> I now have them queued up locally for v4.13 and I plan to push this morning.

Please don't, the ping was for Ulrich, he needs to address review comments on 
patches 2/3 and 3/3.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 0/3] r8a7793 Gose video input support

[Simon Horman]

On Fri, Apr 28, 2017 at 11:40:20AM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Friday 28 Apr 2017 07:16:24 Simon Horman wrote:
> > On Wed, Apr 26, 2017 at 06:56:06PM +0300, Laurent Pinchart wrote:
> > > On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote:
> > >> On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote:
> > >>> On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote:
> > >>>> Hi!
> > >>>> 
> > >>>> This is a by-the-datasheet implementation of analog and digital video
> > >>>> input on the Gose board.
> > >>>> 
> > >>>> I have tried to address all concerns raised by reviewers, with the
> > >>>> exception of the composite input patch, which has been left as is for
> > >>>> now.
> > >>>> 
> > >>>> CU
> > >>>> Uli
> > >>>> 
> > >>>> 
> > >>>> Changes since v1:
> > >>>> - r8a7793.dtsi: added VIN2
> > >>>> - modeled HDMI decoder input/output and connector
> > >>>> - added "renesas,rcar-gen2-vin" compat strings
> > >>>> - removed unnecessary "remote" node and aliases
> > >>>> - set ADV7612 interrupt to GP4_2
> > >>>> 
> > >>>> Ulrich Hecht (3):
> > >>>>   ARM: dts: r8a7793: Enable VIN0-VIN2
> > >>> 
> > >>> I have queued up the above patch with Laurent and Geert's tags.
> > >>> 
> > >>>>   ARM: dts: gose: add HDMI input
> > >>>>   ARM: dts: gose: add composite video input
> > >>> 
> > >>> Please address the review of the above two patches and repost.
> > >> 
> > >> Could you please do so ? Feedback on 2/3 should be easy to handle. For
> > >> 3/3, you might need to ping the DT maintainers.
> > > 
> > > Ping. These are the only two patches that block
> > > 
> > > VIN,v4.12,public,ulrich,Gen2 VIN integration
> > 
> > Sorry, I'm unsure how these slipped through the cracks.
> > I now have them queued up locally for v4.13 and I plan to push this morning.
> 
> Please don't, the ping was for Ulrich, he needs to address review comments on 
> patches 2/3 and 3/3.

Oh, sorry. I will dequeue them.