[PATCH net 0/3] bnxt_en: Bug fixes

[PATCH net 0/3] bnxt_en: Bug fixes

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

This series includes 3 fixes.  The first one fixes a race condition
between devlink reload and SR-IOV configuration.  The second one
fixes a type mismatch warning in devlink fw live patching.  The
last one fixes unwanted OVS TC dmesg error logs when tc-hw-offload is
disabled on bnxt_en.

Edwin Peer (2):
  bnxt_en: extend RTNL to VF check in devlink driver_reinit
  bnxt_en: fix format specifier in live patch error message

Sriharsha Basavapatna (1):
  bnxt_en: reject indirect blk offload when hw-tc-offload is off

 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 9 +++++----
 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c      | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

[PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]

From: Edwin Peer <edwin.peer@broadcom.com>

The fixes the race condition between configuring SR-IOV and devlink
reload.  The SR-IOV configure logic already takes the RTNL lock,
setting sriov_cfg under the lock while changes are underway. Extend
the lock scope in devlink driver_reinit to cover the VF check and
don't run concurrently with SR-IOV configure.

Reported-by: Leon Romanovsky <leon@kernel.org>
Fixes: 228ea8c187d8 ("bnxt_en: implement devlink dev reload driver_reinit")
Cc: Leon Romanovsky <leon@kernel.org>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 5c464ea73576..a0a9af402642 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -441,12 +441,13 @@ static int bnxt_dl_reload_down(struct devlink *dl, bool netns_change,
 
 	switch (action) {
 	case DEVLINK_RELOAD_ACTION_DRIVER_REINIT: {
-		if (BNXT_PF(bp) && bp->pf.active_vfs) {
+		rtnl_lock();
+		if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
 			NL_SET_ERR_MSG_MOD(extack,
-					   "reload is unsupported when VFs are allocated");
+					   "reload is unsupported while VFs are allocated or being configured");
+			rtnl_unlock();
 			return -EOPNOTSUPP;
 		}
-		rtnl_lock();
 		if (bp->dev->reg_state == NETREG_UNREGISTERED) {
 			rtnl_unlock();
 			return -ENODEV;
-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

[PATCH net 2/3] bnxt_en: fix format specifier in live patch error message

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

From: Edwin Peer <edwin.peer@broadcom.com>

This fixes type mismatch warning.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 3c4153394e2c ("bnxt_en: implement firmware live patching")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index a0a9af402642..6fe9e9b59f83 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -360,7 +360,7 @@ bnxt_dl_livepatch_report_err(struct bnxt *bp, struct netlink_ext_ack *extack,
 		NL_SET_ERR_MSG_MOD(extack, "Live patch already applied");
 		break;
 	default:
-		netdev_err(bp->dev, "Unexpected live patch error: %hhd\n", err);
+		netdev_err(bp->dev, "Unexpected live patch error: %d\n", err);
 		NL_SET_ERR_MSG_MOD(extack, "Failed to activate live patch");
 		break;
 	}
-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

[PATCH net 3/3] bnxt_en: reject indirect blk offload when hw-tc-offload is off

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>

The driver does not check if hw-tc-offload is enabled for the device
before offloading a flow in the context of indirect block callback.
Fix this by checking NETIF_F_HW_TC in the features flag and rejecting
the offload request.  This will avoid unnecessary dmesg error logs when
hw-tc-offload is disabled, such as these:

bnxt_en 0000:19:00.1 eno2np1: dev(ifindex=294) not on same switch
bnxt_en 0000:19:00.1 eno2np1: Error: bnxt_tc_add_flow: cookie=0xffff8dace1c88000 error=-22
bnxt_en 0000:19:00.0 eno1np0: dev(ifindex=294) not on same switch
bnxt_en 0000:19:00.0 eno1np0: Error: bnxt_tc_add_flow: cookie=0xffff8dace1c88000 error=-22

Reported-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
Fixes: 627c89d00fb9 ("bnxt_en: flow_offload: offload tunnel decap rules via indirect callbacks")
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
index e6a4a768b10b..1471b6130a2b 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -1868,7 +1868,7 @@ static int bnxt_tc_setup_indr_block_cb(enum tc_setup_type type,
 	struct flow_cls_offload *flower = type_data;
 	struct bnxt *bp = priv->bp;
 
-	if (flower->common.chain_index)
+	if (!tc_cls_can_offload_and_chain0(bp->dev, type_data))
 		return -EOPNOTSUPP;
 
 	switch (type) {
-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH net 0/3] bnxt_en: Bug fixes

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon, 15 Nov 2021 02:37:58 -0500 you wrote:
> This series includes 3 fixes.  The first one fixes a race condition
> between devlink reload and SR-IOV configuration.  The second one
> fixes a type mismatch warning in devlink fw live patching.  The
> last one fixes unwanted OVS TC dmesg error logs when tc-hw-offload is
> disabled on bnxt_en.
> 
> Edwin Peer (2):
>   bnxt_en: extend RTNL to VF check in devlink driver_reinit
>   bnxt_en: fix format specifier in live patch error message
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit
    https://git.kernel.org/netdev/net/c/46d08f55d24e
  - [net,2/3] bnxt_en: fix format specifier in live patch error message
    https://git.kernel.org/netdev/net/c/b68a1a933fe4
  - [net,3/3] bnxt_en: reject indirect blk offload when hw-tc-offload is off
    https://git.kernel.org/netdev/net/c/b0757491a118

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5141 bytes --]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Bug-fixes/20211115-154005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 1aa3b2207e889a948049c9a8016cedb0218c2389
config: mips-randconfig-r031-20211115 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project fbe72e41b99dc7994daac300d208a955be3e4a0a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/b17bc036418692ffb8055b7cbcdff979ec378e37
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Chan/bnxt_en-Bug-fixes/20211115-154005
        git checkout b17bc036418692ffb8055b7cbcdff979ec378e37
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:363:62: warning: format specifies type 'char' but the argument has type 'int' [-Wformat]
                   netdev_err(bp->dev, "Unexpected live patch error: %hhd\n", err);
                                                                     ~~~~     ^~~
                                                                     %d
>> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:48: error: no member named 'sriov_cfg' in 'struct bnxt'
                   if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
                                                            ~~  ^
   1 warning and 1 error generated.


vim +445 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

   433	
   434	static int bnxt_dl_reload_down(struct devlink *dl, bool netns_change,
   435				       enum devlink_reload_action action,
   436				       enum devlink_reload_limit limit,
   437				       struct netlink_ext_ack *extack)
   438	{
   439		struct bnxt *bp = bnxt_get_bp_from_dl(dl);
   440		int rc = 0;
   441	
   442		switch (action) {
   443		case DEVLINK_RELOAD_ACTION_DRIVER_REINIT: {
   444			rtnl_lock();
 > 445			if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
   446				NL_SET_ERR_MSG_MOD(extack,
   447						   "reload is unsupported while VFs are allocated or being configured");
   448				rtnl_unlock();
   449				return -EOPNOTSUPP;
   450			}
   451			if (bp->dev->reg_state == NETREG_UNREGISTERED) {
   452				rtnl_unlock();
   453				return -ENODEV;
   454			}
   455			bnxt_ulp_stop(bp);
   456			if (netif_running(bp->dev)) {
   457				rc = bnxt_close_nic(bp, true, true);
   458				if (rc) {
   459					NL_SET_ERR_MSG_MOD(extack, "Failed to close");
   460					dev_close(bp->dev);
   461					rtnl_unlock();
   462					break;
   463				}
   464			}
   465			bnxt_vf_reps_free(bp);
   466			rc = bnxt_hwrm_func_drv_unrgtr(bp);
   467			if (rc) {
   468				NL_SET_ERR_MSG_MOD(extack, "Failed to deregister");
   469				if (netif_running(bp->dev))
   470					dev_close(bp->dev);
   471				rtnl_unlock();
   472				break;
   473			}
   474			bnxt_cancel_reservations(bp, false);
   475			bnxt_free_ctx_mem(bp);
   476			kfree(bp->ctx);
   477			bp->ctx = NULL;
   478			break;
   479		}
   480		case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: {
   481			if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
   482				return bnxt_dl_livepatch_activate(bp, extack);
   483			if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET) {
   484				NL_SET_ERR_MSG_MOD(extack, "Device not capable, requires reboot");
   485				return -EOPNOTSUPP;
   486			}
   487			if (!bnxt_hwrm_reset_permitted(bp)) {
   488				NL_SET_ERR_MSG_MOD(extack,
   489						   "Reset denied by firmware, it may be inhibited by remote driver");
   490				return -EPERM;
   491			}
   492			rtnl_lock();
   493			if (bp->dev->reg_state == NETREG_UNREGISTERED) {
   494				rtnl_unlock();
   495				return -ENODEV;
   496			}
   497			if (netif_running(bp->dev))
   498				set_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
   499			rc = bnxt_hwrm_firmware_reset(bp->dev,
   500						      FW_RESET_REQ_EMBEDDED_PROC_TYPE_CHIP,
   501						      FW_RESET_REQ_SELFRST_STATUS_SELFRSTASAP,
   502						      FW_RESET_REQ_FLAGS_RESET_GRACEFUL |
   503						      FW_RESET_REQ_FLAGS_FW_ACTIVATION);
   504			if (rc) {
   505				NL_SET_ERR_MSG_MOD(extack, "Failed to activate firmware");
   506				clear_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
   507				rtnl_unlock();
   508			}
   509			break;
   510		}
   511		default:
   512			rc = -EOPNOTSUPP;
   513		}
   514	
   515		return rc;
   516	}
   517	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37709 bytes --]

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5272 bytes --]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Bug-fixes/20211115-154005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 1aa3b2207e889a948049c9a8016cedb0218c2389
config: mips-randconfig-r031-20211115 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project fbe72e41b99dc7994daac300d208a955be3e4a0a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/b17bc036418692ffb8055b7cbcdff979ec378e37
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Chan/bnxt_en-Bug-fixes/20211115-154005
        git checkout b17bc036418692ffb8055b7cbcdff979ec378e37
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:363:62: warning: format specifies type 'char' but the argument has type 'int' [-Wformat]
                   netdev_err(bp->dev, "Unexpected live patch error: %hhd\n", err);
                                                                     ~~~~     ^~~
                                                                     %d
>> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:48: error: no member named 'sriov_cfg' in 'struct bnxt'
                   if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
                                                            ~~  ^
   1 warning and 1 error generated.


vim +445 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

   433	
   434	static int bnxt_dl_reload_down(struct devlink *dl, bool netns_change,
   435				       enum devlink_reload_action action,
   436				       enum devlink_reload_limit limit,
   437				       struct netlink_ext_ack *extack)
   438	{
   439		struct bnxt *bp = bnxt_get_bp_from_dl(dl);
   440		int rc = 0;
   441	
   442		switch (action) {
   443		case DEVLINK_RELOAD_ACTION_DRIVER_REINIT: {
   444			rtnl_lock();
 > 445			if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
   446				NL_SET_ERR_MSG_MOD(extack,
   447						   "reload is unsupported while VFs are allocated or being configured");
   448				rtnl_unlock();
   449				return -EOPNOTSUPP;
   450			}
   451			if (bp->dev->reg_state == NETREG_UNREGISTERED) {
   452				rtnl_unlock();
   453				return -ENODEV;
   454			}
   455			bnxt_ulp_stop(bp);
   456			if (netif_running(bp->dev)) {
   457				rc = bnxt_close_nic(bp, true, true);
   458				if (rc) {
   459					NL_SET_ERR_MSG_MOD(extack, "Failed to close");
   460					dev_close(bp->dev);
   461					rtnl_unlock();
   462					break;
   463				}
   464			}
   465			bnxt_vf_reps_free(bp);
   466			rc = bnxt_hwrm_func_drv_unrgtr(bp);
   467			if (rc) {
   468				NL_SET_ERR_MSG_MOD(extack, "Failed to deregister");
   469				if (netif_running(bp->dev))
   470					dev_close(bp->dev);
   471				rtnl_unlock();
   472				break;
   473			}
   474			bnxt_cancel_reservations(bp, false);
   475			bnxt_free_ctx_mem(bp);
   476			kfree(bp->ctx);
   477			bp->ctx = NULL;
   478			break;
   479		}
   480		case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: {
   481			if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
   482				return bnxt_dl_livepatch_activate(bp, extack);
   483			if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET) {
   484				NL_SET_ERR_MSG_MOD(extack, "Device not capable, requires reboot");
   485				return -EOPNOTSUPP;
   486			}
   487			if (!bnxt_hwrm_reset_permitted(bp)) {
   488				NL_SET_ERR_MSG_MOD(extack,
   489						   "Reset denied by firmware, it may be inhibited by remote driver");
   490				return -EPERM;
   491			}
   492			rtnl_lock();
   493			if (bp->dev->reg_state == NETREG_UNREGISTERED) {
   494				rtnl_unlock();
   495				return -ENODEV;
   496			}
   497			if (netif_running(bp->dev))
   498				set_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
   499			rc = bnxt_hwrm_firmware_reset(bp->dev,
   500						      FW_RESET_REQ_EMBEDDED_PROC_TYPE_CHIP,
   501						      FW_RESET_REQ_SELFRST_STATUS_SELFRSTASAP,
   502						      FW_RESET_REQ_FLAGS_RESET_GRACEFUL |
   503						      FW_RESET_REQ_FLAGS_FW_ACTIVATION);
   504			if (rc) {
   505				NL_SET_ERR_MSG_MOD(extack, "Failed to activate firmware");
   506				clear_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
   507				rtnl_unlock();
   508			}
   509			break;
   510		}
   511		default:
   512			rc = -EOPNOTSUPP;
   513		}
   514	
   515		return rc;
   516	}
   517	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37709 bytes --]

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[Jakub Kicinski]

On Tue, 16 Nov 2021 00:30:34 +0800 kernel test robot wrote:
> >> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:48: error: no member named 'sriov_cfg' in 'struct bnxt'  
>                    if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
>                                                             ~~  ^

Hi Michael, is this a false positive? Is the fix coming?

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[Jakub Kicinski]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

On Tue, 16 Nov 2021 00:30:34 +0800 kernel test robot wrote:
> >> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:48: error: no member named 'sriov_cfg' in 'struct bnxt'  
>                    if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
>                                                             ~~  ^

Hi Michael, is this a false positive? Is the fix coming?

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[Michael Chan]

On Tue, Nov 16, 2021 at 6:39 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 16 Nov 2021 00:30:34 +0800 kernel test robot wrote:
> > >> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:48: error: no member named 'sriov_cfg' in 'struct bnxt'
> >                    if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
> >                                                             ~~  ^
>
> Hi Michael, is this a false positive? Is the fix coming?

It's a real error when CONFIG_BNXT_SRIOV is not enabled.  I'll send
the fix later today.  Thanks.

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Tue, Nov 16, 2021 at 6:39 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 16 Nov 2021 00:30:34 +0800 kernel test robot wrote:
> > >> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:48: error: no member named 'sriov_cfg' in 'struct bnxt'
> >                    if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
> >                                                             ~~  ^
>
> Hi Michael, is this a false positive? Is the fix coming?

It's a real error when CONFIG_BNXT_SRIOV is not enabled.  I'll send
the fix later today.  Thanks.

Re: [PATCH net 1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4811 bytes --]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Bug-fixes/20211115-154005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 1aa3b2207e889a948049c9a8016cedb0218c2389
config: arm64-buildonly-randconfig-r003-20211115 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b17bc036418692ffb8055b7cbcdff979ec378e37
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Chan/bnxt_en-Bug-fixes/20211115-154005
        git checkout b17bc036418692ffb8055b7cbcdff979ec378e37
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/ethernet/broadcom/bnxt/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c: In function 'bnxt_dl_reload_down':
>> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:445:60: error: 'struct bnxt' has no member named 'sriov_cfg'
     445 |                 if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
         |                                                            ^~


vim +445 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

   433	
   434	static int bnxt_dl_reload_down(struct devlink *dl, bool netns_change,
   435				       enum devlink_reload_action action,
   436				       enum devlink_reload_limit limit,
   437				       struct netlink_ext_ack *extack)
   438	{
   439		struct bnxt *bp = bnxt_get_bp_from_dl(dl);
   440		int rc = 0;
   441	
   442		switch (action) {
   443		case DEVLINK_RELOAD_ACTION_DRIVER_REINIT: {
   444			rtnl_lock();
 > 445			if (BNXT_PF(bp) && (bp->pf.active_vfs || bp->sriov_cfg)) {
   446				NL_SET_ERR_MSG_MOD(extack,
   447						   "reload is unsupported while VFs are allocated or being configured");
   448				rtnl_unlock();
   449				return -EOPNOTSUPP;
   450			}
   451			if (bp->dev->reg_state == NETREG_UNREGISTERED) {
   452				rtnl_unlock();
   453				return -ENODEV;
   454			}
   455			bnxt_ulp_stop(bp);
   456			if (netif_running(bp->dev)) {
   457				rc = bnxt_close_nic(bp, true, true);
   458				if (rc) {
   459					NL_SET_ERR_MSG_MOD(extack, "Failed to close");
   460					dev_close(bp->dev);
   461					rtnl_unlock();
   462					break;
   463				}
   464			}
   465			bnxt_vf_reps_free(bp);
   466			rc = bnxt_hwrm_func_drv_unrgtr(bp);
   467			if (rc) {
   468				NL_SET_ERR_MSG_MOD(extack, "Failed to deregister");
   469				if (netif_running(bp->dev))
   470					dev_close(bp->dev);
   471				rtnl_unlock();
   472				break;
   473			}
   474			bnxt_cancel_reservations(bp, false);
   475			bnxt_free_ctx_mem(bp);
   476			kfree(bp->ctx);
   477			bp->ctx = NULL;
   478			break;
   479		}
   480		case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: {
   481			if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
   482				return bnxt_dl_livepatch_activate(bp, extack);
   483			if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET) {
   484				NL_SET_ERR_MSG_MOD(extack, "Device not capable, requires reboot");
   485				return -EOPNOTSUPP;
   486			}
   487			if (!bnxt_hwrm_reset_permitted(bp)) {
   488				NL_SET_ERR_MSG_MOD(extack,
   489						   "Reset denied by firmware, it may be inhibited by remote driver");
   490				return -EPERM;
   491			}
   492			rtnl_lock();
   493			if (bp->dev->reg_state == NETREG_UNREGISTERED) {
   494				rtnl_unlock();
   495				return -ENODEV;
   496			}
   497			if (netif_running(bp->dev))
   498				set_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
   499			rc = bnxt_hwrm_firmware_reset(bp->dev,
   500						      FW_RESET_REQ_EMBEDDED_PROC_TYPE_CHIP,
   501						      FW_RESET_REQ_SELFRST_STATUS_SELFRSTASAP,
   502						      FW_RESET_REQ_FLAGS_RESET_GRACEFUL |
   503						      FW_RESET_REQ_FLAGS_FW_ACTIVATION);
   504			if (rc) {
   505				NL_SET_ERR_MSG_MOD(extack, "Failed to activate firmware");
   506				clear_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
   507				rtnl_unlock();
   508			}
   509			break;
   510		}
   511		default:
   512			rc = -EOPNOTSUPP;
   513		}
   514	
   515		return rc;
   516	}
   517	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39263 bytes --]

Re: [PATCH net 0/3] bnxt_en: Bug fixes

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri,  5 Apr 2024 16:55:10 -0700 you wrote:
> The first 2 patches fix 2 potential issues in the aux bus initialization
> and error recovery paths.  The 3rd patch fixes a potential PTP TX
> timestamp issue during error recovery.
> 
> Pavan Chebbi (1):
>   bnxt_en: Reset PTP tx_avail after possible firmware reset
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Fix possible memory leak in bnxt_rdma_aux_device_init()
    https://git.kernel.org/netdev/net/c/7ac10c7d728d
  - [net,2/3] bnxt_en: Fix error recovery for RoCE ulp client
    https://git.kernel.org/netdev/net/c/b5ea7d33ba2a
  - [net,3/3] bnxt_en: Reset PTP tx_avail after possible firmware reset
    https://git.kernel.org/netdev/net/c/faa12ca24558

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net 0/3] bnxt_en: Bug fixes

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

The first 2 patches fix 2 potential issues in the aux bus initialization
and error recovery paths.  The 3rd patch fixes a potential PTP TX
timestamp issue during error recovery.

Pavan Chebbi (1):
  bnxt_en: Reset PTP tx_avail after possible firmware reset

Vikas Gupta (2):
  bnxt_en: Fix possible memory leak in bnxt_rdma_aux_device_init()
  bnxt_en: Fix error recovery for RoCE ulp client

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 2 ++
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.30.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH net 0/3] bnxt_en: Bug fixes

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  2 May 2022 21:13:09 -0400 you wrote:
> This patch series includes 3 fixes:
> 
> 1. Fix an occasional VF open failure.
> 2. Fix a PTP spinlock usage before initialization
> 3. Fix unnecesary RX packet drops under high TX traffic load.
> 
> Michael Chan (2):
>   bnxt_en: Initiallize bp->ptp_lock first before using it
>   bnxt_en: Fix unnecessary dropping of RX packets
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Fix possible bnxt_open() failure caused by wrong RFS flag
    https://git.kernel.org/netdev/net/c/13ba794397e4
  - [net,2/3] bnxt_en: Initiallize bp->ptp_lock first before using it
    https://git.kernel.org/netdev/net/c/2b156fb57d8f
  - [net,3/3] bnxt_en: Fix unnecessary dropping of RX packets
    https://git.kernel.org/netdev/net/c/195af57914d1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net 0/3] bnxt_en: Bug fixes

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

This patch series includes 3 fixes:

1. Fix an occasional VF open failure.
2. Fix a PTP spinlock usage before initialization
3. Fix unnecesary RX packet drops under high TX traffic load. 

Michael Chan (2):
  bnxt_en: Initiallize bp->ptp_lock first before using it
  bnxt_en: Fix unnecessary dropping of RX packets

Somnath Kotur (1):
  bnxt_en: Fix possible bnxt_open() failure caused by wrong RFS flag

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 13 ++++++++-----
 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 15 +++++++--------
 2 files changed, 15 insertions(+), 13 deletions(-)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Sun, 12 Sep 2021 12:34:46 -0400 you wrote:
> The first patch fixes an error recovery regression just introduced
> about a week ago.  The other two patches fix issues related to
> freeing rings in the bnxt_close() path under error conditions.
> 
> Edwin Peer (1):
>   bnxt_en: make bnxt_free_skbs() safe to call after bnxt_free_mem()
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Fix error recovery regression
    https://git.kernel.org/netdev/net/c/eca4cf12acda
  - [net,2/3] bnxt_en: make bnxt_free_skbs() safe to call after bnxt_free_mem()
    https://git.kernel.org/netdev/net/c/1affc01fdc60
  - [net,3/3] bnxt_en: Clean up completion ring page arrays completely
    https://git.kernel.org/netdev/net/c/985941e1dd5e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

The first patch fixes an error recovery regression just introduced
about a week ago.  The other two patches fix issues related to
freeing rings in the bnxt_close() path under error conditions.

Edwin Peer (1):
  bnxt_en: make bnxt_free_skbs() safe to call after bnxt_free_mem()

Michael Chan (2):
  bnxt_en: Fix error recovery regression
  bnxt_en: Clean up completion ring page arrays completely

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 33 ++++++++++++++++++++---
 1 file changed, 29 insertions(+), 4 deletions(-)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH net 0/3] bnxt_en: Bug fixes

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 18 Jun 2021 02:07:24 -0400 you wrote:
> This patchset includes 3 small bug fixes to reinitialize PHY capabilities
> after firmware reset, setup the chip's internal TQM fastpath ring
> backing memory properly for RoCE traffic, and to free ethtool related
> memory if driver probe fails.
> 
> Michael Chan (1):
>   bnxt_en: Rediscover PHY capabilities after firmware reset
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Rediscover PHY capabilities after firmware reset
    https://git.kernel.org/netdev/net/c/0afd6a4e8028
  - [net,2/3] bnxt_en: Fix TQM fastpath ring backing store computation
    https://git.kernel.org/netdev/net/c/c12e1643d273
  - [net,3/3] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path
    https://git.kernel.org/netdev/net/c/03400aaa69f9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net 0/3] bnxt_en: Bug fixes

[Michael Chan]

This patchset includes 3 small bug fixes to reinitialize PHY capabilities
after firmware reset, setup the chip's internal TQM fastpath ring
backing memory properly for RoCE traffic, and to free ethtool related
memory if driver probe fails.

Michael Chan (1):
  bnxt_en: Rediscover PHY capabilities after firmware reset

Rukhsana Ansari (1):
  bnxt_en: Fix TQM fastpath ring backing store computation

Somnath Kotur (1):
  bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.18.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon, 25 May 2020 17:41:16 -0400

> 3 bnxt_en driver fixes, covering a bug in preserving the counters during
> some resets, proper error code when flashing NVRAM fails, and an
> endian bug when extracting the firmware response message length.

Series applied.

> Please also queue these for -stable.  Thanks.

Queued up.

Thanks.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

3 bnxt_en driver fixes, covering a bug in preserving the counters during
some resets, proper error code when flashing NVRAM fails, and an
endian bug when extracting the firmware response message length.

Please also queue these for -stable.  Thanks.

Edwin Peer (1):
  bnxt_en: fix firmware message length endianness

Michael Chan (1):
  bnxt_en: Fix accumulation of bp->net_stats_prev.

Vasundhara Volam (1):
  bnxt_en: Fix return code to "flash_device".

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 16 +++++-----------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  5 -----
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  9 +++++----
 3 files changed, 10 insertions(+), 20 deletions(-)

-- 
2.5.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan <michael.chan@broadcom.com>
Date: Fri, 17 Jan 2020 00:32:44 -0500

> 3 small bug fix patches.  The 1st two are aRFS fixes and the last one
> fixes a fatal driver load failure on some kernels without PCIe
> extended config space support enabled.

Applied.

> Please also queue these for -stable.  Thanks.

Done.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

3 small bug fix patches.  The 1st two are aRFS fixes and the last one
fixes a fatal driver load failure on some kernels without PCIe
extended config space support enabled.

Please also queue these for -stable.  Thanks.

Michael Chan (3):
  bnxt_en: Fix NTUPLE firmware command failures.
  bnxt_en: Fix ipv6 RFS filter matching logic.
  bnxt_en: Do not treat DSN (Digital Serial Number) read failure as
    fatal.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 29 ++++++++++++++++++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  4 +---
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c |  3 +++
 3 files changed, 24 insertions(+), 12 deletions(-)

-- 
2.5.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

On Mon, Sep 3, 2018 at 10:50 PM, Michael Chan <michael.chan@broadcom.com> wrote:
> On Mon, Sep 3, 2018 at 10:01 PM, David Miller <davem@davemloft.net> wrote:
>>
>> From: Michael Chan <michael.chan@broadcom.com>
>> Date: Mon,  3 Sep 2018 04:23:16 -0400
>>
>> > This short series fixes resource related logic in the driver, mostly
>> > affecting the RDMA driver under corner cases.
>>
>> Series applied, thanks Michael.
>>
>> Do you want patch #3 queued up for -stable?
>
> Yes, please go ahead.  Thanks.

But there is a dependency on patch #2 though.  So #2 needs to be queued as well.

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

On Mon, Sep 3, 2018 at 10:01 PM, David Miller <davem@davemloft.net> wrote:
>
> From: Michael Chan <michael.chan@broadcom.com>
> Date: Mon,  3 Sep 2018 04:23:16 -0400
>
> > This short series fixes resource related logic in the driver, mostly
> > affecting the RDMA driver under corner cases.
>
> Series applied, thanks Michael.
>
> Do you want patch #3 queued up for -stable?

Yes, please go ahead.  Thanks.

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon,  3 Sep 2018 04:23:16 -0400

> This short series fixes resource related logic in the driver, mostly
> affecting the RDMA driver under corner cases.

Series applied, thanks Michael.

Do you want patch #3 queued up for -stable?

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

This short series fixes resource related logic in the driver, mostly
affecting the RDMA driver under corner cases.

Michael Chan (3):
  bnxt_en: Fix firmware signaled resource change logic in open.
  bnxt_en: Clean up unused functions.
  bnxt_en: Do not adjust max_cp_rings by the ones used by RDMA.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c       | 22 +++++++++++++++-------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h       |  3 +--
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c |  7 ++++---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c   | 20 --------------------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h   |  1 -
 5 files changed, 20 insertions(+), 33 deletions(-)

-- 
2.5.1

Re: [PATCH net 0/3] bnxt_en: bug fixes.

[David Miller]

From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 23 Aug 2017 19:34:02 -0400

> 3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing
> MSIX vectors when bnxt_re unregisters, and preserving the user-administered
> PF MAC address when disabling SRIOV.

Series applied, thanks.

[PATCH net 0/3] bnxt_en: bug fixes.

[Michael Chan]

3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing
MSIX vectors when bnxt_re unregisters, and preserving the user-administered
PF MAC address when disabling SRIOV.

Michael Chan (3):
  bnxt_en: Fix .ndo_setup_tc() to include XDP rings.
  bnxt_en: Free MSIX vectors when unregistering the device from bnxt_re.
  bnxt_en: Do not setup MAC address in bnxt_hwrm_func_qcaps().

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 41 +++++++++++++++++++--------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  2 ++
 2 files changed, 31 insertions(+), 12 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan <michael.chan@broadcom.com>
Date: Tue, 11 Jul 2017 13:05:33 -0400

> 3 bug fixes in this series.  Fix a crash in bnxt_get_stats64() that can
> happen if the device is closing and freeing the statistics block at the
> same time.  The 2nd one fixes ethtool -L failing when changing from
> combined to non-combined mode or vice versa.  The last one fixes SRIOV
> failure on big-endian systems because we were setting a bitmap wrong in
> a firmware message.

Series applied, thanks Michael.

We really should look into generically taking care of the ->ndo_close()
vs. statistics pulling synchronization so that every driver doesn't
need to have code like this.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

3 bug fixes in this series.  Fix a crash in bnxt_get_stats64() that can
happen if the device is closing and freeing the statistics block at the
same time.  The 2nd one fixes ethtool -L failing when changing from
combined to non-combined mode or vice versa.  The last one fixes SRIOV
failure on big-endian systems because we were setting a bitmap wrong in
a firmware message.

Michael Chan (3):
  bnxt_en: Fix race conditions in .ndo_get_stats64().
  bnxt_en: Fix bug in ethtool -L.
  bnxt_en: Fix SRIOV on big-endian architecture.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 42 ++++++++++++++++-------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  4 ++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  3 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c     |  2 +-
 4 files changed, 35 insertions(+), 16 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon,  6 Jun 2016 02:37:13 -0400

> Fix a race condition and VLAN rx acceleration logic.

Series applied.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

Fix a race condition and VLAN rx acceleration logic.

Michael Chan (3):
  bnxt_en: Fix tx push race condition.
  bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration
    together.
  bnxt_en: Simplify VLAN receive logic.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 47 +++++++++++++++++--------------
 1 file changed, 26 insertions(+), 21 deletions(-)

-- 
1.8.3.1

Re: [PATCH net 0/3] bnxt_en: Bug fixes.

[David Miller]

From: Michael Chan <mchan@broadcom.com>
Date: Thu, 28 Jan 2016 03:11:19 -0500

> 3 small bug fix patches for net.

Series applied, thanks Michael.

[PATCH net 0/3] bnxt_en: Bug fixes.

[Michael Chan]

3 small bug fix patches for net.

Michael Chan (3):
  bnxt_en: Ring free response from close path should use completion ring
  bnxt_en: Exclude rx_drop_pkts hw counter from the stack's rx_dropped
    counter.
  bnxt_en: Fix crash in bnxt_free_tx_skbs() during tx timeout.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
1.8.3.1