* [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled
@ 2021-12-01 8:58 ` Bixuan Cui
0 siblings, 0 replies; 4+ messages in thread
From: Bixuan Cui @ 2021-12-01 8:58 UTC (permalink / raw)
To: alsa-devel, linux-kernel; +Cc: cuibixuan, perex, tiwai
Fix compile error when OSS_DEBUG is enabled:
sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
use in this function); did you mean 'csubstream'?
pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
^
Fixes: 61efcee8608c ("ALSA: oss: Use standard printk helpers")
Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
---
sound/core/oss/pcm_oss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index 82a8187..bb37665 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -2052,7 +2052,7 @@ static int snd_pcm_oss_set_trigger(struct snd_pcm_oss_file *pcm_oss_file, int tr
int err, cmd;
#ifdef OSS_DEBUG
- pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
+ pr_debug("pcm_oss: trigger = 0x%x\n", trigger);
#endif
psubstream = pcm_oss_file->streams[SNDRV_PCM_STREAM_PLAYBACK];
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled
@ 2021-12-01 8:58 ` Bixuan Cui
0 siblings, 0 replies; 4+ messages in thread
From: Bixuan Cui @ 2021-12-01 8:58 UTC (permalink / raw)
To: alsa-devel, linux-kernel; +Cc: cuibixuan, tiwai
Fix compile error when OSS_DEBUG is enabled:
sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
use in this function); did you mean 'csubstream'?
pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
^
Fixes: 61efcee8608c ("ALSA: oss: Use standard printk helpers")
Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
---
sound/core/oss/pcm_oss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index 82a8187..bb37665 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -2052,7 +2052,7 @@ static int snd_pcm_oss_set_trigger(struct snd_pcm_oss_file *pcm_oss_file, int tr
int err, cmd;
#ifdef OSS_DEBUG
- pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
+ pr_debug("pcm_oss: trigger = 0x%x\n", trigger);
#endif
psubstream = pcm_oss_file->streams[SNDRV_PCM_STREAM_PLAYBACK];
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled
2021-12-01 8:58 ` Bixuan Cui
@ 2021-12-01 9:32 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-12-01 9:32 UTC (permalink / raw)
To: Bixuan Cui; +Cc: alsa-devel, linux-kernel, perex, tiwai
On Wed, 01 Dec 2021 09:58:54 +0100,
Bixuan Cui wrote:
>
> Fix compile error when OSS_DEBUG is enabled:
> sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
> sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
> use in this function); did you mean 'csubstream'?
> pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
> ^
>
> Fixes: 61efcee8608c ("ALSA: oss: Use standard printk helpers")
> Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled
@ 2021-12-01 9:32 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-12-01 9:32 UTC (permalink / raw)
To: Bixuan Cui; +Cc: alsa-devel, tiwai, linux-kernel
On Wed, 01 Dec 2021 09:58:54 +0100,
Bixuan Cui wrote:
>
> Fix compile error when OSS_DEBUG is enabled:
> sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
> sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
> use in this function); did you mean 'csubstream'?
> pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
> ^
>
> Fixes: 61efcee8608c ("ALSA: oss: Use standard printk helpers")
> Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-01 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 8:58 [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled Bixuan Cui
2021-12-01 8:58 ` Bixuan Cui
2021-12-01 9:32 ` Takashi Iwai
2021-12-01 9:32 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.