* [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml
@ 2021-11-30 21:16 Ansuel Smith
2021-11-30 21:16 ` [net-next PATCH v2 2/2] dt-bindings: net: dsa: qca8k: improve port definition documentation Ansuel Smith
2021-12-02 12:10 ` [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Ansuel Smith @ 2021-11-30 21:16 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Rob Herring, John Crispin,
netdev, devicetree, linux-kernel
Cc: Ansuel Smith, Rob Herring
Some switch may require to add additional binding to the node port.
Move DSA generic port definition to a dedicated yaml to permit this.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/net/dsa/dsa-port.yaml | 77 +++++++++++++++++++
.../devicetree/bindings/net/dsa/dsa.yaml | 60 +--------------
2 files changed, 79 insertions(+), 58 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
new file mode 100644
index 000000000000..702df848a71d
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/dsa/dsa-port.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ethernet Switch port Device Tree Bindings
+
+maintainers:
+ - Andrew Lunn <andrew@lunn.ch>
+ - Florian Fainelli <f.fainelli@gmail.com>
+ - Vivien Didelot <vivien.didelot@gmail.com>
+
+description:
+ Ethernet switch port Description
+
+allOf:
+ - $ref: "http://devicetree.org/schemas/net/ethernet-controller.yaml#"
+
+properties:
+ reg:
+ description: Port number
+
+ label:
+ description:
+ Describes the label associated with this port, which will become
+ the netdev name
+ $ref: /schemas/types.yaml#/definitions/string
+
+ link:
+ description:
+ Should be a list of phandles to other switch's DSA port. This
+ port is used as the outgoing port towards the phandle ports. The
+ full routing information must be given, not just the one hop
+ routes to neighbouring switches
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+
+ ethernet:
+ description:
+ Should be a phandle to a valid Ethernet device node. This host
+ device is what the switch port is connected to
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ dsa-tag-protocol:
+ description:
+ Instead of the default, the switch will use this tag protocol if
+ possible. Useful when a device supports multiple protocols and
+ the default is incompatible with the Ethernet device.
+ enum:
+ - dsa
+ - edsa
+ - ocelot
+ - ocelot-8021q
+ - seville
+
+ phy-handle: true
+
+ phy-mode: true
+
+ fixed-link: true
+
+ mac-address: true
+
+ sfp: true
+
+ managed: true
+
+ rx-internal-delay-ps: true
+
+ tx-internal-delay-ps: true
+
+required:
+ - reg
+
+additionalProperties: true
+
+...
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index 2ad7f79ad371..b9d48e357e77 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
@@ -46,65 +46,9 @@ patternProperties:
type: object
description: Ethernet switch ports
- allOf:
- - $ref: "http://devicetree.org/schemas/net/ethernet-controller.yaml#"
+ $ref: dsa-port.yaml#
- properties:
- reg:
- description: Port number
-
- label:
- description:
- Describes the label associated with this port, which will become
- the netdev name
- $ref: /schemas/types.yaml#/definitions/string
-
- link:
- description:
- Should be a list of phandles to other switch's DSA port. This
- port is used as the outgoing port towards the phandle ports. The
- full routing information must be given, not just the one hop
- routes to neighbouring switches
- $ref: /schemas/types.yaml#/definitions/phandle-array
-
- ethernet:
- description:
- Should be a phandle to a valid Ethernet device node. This host
- device is what the switch port is connected to
- $ref: /schemas/types.yaml#/definitions/phandle
-
- dsa-tag-protocol:
- description:
- Instead of the default, the switch will use this tag protocol if
- possible. Useful when a device supports multiple protocols and
- the default is incompatible with the Ethernet device.
- enum:
- - dsa
- - edsa
- - ocelot
- - ocelot-8021q
- - seville
-
- phy-handle: true
-
- phy-mode: true
-
- fixed-link: true
-
- mac-address: true
-
- sfp: true
-
- managed: true
-
- rx-internal-delay-ps: true
-
- tx-internal-delay-ps: true
-
- required:
- - reg
-
- additionalProperties: false
+ unevaluatedProperties: false
oneOf:
- required:
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [net-next PATCH v2 2/2] dt-bindings: net: dsa: qca8k: improve port definition documentation
2021-11-30 21:16 [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml Ansuel Smith
@ 2021-11-30 21:16 ` Ansuel Smith
2021-12-02 12:10 ` [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ansuel Smith @ 2021-11-30 21:16 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Rob Herring, John Crispin,
netdev, devicetree, linux-kernel
Cc: Ansuel Smith, Rob Herring
Clean and improve port definition for qca8k documentation by referencing
the dsa generic port definition and adding the additional specific port
definition.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/net/dsa/qca8k.yaml | 40 ++-----------------
1 file changed, 3 insertions(+), 37 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
index 48de0ace265d..89c21b289447 100644
--- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
@@ -99,40 +99,9 @@ patternProperties:
type: object
description: Ethernet switch ports
- properties:
- reg:
- description: Port number
-
- label:
- description:
- Describes the label associated with this port, which will become
- the netdev name
- $ref: /schemas/types.yaml#/definitions/string
-
- link:
- description:
- Should be a list of phandles to other switch's DSA port. This
- port is used as the outgoing port towards the phandle ports. The
- full routing information must be given, not just the one hop
- routes to neighbouring switches
- $ref: /schemas/types.yaml#/definitions/phandle-array
-
- ethernet:
- description:
- Should be a phandle to a valid Ethernet device node. This host
- device is what the switch port is connected to
- $ref: /schemas/types.yaml#/definitions/phandle
-
- phy-handle: true
-
- phy-mode: true
-
- fixed-link: true
-
- mac-address: true
-
- sfp: true
+ $ref: dsa-port.yaml#
+ properties:
qca,sgmii-rxclk-falling-edge:
$ref: /schemas/types.yaml#/definitions/flag
description:
@@ -154,10 +123,7 @@ patternProperties:
SGMII on the QCA8337, it is advised to set this unless a communication
issue is observed.
- required:
- - reg
-
- additionalProperties: false
+ unevaluatedProperties: false
oneOf:
- required:
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml
2021-11-30 21:16 [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml Ansuel Smith
2021-11-30 21:16 ` [net-next PATCH v2 2/2] dt-bindings: net: dsa: qca8k: improve port definition documentation Ansuel Smith
@ 2021-12-02 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-02 12:10 UTC (permalink / raw)
To: Ansuel Smith
Cc: andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba,
robh+dt, john, netdev, devicetree, linux-kernel, robh
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 30 Nov 2021 22:16:24 +0100 you wrote:
> Some switch may require to add additional binding to the node port.
> Move DSA generic port definition to a dedicated yaml to permit this.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/net/dsa/dsa-port.yaml | 77 +++++++++++++++++++
> .../devicetree/bindings/net/dsa/dsa.yaml | 60 +--------------
> 2 files changed, 79 insertions(+), 58 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
Here is the summary with links:
- [net-next,v2,1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml
https://git.kernel.org/netdev/net-next/c/75c990154479
- [net-next,v2,2/2] dt-bindings: net: dsa: qca8k: improve port definition documentation
https://git.kernel.org/netdev/net-next/c/dfb40cba6d45
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-02 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 21:16 [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml Ansuel Smith
2021-11-30 21:16 ` [net-next PATCH v2 2/2] dt-bindings: net: dsa: qca8k: improve port definition documentation Ansuel Smith
2021-12-02 12:10 ` [net-next PATCH v2 1/2] dt-bindings: net: dsa: split generic port definition from dsa.yaml patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.