* [PATCH 1/2] ASoC: amd: Fix dependency for SPI master
@ 2021-12-01 17:43 ` Lucas Tanure
0 siblings, 0 replies; 8+ messages in thread
From: Lucas Tanure @ 2021-12-01 17:43 UTC (permalink / raw)
To: Len Brown, Takashi Iwai, Liam Girdwood, Jaroslav Kysela, Mark Brown
Cc: alsa-devel, patches, linux-kernel, Lucas Tanure, kernel test robot
Select SPI_MASTER as is using CS35L41 SPI driver
Fixes: 96792fdd77cd1 ("ASoC: amd: enable vangogh platform machine driver build")
Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Reported-by: kernel test robot <lkp@intel.com>
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 092966ff5ea7..8961b8fd23eb 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH
tristate "AMD Vangogh support for NAU8821 CS35L41"
select SND_SOC_NAU8821
select SND_SOC_CS35L41_SPI
- depends on SND_SOC_AMD_ACP5x && I2C
+ depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
help
This option enables machine driver for Vangogh platform
using NAU8821 and CS35L41 codecs.
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ASoC: amd: Fix dependency for SPI master
@ 2021-12-01 17:43 ` Lucas Tanure
0 siblings, 0 replies; 8+ messages in thread
From: Lucas Tanure @ 2021-12-01 17:43 UTC (permalink / raw)
To: Len Brown, Takashi Iwai, Liam Girdwood, Jaroslav Kysela, Mark Brown
Cc: patches, alsa-devel, linux-kernel, Lucas Tanure, kernel test robot
Select SPI_MASTER as is using CS35L41 SPI driver
Fixes: 96792fdd77cd1 ("ASoC: amd: enable vangogh platform machine driver build")
Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Reported-by: kernel test robot <lkp@intel.com>
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 092966ff5ea7..8961b8fd23eb 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH
tristate "AMD Vangogh support for NAU8821 CS35L41"
select SND_SOC_NAU8821
select SND_SOC_CS35L41_SPI
- depends on SND_SOC_AMD_ACP5x && I2C
+ depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
help
This option enables machine driver for Vangogh platform
using NAU8821 and CS35L41 codecs.
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ASoC: cs35l41: Fix undefined reference to core functions
2021-12-01 17:43 ` Lucas Tanure
@ 2021-12-01 17:43 ` Lucas Tanure
-1 siblings, 0 replies; 8+ messages in thread
From: Lucas Tanure @ 2021-12-01 17:43 UTC (permalink / raw)
To: Len Brown, Takashi Iwai, Liam Girdwood, Jaroslav Kysela, Mark Brown
Cc: alsa-devel, patches, linux-kernel, Lucas Tanure, kernel test robot
Auto select core driver if i2c or spi bus drivers are
selected
Fixes: a5e0091d62ab ("ASoC: cs35l41: Fix link problem")
Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Reported-by: kernel test robot <lkp@intel.com>
---
sound/soc/codecs/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index b4f70e27342c..c033ee7d82e4 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -614,17 +614,19 @@ config SND_SOC_CS35L36
config SND_SOC_CS35L41
tristate
+ default y if SND_SOC_CS35L41_SPI=y
+ default y if SND_SOC_CS35L41_I2C=y
+ default m if SND_SOC_CS35L41_SPI=m
+ default m if SND_SOC_CS35L41_I2C=m
config SND_SOC_CS35L41_SPI
tristate "Cirrus Logic CS35L41 CODEC (SPI)"
depends on SPI_MASTER
- select SND_SOC_CS35L41
select REGMAP_SPI
config SND_SOC_CS35L41_I2C
tristate "Cirrus Logic CS35L41 CODEC (I2C)"
depends on I2C
- select SND_SOC_CS35L41
select REGMAP_I2C
config SND_SOC_CS42L42
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ASoC: cs35l41: Fix undefined reference to core functions
@ 2021-12-01 17:43 ` Lucas Tanure
0 siblings, 0 replies; 8+ messages in thread
From: Lucas Tanure @ 2021-12-01 17:43 UTC (permalink / raw)
To: Len Brown, Takashi Iwai, Liam Girdwood, Jaroslav Kysela, Mark Brown
Cc: patches, alsa-devel, linux-kernel, Lucas Tanure, kernel test robot
Auto select core driver if i2c or spi bus drivers are
selected
Fixes: a5e0091d62ab ("ASoC: cs35l41: Fix link problem")
Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Reported-by: kernel test robot <lkp@intel.com>
---
sound/soc/codecs/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index b4f70e27342c..c033ee7d82e4 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -614,17 +614,19 @@ config SND_SOC_CS35L36
config SND_SOC_CS35L41
tristate
+ default y if SND_SOC_CS35L41_SPI=y
+ default y if SND_SOC_CS35L41_I2C=y
+ default m if SND_SOC_CS35L41_SPI=m
+ default m if SND_SOC_CS35L41_I2C=m
config SND_SOC_CS35L41_SPI
tristate "Cirrus Logic CS35L41 CODEC (SPI)"
depends on SPI_MASTER
- select SND_SOC_CS35L41
select REGMAP_SPI
config SND_SOC_CS35L41_I2C
tristate "Cirrus Logic CS35L41 CODEC (I2C)"
depends on I2C
- select SND_SOC_CS35L41
select REGMAP_I2C
config SND_SOC_CS42L42
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master
2021-12-01 17:43 ` Lucas Tanure
@ 2021-12-01 17:49 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2021-12-01 17:49 UTC (permalink / raw)
To: Lucas Tanure
Cc: Len Brown, Takashi Iwai, Liam Girdwood, Jaroslav Kysela,
alsa-devel, patches, linux-kernel, kernel test robot
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
On Wed, Dec 01, 2021 at 05:43:06PM +0000, Lucas Tanure wrote:
> Select SPI_MASTER as is using CS35L41 SPI driver
> - depends on SND_SOC_AMD_ACP5x && I2C
> + depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
This is a depends not a select (which is good, a select wouldn't be
appropriate here).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master
@ 2021-12-01 17:49 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2021-12-01 17:49 UTC (permalink / raw)
To: Lucas Tanure
Cc: alsa-devel, kernel test robot, patches, Takashi Iwai,
Liam Girdwood, linux-kernel, Len Brown
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
On Wed, Dec 01, 2021 at 05:43:06PM +0000, Lucas Tanure wrote:
> Select SPI_MASTER as is using CS35L41 SPI driver
> - depends on SND_SOC_AMD_ACP5x && I2C
> + depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
This is a depends not a select (which is good, a select wouldn't be
appropriate here).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master
2021-12-01 17:43 ` Lucas Tanure
@ 2021-12-02 13:40 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2021-12-02 13:40 UTC (permalink / raw)
To: Lucas Tanure, Takashi Iwai, Jaroslav Kysela, Len Brown, Liam Girdwood
Cc: linux-kernel, kernel test robot, alsa-devel, patches
On Wed, 1 Dec 2021 17:43:06 +0000, Lucas Tanure wrote:
> Select SPI_MASTER as is using CS35L41 SPI driver
>
> Fixes: 96792fdd77cd1 ("ASoC: amd: enable vangogh platform machine driver build")
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: amd: Fix dependency for SPI master
commit: 19a628d8f1a6c16263d8037a918427207c8a95a0
[2/2] ASoC: cs35l41: Fix undefined reference to core functions
commit: 0695ad92fe1a0bb7697eb92c6a145a73c5ab0e24
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ASoC: amd: Fix dependency for SPI master
@ 2021-12-02 13:40 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2021-12-02 13:40 UTC (permalink / raw)
To: Lucas Tanure, Takashi Iwai, Jaroslav Kysela, Len Brown, Liam Girdwood
Cc: patches, alsa-devel, linux-kernel, kernel test robot
On Wed, 1 Dec 2021 17:43:06 +0000, Lucas Tanure wrote:
> Select SPI_MASTER as is using CS35L41 SPI driver
>
> Fixes: 96792fdd77cd1 ("ASoC: amd: enable vangogh platform machine driver build")
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: amd: Fix dependency for SPI master
commit: 19a628d8f1a6c16263d8037a918427207c8a95a0
[2/2] ASoC: cs35l41: Fix undefined reference to core functions
commit: 0695ad92fe1a0bb7697eb92c6a145a73c5ab0e24
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-12-02 13:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 17:43 [PATCH 1/2] ASoC: amd: Fix dependency for SPI master Lucas Tanure
2021-12-01 17:43 ` Lucas Tanure
2021-12-01 17:43 ` [PATCH 2/2] ASoC: cs35l41: Fix undefined reference to core functions Lucas Tanure
2021-12-01 17:43 ` Lucas Tanure
2021-12-01 17:49 ` [PATCH 1/2] ASoC: amd: Fix dependency for SPI master Mark Brown
2021-12-01 17:49 ` Mark Brown
2021-12-02 13:40 ` Mark Brown
2021-12-02 13:40 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.