* [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences
@ 2021-12-03 6:32 Pallavi Mishra
2021-12-03 8:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix possible null ptr dereferences (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Pallavi Mishra @ 2021-12-03 6:32 UTC (permalink / raw)
To: intel-gfx, thomas.hellstrom; +Cc: Pallavi Mishra
add null ptr checks to prevent crash/exceptions.
Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 218a9b3037c7..997fe73c205b 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -906,6 +906,8 @@ vm_access_ttm(struct vm_area_struct *area, unsigned long addr,
struct drm_i915_gem_object *obj =
i915_ttm_to_gem(area->vm_private_data);
+ GEM_BUG_ON(!obj);
+
if (i915_gem_object_is_readonly(obj) && write)
return -EACCES;
@@ -966,6 +968,7 @@ static const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = {
void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)
{
struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
+ GEM_BUG_ON(!obj);
i915_gem_object_release_memory_region(obj);
mutex_destroy(&obj->ttm.get_io_page.lock);
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
index 80df9f592407..2b684903a9f5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
@@ -371,6 +371,7 @@ int i915_ttm_move_notify(struct ttm_buffer_object *bo)
struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
int ret;
+ GEM_BUG_ON(!obj);
ret = i915_gem_object_unbind(obj, I915_GEM_OBJECT_UNBIND_ACTIVE);
if (ret)
return ret;
@@ -506,7 +507,7 @@ static void i915_ttm_memcpy_init(struct i915_ttm_memcpy_arg *arg,
dst_reg = i915_ttm_region(bo->bdev, dst_mem->mem_type);
src_reg = i915_ttm_region(bo->bdev, bo->resource->mem_type);
- GEM_BUG_ON(!dst_reg || !src_reg);
+ GEM_BUG_ON(!dst_reg || !src_reg || !obj);
arg->dst_iter = !i915_ttm_cpu_maps_iomem(dst_mem) ?
ttm_kmap_iter_tt_init(&arg->_dst_iter.tt, dst_ttm) :
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix possible null ptr dereferences (rev2)
2021-12-03 6:32 [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Pallavi Mishra
@ 2021-12-03 8:20 ` Patchwork
2021-12-03 10:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-03 11:02 ` [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Ville Syrjälä
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-12-03 8:20 UTC (permalink / raw)
To: Pallavi Mishra; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4755 bytes --]
== Series Details ==
Series: drm/i915: Fix possible null ptr dereferences (rev2)
URL : https://patchwork.freedesktop.org/series/97496/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10958 -> Patchwork_21737
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/index.html
Participating hosts (39 -> 33)
------------------------------
Additional (1): fi-icl-u2
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-pnv-d510 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21737 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@amdgpu/amd_cs_nop@fork-gfx0.html
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([fdo#109278]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([fdo#109285])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([i915#3301])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-icl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][8] ([i915#4269]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][10] ([i915#295]) -> [PASS][11] +12 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
Build changes
-------------
* Linux: CI_DRM_10958 -> Patchwork_21737
CI-20190529: 20190529
CI_DRM_10958: df70f2f759f511a174efaf65212bf005fc259be9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6299: 0933b7ccdb2bb054b6a8154171e35315d84299b7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21737: c0625dd8cba773924958e278ce4fb3a2fcfafa66 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c0625dd8cba7 drm/i915: Fix possible null ptr dereferences
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/index.html
[-- Attachment #2: Type: text/html, Size: 5393 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix possible null ptr dereferences (rev2)
2021-12-03 6:32 [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Pallavi Mishra
2021-12-03 8:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix possible null ptr dereferences (rev2) Patchwork
@ 2021-12-03 10:58 ` Patchwork
2021-12-03 11:02 ` [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Ville Syrjälä
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-12-03 10:58 UTC (permalink / raw)
To: Pallavi Mishra; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30274 bytes --]
== Series Details ==
Series: drm/i915: Fix possible null ptr dereferences (rev2)
URL : https://patchwork.freedesktop.org/series/97496/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10958_full -> Patchwork_21737_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_21737_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-apl: ([FAIL][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#4386]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl1/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl1/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl2/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl2/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl3/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl3/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl3/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl3/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl4/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl4/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl4/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl8/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl8/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl8/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl8/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl1/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl6/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl8/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl8/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl8/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#1099])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-snb2/igt@gem_ctx_persistence@engines-mixed-process.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][52] -> [INCOMPLETE][53] ([i915#4547])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-skl4/igt@gem_exec_capture@pi@rcs0.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl6/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][54] ([i915#2842])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][55] -> [FAIL][56] ([i915#2842])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][57] -> [SKIP][58] ([fdo#109271]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [PASS][59] -> [FAIL][60] ([i915#2842]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][61] -> [FAIL][62] ([i915#2849])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#112283])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb5/igt@gem_exec_params@secure-non-master.html
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#112283])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@gem_exec_params@secure-non-master.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@parallel-random:
- shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl1/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#4613])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][68] ([i915#3002])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@gem_userptr_blits@input-checking.html
- shard-iclb: NOTRUN -> [DMESG-WARN][69] ([i915#3002])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@gem_userptr_blits@input-checking.html
* igt@gen7_exec_parse@basic-allocation:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109289])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@gen7_exec_parse@basic-allocation.html
* igt@i915_selftest@live@execlists:
- shard-skl: [PASS][71] -> [INCOMPLETE][72] ([i915#198] / [i915#4547])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-skl4/igt@i915_selftest@live@execlists.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl2/igt@i915_selftest@live@execlists.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: NOTRUN -> [INCOMPLETE][73] ([i915#3614])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl2/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3777])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][75] ([i915#3743]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-snb: NOTRUN -> [SKIP][76] ([fdo#109271]) +57 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-snb2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#3777]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3777])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3689]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb6/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#3886]) +6 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109278] / [i915#3886])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886]) +3 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl3/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3886]) +11 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl9/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271] / [fdo#111827])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-glk5/igt@kms_chamelium@dp-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +18 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl1/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][86] ([fdo#109271] / [fdo#111827]) +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-snb2/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [fdo#111827]) +9 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109284] / [fdo#111827]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-gamma:
- shard-tglb: NOTRUN -> [SKIP][89] ([fdo#109284] / [fdo#111827]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb5/igt@kms_color_chamelium@pipe-b-gamma.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-kbl: NOTRUN -> [SKIP][90] ([fdo#109271] / [fdo#111827]) +6 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl3/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#3116])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@kms_content_protection@dp-mst-lic-type-1.html
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#3116])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb5/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][93] ([i915#1319])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109278]) +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb2/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][95] -> [DMESG-WARN][96] ([i915#180]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][97] -> [SKIP][98] ([i915#3701])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#111825]) +4 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][100] ([fdo#109271]) +74 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109280])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][102] -> [DMESG-WARN][103] ([i915#180]) +5 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#533]) +3 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl10/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][106] ([fdo#108145] / [i915#265])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][107] -> [FAIL][108] ([fdo#108145] / [i915#265])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][109] ([fdo#108145] / [i915#265]) +2 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_cursor@pipe-d-primary-size-64:
- shard-glk: NOTRUN -> [SKIP][110] ([fdo#109271]) +6 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-glk5/igt@kms_plane_cursor@pipe-d-primary-size-64.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2733])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#2920])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#658]) +2 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#658]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl10/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
- shard-kbl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
- shard-iclb: NOTRUN -> [SKIP][116] ([i915#2920])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][117] -> [SKIP][118] ([fdo#109441]) +3 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][119] -> [FAIL][120] ([i915#31])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-glk1/igt@kms_setmode@basic.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-glk1/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][121] ([IGT#2])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl6/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][122] ([fdo#109271]) +113 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#533]) +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl4/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-c-source-rg:
- shard-iclb: NOTRUN -> [SKIP][124] ([i915#2530])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@nouveau_crc@pipe-c-source-rg.html
* igt@perf@gen12-mi-rpc:
- shard-skl: NOTRUN -> [SKIP][125] ([fdo#109271]) +171 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl1/igt@perf@gen12-mi-rpc.html
* igt@prime_vgem@basic-userptr:
- shard-tglb: NOTRUN -> [SKIP][126] ([i915#3301])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb5/igt@prime_vgem@basic-userptr.html
- shard-iclb: NOTRUN -> [SKIP][127] ([i915#3301])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-iclb1/igt@prime_vgem@basic-userptr.html
* igt@sysfs_clients@busy:
- shard-apl: NOTRUN -> [SKIP][128] ([fdo#109271] / [i915#2994])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/igt@sysfs_clients@busy.html
* igt@sysfs_clients@recycle:
- shard-kbl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2994])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@sysfs_clients@recycle.html
* igt@sysfs_clients@split-25:
- shard-skl: NOTRUN -> [SKIP][130] ([fdo#109271] / [i915#2994]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl1/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-kbl: [INCOMPLETE][131] ([i915#794]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [FAIL][133] ([i915#4409]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-snb7/igt@gem_eio@in-flight-contexts-10ms.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-rkl}: [FAIL][135] ([i915#2842]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][137] ([i915#2842]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][139] ([i915#180]) -> [PASS][140] +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: ([SKIP][141], [SKIP][142]) ([i915#1397]) -> [PASS][143]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-4/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][144] ([i915#3921]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-snb6/igt@i915_selftest@live@hangcheck.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-snb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- {shard-rkl}: ([PASS][146], [SKIP][147]) ([i915#1845]) -> [PASS][148] +1 similar issue
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-6/igt@kms_big_fb@linear-64bpp-rotate-180.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-4/igt@kms_big_fb@linear-64bpp-rotate-180.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-6/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][149] ([i915#118]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen:
- {shard-rkl}: [SKIP][151] ([fdo#112022] / [i915#4070]) -> [PASS][152] +2 similar issues
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][153] ([i915#180]) -> [PASS][154] +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge:
- {shard-rkl}: ([PASS][155], [SKIP][156]) ([i915#4098]) -> [PASS][157] +2 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-4/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled:
- {shard-rkl}: [SKIP][158] ([fdo#111314]) -> [PASS][159] +2 similar issues
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][160] ([i915#2122]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
- {shard-rkl}: [SKIP][162] ([i915#1849]) -> [PASS][163] +7 similar issues
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- {shard-rkl}: [SK
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21737/index.html
[-- Attachment #2: Type: text/html, Size: 33569 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences
2021-12-03 6:32 [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Pallavi Mishra
2021-12-03 8:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix possible null ptr dereferences (rev2) Patchwork
2021-12-03 10:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-12-03 11:02 ` Ville Syrjälä
2021-12-03 11:07 ` Thomas Hellström
2 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2021-12-03 11:02 UTC (permalink / raw)
To: Pallavi Mishra; +Cc: thomas.hellstrom, intel-gfx
On Fri, Dec 03, 2021 at 12:02:57PM +0530, Pallavi Mishra wrote:
> add null ptr checks to prevent crash/exceptions.
BUG_ON()s aren't going to fix anything.
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++
> drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 218a9b3037c7..997fe73c205b 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -906,6 +906,8 @@ vm_access_ttm(struct vm_area_struct *area, unsigned long addr,
> struct drm_i915_gem_object *obj =
> i915_ttm_to_gem(area->vm_private_data);
>
> + GEM_BUG_ON(!obj);
> +
> if (i915_gem_object_is_readonly(obj) && write)
> return -EACCES;
>
> @@ -966,6 +968,7 @@ static const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = {
> void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)
> {
> struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
> + GEM_BUG_ON(!obj);
>
> i915_gem_object_release_memory_region(obj);
> mutex_destroy(&obj->ttm.get_io_page.lock);
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> index 80df9f592407..2b684903a9f5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> @@ -371,6 +371,7 @@ int i915_ttm_move_notify(struct ttm_buffer_object *bo)
> struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
> int ret;
>
> + GEM_BUG_ON(!obj);
> ret = i915_gem_object_unbind(obj, I915_GEM_OBJECT_UNBIND_ACTIVE);
> if (ret)
> return ret;
> @@ -506,7 +507,7 @@ static void i915_ttm_memcpy_init(struct i915_ttm_memcpy_arg *arg,
>
> dst_reg = i915_ttm_region(bo->bdev, dst_mem->mem_type);
> src_reg = i915_ttm_region(bo->bdev, bo->resource->mem_type);
> - GEM_BUG_ON(!dst_reg || !src_reg);
> + GEM_BUG_ON(!dst_reg || !src_reg || !obj);
>
> arg->dst_iter = !i915_ttm_cpu_maps_iomem(dst_mem) ?
> ttm_kmap_iter_tt_init(&arg->_dst_iter.tt, dst_ttm) :
> --
> 2.25.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences
2021-12-03 11:02 ` [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Ville Syrjälä
@ 2021-12-03 11:07 ` Thomas Hellström
2021-12-09 13:25 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Hellström @ 2021-12-03 11:07 UTC (permalink / raw)
To: Ville Syrjälä, Pallavi Mishra; +Cc: intel-gfx
On Fri, 2021-12-03 at 13:02 +0200, Ville Syrjälä wrote:
> On Fri, Dec 03, 2021 at 12:02:57PM +0530, Pallavi Mishra wrote:
> > add null ptr checks to prevent crash/exceptions.
>
> BUG_ON()s aren't going to fix anything.
>
> > Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
Pallavi,
The NULL pointer dereferences here are probably all false positives
from a static analyzer. However the GEM_BUG_ONs are fine to assert that
the assumption really holds and to clearly point out what's going wrong
if they are hit in CI tests.
But the commit message must reflect that.
/Thomas.
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++
> > drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 ++-
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > index 218a9b3037c7..997fe73c205b 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > @@ -906,6 +906,8 @@ vm_access_ttm(struct vm_area_struct *area,
> > unsigned long addr,
> > struct drm_i915_gem_object *obj =
> > i915_ttm_to_gem(area->vm_private_data);
> >
> > + GEM_BUG_ON(!obj);
> > +
> > if (i915_gem_object_is_readonly(obj) && write)
> > return -EACCES;
> >
> > @@ -966,6 +968,7 @@ static const struct drm_i915_gem_object_ops
> > i915_gem_ttm_obj_ops = {
> > void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)
> > {
> > struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
> > + GEM_BUG_ON(!obj);
> >
> > i915_gem_object_release_memory_region(obj);
> > mutex_destroy(&obj->ttm.get_io_page.lock);
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> > b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> > index 80df9f592407..2b684903a9f5 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> > @@ -371,6 +371,7 @@ int i915_ttm_move_notify(struct
> > ttm_buffer_object *bo)
> > struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
> > int ret;
> >
> > + GEM_BUG_ON(!obj);
> > ret = i915_gem_object_unbind(obj,
> > I915_GEM_OBJECT_UNBIND_ACTIVE);
> > if (ret)
> > return ret;
> > @@ -506,7 +507,7 @@ static void i915_ttm_memcpy_init(struct
> > i915_ttm_memcpy_arg *arg,
> >
> > dst_reg = i915_ttm_region(bo->bdev, dst_mem->mem_type);
> > src_reg = i915_ttm_region(bo->bdev, bo->resource-
> > >mem_type);
> > - GEM_BUG_ON(!dst_reg || !src_reg);
> > + GEM_BUG_ON(!dst_reg || !src_reg || !obj);
> >
> > arg->dst_iter = !i915_ttm_cpu_maps_iomem(dst_mem) ?
> > ttm_kmap_iter_tt_init(&arg->_dst_iter.tt, dst_ttm)
> > :
> > --
> > 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences
2021-12-03 11:07 ` Thomas Hellström
@ 2021-12-09 13:25 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2021-12-09 13:25 UTC (permalink / raw)
To: Thomas Hellström, Ville Syrjälä, Pallavi Mishra; +Cc: intel-gfx
On Fri, 03 Dec 2021, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote:
> On Fri, 2021-12-03 at 13:02 +0200, Ville Syrjälä wrote:
>> On Fri, Dec 03, 2021 at 12:02:57PM +0530, Pallavi Mishra wrote:
>> > add null ptr checks to prevent crash/exceptions.
>>
>> BUG_ON()s aren't going to fix anything.
>>
>> > Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
>
> Pallavi,
>
> The NULL pointer dereferences here are probably all false positives
> from a static analyzer. However the GEM_BUG_ONs are fine to assert that
> the assumption really holds and to clearly point out what's going wrong
> if they are hit in CI tests.
I think we're massively overusing GEM_BUG_ON() all over the place.
BR,
Jani.
>
> But the commit message must reflect that.
>
> /Thomas.
>
>
>> > ---
>> > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++
>> > drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 ++-
>> > 2 files changed, 5 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> > b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> > index 218a9b3037c7..997fe73c205b 100644
>> > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> > @@ -906,6 +906,8 @@ vm_access_ttm(struct vm_area_struct *area,
>> > unsigned long addr,
>> > struct drm_i915_gem_object *obj =
>> > i915_ttm_to_gem(area->vm_private_data);
>> >
>> > + GEM_BUG_ON(!obj);
>> > +
>> > if (i915_gem_object_is_readonly(obj) && write)
>> > return -EACCES;
>> >
>> > @@ -966,6 +968,7 @@ static const struct drm_i915_gem_object_ops
>> > i915_gem_ttm_obj_ops = {
>> > void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)
>> > {
>> > struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
>> > + GEM_BUG_ON(!obj);
>> >
>> > i915_gem_object_release_memory_region(obj);
>> > mutex_destroy(&obj->ttm.get_io_page.lock);
>> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
>> > b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
>> > index 80df9f592407..2b684903a9f5 100644
>> > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
>> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
>> > @@ -371,6 +371,7 @@ int i915_ttm_move_notify(struct
>> > ttm_buffer_object *bo)
>> > struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
>> > int ret;
>> >
>> > + GEM_BUG_ON(!obj);
>> > ret = i915_gem_object_unbind(obj,
>> > I915_GEM_OBJECT_UNBIND_ACTIVE);
>> > if (ret)
>> > return ret;
>> > @@ -506,7 +507,7 @@ static void i915_ttm_memcpy_init(struct
>> > i915_ttm_memcpy_arg *arg,
>> >
>> > dst_reg = i915_ttm_region(bo->bdev, dst_mem->mem_type);
>> > src_reg = i915_ttm_region(bo->bdev, bo->resource-
>> > >mem_type);
>> > - GEM_BUG_ON(!dst_reg || !src_reg);
>> > + GEM_BUG_ON(!dst_reg || !src_reg || !obj);
>> >
>> > arg->dst_iter = !i915_ttm_cpu_maps_iomem(dst_mem) ?
>> > ttm_kmap_iter_tt_init(&arg->_dst_iter.tt, dst_ttm)
>> > :
>> > --
>> > 2.25.1
>>
>
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-09 17:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03 6:32 [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Pallavi Mishra
2021-12-03 8:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix possible null ptr dereferences (rev2) Patchwork
2021-12-03 10:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-03 11:02 ` [Intel-gfx] [PATCH] drm/i915: Fix possible null ptr dereferences Ville Syrjälä
2021-12-03 11:07 ` Thomas Hellström
2021-12-09 13:25 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.