All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: entry: Use SDEI event constants
@ 2021-11-18 20:18 ` Florian Fainelli
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-11-18 20:18 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: james.morse, Florian Fainelli, Catalin Marinas, Will Deacon,
	Mark Rutland, Marc Zyngier, Joey Gouly, Peter Collingbourne,
	Vincenzo Frascino,
	moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
	open list

Use SDEI_EV_FAILED instead of open coding the 1 to make it clearer how
SDEI_EVENT_COMPLETE vs. SDEI_EVENT_COMPLETE_AND_RESUME is selected.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm64/kernel/entry.S | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index 2f69ae43941d..772ec2ecf488 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -966,8 +966,10 @@ SYM_CODE_START(__sdei_asm_handler)
 	mov	sp, x1
 
 	mov	x1, x0			// address to complete_and_resume
-	/* x0 = (x0 <= 1) ? EVENT_COMPLETE:EVENT_COMPLETE_AND_RESUME */
-	cmp	x0, #1
+	/* x0 = (x0 <= SDEI_EV_FAILED) ?
+	 * EVENT_COMPLETE:EVENT_COMPLETE_AND_RESUME
+	 */
+	cmp	x0, #SDEI_EV_FAILED
 	mov_q	x2, SDEI_1_0_FN_SDEI_EVENT_COMPLETE
 	mov_q	x3, SDEI_1_0_FN_SDEI_EVENT_COMPLETE_AND_RESUME
 	csel	x0, x2, x3, ls
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: entry: Use SDEI event constants
@ 2021-11-18 20:18 ` Florian Fainelli
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-11-18 20:18 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: james.morse, Florian Fainelli, Catalin Marinas, Will Deacon,
	Mark Rutland, Marc Zyngier, Joey Gouly, Peter Collingbourne,
	Vincenzo Frascino,
	moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
	open list

Use SDEI_EV_FAILED instead of open coding the 1 to make it clearer how
SDEI_EVENT_COMPLETE vs. SDEI_EVENT_COMPLETE_AND_RESUME is selected.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm64/kernel/entry.S | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index 2f69ae43941d..772ec2ecf488 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -966,8 +966,10 @@ SYM_CODE_START(__sdei_asm_handler)
 	mov	sp, x1
 
 	mov	x1, x0			// address to complete_and_resume
-	/* x0 = (x0 <= 1) ? EVENT_COMPLETE:EVENT_COMPLETE_AND_RESUME */
-	cmp	x0, #1
+	/* x0 = (x0 <= SDEI_EV_FAILED) ?
+	 * EVENT_COMPLETE:EVENT_COMPLETE_AND_RESUME
+	 */
+	cmp	x0, #SDEI_EV_FAILED
 	mov_q	x2, SDEI_1_0_FN_SDEI_EVENT_COMPLETE
 	mov_q	x3, SDEI_1_0_FN_SDEI_EVENT_COMPLETE_AND_RESUME
 	csel	x0, x2, x3, ls
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: entry: Use SDEI event constants
  2021-11-18 20:18 ` Florian Fainelli
@ 2021-12-06 17:28   ` Catalin Marinas
  -1 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-12-06 17:28 UTC (permalink / raw)
  To: Florian Fainelli, linux-arm-kernel
  Cc: Will Deacon, Mark Rutland, open list,
	moderated list:ARM64 PORT AARCH64 ARCHITECTURE, james.morse,
	Vincenzo Frascino, Joey Gouly, Peter Collingbourne, Marc Zyngier

On Thu, 18 Nov 2021 12:18:10 -0800, Florian Fainelli wrote:
> Use SDEI_EV_FAILED instead of open coding the 1 to make it clearer how
> SDEI_EVENT_COMPLETE vs. SDEI_EVENT_COMPLETE_AND_RESUME is selected.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: entry: Use SDEI event constants
      https://git.kernel.org/arm64/c/c9f5ea08a0f0

-- 
Catalin


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: entry: Use SDEI event constants
@ 2021-12-06 17:28   ` Catalin Marinas
  0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-12-06 17:28 UTC (permalink / raw)
  To: Florian Fainelli, linux-arm-kernel
  Cc: Will Deacon, Mark Rutland, open list,
	moderated list:ARM64 PORT AARCH64 ARCHITECTURE, james.morse,
	Vincenzo Frascino, Joey Gouly, Peter Collingbourne, Marc Zyngier

On Thu, 18 Nov 2021 12:18:10 -0800, Florian Fainelli wrote:
> Use SDEI_EV_FAILED instead of open coding the 1 to make it clearer how
> SDEI_EVENT_COMPLETE vs. SDEI_EVENT_COMPLETE_AND_RESUME is selected.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: entry: Use SDEI event constants
      https://git.kernel.org/arm64/c/c9f5ea08a0f0

-- 
Catalin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-06 17:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 20:18 [PATCH] arm64: entry: Use SDEI event constants Florian Fainelli
2021-11-18 20:18 ` Florian Fainelli
2021-12-06 17:28 ` Catalin Marinas
2021-12-06 17:28   ` Catalin Marinas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.