* [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
@ 2021-12-10 1:31 dong.yang
2021-12-10 8:51 ` Tvrtko Ursulin
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: dong.yang @ 2021-12-10 1:31 UTC (permalink / raw)
To: intel-gfx; +Cc: dong.yang, Yang
From: "Yang, Dong" <dong.yang@intel.com>
With unknow race condition, the i915_request will be added
to intel_context list twice, and result in system panic.
If node alreay exist then do not add it again.
Signed-off-by: Yang, Dong <dong.yang@intel.com>
---
drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
index 209cf265bf74..9c7bc060d2ae 100644
--- a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
+++ b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
@@ -387,6 +387,9 @@ static void insert_breadcrumb(struct i915_request *rq)
}
}
+ if (&rq->signal_link == pos)
+ return;
+
i915_request_get(rq);
list_add_rcu(&rq->signal_link, pos);
GEM_BUG_ON(!check_signal_order(ce, rq));
--
2.27.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-10 1:31 [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice dong.yang
@ 2021-12-10 8:51 ` Tvrtko Ursulin
2021-12-13 1:53 ` Yang, Dong
2021-12-10 11:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Tvrtko Ursulin @ 2021-12-10 8:51 UTC (permalink / raw)
To: dong.yang, intel-gfx
On 10/12/2021 01:31, dong.yang@intel.com wrote:
> From: "Yang, Dong" <dong.yang@intel.com>
>
> With unknow race condition, the i915_request will be added
What do you mean with unknown here?
> to intel_context list twice, and result in system panic.
>
> If node alreay exist then do not add it again.
Note the call chains are under ce->signal_lock and protecting from double add AFAICT:
static void insert_breadcrumb(struct i915_request *rq)
{
...
if (test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags))
return;
...
set_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
bool i915_request_enable_breadcrumb(struct i915_request *rq)
{
...
spin_lock(&ce->signal_lock);
if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags))
insert_breadcrumb(rq);
spin_unlock(&ce->signal_lock);
void i915_request_cancel_breadcrumb(struct i915_request *rq)
{
...
spin_lock(&ce->signal_lock);
if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
spin_unlock(&ce->signal_lock);
return;
}
void intel_context_remove_breadcrumbs(struct intel_context *ce,
struct intel_breadcrumbs *b)
{
...
spin_lock_irqsave(&ce->signal_lock, flags);
if (list_empty(&ce->signals))
goto unlock;
list_for_each_entry_safe(rq, rn, &ce->signals, signal_link) {
GEM_BUG_ON(!__i915_request_is_complete(rq));
if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL,
&rq->fence.flags))
continue;
The last one in signal_irq_work is guarded by the __i915_request_is_complete check.
So I think more context is needed on how you found this may be an issue.
Regards,
Tvrtko
>
> Signed-off-by: Yang, Dong <dong.yang@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> index 209cf265bf74..9c7bc060d2ae 100644
> --- a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> @@ -387,6 +387,9 @@ static void insert_breadcrumb(struct i915_request *rq)
> }
> }
>
> + if (&rq->signal_link == pos)
> + return;
> +
> i915_request_get(rq);
> list_add_rcu(&rq->signal_link, pos);
> GEM_BUG_ON(!check_signal_order(ce, rq));
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-10 1:31 [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice dong.yang
2021-12-10 8:51 ` Tvrtko Ursulin
@ 2021-12-10 11:00 ` Patchwork
2021-12-10 11:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-11 4:59 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-12-10 11:00 UTC (permalink / raw)
To: dong.yang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Do not add same i915_request to intel_context twice
URL : https://patchwork.freedesktop.org/series/97843/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
94b2a1bdd53a drm/i915/gt: Do not add same i915_request to intel_context twice
-:7: WARNING:TYPO_SPELLING: 'unknow' may be misspelled - perhaps 'unknown'?
#7:
With unknow race condition, the i915_request will be added
^^^^^^
-:10: WARNING:TYPO_SPELLING: 'alreay' may be misspelled - perhaps 'already'?
#10:
If node alreay exist then do not add it again.
^^^^^^
total: 0 errors, 2 warnings, 0 checks, 9 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-10 1:31 [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice dong.yang
2021-12-10 8:51 ` Tvrtko Ursulin
2021-12-10 11:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2021-12-10 11:31 ` Patchwork
2021-12-11 4:59 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-12-10 11:31 UTC (permalink / raw)
To: dong.yang; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5516 bytes --]
== Series Details ==
Series: drm/i915/gt: Do not add same i915_request to intel_context twice
URL : https://patchwork.freedesktop.org/series/97843/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21816
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/index.html
Participating hosts (43 -> 35)
------------------------------
Additional (1): fi-apl-guc
Missing (9): fi-ilk-m540 bat-dg1-6 fi-hsw-4200u fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-jsl-2 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_21816 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][1] ([fdo#109271]) +18 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-bsw-n3050/igt@amdgpu/amd_cs_nop@sync-gfx0.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-apl-guc: NOTRUN -> [SKIP][3] ([fdo#109271]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-apl-guc/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [PASS][4] -> [INCOMPLETE][5] ([i915#146])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-apl-guc/igt@gem_lmem_swapping@basic.html
* igt@i915_hangman@error-state-basic:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][7] ([i915#1610])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-apl-guc/igt@i915_hangman@error-state-basic.html
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> [FAIL][8] ([i915#2426] / [i915#4312])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-apl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][9] ([i915#1888]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@i915_selftest@live@hangcheck:
- {fi-jsl-1}: [INCOMPLETE][11] ([i915#3970]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/fi-jsl-1/igt@i915_selftest@live@hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-jsl-1/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [DMESG-FAIL][13] ([i915#2927] / [i915#3428]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [FAIL][15] ([i915#4547]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3970]: https://gitlab.freedesktop.org/drm/intel/issues/3970
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
Build changes
-------------
* Linux: CI_DRM_10987 -> Patchwork_21816
CI-20190529: 20190529
CI_DRM_10987: f23f5bbad359e45b00ea1622c96872a02cd6b30f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6305: 136258e86a093fdb50a7a341de1c09ac9a076fea @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21816: 94b2a1bdd53a918a152dd624d945db39c326674c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
94b2a1bdd53a drm/i915/gt: Do not add same i915_request to intel_context twice
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/index.html
[-- Attachment #2: Type: text/html, Size: 6466 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-10 1:31 [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice dong.yang
` (2 preceding siblings ...)
2021-12-10 11:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-12-11 4:59 ` Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-12-11 4:59 UTC (permalink / raw)
To: dong.yang; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30287 bytes --]
== Series Details ==
Series: drm/i915/gt: Do not add same i915_request to intel_context twice
URL : https://patchwork.freedesktop.org/series/97843/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10987_full -> Patchwork_21816_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21816_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21816_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21816_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@requests:
- shard-tglb: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-tglb3/igt@i915_selftest@live@requests.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@i915_selftest@live@requests.html
Known issues
------------
Here are the changes found in Patchwork_21816_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl4/igt@gem_exec_capture@pi@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl8/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-glk2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb3/igt@gem_exec_fair@basic-pace@bcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb6/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][14] -> [DMESG-WARN][15] ([i915#118])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-glk5/igt@gem_exec_whisper@basic-contexts-all.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-glk9/igt@gem_exec_whisper@basic-contexts-all.html
* igt@gem_lmem_swapping@verify:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl7/igt@gem_lmem_swapping@verify.html
* igt@gem_pxp@create-regular-context-1:
- shard-tglb: NOTRUN -> [SKIP][17] ([i915#4270])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@gem_pxp@create-regular-context-1.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][18] ([i915#3297])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1436] / [i915#716])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl9/igt@gen9_exec_parse@allowed-single.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl9/igt@gen9_exec_parse@allowed-single.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl6/igt@i915_module_load@reload-with-fault-injection.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl7/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#111644] / [i915#1397] / [i915#2411])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3777])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl3/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl3/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl7/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-frame-dump:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#109284] / [fdo#111827])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@kms_chamelium@dp-frame-dump.html
* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +10 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl1/igt@kms_chamelium@vga-edid-read.html
* igt@kms_color_chamelium@pipe-b-degamma:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +7 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl3/igt@kms_color_chamelium@pipe-b-degamma.html
* igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271]) +105 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109279] / [i915#3359])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3319])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271]) +71 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl4/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#2346])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#2346] / [i915#533])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [PASS][39] -> [FAIL][40] ([i915#2346])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb4/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_flip@2x-busy-flip:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#111825]) +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@kms_flip@2x-busy-flip.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#79])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][44] -> [DMESG-WARN][45] ([i915#180])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_tiling@flip-change-tiling@dp-1-pipe-a-y-to-yf-ccs:
- shard-apl: NOTRUN -> [DMESG-WARN][46] ([i915#1226])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl1/igt@kms_flip_tiling@flip-change-tiling@dp-1-pipe-a-y-to-yf-ccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271]) +39 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#533])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl10/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][50] ([i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][54] -> [SKIP][55] ([fdo#109441]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_selftest@all@check_plane_state:
- shard-tglb: NOTRUN -> [INCOMPLETE][56] ([i915#4663])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@kms_selftest@all@check_plane_state.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][57] -> [DMESG-WARN][58] ([i915#180] / [i915#295])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
- shard-apl: [PASS][59] -> [DMESG-WARN][60] ([i915#180] / [i915#295])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2437])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl4/igt@kms_writeback@writeback-invalid-parameters.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][62] -> [FAIL][63] ([i915#1542])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl4/igt@perf@polling-parameterized.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl8/igt@perf@polling-parameterized.html
* igt@prime_nv_test@nv_write_i915_gtt_mmap_read:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109291])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@prime_nv_test@nv_write_i915_gtt_mmap_read.html
* igt@sysfs_clients@busy:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2994])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl4/igt@sysfs_clients@busy.html
* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2994])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl4/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@fair-3:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2994])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@sysfs_clients@fair-3.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [DMESG-WARN][68] ([i915#180]) -> [PASS][69] +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][70] ([i915#2842]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-tglb6/igt@gem_exec_fair@basic-pace@rcs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
- shard-glk: [FAIL][72] ([i915#2842]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-glk9/igt@gem_exec_fair@basic-pace@rcs0.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-glk1/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][74] ([fdo#109271]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][76] ([i915#2849]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][78] ([i915#2190]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-tglb6/igt@gem_huc_copy@huc-copy.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb2/igt@gem_huc_copy@huc-copy.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][80] ([i915#198]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl8/igt@gem_softpin@noreloc-s3.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl10/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_backlight@basic-brightness:
- {shard-rkl}: [SKIP][82] ([i915#3012]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@i915_pm_backlight@basic-brightness.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][84] ([i915#4281]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb6/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [INCOMPLETE][86] ([i915#151]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl9/igt@i915_pm_rpm@system-suspend-modeset.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl4/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_pm_rps@reset:
- {shard-rkl}: [FAIL][88] ([i915#4016]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@i915_pm_rps@reset.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-4/igt@i915_pm_rps@reset.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- {shard-rkl}: ([SKIP][90], [SKIP][91]) ([i915#1845]) -> [PASS][92]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_big_fb@linear-32bpp-rotate-0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-4/igt@kms_big_fb@linear-32bpp-rotate-0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-glk: [FAIL][93] ([i915#1888] / [i915#3653]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-glk2/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [DMESG-WARN][95] ([i915#1982]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl1/igt@kms_color@pipe-b-ctm-0-75.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl6/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color@pipe-b-gamma:
- {shard-rkl}: ([SKIP][97], [SKIP][98]) ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][99]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_color@pipe-b-gamma.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-4/igt@kms_color@pipe-b-gamma.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_color@pipe-b-gamma.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-random:
- {shard-rkl}: [SKIP][100] ([fdo#112022] / [i915#4070]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-256x85-random.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x85-random.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
- {shard-rkl}: ([SKIP][102], [SKIP][103]) ([fdo#112022] / [i915#4070]) -> [PASS][104]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
* igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge:
- shard-kbl: [FAIL][105] ([i915#3435]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl1/igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl6/igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- {shard-rkl}: ([SKIP][107], [SKIP][108]) ([fdo#111825] / [i915#4070]) -> [PASS][109]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- {shard-rkl}: [SKIP][110] ([fdo#111825] / [i915#4070]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-rkl}: ([SKIP][112], [SKIP][113]) ([i915#1849] / [i915#4098]) -> [PASS][114] +4 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-4/igt@kms_fbcon_fbt@fbc-suspend.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_fbcon_fbt@fbc-suspend.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_fbcon_fbt@fbc-suspend.html
- shard-kbl: [INCOMPLETE][115] ([i915#180] / [i915#636]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [SKIP][117] ([i915#3701]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt:
- {shard-rkl}: [SKIP][119] ([i915#1849]) -> [PASS][120] +3 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][121] ([i915#1188]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl4/igt@kms_hdr@bpc-switch-suspend.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_invalid_mode@bad-vsync-end:
- {shard-rkl}: [SKIP][123] ([i915#4278]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_invalid_mode@bad-vsync-end.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_invalid_mode@bad-vsync-end.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [DMESG-WARN][125] ([i915#180]) -> [PASS][126] +3 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- {shard-rkl}: [SKIP][127] ([i915#1849] / [i915#4070]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][129] ([fdo#108145] / [i915#265]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- {shard-rkl}: [SKIP][131] ([i915#3558] / [i915#4070]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html
* igt@kms_psr@primary_blt:
- {shard-rkl}: [SKIP][133] ([i915#1072]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_psr@primary_blt.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_psr@primary_blt.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][135] ([fdo#109441]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb4/igt@kms_psr@psr2_basic.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@kms_rotation_crc@sprite-rotation-180:
- shard-tglb: [INCOMPLETE][137] -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-tglb8/igt@kms_rotation_crc@sprite-rotation-180.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-tglb7/igt@kms_rotation_crc@sprite-rotation-180.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][139] ([i915#31]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-apl1/igt@kms_setmode@basic.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-apl6/igt@kms_setmode@basic.html
- shard-glk: [FAIL][141] ([i915#31]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-glk4/igt@kms_setmode@basic.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-glk6/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-modeset:
- {shard-rkl}: [SKIP][143] ([i915#1845]) -> [PASS][144] +4 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-rkl-1/igt@kms_vblank@pipe-a-ts-continuation-modeset.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-rkl-6/igt@kms_vblank@pipe-a-ts-continuation-modeset.html
#### Warnings ####
* igt@i915_suspend@forcewake:
- shard-kbl: [DMESG-WARN][145] ([i915#180]) -> [INCOMPLETE][146] ([i915#636])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-kbl6/igt@i915_suspend@forcewake.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-kbl6/igt@i915_suspend@forcewake.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][147] ([i915#2920]) -> [SKIP][148] ([i915#658]) +3 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/shard-iclb5/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][149] ([i915#658]) -> [SKIP][150] ([i915#2920]) +3 similar issues
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10987/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwo
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21816/index.html
[-- Attachment #2: Type: text/html, Size: 33215 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-10 8:51 ` Tvrtko Ursulin
@ 2021-12-13 1:53 ` Yang, Dong
2021-12-13 9:36 ` Tvrtko Ursulin
0 siblings, 1 reply; 9+ messages in thread
From: Yang, Dong @ 2021-12-13 1:53 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
I am working on a customized kernel based on 5.4.39, issue can only reproduced when system facing low memory pressure, and system try to reclaim memory, then wrong double insert i915_reqeust coming from the i915_gem_shrink() path.
i915_request_enable_breadcrumb+0x136/0x14a
dma_fence_enable_sw_signaling+0x47/0xb0
enable_signaling+0x66/0x80
i915_active_wait+0xc1/0x150
__i915_vma_unbind+0x17/0x1a0
i915_vma_unbind+0x47/0xc0
i915_gem_object_unbind+0x189/0x290
i915_gem_shrink+0x139/0x460
? __pm_runtime_resume+0x53/0x70
i915_gem_shrinker_scan+0x9c/0xb0
do_shrink_slab+0x14f/0x2b0
shrink_slab+0xa7/0x2a0
shrink_node+0xd1/0x410
balance_pgdat+0x2b7/0x500
kswapd+0x1e2/0x3b0
I believe it's not related to the ce->signal_lock, the lock should works normally.
The i915_request_enable_breadcrumb() can be invoked by several context, like called from ioctl(), from interrupt context, and from memory swap thread, I suggest add a double check before insert i915_request to the list, it's hard to assure valid call from all the paths, but add check&protect can avoid the critical effect, because add same i915_request twice will trigger a dead loop in signal_irq_work() , and the loop will never break continue the i915_request. hwsp_seqno be changed, and invalid address access error reported followed by system panic.
Thanks,
Dong
-----Original Message-----
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Sent: Friday, December 10, 2021 4:51 PM
To: Yang, Dong <dong.yang@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
On 10/12/2021 01:31, dong.yang@intel.com wrote:
> From: "Yang, Dong" <dong.yang@intel.com>
>
> With unknow race condition, the i915_request will be added
What do you mean with unknown here?
> to intel_context list twice, and result in system panic.
>
> If node alreay exist then do not add it again.
Note the call chains are under ce->signal_lock and protecting from double add AFAICT:
static void insert_breadcrumb(struct i915_request *rq) { ...
if (test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags))
return;
...
set_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
bool i915_request_enable_breadcrumb(struct i915_request *rq) { ...
spin_lock(&ce->signal_lock);
if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags))
insert_breadcrumb(rq);
spin_unlock(&ce->signal_lock);
void i915_request_cancel_breadcrumb(struct i915_request *rq) { ...
spin_lock(&ce->signal_lock);
if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
spin_unlock(&ce->signal_lock);
return;
}
void intel_context_remove_breadcrumbs(struct intel_context *ce,
struct intel_breadcrumbs *b)
{
...
spin_lock_irqsave(&ce->signal_lock, flags);
if (list_empty(&ce->signals))
goto unlock;
list_for_each_entry_safe(rq, rn, &ce->signals, signal_link) {
GEM_BUG_ON(!__i915_request_is_complete(rq));
if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL,
&rq->fence.flags))
continue;
The last one in signal_irq_work is guarded by the __i915_request_is_complete check.
So I think more context is needed on how you found this may be an issue.
Regards,
Tvrtko
>
> Signed-off-by: Yang, Dong <dong.yang@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> index 209cf265bf74..9c7bc060d2ae 100644
> --- a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
> @@ -387,6 +387,9 @@ static void insert_breadcrumb(struct i915_request *rq)
> }
> }
>
> + if (&rq->signal_link == pos)
> + return;
> +
> i915_request_get(rq);
> list_add_rcu(&rq->signal_link, pos);
> GEM_BUG_ON(!check_signal_order(ce, rq));
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-13 1:53 ` Yang, Dong
@ 2021-12-13 9:36 ` Tvrtko Ursulin
2021-12-14 5:58 ` Yang, Dong
0 siblings, 1 reply; 9+ messages in thread
From: Tvrtko Ursulin @ 2021-12-13 9:36 UTC (permalink / raw)
To: Yang, Dong, intel-gfx
On 13/12/2021 01:53, Yang, Dong wrote:
> I am working on a customized kernel based on 5.4.39, issue can only reproduced when system facing low memory pressure, and system try to reclaim memory, then wrong double insert i915_reqeust coming from the i915_gem_shrink() path.
5.4 is quite old and there have been fixes to this code since. Any chance that you can repro on drm-tip? What project are you working on?
Is your bug perhaps similar to what c744d50363b7 ("drm/i915/gt: Split the breadcrumb spinlock between global and contexts") fixed? As the commit says:
"""
Furthermore, this closes the race between enabling the signaling context
while it is in the process of being signaled and removed:
"""
>
> i915_request_enable_breadcrumb+0x136/0x14a
> dma_fence_enable_sw_signaling+0x47/0xb0
> enable_signaling+0x66/0x80
> i915_active_wait+0xc1/0x150
> __i915_vma_unbind+0x17/0x1a0
> i915_vma_unbind+0x47/0xc0
> i915_gem_object_unbind+0x189/0x290
> i915_gem_shrink+0x139/0x460
> ? __pm_runtime_resume+0x53/0x70
> i915_gem_shrinker_scan+0x9c/0xb0
> do_shrink_slab+0x14f/0x2b0
> shrink_slab+0xa7/0x2a0
> shrink_node+0xd1/0x410
> balance_pgdat+0x2b7/0x500
> kswapd+0x1e2/0x3b0
>
> I believe it's not related to the ce->signal_lock, the lock should works normally.
>
> The i915_request_enable_breadcrumb() can be invoked by several context, like called from ioctl(), from interrupt context, and from memory swap thread, I suggest add a double check before insert i915_request to the list, it's hard to assure valid call from all the paths, but add check&protect can avoid the critical effect, because add same i915_request twice will trigger a dead loop in signal_irq_work() , and the loop will never break continue the i915_request. hwsp_seqno be changed, and invalid address access error reported followed by system panic.
Maybe, but I was pointing out double insert_breadcrumb is already protected when called inside i915_request_enable_breadcrumb - by the virtue of the spinlock and I915_FENCE_FLAG_SIGNAL. So maybe a race with remove or something, but it looks unlikely it is simple double add due parallel enablement.
Regards,
Tvrtko
>
> Thanks,
> Dong
>
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: Friday, December 10, 2021 4:51 PM
> To: Yang, Dong <dong.yang@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
>
>
> On 10/12/2021 01:31, dong.yang@intel.com wrote:
>> From: "Yang, Dong" <dong.yang@intel.com>
>>
>> With unknow race condition, the i915_request will be added
>
> What do you mean with unknown here?
>
>> to intel_context list twice, and result in system panic.
>>
>> If node alreay exist then do not add it again.
>
> Note the call chains are under ce->signal_lock and protecting from double add AFAICT:
>
> static void insert_breadcrumb(struct i915_request *rq) { ...
> if (test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags))
> return;
> ...
> set_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
>
>
> bool i915_request_enable_breadcrumb(struct i915_request *rq) { ...
> spin_lock(&ce->signal_lock);
> if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags))
> insert_breadcrumb(rq);
> spin_unlock(&ce->signal_lock);
>
>
> void i915_request_cancel_breadcrumb(struct i915_request *rq) { ...
> spin_lock(&ce->signal_lock);
> if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
> spin_unlock(&ce->signal_lock);
> return;
> }
>
> void intel_context_remove_breadcrumbs(struct intel_context *ce,
> struct intel_breadcrumbs *b)
> {
> ...
> spin_lock_irqsave(&ce->signal_lock, flags);
>
> if (list_empty(&ce->signals))
> goto unlock;
>
> list_for_each_entry_safe(rq, rn, &ce->signals, signal_link) {
> GEM_BUG_ON(!__i915_request_is_complete(rq));
> if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL,
> &rq->fence.flags))
> continue;
>
> The last one in signal_irq_work is guarded by the __i915_request_is_complete check.
>
> So I think more context is needed on how you found this may be an issue.
>
> Regards,
>
> Tvrtko
>
>>
>> Signed-off-by: Yang, Dong <dong.yang@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> index 209cf265bf74..9c7bc060d2ae 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> @@ -387,6 +387,9 @@ static void insert_breadcrumb(struct i915_request *rq)
>> }
>> }
>>
>> + if (&rq->signal_link == pos)
>> + return;
>> +
>> i915_request_get(rq);
>> list_add_rcu(&rq->signal_link, pos);
>> GEM_BUG_ON(!check_signal_order(ce, rq));
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-13 9:36 ` Tvrtko Ursulin
@ 2021-12-14 5:58 ` Yang, Dong
2021-12-14 15:40 ` Tvrtko Ursulin
0 siblings, 1 reply; 9+ messages in thread
From: Yang, Dong @ 2021-12-14 5:58 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
Thanks Tvrtko, I will try the patch you mentioned.
BTW, how do you think we use this patch in our project, any side-effect it may have? If no side-effect we can take it as WA for temporally fix till we got the final root fixed.
Thanks,
Dong
-----Original Message-----
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Sent: Monday, December 13, 2021 5:37 PM
To: Yang, Dong <dong.yang@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
On 13/12/2021 01:53, Yang, Dong wrote:
> I am working on a customized kernel based on 5.4.39, issue can only reproduced when system facing low memory pressure, and system try to reclaim memory, then wrong double insert i915_reqeust coming from the i915_gem_shrink() path.
5.4 is quite old and there have been fixes to this code since. Any chance that you can repro on drm-tip? What project are you working on?
Is your bug perhaps similar to what c744d50363b7 ("drm/i915/gt: Split the breadcrumb spinlock between global and contexts") fixed? As the commit says:
"""
Furthermore, this closes the race between enabling the signaling context
while it is in the process of being signaled and removed:
"""
>
> i915_request_enable_breadcrumb+0x136/0x14a
> dma_fence_enable_sw_signaling+0x47/0xb0
> enable_signaling+0x66/0x80
> i915_active_wait+0xc1/0x150
> __i915_vma_unbind+0x17/0x1a0
> i915_vma_unbind+0x47/0xc0
> i915_gem_object_unbind+0x189/0x290
> i915_gem_shrink+0x139/0x460
> ? __pm_runtime_resume+0x53/0x70
> i915_gem_shrinker_scan+0x9c/0xb0
> do_shrink_slab+0x14f/0x2b0
> shrink_slab+0xa7/0x2a0
> shrink_node+0xd1/0x410
> balance_pgdat+0x2b7/0x500
> kswapd+0x1e2/0x3b0
>
> I believe it's not related to the ce->signal_lock, the lock should works normally.
>
> The i915_request_enable_breadcrumb() can be invoked by several context, like called from ioctl(), from interrupt context, and from memory swap thread, I suggest add a double check before insert i915_request to the list, it's hard to assure valid call from all the paths, but add check&protect can avoid the critical effect, because add same i915_request twice will trigger a dead loop in signal_irq_work() , and the loop will never break continue the i915_request. hwsp_seqno be changed, and invalid address access error reported followed by system panic.
Maybe, but I was pointing out double insert_breadcrumb is already protected when called inside i915_request_enable_breadcrumb - by the virtue of the spinlock and I915_FENCE_FLAG_SIGNAL. So maybe a race with remove or something, but it looks unlikely it is simple double add due parallel enablement.
Regards,
Tvrtko
>
> Thanks,
> Dong
>
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: Friday, December 10, 2021 4:51 PM
> To: Yang, Dong <dong.yang@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same
> i915_request to intel_context twice
>
>
> On 10/12/2021 01:31, dong.yang@intel.com wrote:
>> From: "Yang, Dong" <dong.yang@intel.com>
>>
>> With unknow race condition, the i915_request will be added
>
> What do you mean with unknown here?
>
>> to intel_context list twice, and result in system panic.
>>
>> If node alreay exist then do not add it again.
>
> Note the call chains are under ce->signal_lock and protecting from double add AFAICT:
>
> static void insert_breadcrumb(struct i915_request *rq) { ...
> if (test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags))
> return;
> ...
> set_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
>
>
> bool i915_request_enable_breadcrumb(struct i915_request *rq) { ...
> spin_lock(&ce->signal_lock);
> if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags))
> insert_breadcrumb(rq);
> spin_unlock(&ce->signal_lock);
>
>
> void i915_request_cancel_breadcrumb(struct i915_request *rq) { ...
> spin_lock(&ce->signal_lock);
> if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
> spin_unlock(&ce->signal_lock);
> return;
> }
>
> void intel_context_remove_breadcrumbs(struct intel_context *ce,
> struct intel_breadcrumbs *b) { ...
> spin_lock_irqsave(&ce->signal_lock, flags);
>
> if (list_empty(&ce->signals))
> goto unlock;
>
> list_for_each_entry_safe(rq, rn, &ce->signals, signal_link) {
> GEM_BUG_ON(!__i915_request_is_complete(rq));
> if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL,
> &rq->fence.flags))
> continue;
>
> The last one in signal_irq_work is guarded by the __i915_request_is_complete check.
>
> So I think more context is needed on how you found this may be an issue.
>
> Regards,
>
> Tvrtko
>
>>
>> Signed-off-by: Yang, Dong <dong.yang@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> index 209cf265bf74..9c7bc060d2ae 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
>> @@ -387,6 +387,9 @@ static void insert_breadcrumb(struct i915_request *rq)
>> }
>> }
>>
>> + if (&rq->signal_link == pos)
>> + return;
>> +
>> i915_request_get(rq);
>> list_add_rcu(&rq->signal_link, pos);
>> GEM_BUG_ON(!check_signal_order(ce, rq));
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice
2021-12-14 5:58 ` Yang, Dong
@ 2021-12-14 15:40 ` Tvrtko Ursulin
0 siblings, 0 replies; 9+ messages in thread
From: Tvrtko Ursulin @ 2021-12-14 15:40 UTC (permalink / raw)
To: Yang, Dong, intel-gfx
On 14/12/2021 05:58, Yang, Dong wrote:
> Thanks Tvrtko, I will try the patch you mentioned.
>
> BTW, how do you think we use this patch in our project, any side-effect it may have? If no side-effect we can take it as WA for temporally fix till we got the final root fixed.
For side effects I can't be sure. Best to try backporting and see if it
fixes your issue, but note backporting may be tricky and you may end up
pulling other patches as well.
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-12-14 15:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-10 1:31 [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice dong.yang
2021-12-10 8:51 ` Tvrtko Ursulin
2021-12-13 1:53 ` Yang, Dong
2021-12-13 9:36 ` Tvrtko Ursulin
2021-12-14 5:58 ` Yang, Dong
2021-12-14 15:40 ` Tvrtko Ursulin
2021-12-10 11:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-12-10 11:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-11 4:59 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.