* [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10
@ 2021-12-13 8:36 Hangbin Liu
2021-12-13 13:25 ` Ido Schimmel
2021-12-13 15:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2021-12-13 8:36 UTC (permalink / raw)
To: netdev; +Cc: Stephen Suryaputra, Ido Schimmel, David S . Miller, Hangbin Liu
The resent GRE selftests defined NUM_NETIFS=10. If the users copy
forwarding.config.sample to forwarding.config directly, they will get
error "Command line is not complete" when run the GRE tests, because
create_netif_veth() failed with no interface name defined.
Fix it by extending the NETIFS with p9 and p10.
Fixes: 2800f2485417 ("selftests: forwarding: Test multipath hashing on inner IP pkts for GRE tunnel")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/forwarding/forwarding.config.sample | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/forwarding/forwarding.config.sample b/tools/testing/selftests/net/forwarding/forwarding.config.sample
index bf17e485684f..b0980a2efa31 100644
--- a/tools/testing/selftests/net/forwarding/forwarding.config.sample
+++ b/tools/testing/selftests/net/forwarding/forwarding.config.sample
@@ -13,6 +13,8 @@ NETIFS[p5]=veth4
NETIFS[p6]=veth5
NETIFS[p7]=veth6
NETIFS[p8]=veth7
+NETIFS[p9]=veth8
+NETIFS[p10]=veth9
# Port that does not have a cable connected.
NETIF_NO_CABLE=eth8
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10
2021-12-13 8:36 [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10 Hangbin Liu
@ 2021-12-13 13:25 ` Ido Schimmel
2021-12-13 15:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2021-12-13 13:25 UTC (permalink / raw)
To: Hangbin Liu; +Cc: netdev, Stephen Suryaputra, Ido Schimmel, David S . Miller
On Mon, Dec 13, 2021 at 04:36:00PM +0800, Hangbin Liu wrote:
> The resent GRE selftests defined NUM_NETIFS=10. If the users copy
s/resent/recent/
> forwarding.config.sample to forwarding.config directly, they will get
> error "Command line is not complete" when run the GRE tests, because
> create_netif_veth() failed with no interface name defined.
>
> Fix it by extending the NETIFS with p9 and p10.
>
> Fixes: 2800f2485417 ("selftests: forwarding: Test multipath hashing on inner IP pkts for GRE tunnel")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10
2021-12-13 8:36 [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10 Hangbin Liu
2021-12-13 13:25 ` Ido Schimmel
@ 2021-12-13 15:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-13 15:00 UTC (permalink / raw)
To: Hangbin Liu; +Cc: netdev, ssuryaextr, idosch, davem
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 13 Dec 2021 16:36:00 +0800 you wrote:
> The resent GRE selftests defined NUM_NETIFS=10. If the users copy
> forwarding.config.sample to forwarding.config directly, they will get
> error "Command line is not complete" when run the GRE tests, because
> create_netif_veth() failed with no interface name defined.
>
> Fix it by extending the NETIFS with p9 and p10.
>
> [...]
Here is the summary with links:
- [net] selftest/net/forwarding: declare NETIFS p9 p10
https://git.kernel.org/netdev/net/c/71da1aec2152
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-13 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 8:36 [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10 Hangbin Liu
2021-12-13 13:25 ` Ido Schimmel
2021-12-13 15:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.