* [PATCH -next] mt76: remove variable set but not used
@ 2021-12-13 9:54 ` Yang Li
0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2021-12-13 9:54 UTC (permalink / raw)
To: nbd
Cc: lorenzo.bianconi83, ryder.lee, shayne.chen, sean.wang, kvalo,
davem, kuba, matthias.bgg, nathan, ndesaulniers, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel, llvm,
Yang Li, Abaci Robot
The code that uses variable queued has been removed,
and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued"
didn't do anything, so all they should be removed as well.
Eliminate the following clang warnings:
drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable
‘queued’ set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 2d8be76c1674 ("mt76: debugfs: improve queue node readability")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/wireless/mediatek/mt76/debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/debugfs.c b/drivers/net/wireless/mediatek/mt76/debugfs.c
index b8bcf22a07fd..027d9ea17d04 100644
--- a/drivers/net/wireless/mediatek/mt76/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/debugfs.c
@@ -74,13 +74,12 @@ EXPORT_SYMBOL_GPL(mt76_queues_read);
static int mt76_rx_queues_read(struct seq_file *s, void *data)
{
struct mt76_dev *dev = dev_get_drvdata(s->private);
- int i, queued;
+ int i;
seq_puts(s, " queue | hw-queued | head | tail |\n");
mt76_for_each_q_rx(dev, i) {
struct mt76_queue *q = &dev->q_rx[i];
- queued = mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued;
seq_printf(s, " %9d | %9d | %9d | %9d |\n",
i, q->queued, q->head, q->tail);
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] mt76: remove variable set but not used
@ 2021-12-13 9:54 ` Yang Li
0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2021-12-13 9:54 UTC (permalink / raw)
To: nbd
Cc: lorenzo.bianconi83, ryder.lee, shayne.chen, sean.wang, kvalo,
davem, kuba, matthias.bgg, nathan, ndesaulniers, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel, llvm,
Yang Li, Abaci Robot
The code that uses variable queued has been removed,
and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued"
didn't do anything, so all they should be removed as well.
Eliminate the following clang warnings:
drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable
‘queued’ set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 2d8be76c1674 ("mt76: debugfs: improve queue node readability")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/wireless/mediatek/mt76/debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/debugfs.c b/drivers/net/wireless/mediatek/mt76/debugfs.c
index b8bcf22a07fd..027d9ea17d04 100644
--- a/drivers/net/wireless/mediatek/mt76/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/debugfs.c
@@ -74,13 +74,12 @@ EXPORT_SYMBOL_GPL(mt76_queues_read);
static int mt76_rx_queues_read(struct seq_file *s, void *data)
{
struct mt76_dev *dev = dev_get_drvdata(s->private);
- int i, queued;
+ int i;
seq_puts(s, " queue | hw-queued | head | tail |\n");
mt76_for_each_q_rx(dev, i) {
struct mt76_queue *q = &dev->q_rx[i];
- queued = mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued;
seq_printf(s, " %9d | %9d | %9d | %9d |\n",
i, q->queued, q->head, q->tail);
}
--
2.20.1.7.g153144c
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] mt76: remove variable set but not used
@ 2021-12-13 9:54 ` Yang Li
0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2021-12-13 9:54 UTC (permalink / raw)
To: nbd
Cc: lorenzo.bianconi83, ryder.lee, shayne.chen, sean.wang, kvalo,
davem, kuba, matthias.bgg, nathan, ndesaulniers, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel, llvm,
Yang Li, Abaci Robot
The code that uses variable queued has been removed,
and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued"
didn't do anything, so all they should be removed as well.
Eliminate the following clang warnings:
drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable
‘queued’ set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 2d8be76c1674 ("mt76: debugfs: improve queue node readability")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/wireless/mediatek/mt76/debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/debugfs.c b/drivers/net/wireless/mediatek/mt76/debugfs.c
index b8bcf22a07fd..027d9ea17d04 100644
--- a/drivers/net/wireless/mediatek/mt76/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/debugfs.c
@@ -74,13 +74,12 @@ EXPORT_SYMBOL_GPL(mt76_queues_read);
static int mt76_rx_queues_read(struct seq_file *s, void *data)
{
struct mt76_dev *dev = dev_get_drvdata(s->private);
- int i, queued;
+ int i;
seq_puts(s, " queue | hw-queued | head | tail |\n");
mt76_for_each_q_rx(dev, i) {
struct mt76_queue *q = &dev->q_rx[i];
- queued = mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued;
seq_printf(s, " %9d | %9d | %9d | %9d |\n",
i, q->queued, q->head, q->tail);
}
--
2.20.1.7.g153144c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mt76: remove variable set but not used
2021-12-13 9:54 ` Yang Li
(?)
@ 2021-12-13 15:00 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-13 15:00 UTC (permalink / raw)
To: Yang Li
Cc: nbd, lorenzo.bianconi83, ryder.lee, shayne.chen, sean.wang,
kvalo, davem, kuba, matthias.bgg, nathan, ndesaulniers,
linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, llvm, abaci
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 13 Dec 2021 17:54:13 +0800 you wrote:
> The code that uses variable queued has been removed,
> and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued"
> didn't do anything, so all they should be removed as well.
>
> Eliminate the following clang warnings:
> drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable
> ‘queued’ set but not used.
>
> [...]
Here is the summary with links:
- [-next] mt76: remove variable set but not used
https://git.kernel.org/netdev/net-next/c/93d576f54e0f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mt76: remove variable set but not used
@ 2021-12-13 15:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-13 15:00 UTC (permalink / raw)
To: Yang Li
Cc: nbd, lorenzo.bianconi83, ryder.lee, shayne.chen, sean.wang,
kvalo, davem, kuba, matthias.bgg, nathan, ndesaulniers,
linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, llvm, abaci
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 13 Dec 2021 17:54:13 +0800 you wrote:
> The code that uses variable queued has been removed,
> and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued"
> didn't do anything, so all they should be removed as well.
>
> Eliminate the following clang warnings:
> drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable
> ‘queued’ set but not used.
>
> [...]
Here is the summary with links:
- [-next] mt76: remove variable set but not used
https://git.kernel.org/netdev/net-next/c/93d576f54e0f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mt76: remove variable set but not used
@ 2021-12-13 15:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-13 15:00 UTC (permalink / raw)
To: Yang Li
Cc: nbd, lorenzo.bianconi83, ryder.lee, shayne.chen, sean.wang,
kvalo, davem, kuba, matthias.bgg, nathan, ndesaulniers,
linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, llvm, abaci
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 13 Dec 2021 17:54:13 +0800 you wrote:
> The code that uses variable queued has been removed,
> and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued"
> didn't do anything, so all they should be removed as well.
>
> Eliminate the following clang warnings:
> drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable
> ‘queued’ set but not used.
>
> [...]
Here is the summary with links:
- [-next] mt76: remove variable set but not used
https://git.kernel.org/netdev/net-next/c/93d576f54e0f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-13 15:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 9:54 [PATCH -next] mt76: remove variable set but not used Yang Li
2021-12-13 9:54 ` Yang Li
2021-12-13 9:54 ` Yang Li
2021-12-13 15:00 ` patchwork-bot+netdevbpf
2021-12-13 15:00 ` patchwork-bot+netdevbpf
2021-12-13 15:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.