All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ci: temporarily remove linux-i686-gcc build
@ 2021-12-14 11:18 Niklas Cassel
  2021-12-14 11:18 ` [PATCH 2/2] ci: use macos 11 in virtual environment Niklas Cassel
  2021-12-14 13:47 ` [PATCH 1/2] ci: temporarily remove linux-i686-gcc build Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Niklas Cassel @ 2021-12-14 11:18 UTC (permalink / raw)
  To: axboe; +Cc: fio, Sitsofe Wheeler, Niklas Cassel

From: Niklas Cassel <niklas.cassel@wdc.com>

GitHub Actions was recently enabled in commit ce1b5612ce99 ("ci: add CI
via GitHub Actions").

The new CI configuration was not properly tested before being merged,
as the linux-i686-gcc build currently fails for the master branch:
https://github.com/axboe/fio/actions

The problem appears to be related to ci/actions-install.sh wanting to
install broken packages on linux-i686-gcc.

The new CI configuration will also cause fio forks on GitHub to trigger
a GitHub Action (inside the forked repo) for every push.

Since the linux-i686-gcc build currently fails, this will currently cause
error emails to be sent out for every push to a forked repo.

In order to avoid spamming everyone who has forked fio on GitHub, let's
temporarily remove the linux-i686-gcc build until ci/actions-install.sh
specifies a working list of packages. Once that is done, this commit can
simply be reverted.

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
 .github/workflows/ci.yml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a766cfa8..04351dd5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -14,7 +14,6 @@ jobs:
         - linux-gcc
         - linux-clang
         - macos
-        - linux-i686-gcc
         include:
         - build: linux-gcc
           os: ubuntu-20.04
@@ -24,9 +23,6 @@ jobs:
           cc: clang
         - build: macos
           os: macos-10.15
-        - build: linux-i686-gcc
-          os: ubuntu-20.04
-          arch: i686
 
     env:
       CI_TARGET_ARCH: ${{ matrix.arch }}
-- 
2.33.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ci: use macos 11 in virtual environment
  2021-12-14 11:18 [PATCH 1/2] ci: temporarily remove linux-i686-gcc build Niklas Cassel
@ 2021-12-14 11:18 ` Niklas Cassel
  2021-12-14 13:47 ` [PATCH 1/2] ci: temporarily remove linux-i686-gcc build Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2021-12-14 11:18 UTC (permalink / raw)
  To: axboe; +Cc: fio, Sitsofe Wheeler, Niklas Cassel

From: Niklas Cassel <niklas.cassel@wdc.com>

GitHub Actions was recently enabled in commit ce1b5612ce99 ("ci: add CI
via GitHub Actions").

The commit has a AuthorDate of 2020.

The commit mentions that it uses macOS 10.15 rather than 11.0 because
11.0 is only private preview.

This was true in 2020, but looking at:
https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners

macos-11 is no longer marked as private preview, so let's use it in the
virtual environment.

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 04351dd5..8167e3d1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
           os: ubuntu-20.04
           cc: clang
         - build: macos
-          os: macos-10.15
+          os: macos-11
 
     env:
       CI_TARGET_ARCH: ${{ matrix.arch }}
-- 
2.33.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ci: temporarily remove linux-i686-gcc build
  2021-12-14 11:18 [PATCH 1/2] ci: temporarily remove linux-i686-gcc build Niklas Cassel
  2021-12-14 11:18 ` [PATCH 2/2] ci: use macos 11 in virtual environment Niklas Cassel
@ 2021-12-14 13:47 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-12-14 13:47 UTC (permalink / raw)
  To: Niklas Cassel; +Cc: Sitsofe Wheeler, fio

On Tue, 14 Dec 2021 11:18:03 +0000, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> 
> GitHub Actions was recently enabled in commit ce1b5612ce99 ("ci: add CI
> via GitHub Actions").
> 
> The new CI configuration was not properly tested before being merged,
> as the linux-i686-gcc build currently fails for the master branch:
> https://github.com/axboe/fio/actions
> 
> [...]

Applied, thanks!

[1/2] ci: temporarily remove linux-i686-gcc build
      commit: cea3243fb3bb44d541c2b3fb82ee45eb669b6fe6
[2/2] ci: use macos 11 in virtual environment
      commit: d685f07ecb0f2ff64e475fe0ddf86e69b295fbf6

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-14 13:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 11:18 [PATCH 1/2] ci: temporarily remove linux-i686-gcc build Niklas Cassel
2021-12-14 11:18 ` [PATCH 2/2] ci: use macos 11 in virtual environment Niklas Cassel
2021-12-14 13:47 ` [PATCH 1/2] ci: temporarily remove linux-i686-gcc build Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.