* [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors
@ 2021-12-15 22:51 Jessica Zhang
2021-12-15 23:28 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jessica Zhang @ 2021-12-15 22:51 UTC (permalink / raw)
To: igt-dev; +Cc: petri.latvala, quic_khsieh, swboyd, nganji, seanpaul, aravindh
Catch edge cases where driver doesn't support larger scale factors or
pipe doesn't support scaling.
Currently, a 20x20 framebuffer is passed in to be upscaled. However,
this will cause issues with other drivers as they may not support larger
scale factors or may not support scaling at all for certain planes.
This avoids failures due to invalid scale factor by trying
the original 20x20 framebuffer commit, then trying to commit larger
framebuffers up to and including unity scale.
Changes since V1:
- try_commit_with_fb_size: Changed igt_try_commit2 to
igt_display_try_commit_atomic instead to avoid redundant commits
- try_commit_with_fb_size: Moved calls to clear framebuffer to outside
of success condition and moved cleanup_crtc back to outside of method
Changes since V2:
- try_commit_with_fb_size: Replaced igt_display_try_commit_atomic with
igt_display_try_commit2 and removed igt_display_try_commit2 to avoid
redundant checks
Tested-on: Qualcomm RB5 (sdm845)
Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
tests/kms_plane_scaling.c | 51 ++++++++++++++++++++++++++++++++-------
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 85db11ee..55042d40 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -1,5 +1,6 @@
/*
* Copyright © 2013,2014 Intel Corporation
+ * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
@@ -118,6 +119,28 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
igt_display_commit2(display, COMMIT_ATOMIC);
}
+static int try_commit_with_fb_size(int width, int height, igt_rotation_t rot,
+ igt_display_t *display, data_t *d,
+ igt_plane_t *plane,
+ drmModeModeInfo *mode)
+{
+ int ret;
+
+ /* Check min to full resolution upscaling */
+ igt_fb_set_position(&d->fb[0], plane, 0, 0);
+ igt_fb_set_size(&d->fb[0], plane, width, height);
+ igt_plane_set_position(plane, 0, 0);
+ igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ igt_plane_set_rotation(plane, rot);
+
+ ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
+
+ igt_plane_set_fb(plane, NULL);
+ igt_plane_set_position(plane, 0, 0);
+
+ return ret;
+}
+
static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
uint32_t pixel_format,
uint64_t modifier, enum pipe pipe,
@@ -126,6 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
{
igt_display_t *display = &d->display;
int width, height;
+ int commit_ret;
drmModeModeInfo *mode;
cleanup_crtc(d);
@@ -139,16 +163,25 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
pixel_format, modifier, 0.0, 1.0, 0.0, &d->fb[0]);
igt_plane_set_fb(plane, &d->fb[0]);
- /* Check min to full resolution upscaling */
- igt_fb_set_position(&d->fb[0], plane, 0, 0);
- igt_fb_set_size(&d->fb[0], plane, width, height);
- igt_plane_set_position(plane, 0, 0);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_rotation(plane, rot);
- igt_display_commit2(display, COMMIT_ATOMIC);
+ commit_ret = try_commit_with_fb_size(width, height, rot, display,
+ d, plane, mode);
- igt_plane_set_fb(plane, NULL);
- igt_plane_set_position(plane, 0, 0);
+ if(commit_ret == -ERANGE) {
+ igt_debug("Scaling for %dx%d plane not supported, trying scale factor of 4x\n", width, height);
+ width = height = mode->vdisplay / 4;
+ commit_ret = try_commit_with_fb_size(width, height, rot, display,
+ d, plane, mode);
+ }
+
+ if (commit_ret == -ERANGE) {
+ igt_debug("Scale factor of 4x (or scaling in general) not supported, trying unity scale\n");
+ width = mode->hdisplay;
+ height = mode->vdisplay;
+ commit_ret = try_commit_with_fb_size(width, height, rot, display,
+ d, plane, mode);
+ }
+
+ igt_assert_eq(commit_ret, 0);
}
static const igt_rotation_t rotations[] = {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3)
2021-12-15 22:51 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Jessica Zhang
@ 2021-12-15 23:28 ` Patchwork
2021-12-16 0:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-12-17 12:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Petri Latvala
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-12-15 23:28 UTC (permalink / raw)
To: Jessica Zhang; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 6142 bytes --]
== Series Details ==
Series: tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3)
URL : https://patchwork.freedesktop.org/series/97584/
State : success
== Summary ==
CI Bug Log - changes from IGT_6310 -> IGTPW_6498
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/index.html
Participating hosts (36 -> 34)
------------------------------
Additional (1): fi-kbl-soraka
Missing (3): fi-bsw-cyan fi-icl-u2 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6498:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@objects:
- {fi-tgl-dsi}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/fi-tgl-dsi/igt@i915_selftest@live@objects.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-tgl-dsi/igt@i915_selftest@live@objects.html
Known issues
------------
Here are the changes found in IGTPW_6498 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-hsw-4770/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271]) +26 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [PASS][6] -> [INCOMPLETE][7] ([i915#146])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [PASS][10] -> [INCOMPLETE][11] ([i915#2940])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][12] ([i915#1886] / [i915#2291])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-bsw-kefka/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6310 -> IGTPW_6498
CI-20190529: 20190529
CI_DRM_11005: 2e6d871494af25300763592917a5a133a14d0f12 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6498: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/index.html
IGT_6310: 07dfbd0af8b49c75036f0ccb0a161f6e290a91a3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/index.html
[-- Attachment #2: Type: text/html, Size: 7386 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3)
2021-12-15 22:51 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Jessica Zhang
2021-12-15 23:28 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3) Patchwork
@ 2021-12-16 0:49 ` Patchwork
2021-12-17 12:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Petri Latvala
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-12-16 0:49 UTC (permalink / raw)
To: Jessica Zhang; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30317 bytes --]
== Series Details ==
Series: tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3)
URL : https://patchwork.freedesktop.org/series/97584/
State : success
== Summary ==
CI Bug Log - changes from IGT_6310_full -> IGTPW_6498_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_6498_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl6/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][3] ([i915#280])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb8/igt@gem_ctx_sseu@engines.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: NOTRUN -> [TIMEOUT][4] ([i915#3063] / [i915#3648])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb3/igt@gem_eio@unwedge-stress.html
- shard-snb: NOTRUN -> [FAIL][5] ([i915#3354])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-snb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: NOTRUN -> [SKIP][6] ([i915#4525]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html
- shard-tglb: NOTRUN -> [SKIP][7] ([i915#4525]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb5/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_params@no-vebox:
- shard-iclb: NOTRUN -> [SKIP][15] ([fdo#109283])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb6/igt@gem_exec_params@no-vebox.html
- shard-tglb: NOTRUN -> [SKIP][16] ([fdo#109283])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@gem_exec_params@no-vebox.html
* igt@gem_exec_params@secure-non-root:
- shard-tglb: NOTRUN -> [SKIP][17] ([fdo#112283])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb5/igt@gem_exec_params@secure-non-root.html
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#112283])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb2/igt@gem_exec_params@secure-non-root.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_lmem_swapping@random:
- shard-kbl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl4/igt@gem_lmem_swapping@random.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl8/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#4270]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@gem_pxp@create-protected-buffer.html
* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#4270]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb6/igt@gem_pxp@protected-encrypted-src-copy-not-readible.html
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#768])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb1/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#3297])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@gem_userptr_blits@dmabuf-unsync.html
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#3297])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb6/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][28] -> [DMESG-WARN][29] ([i915#180]) +4 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-apl3/igt@gem_workarounds@suspend-resume-context.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
* igt@gen7_exec_parse@bitmasks:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109289]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb3/igt@gen7_exec_parse@bitmasks.html
* igt@gen7_exec_parse@load-register-reg:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109289]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb5/igt@gen7_exec_parse@load-register-reg.html
* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#2856]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb1/igt@gen9_exec_parse@allowed-all.html
* igt@gen9_exec_parse@allowed-single:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#2856]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb1/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_backlight@bad-brightness:
- shard-glk: NOTRUN -> [SKIP][34] ([fdo#109271]) +70 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk7/igt@i915_pm_backlight@bad-brightness.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][35] -> [SKIP][36] ([fdo#109271])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
- shard-iclb: [PASS][37] -> [SKIP][38] ([i915#4281])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-iclb1/igt@i915_pm_dc@dc9-dpms.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111644] / [i915#1397] / [i915#2411])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#110892])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb5/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#1769])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#1769])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb1/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: NOTRUN -> [DMESG-WARN][43] ([i915#118])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk9/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#110725] / [fdo#111614])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb5/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3777]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#111614])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb8/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3777])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111615]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb3/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271]) +153 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#110723]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_big_joiner@basic:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#2705])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb5/igt@kms_big_joiner@basic.html
- shard-iclb: NOTRUN -> [SKIP][52] ([i915#2705])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb2/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3689] / [i915#3886]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb3/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#3689]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb7/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#3886]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk9/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl8/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#3886]) +8 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [i915#3886]) +3 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][59] ([fdo#111615] / [i915#3689]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109278]) +22 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb5/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +12 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl3/igt@kms_chamelium@dp-hpd-for-each-pipe.html
* igt@kms_chamelium@hdmi-crc-multiple:
- shard-snb: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-snb6/igt@kms_chamelium@hdmi-crc-multiple.html
* igt@kms_color@pipe-d-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278] / [i915#1149])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@kms_color@pipe-d-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109284] / [fdo#111827]) +8 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb3/igt@kms_color_chamelium@pipe-b-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109284] / [fdo#111827]) +4 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb2/igt@kms_color_chamelium@pipe-c-ctm-0-5.html
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +10 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl7/igt@kms_color_chamelium@pipe-c-ctm-0-5.html
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-glk: NOTRUN -> [SKIP][67] ([fdo#109271] / [fdo#111827]) +5 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk2/igt@kms_color_chamelium@pipe-d-degamma.html
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb4/igt@kms_color_chamelium@pipe-d-degamma.html
* igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#3359]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#109279] / [i915#3359]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen.html
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109278] / [fdo#109279])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb1/igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][72] ([i915#2828])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3319]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x32-onscreen.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#111825]) +23 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109274] / [fdo#109278]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [PASS][76] -> [FAIL][77] ([i915#2346])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-iclb4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#4103]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb7/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_dsc@basic-dsc-enable:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#3840])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@kms_dsc@basic-dsc-enable.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][80] -> [INCOMPLETE][81] ([i915#180] / [i915#636])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109274]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@kms_flip@2x-flip-vs-wf_vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][83] ([i915#180]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
- shard-glk: [PASS][84] -> [FAIL][85] ([i915#2546])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109280]) +10 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271]) +140 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][89] ([fdo#108145] / [i915#265])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
- shard-glk: NOTRUN -> [FAIL][90] ([fdo#108145] / [i915#265])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk9/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
- shard-apl: NOTRUN -> [FAIL][91] ([fdo#108145] / [i915#265])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl2/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][92] ([i915#265])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#3536])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_plane_lowres@pipe-d-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#3536]) +2 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb8/igt@kms_plane_lowres@pipe-d-tiling-x.html
* igt@kms_plane_lowres@pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111615] / [fdo#112054])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb5/igt@kms_plane_lowres@pipe-d-tiling-yf.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl3/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#658])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl2/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109441])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][99] -> [SKIP][100] ([fdo#109441])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][101] ([IGT#2])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl6/igt@kms_sysfs_edid_timing.html
- shard-kbl: NOTRUN -> [FAIL][102] ([IGT#2])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl4/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][103] -> [DMESG-WARN][104] ([i915#180] / [i915#295])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [PASS][105] -> [INCOMPLETE][106] ([i915#2828] / [i915#794])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-query-forked-hang:
- shard-snb: NOTRUN -> [SKIP][107] ([fdo#109271]) +124 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-snb5/igt@kms_vblank@pipe-d-query-forked-hang.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-tglb: NOTRUN -> [SKIP][108] ([i915#2437])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb1/igt@kms_writeback@writeback-invalid-parameters.html
- shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2437])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl8/igt@kms_writeback@writeback-invalid-parameters.html
- shard-glk: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2437])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk1/igt@kms_writeback@writeback-invalid-parameters.html
- shard-iclb: NOTRUN -> [SKIP][111] ([i915#2437])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb1/igt@kms_writeback@writeback-invalid-parameters.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-kbl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2437]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl2/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-a-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][113] ([i915#2530])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb2/igt@nouveau_crc@pipe-a-source-outp-inactive.html
- shard-tglb: NOTRUN -> [SKIP][114] ([i915#2530])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb8/igt@nouveau_crc@pipe-a-source-outp-inactive.html
* igt@prime_nv_pcopy@test1_macro:
- shard-tglb: NOTRUN -> [SKIP][115] ([fdo#109291]) +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb8/igt@prime_nv_pcopy@test1_macro.html
* igt@prime_nv_test@nv_i915_sharing:
- shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109291]) +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb6/igt@prime_nv_test@nv_i915_sharing.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#2994])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-apl3/igt@sysfs_clients@fair-7.html
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#2994])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@sysfs_clients@fair-7.html
- shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl3/igt@sysfs_clients@fair-7.html
- shard-tglb: NOTRUN -> [SKIP][120] ([i915#2994]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-tglb7/igt@sysfs_clients@fair-7.html
- shard-glk: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk8/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][122] ([i915#2846]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [FAIL][124] ([i915#2842]) -> [PASS][125] +3 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-kbl2/igt@gem_exec_fair@basic-none-vip@rcs0.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-kbl6/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][126] ([i915#2842]) -> [PASS][127] +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_parallel@engines@fds:
- shard-iclb: [INCOMPLETE][128] ([i915#1895]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-iclb5/igt@gem_exec_parallel@engines@fds.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb6/igt@gem_exec_parallel@engines@fds.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [DMESG-WARN][130] ([i915#118]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-glk9/igt@gem_exec_whisper@basic-forked-all.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-glk4/igt@gem_exec_whisper@basic-forked-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][132] ([i915#454]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [FAIL][134] ([i915#2346]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/shard-iclb3/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][136] ([i915#180]) -> [PASS][137] +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6310/shard-apl4/igt@kms_flip@flip-vs-suspend@a-dp1.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTP
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6498/index.html
[-- Attachment #2: Type: text/html, Size: 33942 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors
2021-12-15 22:51 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Jessica Zhang
2021-12-15 23:28 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3) Patchwork
2021-12-16 0:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2021-12-17 12:34 ` Petri Latvala
2021-12-23 16:20 ` Jessica Zhang
2 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2021-12-17 12:34 UTC (permalink / raw)
To: Jessica Zhang; +Cc: quic_khsieh, swboyd, igt-dev, nganji, seanpaul, aravindh
On Wed, Dec 15, 2021 at 02:51:18PM -0800, Jessica Zhang wrote:
> Catch edge cases where driver doesn't support larger scale factors or
> pipe doesn't support scaling.
>
> Currently, a 20x20 framebuffer is passed in to be upscaled. However,
> this will cause issues with other drivers as they may not support larger
> scale factors or may not support scaling at all for certain planes.
>
> This avoids failures due to invalid scale factor by trying
> the original 20x20 framebuffer commit, then trying to commit larger
> framebuffers up to and including unity scale.
>
> Changes since V1:
> - try_commit_with_fb_size: Changed igt_try_commit2 to
> igt_display_try_commit_atomic instead to avoid redundant commits
> - try_commit_with_fb_size: Moved calls to clear framebuffer to outside
> of success condition and moved cleanup_crtc back to outside of method
>
> Changes since V2:
> - try_commit_with_fb_size: Replaced igt_display_try_commit_atomic with
> igt_display_try_commit2 and removed igt_display_try_commit2 to avoid
> redundant checks
>
> Tested-on: Qualcomm RB5 (sdm845)
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> tests/kms_plane_scaling.c | 51 ++++++++++++++++++++++++++++++++-------
> 1 file changed, 42 insertions(+), 9 deletions(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 85db11ee..55042d40 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -1,5 +1,6 @@
> /*
> * Copyright © 2013,2014 Intel Corporation
> + * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
> *
> * Permission is hereby granted, free of charge, to any person obtaining a
> * copy of this software and associated documentation files (the "Software"),
> @@ -118,6 +119,28 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
> igt_display_commit2(display, COMMIT_ATOMIC);
> }
>
> +static int try_commit_with_fb_size(int width, int height, igt_rotation_t rot,
> + igt_display_t *display, data_t *d,
> + igt_plane_t *plane,
> + drmModeModeInfo *mode)
> +{
> + int ret;
> +
> + /* Check min to full resolution upscaling */
> + igt_fb_set_position(&d->fb[0], plane, 0, 0);
> + igt_fb_set_size(&d->fb[0], plane, width, height);
> + igt_plane_set_position(plane, 0, 0);
> + igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> + igt_plane_set_rotation(plane, rot);
> +
> + ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
> +
> + igt_plane_set_fb(plane, NULL);
> + igt_plane_set_position(plane, 0, 0);
These set_fb and set_position calls should only be done if the commit
is successful, maybe?
> +
> + return ret;
> +}
> +
> static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
> uint32_t pixel_format,
> uint64_t modifier, enum pipe pipe,
> @@ -126,6 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
> {
> igt_display_t *display = &d->display;
> int width, height;
> + int commit_ret;
> drmModeModeInfo *mode;
>
> cleanup_crtc(d);
> @@ -139,16 +163,25 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
> pixel_format, modifier, 0.0, 1.0, 0.0, &d->fb[0]);
> igt_plane_set_fb(plane, &d->fb[0]);
>
> - /* Check min to full resolution upscaling */
> - igt_fb_set_position(&d->fb[0], plane, 0, 0);
> - igt_fb_set_size(&d->fb[0], plane, width, height);
> - igt_plane_set_position(plane, 0, 0);
> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> - igt_plane_set_rotation(plane, rot);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
> + d, plane, mode);
>
> - igt_plane_set_fb(plane, NULL);
> - igt_plane_set_position(plane, 0, 0);
> + if(commit_ret == -ERANGE) {
> + igt_debug("Scaling for %dx%d plane not supported, trying scale factor of 4x\n", width, height);
> + width = height = mode->vdisplay / 4;
> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
> + d, plane, mode);
> + }
> +
> + if (commit_ret == -ERANGE) {
> + igt_debug("Scale factor of 4x (or scaling in general) not supported, trying unity scale\n");
> + width = mode->hdisplay;
> + height = mode->vdisplay;
> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
> + d, plane, mode);
> + }
> +
In here, after going through the fallbacks.
--
Petri Latvala
> + igt_assert_eq(commit_ret, 0);
> }
>
> static const igt_rotation_t rotations[] = {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors
2021-12-17 12:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Petri Latvala
@ 2021-12-23 16:20 ` Jessica Zhang
2021-12-23 19:00 ` Jessica Zhang
0 siblings, 1 reply; 6+ messages in thread
From: Jessica Zhang @ 2021-12-23 16:20 UTC (permalink / raw)
To: Petri Latvala; +Cc: quic_khsieh, swboyd, igt-dev, nganji, seanpaul, aravindh
On 12/17/2021 4:34 AM, Petri Latvala wrote:
> On Wed, Dec 15, 2021 at 02:51:18PM -0800, Jessica Zhang wrote:
>> Catch edge cases where driver doesn't support larger scale factors or
>> pipe doesn't support scaling.
>>
>> Currently, a 20x20 framebuffer is passed in to be upscaled. However,
>> this will cause issues with other drivers as they may not support larger
>> scale factors or may not support scaling at all for certain planes.
>>
>> This avoids failures due to invalid scale factor by trying
>> the original 20x20 framebuffer commit, then trying to commit larger
>> framebuffers up to and including unity scale.
>>
>> Changes since V1:
>> - try_commit_with_fb_size: Changed igt_try_commit2 to
>> igt_display_try_commit_atomic instead to avoid redundant commits
>> - try_commit_with_fb_size: Moved calls to clear framebuffer to outside
>> of success condition and moved cleanup_crtc back to outside of method
>>
>> Changes since V2:
>> - try_commit_with_fb_size: Replaced igt_display_try_commit_atomic with
>> igt_display_try_commit2 and removed igt_display_try_commit2 to avoid
>> redundant checks
>>
>> Tested-on: Qualcomm RB5 (sdm845)
>>
>> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>> ---
>> tests/kms_plane_scaling.c | 51 ++++++++++++++++++++++++++++++++-------
>> 1 file changed, 42 insertions(+), 9 deletions(-)
>>
>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>> index 85db11ee..55042d40 100644
>> --- a/tests/kms_plane_scaling.c
>> +++ b/tests/kms_plane_scaling.c
>> @@ -1,5 +1,6 @@
>> /*
>> * Copyright © 2013,2014 Intel Corporation
>> + * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
>> *
>> * Permission is hereby granted, free of charge, to any person obtaining a
>> * copy of this software and associated documentation files (the "Software"),
>> @@ -118,6 +119,28 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
>> igt_display_commit2(display, COMMIT_ATOMIC);
>> }
>>
>> +static int try_commit_with_fb_size(int width, int height, igt_rotation_t rot,
>> + igt_display_t *display, data_t *d,
>> + igt_plane_t *plane,
>> + drmModeModeInfo *mode)
>> +{
>> + int ret;
>> +
>> + /* Check min to full resolution upscaling */
>> + igt_fb_set_position(&d->fb[0], plane, 0, 0);
>> + igt_fb_set_size(&d->fb[0], plane, width, height);
>> + igt_plane_set_position(plane, 0, 0);
>> + igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>> + igt_plane_set_rotation(plane, rot);
>> +
>> + ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
>> +
>> + igt_plane_set_fb(plane, NULL);
>> + igt_plane_set_position(plane, 0, 0);
>
> These set_fb and set_position calls should only be done if the commit
> is successful, maybe?
>
>> +
>> + return ret;
>> +}
>> +
>> static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>> uint32_t pixel_format,
>> uint64_t modifier, enum pipe pipe,
>> @@ -126,6 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>> {
>> igt_display_t *display = &d->display;
>> int width, height;
>> + int commit_ret;
>> drmModeModeInfo *mode;
>>
>> cleanup_crtc(d);
>> @@ -139,16 +163,25 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>> pixel_format, modifier, 0.0, 1.0, 0.0, &d->fb[0]);
>> igt_plane_set_fb(plane, &d->fb[0]);
>>
>> - /* Check min to full resolution upscaling */
>> - igt_fb_set_position(&d->fb[0], plane, 0, 0);
>> - igt_fb_set_size(&d->fb[0], plane, width, height);
>> - igt_plane_set_position(plane, 0, 0);
>> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>> - igt_plane_set_rotation(plane, rot);
>> - igt_display_commit2(display, COMMIT_ATOMIC);
>> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
>> + d, plane, mode);
>>
>> - igt_plane_set_fb(plane, NULL);
>> - igt_plane_set_position(plane, 0, 0);
>> + if(commit_ret == -ERANGE) {
>> + igt_debug("Scaling for %dx%d plane not supported, trying scale factor of 4x\n", width, height);
>> + width = height = mode->vdisplay / 4;
>> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
>> + d, plane, mode);
>> + }
>> +
>> + if (commit_ret == -ERANGE) {
>> + igt_debug("Scale factor of 4x (or scaling in general) not supported, trying unity scale\n");
>> + width = mode->hdisplay;
>> + height = mode->vdisplay;
>> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
>> + d, plane, mode);
>> + }
>> +
>
> In here, after going through the fallbacks.
>Yes, makes sense.
Thanks,
Jessica Zhang
>
> --
> Petri Latvala
>
>
>
>> + igt_assert_eq(commit_ret, 0);
>> }
>>
>> static const igt_rotation_t rotations[] = {
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors
2021-12-23 16:20 ` Jessica Zhang
@ 2021-12-23 19:00 ` Jessica Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Jessica Zhang @ 2021-12-23 19:00 UTC (permalink / raw)
To: Petri Latvala; +Cc: quic_khsieh, swboyd, igt-dev, nganji, seanpaul, aravindh
On 12/23/2021 8:20 AM, Jessica Zhang wrote:
>
>
> On 12/17/2021 4:34 AM, Petri Latvala wrote:
>> On Wed, Dec 15, 2021 at 02:51:18PM -0800, Jessica Zhang wrote:
>>> Catch edge cases where driver doesn't support larger scale factors or
>>> pipe doesn't support scaling.
>>>
>>> Currently, a 20x20 framebuffer is passed in to be upscaled. However,
>>> this will cause issues with other drivers as they may not support larger
>>> scale factors or may not support scaling at all for certain planes.
>>>
>>> This avoids failures due to invalid scale factor by trying
>>> the original 20x20 framebuffer commit, then trying to commit larger
>>> framebuffers up to and including unity scale.
>>>
>>> Changes since V1:
>>> - try_commit_with_fb_size: Changed igt_try_commit2 to
>>> igt_display_try_commit_atomic instead to avoid redundant commits
>>> - try_commit_with_fb_size: Moved calls to clear framebuffer to outside
>>> of success condition and moved cleanup_crtc back to outside of method
>>>
>>> Changes since V2:
>>> - try_commit_with_fb_size: Replaced igt_display_try_commit_atomic with
>>> igt_display_try_commit2 and removed igt_display_try_commit2 to avoid
>>> redundant checks
>>>
>>> Tested-on: Qualcomm RB5 (sdm845)
>>>
>>> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>>> ---
>>> tests/kms_plane_scaling.c | 51 ++++++++++++++++++++++++++++++++-------
>>> 1 file changed, 42 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>>> index 85db11ee..55042d40 100644
>>> --- a/tests/kms_plane_scaling.c
>>> +++ b/tests/kms_plane_scaling.c
>>> @@ -1,5 +1,6 @@
>>> /*
>>> * Copyright © 2013,2014 Intel Corporation
>>> + * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights
>>> reserved.
>>> *
>>> * Permission is hereby granted, free of charge, to any person
>>> obtaining a
>>> * copy of this software and associated documentation files (the
>>> "Software"),
>>> @@ -118,6 +119,28 @@ static void prepare_crtc(data_t *data,
>>> igt_output_t *output, enum pipe pipe,
>>> igt_display_commit2(display, COMMIT_ATOMIC);
>>> }
>>> +static int try_commit_with_fb_size(int width, int height,
>>> igt_rotation_t rot,
>>> + igt_display_t *display, data_t *d,
>>> + igt_plane_t *plane,
>>> + drmModeModeInfo *mode)
>>> +{
>>> + int ret;
>>> +
>>> + /* Check min to full resolution upscaling */
>>> + igt_fb_set_position(&d->fb[0], plane, 0, 0);
>>> + igt_fb_set_size(&d->fb[0], plane, width, height);
>>> + igt_plane_set_position(plane, 0, 0);
>>> + igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>>> + igt_plane_set_rotation(plane, rot);
>>> +
>>> + ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
>>> +
>>> + igt_plane_set_fb(plane, NULL);
>>> + igt_plane_set_position(plane, 0, 0);
>>
>> These set_fb and set_position calls should only be done if the commit
>> is successful, maybe?
>>
(Sorry, responded a little too quickly previously)
set_position can be moved out to after a successful commit, but we want
to keep set_fb inside the method, since we want to clear the fb
properties before trying a different size.
Thanks,
Jessica Zhang
>>> +
>>> + return ret;
>>> +}
>>> +
>>> static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t
>>> *plane,
>>> uint32_t pixel_format,
>>> uint64_t modifier, enum pipe pipe,
>>> @@ -126,6 +149,7 @@ static void check_scaling_pipe_plane_rot(data_t
>>> *d, igt_plane_t *plane,
>>> {
>>> igt_display_t *display = &d->display;
>>> int width, height;
>>> + int commit_ret;
>>> drmModeModeInfo *mode;
>>> cleanup_crtc(d);
>>> @@ -139,16 +163,25 @@ static void check_scaling_pipe_plane_rot(data_t
>>> *d, igt_plane_t *plane,
>>> pixel_format, modifier, 0.0, 1.0, 0.0, &d->fb[0]);
>>> igt_plane_set_fb(plane, &d->fb[0]);
>>> - /* Check min to full resolution upscaling */
>>> - igt_fb_set_position(&d->fb[0], plane, 0, 0);
>>> - igt_fb_set_size(&d->fb[0], plane, width, height);
>>> - igt_plane_set_position(plane, 0, 0);
>>> - igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>>> - igt_plane_set_rotation(plane, rot);
>>> - igt_display_commit2(display, COMMIT_ATOMIC);
>>> + commit_ret = try_commit_with_fb_size(width, height, rot, display,
>>> + d, plane, mode);
>>> - igt_plane_set_fb(plane, NULL);
>>> - igt_plane_set_position(plane, 0, 0);
>>> + if(commit_ret == -ERANGE) {
>>> + igt_debug("Scaling for %dx%d plane not supported, trying
>>> scale factor of 4x\n", width, height);
>>> + width = height = mode->vdisplay / 4;
>>> + commit_ret = try_commit_with_fb_size(width, height, rot,
>>> display,
>>> + d, plane, mode);
>>> + }
>>> +
>>> + if (commit_ret == -ERANGE) {
>>> + igt_debug("Scale factor of 4x (or scaling in general) not
>>> supported, trying unity scale\n");
>>> + width = mode->hdisplay;
>>> + height = mode->vdisplay;
>>> + commit_ret = try_commit_with_fb_size(width, height, rot,
>>> display,
>>> + d, plane, mode);
>>> + }
>>> +
>>
>> In here, after going through the fallbacks.
>> Yes, makes sense.
>
> Thanks,
> Jessica Zhang
>>
>> --
>> Petri Latvala
>>
>>
>>
>>> + igt_assert_eq(commit_ret, 0);
>>> }
>>> static const igt_rotation_t rotations[] = {
>>> --
>>> 2.34.1
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-23 19:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 22:51 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Jessica Zhang
2021-12-15 23:28 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors (rev3) Patchwork
2021-12-16 0:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-12-17 12:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Increase buffer size if driver doesn't support larger scale factors Petri Latvala
2021-12-23 16:20 ` Jessica Zhang
2021-12-23 19:00 ` Jessica Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.