Split and join. The preferred way.

Split and join. The preferred way.

[Alexander Amelkin]

[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

Hi all!

As we all know, it's a common programming task to split/tokenize strings and join tokens back together. Those trivial methods are however not implemented in STL for C++. There is a Boost way to do it, but as far as I understand, Boost is not endorsed in OpenBMC for understandable reasons of space-saving. Is there any openbmc-blessed method to split and join? Any commonly used library with the methods to perform the task? I hate code duplication and wouldn't like to reinvent the bicycle.

Thank you.

Alexander.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Split and join. The preferred way.

[vishwa]

When I had to tokenize before, I believe to have used std::stringstream 
/ std:strtok_r and no library that I am aware of.

I believe someone initiated this discussion a while ago and I am not 
sure where that went. Brad ?

!! Vishwa !!

On 12/06/2018 02:41 PM, Alexander Amelkin wrote:
> Hi all!
>
> As we all know, it's a common programming task to split/tokenize strings and join tokens back together. Those trivial methods are however not implemented in STL for C++. There is a Boost way to do it, but as far as I understand, Boost is not endorsed in OpenBMC for understandable reasons of space-saving. Is there any openbmc-blessed method to split and join? Any commonly used library with the methods to perform the task? I hate code duplication and wouldn't like to reinvent the bicycle.
>
> Thank you.
>
> Alexander.
>
>

Re: Split and join. The preferred way.

[James Feist]

On 12/6/18 11:51 PM, vishwa wrote:
> When I had to tokenize before, I believe to have used std::stringstream 
> / std:strtok_r and no library that I am aware of.
> 
> I believe someone initiated this discussion a while ago and I am not 
> sure where that went. Brad ?
> 
> !! Vishwa !!
> 
> On 12/06/2018 02:41 PM, Alexander Amelkin wrote:
>> Hi all!
>>
>> As we all know, it's a common programming task to split/tokenize 
>> strings and join tokens back together. Those trivial methods are 
>> however not implemented in STL for C++. There is a Boost way to do it, 
>> but as far as I understand, Boost is not endorsed in OpenBMC for 

This has changed, boost is allowed if it is header only. We've use 
boost::split before.

https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#boost

Thanks,

James

>> understandable reasons of space-saving. Is there any openbmc-blessed 
>> method to split and join? Any commonly used library with the methods 
>> to perform the task? I hate code duplication and wouldn't like to 
>> reinvent the bicycle.
>>
>> Thank you.
>>
>> Alexander.
>>
>>
> 

Re: Split and join. The preferred way.

[Ed Tanous]

The current disposition on boost is documented here:

https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#boost

In short, so long as we're not compromising the project longevity by
increasing the binary sizes, and using well known, tested libraries,
boost functions are perfectly acceptable to use.  There are several
daemons that use a number of string operations from boost today, so
there are several examples that you could follow.  boost::asio is used
in the new webserver implementation, and there are asio extensions for
sdbusplus.

One thing that's recommended is to at a minimum set
BOOST_SYSTEM_NO_DEPRECATED in your compiler flags, to ensure you're not
linking against a static library for boost::system.

-Ed