[PATCH net-next] netlink: do not allocate a device refcount tracker in ethnl_default_notify()

[PATCH net-next] netlink: do not allocate a device refcount tracker in ethnl_default_notify()

[Eric Dumazet]

From: Eric Dumazet <edumazet@google.com>

As reported by Johannes, the tracker allocated in
ethnl_default_notify() is not really needed, as this
function is not expected to change a device reference count.

Fixes: e4b8954074f6 ("netlink: add net device refcount tracker to struct ethnl_req_info")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Tested-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/ethtool/netlink.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index ea23659fab28c734d1a8c11d857b3795f104beec..5fe8f4ae2cebc48eed6d0ce2b9d6607546e66bd6 100644
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c
@@ -627,7 +627,6 @@ static void ethnl_default_notify(struct net_device *dev, unsigned int cmd,
 	}
 
 	req_info->dev = dev;
-	netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
 	req_info->flags |= ETHTOOL_FLAG_COMPACT_BITSETS;
 
 	ethnl_init_reply_data(reply_data, ops, dev);
-- 
2.34.1.448.ga2b2bfdf31-goog

Re: [PATCH net-next] netlink: do not allocate a device refcount tracker in ethnl_default_notify()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  5 Jan 2022 09:08:49 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> As reported by Johannes, the tracker allocated in
> ethnl_default_notify() is not really needed, as this
> function is not expected to change a device reference count.
> 
> Fixes: e4b8954074f6 ("netlink: add net device refcount tracker to struct ethnl_req_info")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Johannes Berg <johannes@sipsolutions.net>
> Tested-by: Johannes Berg <johannes@sipsolutions.net>
> 
> [...]

Here is the summary with links:
  - [net-next] netlink: do not allocate a device refcount tracker in ethnl_default_notify()
    https://git.kernel.org/netdev/net-next/c/2d6ec25539b0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html