* [PATCH] aoe: remove redundant assignment on variable n
@ 2022-01-13 0:05 Colin Ian King
2022-01-13 20:00 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-01-13 0:05 UTC (permalink / raw)
To: Justin Sanders, Jens Axboe, linux-block
Cc: kernel-janitors, linux-kernel, llvm
The variable n is being bit-wise or'd with a value and reassigned
before being returned. The update of n is redundant, replace
the |= operator with | instead. Cleans up clang scan warning:
drivers/block/aoe/aoecmd.c:125:9: warning: Although the value stored
to 'n' is used in the enclosing expression, the value is never
actually read from 'n' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/block/aoe/aoecmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 588889bea7c3..6af111f568e4 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -122,7 +122,7 @@ newtag(struct aoedev *d)
register ulong n;
n = jiffies & 0xffff;
- return n |= (++d->lasttag & 0x7fff) << 16;
+ return n | (++d->lasttag & 0x7fff) << 16;
}
static u32
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] aoe: remove redundant assignment on variable n
2022-01-13 0:05 [PATCH] aoe: remove redundant assignment on variable n Colin Ian King
@ 2022-01-13 20:00 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-01-13 20:00 UTC (permalink / raw)
To: Justin Sanders, Colin Ian King, linux-block
Cc: llvm, kernel-janitors, linux-kernel
On Thu, 13 Jan 2022 00:05:45 +0000, Colin Ian King wrote:
> The variable n is being bit-wise or'd with a value and reassigned
> before being returned. The update of n is redundant, replace
> the |= operator with | instead. Cleans up clang scan warning:
>
> drivers/block/aoe/aoecmd.c:125:9: warning: Although the value stored
> to 'n' is used in the enclosing expression, the value is never
> actually read from 'n' [deadcode.DeadStores]
>
> [...]
Applied, thanks!
[1/1] aoe: remove redundant assignment on variable n
commit: a6431e351c6ec5bb6800787d259b343088f369a3
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-13 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-13 0:05 [PATCH] aoe: remove redundant assignment on variable n Colin Ian King
2022-01-13 20:00 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.