All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Andi Shyti" <andi.shyti@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support
Date: Mon, 17 Jan 2022 19:49:12 -0000	[thread overview]
Message-ID: <164244895219.28491.7254640658871894419@emeril.freedesktop.org> (raw)
In-Reply-To: <20220117193255.236599-1-andi.shyti@linux.intel.com>

== Series Details ==

Series: Introduce multitile support
URL   : https://patchwork.freedesktop.org/series/98958/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3a9bf34c3413 drm/i915: Prepare for multiple GTs
-:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#255: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:91:
+#define for_each_gt(gt__, i915__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_MAX_GT; \
+	     (id__)++) \
+		for_each_if(((gt__) = (i915__)->gt[(id__)]))

total: 0 errors, 0 warnings, 1 checks, 436 lines checked
19cc34444270 drm/i915/gt: make a gt sysfs group and move power management files
-:111: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#111: 
new file mode 100644

-:588: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mode' - possible side-effects?
#588: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:293:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:588: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_show' - possible side-effects?
#588: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:293:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:588: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_store' - possible side-effects?
#588: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:293:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:611: CHECK:CAMELCASE: Avoid CamelCase: <RPn_freq_mhz>
#611: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:316:
+static INTEL_GT_RPS_SYSFS_ATTR(RPn_freq_mhz, 0444, rps_rp_mhz_show, NULL);

-:621: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_##s##_RPn_freq_mhz>
#621: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:326:
+		&dev_attr_##s##_RPn_freq_mhz.attr, \

-:640: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19)
#640: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:345:
+	} else if (attr == &dev_attr_gt_RP1_freq_mhz ||
[...]
+		   val = intel_rps_get_rp1_frequency(rps);

-:643: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19)
#643: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:348:
+	} else if (attr == &dev_attr_gt_RPn_freq_mhz ||
[...]
+		   val = intel_rps_get_rpn_frequency(rps);

-:643: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_gt_RPn_freq_mhz>
#643: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:348:
+	} else if (attr == &dev_attr_gt_RPn_freq_mhz ||

-:644: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_rps_RPn_freq_mhz>
#644: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:349:
+		   attr == &dev_attr_rps_RPn_freq_mhz) {

total: 0 errors, 3 warnings, 7 checks, 974 lines checked



  parent reply	other threads:[~2022-01-17 19:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 19:32 [PATCH v4 0/2] Introduce multitile support Andi Shyti
2022-01-17 19:32 ` [Intel-gfx] " Andi Shyti
2022-01-17 19:32 ` [PATCH v4 1/2] drm/i915: Prepare for multiple GTs Andi Shyti
2022-01-17 19:32   ` [Intel-gfx] " Andi Shyti
2022-01-17 22:24   ` Michal Wajdeczko
2022-01-17 22:24     ` Michal Wajdeczko
2022-01-17 23:12     ` Andi Shyti
2022-01-17 23:12       ` [Intel-gfx] " Andi Shyti
2022-01-17 19:32 ` [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files Andi Shyti
2022-01-17 19:32   ` [Intel-gfx] " Andi Shyti
2022-01-17 22:49   ` Michal Wajdeczko
2022-01-17 22:49     ` [Intel-gfx] " Michal Wajdeczko
2022-01-18  0:00     ` Andi Shyti
2022-01-18  0:00       ` [Intel-gfx] " Andi Shyti
2022-01-18 11:16   ` Tvrtko Ursulin
2022-01-18 12:49     ` Andi Shyti
2022-01-18 12:49       ` Andi Shyti
2022-01-17 19:49 ` Patchwork [this message]
2022-01-17 19:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce multitile support Patchwork
2022-01-17 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-17 21:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-03-18 23:39 [PATCH v7 0/7] " Andi Shyti
2022-03-18 23:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-18 22:46 [PATCH v6 0/7] " Andi Shyti
2022-03-18 23:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-18  2:10 [PATCH v6 0/7] " Andi Shyti
2022-03-18  3:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-02-17 14:41 [PATCH v5 0/7] " Andi Shyti
2022-02-17 23:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-17 15:09 [PATCH v3 0/2] " Andi Shyti
2022-01-17 15:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-12 22:20 [PATCH v2 0/2] " Andi Shyti
2022-01-12 22:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-11 12:15 [PATCH 0/2] " Andi Shyti
2022-01-11 15:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164244895219.28491.7254640658871894419@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.