All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Andi Shyti" <andi.shyti@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support
Date: Fri, 18 Mar 2022 23:18:54 -0000	[thread overview]
Message-ID: <164764553486.31588.13331738414786480511@emeril.freedesktop.org> (raw)
In-Reply-To: <20220318224640.61594-1-andi.shyti@linux.intel.com>

== Series Details ==

Series: Introduce multitile support
URL   : https://patchwork.freedesktop.org/series/101549/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ac3a14b22f9a drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0
373961700ada drm/i915/gt: add gt_is_root() helper
8fbc02b492a6 drm/i915: Prepare for multiple GTs
-:248: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#248: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:103:
+#define for_each_gt(gt__, i915__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_MAX_GT; \
+	     (id__)++) \
+		for_each_if(((gt__) = (i915__)->gt[(id__)]))

total: 0 errors, 0 warnings, 1 checks, 429 lines checked
287368b2d564 drm/i915/gt: create per-tile sysfs interface
-:70: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#70: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 196 lines checked
a4492f268173 drm/i915/gt: Create per-tile RC6 sysfs interface
-:121: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#121: 
new file mode 100644

-:157: CHECK:SPACING: No space is necessary after a cast
#157: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:32:
+	ret = (op == INTEL_GT_SYSFS_MAX) ? 0 : (u32) -1;

total: 0 errors, 1 warnings, 1 checks, 453 lines checked
a85aedc94158 drm/i915/gt: Create per-tile RPS sysfs interfaces
-:319: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mode' - possible side-effects?
#319: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:458:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:319: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_show' - possible side-effects?
#319: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:458:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:319: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_store' - possible side-effects?
#319: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:458:
+#define INTEL_GT_RPS_SYSFS_ATTR(_name, _mode, _show, _store) \
+	struct device_attribute dev_attr_gt_##_name = __ATTR(gt_##_name, _mode, _show, _store); \
+	struct device_attribute dev_attr_rps_##_name = __ATTR(rps_##_name, _mode, _show, _store)

-:333: CHECK:CAMELCASE: Avoid CamelCase: <RPn_freq_mhz>
#333: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:472:
+static INTEL_GT_RPS_SYSFS_ATTR_RO(RPn_freq_mhz);

-:347: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_##s##_RPn_freq_mhz>
#347: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:486:
+		&dev_attr_##s##_RPn_freq_mhz.attr, \

total: 0 errors, 0 warnings, 5 checks, 503 lines checked
59ae69ae1370 drm/i915/gt: Adding new sysfs frequency attributes
-:63: CHECK:SPACING: No space is necessary after a cast
#63: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:521:
+				(struct intel_gt_bool_throttle_attr *) attr;

total: 0 errors, 0 warnings, 1 checks, 147 lines checked



  parent reply	other threads:[~2022-03-18 23:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 22:46 [PATCH v6 0/7] Introduce multitile support Andi Shyti
2022-03-18 22:46 ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 1/7] drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0 Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 2/7] drm/i915/gt: add gt_is_root() helper Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 3/7] drm/i915: Prepare for multiple GTs Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 4/7] drm/i915/gt: create per-tile sysfs interface Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 5/7] drm/i915/gt: Create per-tile RC6 " Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 22:46 ` [PATCH v6 7/7] drm/i915/gt: Adding new sysfs frequency attributes Andi Shyti
2022-03-18 22:46   ` [Intel-gfx] " Andi Shyti
2022-03-18 23:18 ` Patchwork [this message]
2022-03-18 23:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce multitile support Patchwork
2022-03-18 23:32 ` [Intel-gfx] [PATCH v6 0/7] " Andi Shyti
2022-03-18 23:32   ` Andi Shyti
2022-03-18 23:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-03-19  1:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-03-18 23:39 [PATCH v7 0/7] " Andi Shyti
2022-03-18 23:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-18  2:10 [PATCH v6 0/7] " Andi Shyti
2022-03-18  3:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-02-17 14:41 [PATCH v5 0/7] " Andi Shyti
2022-02-17 23:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-17 19:32 [PATCH v4 0/2] " Andi Shyti
2022-01-17 19:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-17 15:09 [PATCH v3 0/2] " Andi Shyti
2022-01-17 15:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-12 22:20 [PATCH v2 0/2] " Andi Shyti
2022-01-12 22:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-11 12:15 [PATCH 0/2] " Andi Shyti
2022-01-11 15:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164764553486.31588.13331738414786480511@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.